Re: [Piglit] [PATCH v2 00/17] ARB_gl_spirv: v2 ubo/ssbo tests
I have just resend the mesa series for ubo/ssbo support. I will not do the same for the piglit series, as there are no changes even after rebasing against master. If the mesa series gets reviewed, I plan to push this piglit series. A review/ack would be welcome though. BR On 27/09/18 11:54, Alejandro Piñeiro wrote: > Hi, > > this is the second version of the ubo/ssbo tests for > ARB_gl_spirv. Differences compared with v1: > > * Rebased against today master. > > * Updated the pass checks on several tests. Instead of a silly > addition/substraction of the ubo/ssbo content, and check a > specific value, the value of the individual ubo/ssbo members are > checked. > > * array-complex became even more complex. Specifically thinking on > testing some cases mentioned by Timothy feedback on the mesa-dev > series. > > v1 announcement: >https://lists.freedesktop.org/archives/piglit/2018-September/025065.html > > The series can be found on this branch: >https://github.com/Igalia/piglit/tree/arb_gl_spirv-series5-ubo-ssbo-v2 > > > Alejandro Piñeiro (15): > shader_runner/spirv: log skip reason on ARB_gl_spirv extension check > shader_runner/spirv: check if test really includes spirv > shader_runner: add force_no_names mode > shader_runner: add support for glGetProgram queries > arb_gl_spirv: add GL_ACTIVE_UNIFORMS checks > arb_gl_spirv: add some simple ubo tests > arb_gl_spirv: add simple ubo tests with matrices > arb_gl_spirv: add complex ubo test with matrices > arb_gl_spirv: add a array of ubo test, with complex ubo content > arb_gl_spirv: add ubo matrix test with different matrix_stride > arb_gl_spirv: add ubo array test with different array_stride > arb_gl_spirv: add some simple ssbo tests > arb_gl_spirv: add simple ssbo tests with matrices > arb_gl_spirv: adding complex ssbo matrix test > arb_gl_spirv: add ssbo test using std140 and std430 > > Neil Roberts (2): > arb_gl_spirv: Add tests for UBOs with explicit offsets > arb_gl_spirv: Add a test for SSBOs with an unsized array > > tests/shaders/shader_runner.c | 485 +++--- > .../execution/ssbo/array-indirect.shader_test | 121 > .../execution/ssbo/array-inside-ssbo.shader_test | 189 ++ > .../ssbo/array-of-arrays-inside-ssbo.shader_test | 203 ++ > .../arb_gl_spirv/execution/ssbo/array.shader_test | 173 + > .../execution/ssbo/matrix/column-major.shader_test | 188 ++ > .../ssbo/matrix/column-vs-row.shader_test | 291 + > .../execution/ssbo/matrix/complex.shader_test | 702 > + > .../ssbo/matrix/indirect-column-major.shader_test | 132 > .../ssbo/matrix/indirect-row-major.shader_test | 132 > .../execution/ssbo/matrix/row-major.shader_test| 194 ++ > .../arb_gl_spirv/execution/ssbo/simple.shader_test | 138 > .../ssbo/two-ssbo-different-layouts.shader_test| 372 +++ > .../execution/ssbo/two-ssbo.shader_test| 151 + > .../execution/ssbo/two-stages.shader_test | 279 > .../execution/ssbo/unsized-array.shader_test | 119 > .../execution/ubo/array-complex.shader_test| 360 +++ > .../array-different-array-stride-ubo.shader_test | 271 > .../execution/ubo/array-indirect.shader_test | 108 > .../execution/ubo/array-inside-ubo.shader_test | 154 + > .../ubo/array-of-arrays-inside-ubo.shader_test | 184 ++ > .../arb_gl_spirv/execution/ubo/array.shader_test | 140 > .../ubo/explicit-offset-nested-struct.shader_test | 81 +++ > .../execution/ubo/explicit-offset.shader_test | 80 +++ > .../execution/ubo/location-0-crash.shader_test | 93 +++ > .../execution/ubo/matrix/column-major.shader_test | 176 ++ > .../execution/ubo/matrix/column-vs-row.shader_test | 303 + > .../execution/ubo/matrix/complex.shader_test | 624 ++ > .../ubo/matrix/different-matrix-stride.shader_test | 260 > .../ubo/matrix/indirect-column-major.shader_test | 120 > .../ubo/matrix/indirect-row-major.shader_test | 120 > .../execution/ubo/matrix/row-major.shader_test | 175 + > .../arb_gl_spirv/execution/ubo/simple.shader_test | 131 > .../execution/ubo/two-stages.shader_test | 276 > .../execution/ubo/two-ubos.shader_test | 141 + > .../execution/uniform/array.shader_test| 2 + > .../execution/uniform/arrays-of-arrays.shader_test | 2 + > .../uniform/atomic-uint-aoa-cs.shader_test | 2 + > .../uniform/atomic-uint-aoa-fs.shader_test | 2 + > .../uniform/atomic-uint-array-cs.shader_test | 2 + > .../uniform/atomic-uint-array-fs.shader_test | 2 + > .../execution/uniform/atomic-uint-cs.shader_test | 2 + > .../execution/uniform/atomic-uint-fs.shader_runner | 1 + > ...ic-uint-mixing-with-normal-uniforms.shader_test |
[Piglit] [PATCH v2 00/17] ARB_gl_spirv: v2 ubo/ssbo tests
Hi, this is the second version of the ubo/ssbo tests for ARB_gl_spirv. Differences compared with v1: * Rebased against today master. * Updated the pass checks on several tests. Instead of a silly addition/substraction of the ubo/ssbo content, and check a specific value, the value of the individual ubo/ssbo members are checked. * array-complex became even more complex. Specifically thinking on testing some cases mentioned by Timothy feedback on the mesa-dev series. v1 announcement: https://lists.freedesktop.org/archives/piglit/2018-September/025065.html The series can be found on this branch: https://github.com/Igalia/piglit/tree/arb_gl_spirv-series5-ubo-ssbo-v2 Alejandro Piñeiro (15): shader_runner/spirv: log skip reason on ARB_gl_spirv extension check shader_runner/spirv: check if test really includes spirv shader_runner: add force_no_names mode shader_runner: add support for glGetProgram queries arb_gl_spirv: add GL_ACTIVE_UNIFORMS checks arb_gl_spirv: add some simple ubo tests arb_gl_spirv: add simple ubo tests with matrices arb_gl_spirv: add complex ubo test with matrices arb_gl_spirv: add a array of ubo test, with complex ubo content arb_gl_spirv: add ubo matrix test with different matrix_stride arb_gl_spirv: add ubo array test with different array_stride arb_gl_spirv: add some simple ssbo tests arb_gl_spirv: add simple ssbo tests with matrices arb_gl_spirv: adding complex ssbo matrix test arb_gl_spirv: add ssbo test using std140 and std430 Neil Roberts (2): arb_gl_spirv: Add tests for UBOs with explicit offsets arb_gl_spirv: Add a test for SSBOs with an unsized array tests/shaders/shader_runner.c | 485 +++--- .../execution/ssbo/array-indirect.shader_test | 121 .../execution/ssbo/array-inside-ssbo.shader_test | 189 ++ .../ssbo/array-of-arrays-inside-ssbo.shader_test | 203 ++ .../arb_gl_spirv/execution/ssbo/array.shader_test | 173 + .../execution/ssbo/matrix/column-major.shader_test | 188 ++ .../ssbo/matrix/column-vs-row.shader_test | 291 + .../execution/ssbo/matrix/complex.shader_test | 702 + .../ssbo/matrix/indirect-column-major.shader_test | 132 .../ssbo/matrix/indirect-row-major.shader_test | 132 .../execution/ssbo/matrix/row-major.shader_test| 194 ++ .../arb_gl_spirv/execution/ssbo/simple.shader_test | 138 .../ssbo/two-ssbo-different-layouts.shader_test| 372 +++ .../execution/ssbo/two-ssbo.shader_test| 151 + .../execution/ssbo/two-stages.shader_test | 279 .../execution/ssbo/unsized-array.shader_test | 119 .../execution/ubo/array-complex.shader_test| 360 +++ .../array-different-array-stride-ubo.shader_test | 271 .../execution/ubo/array-indirect.shader_test | 108 .../execution/ubo/array-inside-ubo.shader_test | 154 + .../ubo/array-of-arrays-inside-ubo.shader_test | 184 ++ .../arb_gl_spirv/execution/ubo/array.shader_test | 140 .../ubo/explicit-offset-nested-struct.shader_test | 81 +++ .../execution/ubo/explicit-offset.shader_test | 80 +++ .../execution/ubo/location-0-crash.shader_test | 93 +++ .../execution/ubo/matrix/column-major.shader_test | 176 ++ .../execution/ubo/matrix/column-vs-row.shader_test | 303 + .../execution/ubo/matrix/complex.shader_test | 624 ++ .../ubo/matrix/different-matrix-stride.shader_test | 260 .../ubo/matrix/indirect-column-major.shader_test | 120 .../ubo/matrix/indirect-row-major.shader_test | 120 .../execution/ubo/matrix/row-major.shader_test | 175 + .../arb_gl_spirv/execution/ubo/simple.shader_test | 131 .../execution/ubo/two-stages.shader_test | 276 .../execution/ubo/two-ubos.shader_test | 141 + .../execution/uniform/array.shader_test| 2 + .../execution/uniform/arrays-of-arrays.shader_test | 2 + .../uniform/atomic-uint-aoa-cs.shader_test | 2 + .../uniform/atomic-uint-aoa-fs.shader_test | 2 + .../uniform/atomic-uint-array-cs.shader_test | 2 + .../uniform/atomic-uint-array-fs.shader_test | 2 + .../execution/uniform/atomic-uint-cs.shader_test | 2 + .../execution/uniform/atomic-uint-fs.shader_runner | 1 + ...ic-uint-mixing-with-normal-uniforms.shader_test | 2 + .../uniform/atomic-uint-several-slots.shader_test | 2 + .../execution/uniform/embedded-structs.shader_test | 2 + .../uniform/index-matches-location.shader_test | 2 + .../uniform/initializer-complex.shader_test| 2 + .../uniform/initializer-dvec4.shader_test | 3 + .../uniform/initializer-mat4x3.shader_test | 4 + .../execution/uniform/initializer.shader_test | 2 + .../uniform/nonsequential-locations.shader_test| 2 + .
