Re: [Piglit] [PATCH v2 3/5] arb_timer_query: Add missing header

2014-12-14 Thread Emil Velikov
On 12/12/14 17:47, Jan Vesely wrote:
 v2: protect the include with guards
 
 Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
 ---
  tests/spec/arb_timer_query/timestamp-get.c | 3 +++
  1 file changed, 3 insertions(+)
 
 diff --git a/tests/spec/arb_timer_query/timestamp-get.c 
 b/tests/spec/arb_timer_query/timestamp-get.c
 index 031c7a1..bcfc3f9 100644
 --- a/tests/spec/arb_timer_query/timestamp-get.c
 +++ b/tests/spec/arb_timer_query/timestamp-get.c
 @@ -24,6 +24,9 @@
  #include piglit-util-gl.h
  
  #include inttypes.h  /* for PRIu64 macro */
 +#ifdef HAVE_UNISTD_H
 +#include unistd.h/* for usleep */
 +#endif
  
Would be great if we can have the tests clear of such hacks, and push
them to the util libraries. That of course can be done as a follow up
commit in case you're interested :)

-Emil

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit


[Piglit] [PATCH v2 3/5] arb_timer_query: Add missing header

2014-12-12 Thread Jan Vesely
v2: protect the include with guards

Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
---
 tests/spec/arb_timer_query/timestamp-get.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/spec/arb_timer_query/timestamp-get.c 
b/tests/spec/arb_timer_query/timestamp-get.c
index 031c7a1..bcfc3f9 100644
--- a/tests/spec/arb_timer_query/timestamp-get.c
+++ b/tests/spec/arb_timer_query/timestamp-get.c
@@ -24,6 +24,9 @@
 #include piglit-util-gl.h
 
 #include inttypes.h  /* for PRIu64 macro */
+#ifdef HAVE_UNISTD_H
+#include unistd.h/* for usleep */
+#endif
 
 /**
  * @file timestamp-get.c
-- 
2.1.0

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit


Re: [Piglit] [PATCH v2 3/5] arb_timer_query: Add missing header

2014-12-12 Thread Vinson Lee
On Fri, Dec 12, 2014 at 9:47 AM, Jan Vesely jan.ves...@rutgers.edu wrote:
 v2: protect the include with guards

 Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
 ---
  tests/spec/arb_timer_query/timestamp-get.c | 3 +++
  1 file changed, 3 insertions(+)

 diff --git a/tests/spec/arb_timer_query/timestamp-get.c 
 b/tests/spec/arb_timer_query/timestamp-get.c
 index 031c7a1..bcfc3f9 100644
 --- a/tests/spec/arb_timer_query/timestamp-get.c
 +++ b/tests/spec/arb_timer_query/timestamp-get.c
 @@ -24,6 +24,9 @@
  #include piglit-util-gl.h

  #include inttypes.h  /* for PRIu64 macro */
 +#ifdef HAVE_UNISTD_H
 +#include unistd.h/* for usleep */
 +#endif

  /**
   * @file timestamp-get.c
 --
 2.1.0


Reviewed-by: Vinson Lee v...@freedesktop.org
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit