Re: [Piglit] [PATCH] generated_tests: Actually catch exception in os.makedirs

2014-12-17 Thread Mark Janes 
It seems like you unintentionally included an extra file:
generated_tests/genclbuiltins.py

The deltas are not related to os.makedirs.

Dylan Baker baker.dyla...@gmail.com writes:

  generated_tests/genclbuiltins.py   | 54 
 +-

 diff --git a/generated_tests/genclbuiltins.py 
 b/generated_tests/genclbuiltins.py
 index 7e85a51..681aa29 100644
 --- a/generated_tests/genclbuiltins.py
 +++ b/generated_tests/genclbuiltins.py
 @@ -3,6 +3,8 @@ __all__ = ['gen', 'DATA_SIZES', 'MAX_VALUES', 'MAX', 'MIN', 
 'BMIN', 'BMAX',
  
  import os
  
 +from modules import utils
 +
  
  DATA_SIZES = {
  'char': 8,
 @@ -139,44 +141,44 @@ def gen_kernel_1_arg(f, fnName, inType, outType):
  gen_kernel(f, fnName, [inType], outType, [vecSize], '')
  
  
 -#  2 argument kernel with input types that match their vector size
 -def gen_kernel_2_arg_same_size(f, fnName, inTypes, outType):
 +#  2 argument kernel with input types that match
 +def gen_kernel_2_arg_same_type(f, fnName, inType, outType):
  for vecSize in ALL_WIDTHS:
 -gen_kernel(f, fnName, inTypes, outType, [vecSize, vecSize],
 +gen_kernel(f, fnName, [inType, inType], outType, [vecSize, vecSize],
 '')
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] generated_tests: Actually catch exception in os.makedirs

2014-12-17 Thread Dylan Baker 
You're right. Obviously I picked up a stray hunk from another branch.
I'll fix that and send a v2.

On Wednesday, December 17, 2014 03:28:43 PM Mark Janes wrote:
 It seems like you unintentionally included an extra file:
 generated_tests/genclbuiltins.py
 
 The deltas are not related to os.makedirs.
 
 Dylan Baker baker.dyla...@gmail.com writes:
 
   generated_tests/genclbuiltins.py   | 54 
  +-
 
  diff --git a/generated_tests/genclbuiltins.py 
  b/generated_tests/genclbuiltins.py
  index 7e85a51..681aa29 100644
  --- a/generated_tests/genclbuiltins.py
  +++ b/generated_tests/genclbuiltins.py
  @@ -3,6 +3,8 @@ __all__ = ['gen', 'DATA_SIZES', 'MAX_VALUES', 'MAX', 'MIN', 
  'BMIN', 'BMAX',
   
   import os
   
  +from modules import utils
  +
   
   DATA_SIZES = {
   'char': 8,
  @@ -139,44 +141,44 @@ def gen_kernel_1_arg(f, fnName, inType, outType):
   gen_kernel(f, fnName, [inType], outType, [vecSize], '')
   
   
  -#  2 argument kernel with input types that match their vector size
  -def gen_kernel_2_arg_same_size(f, fnName, inTypes, outType):
  +#  2 argument kernel with input types that match
  +def gen_kernel_2_arg_same_type(f, fnName, inType, outType):
   for vecSize in ALL_WIDTHS:
  -gen_kernel(f, fnName, inTypes, outType, [vecSize, vecSize],
  +gen_kernel(f, fnName, [inType, inType], outType, [vecSize, 
  vecSize],
  '')


signature.asc
Description: This is a digitally signed message part.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit