[Pixman] [PATCH v2] MIPS: Drop #ifdef __ELF__ in definition of LEAF_MIPS32R2
Commit 6d2cf40166d8 (MIPS: Fix exported symbols in public API) attempted to add a .hidden assembly directive, conditional on the code being compiled for an ELF target. Unfortunately the #ifdef added was already inside a macro and wasn't expanded properly by the preprocessor. Fix by removing the check. It's unlikely there are many non-ELF MIPS systems around anyway. Fixes: Bug 83358 (https://bugs.freedesktop.org/83358) Fixes: 6d2cf40166d8 (MIPS: Fix exported symbols in public API) Signed-off-by: James Cowgill james...@cowgill.org.uk Cc: Vicente Olivert Riera vincent.ri...@imgtec.com Cc: Nemanja Lukic nemanja.lu...@rt-rk.com --- pixman/pixman-mips-dspr2-asm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/pixman/pixman-mips-dspr2-asm.h b/pixman/pixman-mips-dspr2-asm.h index 11849bd..e44edd6 100644 --- a/pixman/pixman-mips-dspr2-asm.h +++ b/pixman/pixman-mips-dspr2-asm.h @@ -72,10 +72,8 @@ #define LEAF_MIPS32R2(symbol) \ .globl symbol; \ .align 2; \ -#ifdef __ELF__ .hidden symbol; \ .type symbol, @function; \ -#endif .entsymbol, 0; \ symbol: .frame sp, 0, ra; \ .setpush; \ -- 2.1.4 ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] [PATCH pixman] test: Added more demos and tests to .gitignore file
On 05/04/2015 11:57 PM, Pekka Paalanen wrote: On Wed, 29 Apr 2015 11:44:17 -0700 Bill Spitzak spit...@gmail.com wrote: Uses a wildcard to handle the majority which end in -test. --- .gitignore | 45 + 1 file changed, 5 insertions(+), 40 deletions(-) Looks fine to me, so R-b me and pushed: e0c0153..6f14bae master - master .log and .trs files in test/ would probably be good to ignore too. They are created by 'make check'. I tried running make check but I don't get any such files and git status does not list any unknown files. However one test (stress-test) failed with a floating point exception for me. ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] pixman fails to build on mips32r2
On Mon, 27 Apr 2015 09:58:18 +0100 James Cowgill james...@cowgill.org.uk wrote: On Mon, 2015-04-27 at 11:35 +0300, Pekka Paalanen wrote: On Fri, 24 Apr 2015 17:09:52 +0100 James Cowgill james...@cowgill.org.uk wrote: Hi, Pixman has been failing to build on mips32r2 since 0.32.6. Can the patch posted in this bug report be applied to fix it? https://bugs.freedesktop.org/show_bug.cgi?id=83358#c1 Hi, was that patch posted to the mailing list? Looks like CC'ing Nemanja Lukic nemanja.lu...@rt-rk.com would be appropriate. I am not qualified to review that patch. Just looking back, it was posted mid September: http://lists.freedesktop.org/archives/pixman/2014-September/003419.html He said it was ok, but I've CCed him again anyway. Hi, if you send this patch with the proper author, bug report and reviewed-by info to the mailing list, I can push it to master. The commit message needs a link to the bug report, most importantly because the bug report explains the issue. Make it inline like git-send-email does, not as an attachment, please. More info is the README if needed. I'm not sure what to do with the stable branches, though. Thanks, pq ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
