I believe on the good/best patch you are worried about the freeing of the filter array. However in commit 756b54f6 you made pixman_set_filter always copy the one provided by the caller. This means my code works because the filter cannot be changed away from/to good/best without also freeing the previous data.

The commit just says "Add boolean returns to various setters" so I am wondering if this is a mistake. There is also a comparison of the old/new pointers which won't work if the filter array is copied.

_______________________________________________
Pixman mailing list
Pixman@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pixman

Reply via email to