Your message dated Sat, 19 May 2018 15:50:52 +0000 with message-id <e1fk48c-000cqs...@fasolo.debian.org> and subject line Bug#898652: fixed in golang-github-go-debos-fakemachine 0.0~git20180517.7d8d48a-1 has caused the Debian Bug report #898652, regarding golang-github-go-debos-fakemachine: autopkgtest doesn't actually run any tests to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 898652: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898652 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: golang-github-go-debos-fakemachine Version: 0.0~git20180126.e307c2f-1 Severity: normal Tags: patch The tests for this package appear to pass, but if you look more closely, there is very little actual testing going on: autopkgtest [02:05:31]: test command1: /usr/bin/dh_golang_autopkgtest autopkgtest [02:05:31]: test command1: [----------------------- [info] Testing github.com/go-debos/fakemachine... [info] Source code installed by binary package, overriding dh_auto_configure... dh build --buildsystem=golang --with=golang ... debian/rules override_dh_auto_test make[1]: Entering directory '/tmp/autopkgtest-lxc.6okl3mgq/downtmp/autopkgtest_tmp' # Disable auto tests at build time # fakemachine need to be able to use /dev/kvm : make[1]: Leaving directory '/tmp/autopkgtest-lxc.6okl3mgq/downtmp/autopkgtest_tmp' create-stamp debian/debhelper-build-stamp autopkgtest [02:05:33]: test command1: -----------------------] autopkgtest [02:05:33]: test command1: - - - - - - - - - - results - - - - - - - - - - command1 PASS I suspect autopkgtest-pkg-go is not appropriate for this particular package. I attach a simple smoke-test which tries to detect whether fakemachine should be expected to be able to operate or not. This would hopefully have detected the missing runtime dependencies. Regards, smcv>From 17bec09d74237f3961a423e416de72c6be30afd6 Mon Sep 17 00:00:00 2001 From: Simon McVittie <s...@collabora.com> Date: Mon, 14 May 2018 18:21:50 +0100 Subject: [PATCH 1/3] Add an autopkgtest smoke test Unlike the (disabled) build-time tests, this checks for access to /dev/kvm and is skipped if that isn't possible. Signed-off-by: Simon McVittie <s...@collabora.com> --- debian/control | 1 - debian/tests/control | 3 ++ debian/tests/hello | 72 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 75 insertions(+), 1 deletion(-) create mode 100644 debian/tests/control create mode 100755 debian/tests/hello diff --git a/debian/control b/debian/control index 9d746bf..bd58272 100644 --- a/debian/control +++ b/debian/control @@ -18,7 +18,6 @@ Homepage: https://github.com/go-debos/fakemachine Vcs-Browser: https://salsa.debian.org/go-team/packages/golang-github-go-debos-fakemachine Vcs-Git: https://salsa.debian.org/go-team/packages/golang-github-go-debos-fakemachine.git XS-Go-Import-Path: github.com/go-debos/fakemachine -Testsuite: autopkgtest-pkg-go Package: fakemachine Architecture: any diff --git a/debian/tests/control b/debian/tests/control new file mode 100644 index 0000000..a7d8062 --- /dev/null +++ b/debian/tests/control @@ -0,0 +1,3 @@ +Tests: hello +Depends: fakemachine, hello +Restrictions: allow-stderr needs-recommends diff --git a/debian/tests/hello b/debian/tests/hello new file mode 100755 index 0000000..d99aef6 --- /dev/null +++ b/debian/tests/hello @@ -0,0 +1,72 @@ +#!/bin/bash + +# Copyright © 2018 Collabora Ltd. +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -e +set -u +set -o pipefail + +cd "${AUTOPKGTEST_TMP:-"${ADTTMP}"}" + +if ! [ -w /dev/kvm ]; then + echo "1..0 # SKIP no write access to /dev/kvm" + exit 0 +fi + +if ! grep -E '^flags[[:space:]]*:.*[[:space:]](vmx|svm)( |$)' /proc/cpuinfo >&2; then + echo "1..0 # SKIP could not find AMD-V (svm) or Intel VT-x (vmx) in /proc/cpuinfo" + exit 0 +fi + +echo "1..3" +fail=0 + +# Filter out Esc and Tab for a cleaner log and easier grepping +if timeout -k 5s -s ABRT 60s \ + fakemachine env LC_ALL=C hello </dev/null 2>&1 | \ + stdbuf -oL tr -d '\033\015' | \ + tee fakemachine.log >&2; then + e=0 +else + e=$? +fi + +if [ "$e" -eq 0 ]; then + echo "ok 1 - fakemachine hello exited successfully" +elif [ "$e" -eq 124 ]; then + echo "not ok 1 - fakemachine hello timed out" + fail=1 +else + echo "not ok 1 - fakemachine hello exited $e" + fail=1 +fi + +if grep -E '^Running env LC_ALL=C hello$' fakemachine.log >&2; then + echo "ok 2 - fakemachine tried to run hello" +else + echo "not ok 2 - fakemachine didn't get as far as running hello" + fail=1 +fi + +if grep -E '^Hello, world!$' fakemachine.log >&2; then + echo "ok 3 - received a friendly greeting" +else + echo "not ok 3 - did not receive a friendly greeting" + fail=1 +fi + +exit "$fail" -- 2.17.0
--- End Message ---
--- Begin Message ---Source: golang-github-go-debos-fakemachine Source-Version: 0.0~git20180517.7d8d48a-1 We believe that the bug you reported is fixed in the latest version of golang-github-go-debos-fakemachine, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 898...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Héctor Orón Martínez <zu...@debian.org> (supplier of updated golang-github-go-debos-fakemachine package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sat, 19 May 2018 17:05:51 +0200 Source: golang-github-go-debos-fakemachine Binary: fakemachine golang-github-go-debos-fakemachine-dev Architecture: source Version: 0.0~git20180517.7d8d48a-1 Distribution: unstable Urgency: medium Maintainer: Debian Go Packaging Team <pkg-go-maintain...@lists.alioth.debian.org> Changed-By: Héctor Orón Martínez <zu...@debian.org> Description: fakemachine - create and spawn virtual machines for building images with debos. golang-github-go-debos-fakemachine-dev - create and spawn virtual machines for building images with debos. Closes: 891896 898650 898651 898652 Changes: golang-github-go-debos-fakemachine (0.0~git20180517.7d8d48a-1) unstable; urgency=medium . [ Alexandre Viau ] * Point Vcs-* urls to salsa.debian.org. . [ Héctor Orón Martínez ] * New upstream version 0.0~git20180517.7d8d48a * debian/control: set architecture to amd64 (Closes: #898650) * debian/control: bump standards version, no changes . [ Simon McVittie ] * Add missing dependencies (Closes: #898651, #891896) * Add an autopkgtest smoke test (Closes: #898652) Checksums-Sha1: 48378023995a104dad34179e755625f7aaf9fb67 2652 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1.dsc 7b83b1c4a65f383497ff4a17290139d5db806992 11244 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a.orig.tar.xz 785e479dbab0a9d229874aeafa05eca1549e8df3 3364 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1.debian.tar.xz eaf2718161e0dbcf0a1f505c43ccae8842ebce03 6052 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1_source.buildinfo Checksums-Sha256: 86cf1092e9dabfdc75ef0b31fedba91ab19821f667f21c3fdb840f8301678ae1 2652 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1.dsc 3b43bb5f74fa9cbfe38521f3dad54247e0f413d2dbfe8ce1cc85e1df4485afc1 11244 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a.orig.tar.xz 913178ada3b5839c0ab3af40b61e994137da7168f64d0118fc683f07d5674f9b 3364 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1.debian.tar.xz 9888f7bfc70fc4aeea0e7e6e7461d47d0f1918ff36fbbd4187ff265570b546d7 6052 golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1_source.buildinfo Files: 2284d53534ce859d13a6d0a58dd2f01d 2652 devel optional golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1.dsc 623022bfae0cf4915075e1227577c5ab 11244 devel optional golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a.orig.tar.xz e0a38b888f2515c01f880012636592ca 3364 devel optional golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1.debian.tar.xz e12265923a6b8ebc3dcc1676e9cc5752 6052 devel optional golang-github-go-debos-fakemachine_0.0~git20180517.7d8d48a-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6Q8IiVReeMgqnedOryKDqnbirHsFAlsAPmEACgkQryKDqnbi rHtNqA//UmgWbbdy5hjmM4c6rQiIIMY1j92ijt1H6qEcWD4B397F2I8xqpSJ9Ve+ URRY3JDzDxz+3orBC9vTnUgK82HpDQzdNZU7psQ0efuUKyid8S3oKDLjgnr81iWd U7gFYF5DNLeSlToNmvm+Yt5naUUaIfH/du2bNHXrY7nb3tfi2cKu+bCqze3e1ydm qRyksNWDTGMBR2/pGByZ3JibxPXBgCOJGWUZg3DWhWS+Rf+OZ5dVoTgdujl03ZDs us76XPkx3LXt35UhY+Jl5aFp2ke15qmpo6ElSgh/HlWGD+idcXOdCDDEoI0az0r5 5DFaa6pSvxk9RQTuwG4Gr5FLJz+FjgS4digGjEif9rwJr6FC+c0gVlJKuZXlKFuY kDy69hvbmvsKkgCd2jNg516U53hz4ZDs3pJMFBq4C3eEtmncai8Gho7rgsjzbx06 4GFO3gxYyurGPVqhqZXi60t1/14uQS+/0Po/hUR2bA/qUw64839hpvjKDK/gr7uF 2WUr/b+zJP6+Ytc0HTfua4luxee14mPHwa25rcIBDR7nBLd4gVsnJSod3UNjR45f 2uSg7hGsdrRQDiby0JeGN50em2cttNvauh7jkx/dj20TG3/Ok7AJv2DQOY6dQeqF Jeaa1K51LIclLmzdBzPmgzQeSDHvYqRMJumrk+geQcgDJdB2kyA= =H1x3 -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Pkg-go-maintainers mailing list Pkg-go-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers
