Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud Rebillout]

On 03/21/2018 03:12 PM, Arnaud Rebillout wrote:
>
> On 03/21/2018 02:55 PM, Michael Stapelberg wrote:
>>
>>
>> On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout
>> > > wrote:
>>
>>
>> On 03/20/2018 02:36 PM, Michael Stapelberg wrote:
>>>
>>>
>>> Uploaded.
>>>  
>>>
>>>
>>>
>>> PULL - there are a few changes
>>>
>>> 
>>> 
>>>
>>>
>>> I’ll hold off with this one until the build-deps are satisfied.
>>>
>>> By the way, do you want to include the most recent commits in
>>> the debian/changelog entry?
>>
>> Yep sure, I just updated the changelog and pushed it all.
>>
>>
>> I can’t seem to build this
>> because 
>> https://tracker.debian.org/pkg/golang-github-opencontainers-image-spec
>> is broken, and I’m not entirely sure why/how to fix it. Any hints
>> welcome.
>
> I think I know. The pristine-tar branch is missing a commit, compared
> to the upstream branch. My tree at
> https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec
> has it all, so if you merge everything to the alioth git repo, I guess
> that should fix the issue.
>
> Notice however that I issued a changelog entry ending with `-2`, I
> didn't notice that the `-1` package didn't exist. I don't know if it's
> a problem.

BTW I just pushed a last commit at
https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec
that really address this issue, ie. fix the gbp configuration, if my
understanding is correct.


___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud Rebillout]

On 03/21/2018 02:55 PM, Michael Stapelberg wrote:
>
>
> On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout
>  > wrote:
>
>
> On 03/20/2018 02:36 PM, Michael Stapelberg wrote:
>>
>>
>> Uploaded.
>>  
>>
>>
>>
>> PULL - there are a few changes
>>
>> 
>> 
>>
>>
>> I’ll hold off with this one until the build-deps are satisfied.
>>
>> By the way, do you want to include the most recent commits in the
>> debian/changelog entry?
>
> Yep sure, I just updated the changelog and pushed it all.
>
>
> I can’t seem to build this
> because https://tracker.debian.org/pkg/golang-github-opencontainers-image-spec
> is broken, and I’m not entirely sure why/how to fix it. Any hints welcome.

I think I know. The pristine-tar branch is missing a commit, compared to
the upstream branch. My tree at
https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec
has it all, so if you merge everything to the alioth git repo, I guess
that should fix the issue.

Notice however that I issued a changelog entry ending with `-2`, I
didn't notice that the `-1` package didn't exist. I don't know if it's a
problem.

Cheers,

  Arnaud
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Call for review - containerd and dependencies

[Michael Stapelberg]

On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout <
arnaud.rebill...@collabora.com> wrote:

>
>
> On 03/20/2018 02:36 PM, Michael Stapelberg wrote:
>
>
>
> On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout <
> arnaud.rebill...@collabora.com> wrote:
>
>> Hello all, let me follow up on this !
>>
>> According to discussions on this mailing list, I made the following
>> changes on the packages:
>> - the license issues have been clarified with containerd projects, except
>> for containerd-typeurl which doesn't receive much attention from upstream.
>> As a consequence I let the copyright to 'containerd', except if there's a
>> better thing to do (like, nothing in the copyright field ?).
>> - I re-packaged docker-go-metrics to a lower version, so that there is no
>> need to bump prometheus-client-golang.
>> - I think I addressed most (if all) of the comments from Michael, ie.
>> DEP-3 patches, more lintian warnings fixed, and others all along the
>> discussion.
>>
>> So let me sum up here the list of packages we're talking about, and that
>> received changes.
>>
>> FORGET ABOUT (because it's not needed anymore)
>> > mcgowan-go-tar>
>> 
>> > rometheus-client-golang>
>> 
>>
>> CLONE AGAIN (don't pull because I re-wrote history)
>>
>> > ocker-go-metrics>
>> 
>>
>
> Uploaded.
>
>
>>
>>
>> PULL - there are a few changes
>>
>> 
>> 
>>
>
> I’ll hold off with this one until the build-deps are satisfied.
>
> By the way, do you want to include the most recent commits in the
> debian/changelog entry?
>
>
> Yep sure, I just updated the changelog and pushed it all.
>

I can’t seem to build this because
https://tracker.debian.org/pkg/golang-github-opencontainers-image-spec is
broken, and I’m not entirely sure why/how to fix it. Any hints welcome.


>
>
>
>
>> 
>> 
>>
>
> Looks good. Can you move this repository to its intended location
> https://salsa.debian.org/go-team/packages/continuity please?
>
>
> Repo moved.
>

Uploaded.


>
>
>
> > ontainerd-btrfs>
>> 
>>
>
>  The description for golang-github-containerd-btrfs-dev should be
> trimmed: upstream’s recommendation to vendor the package doesn’t make sense
> in Debian, and neither does the contribution guidelines.
>
> Looks good otherwise. Can you move it to https://salsa.debian.org/go
> -team/packages/golang-github-containerd-btrfs please?
>
>
> Description updated, repo moved.
>

Uploaded.


>
>
>
> > ontainerd-typeurl>
>> 
>>
>
>  Looks good. Can you move this to https://salsa.debian.org/go
> -team/packages/golang-github-containerd-typeurl please?
>
>
> Repo moved.
>

Uploaded.


>
>
>
> > ocker-go-events>
>> 
>>
>
>  Uploaded.
>
> > pencontainers-image-spec>
>> 
>>
>
>  This one is missing a debian/changelog entry for your changes.
>
>
> Indeed, I pushed some last changes.
>

Looks good, can you move it please?


>
>
> 
>> 
>>
>
> Looks good. Can you move this to https://salsa.debian.org/el
> boulangero-guest/golang-gogottrpc please?
>
>
> Repo moved.
>

Uploaded.


>
>
>
>
>>
>>
>> PULL - these packages have been rejected due to copyright issues
>>
>> > tainerd-console>
>> 
>>
>
> Uploaded.
>
>
>> 
>> 
>>
>
> Uploaded.
>
>
>> > tainerd-go-runc>
>> 
>>
>
> Uploaded.
>
>
> Ok, according to the mails from FTP Masters 'fifo' and 'go-runc' have made
> 

Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud Rebillout]

On 03/20/2018 02:36 PM, Michael Stapelberg wrote:
>
>
> On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout
>  > wrote:
>
> Hello all, let me follow up on this !
>
> According to discussions on this mailing list, I made the
> following changes on the packages:
>
> - the license issues have been clarified with containerd projects,
> except for containerd-typeurl which doesn't receive much attention
> from upstream. As a consequence I let the copyright to
> 'containerd', except if there's a better thing to do (like,
> nothing in the copyright field ?).
> - I re-packaged docker-go-metrics to a lower version, so that
> there is no need to bump prometheus-client-golang.
> - I think I addressed most (if all) of the comments from Michael,
> ie. DEP-3 patches, more lintian warnings fixed, and others all
> along the discussion.
>
> So let me sum up here the list of packages we're talking about,
> and that received changes.
>
> FORGET ABOUT (because it's not needed anymore)
>
> 
> 
> 
> 
> 
> 
> 
> 
>
> CLONE AGAIN (don't pull because I re-wrote history)
>
> 
> 
> 
> 
>
>
> Uploaded.
>  
>
>
>
> PULL - there are a few changes
>
> 
> 
>
>
> I’ll hold off with this one until the build-deps are satisfied.
>
> By the way, do you want to include the most recent commits in the
> debian/changelog entry?

Yep sure, I just updated the changelog and pushed it all.

>  
>
> 
> 
>
>
> Looks good. Can you move this repository to its intended location
> https://salsa.debian.org/go-team/packages/continuity please?

Repo moved.

>
> 
> 
> 
> 
>
>
>  The description for golang-github-containerd-btrfs-dev should be
> trimmed: upstream’s recommendation to vendor the package doesn’t make
> sense in Debian, and neither does the contribution guidelines.
>
> Looks good otherwise. Can you move it
> to https://salsa.debian.org/go-team/packages/golang-github-containerd-btrfs
> please?

Description updated, repo moved.

>
> 
> 
> 
> 
>
>
>  Looks good. Can you move this
> to https://salsa.debian.org/go-team/packages/golang-github-containerd-typeurl
> please?

Repo moved.

>
> 
> 
> 
> 
>
>
>  Uploaded.
>
> 
> 
> 
> 
>
>
>  This one is missing a debian/changelog entry for your changes.

Indeed, I pushed some last changes.
>
> 
> 
>
>
> Looks good. Can you move this
> to https://salsa.debian.org/elboulangero-guest/golang-gogottrpc
>  please?

Repo moved.

>  
>
>
>
> PULL - these packages have been rejected due to copyright issues
>
> 
> 
> 
> 
>
>
> Uploaded.
>  
>
> 
> 
>
>
> Uploaded.
>  
>
> 
> 
> 
> 
>
>
> Uploaded.

Ok, according to the mails from FTP Masters 'fifo' and 'go-runc' have
made it to the NEW queue.

However 'console' seem to have an issue, it is REJECTED because
'Source-only uploads' are not accepted. Is there anything I can do here ?

>  
>
>
> PULL 

Re: [pkg-go] Call for review - containerd and dependencies

[Michael Stapelberg]

On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout <
arnaud.rebill...@collabora.com> wrote:

> Hello all, let me follow up on this !
>
> According to discussions on this mailing list, I made the following
> changes on the packages:
> - the license issues have been clarified with containerd projects, except
> for containerd-typeurl which doesn't receive much attention from upstream.
> As a consequence I let the copyright to 'containerd', except if there's a
> better thing to do (like, nothing in the copyright field ?).
> - I re-packaged docker-go-metrics to a lower version, so that there is no
> need to bump prometheus-client-golang.
> - I think I addressed most (if all) of the comments from Michael, ie.
> DEP-3 patches, more lintian warnings fixed, and others all along the
> discussion.
>
> So let me sum up here the list of packages we're talking about, and that
> received changes.
>
> FORGET ABOUT (because it's not needed anymore)
>  github-dmcgowan-go-tar>
> 
>  github-prometheus-client-golang>
> 
>
> CLONE AGAIN (don't pull because I re-wrote history)
>
>  github-docker-go-metrics>
> 
>

Uploaded.


>
>
> PULL - there are a few changes
>
> 
> 
>

I’ll hold off with this one until the build-deps are satisfied.

By the way, do you want to include the most recent commits in the
debian/changelog entry?


> 
> 
>

Looks good. Can you move this repository to its intended location
https://salsa.debian.org/go-team/packages/continuity please?


> 
>

 The description for golang-github-containerd-btrfs-dev should be trimmed:
upstream’s recommendation to vendor the package doesn’t make sense in
Debian, and neither does the contribution guidelines.

Looks good otherwise. Can you move it to
https://salsa.debian.org/go-team/packages/golang-github-containerd-btrfs
please?

 github-containerd-typeurl>
> 
>

 Looks good. Can you move this to
https://salsa.debian.org/go-team/packages/golang-github-containerd-typeurl
please?


> 
>

 Uploaded.

 github-opencontainers-image-spec>
> 
>

 This one is missing a debian/changelog entry for your changes.


> 
>

Looks good. Can you move this to https://salsa.debian.org/
elboulangero-guest/golang-gogottrpc please?


>
>
> PULL - these packages have been rejected due to copyright issues
>
>  containerd-console>
> 
>

Uploaded.


> 
> 
>

Uploaded.


>  containerd-go-runc>
> 
>

Uploaded.


>
>
> PULL - this package is already in Debian Sid, should I issue a new Debian
> release due to copyright change ?
>
>  containerd-cgroups>
> 
>

Yes please. It’s always good to not leave pending changes lying around (for
people touching the package in the future).


>
>
> Ok I think I didn't forget anything :)
>
> Feel free to tell me if there's anything that is still not ok with these
> packages, if there's anything I should do. Like, should I always finish
> with a commit that updates the changelog
>

Yes please.


> (which I didn't do), or not ? Is it OK to have a debian release ending
> with '-2' or more if the package was *never* uploaded before (I know that
> reprepro doesn't like that, but I guess the Debian infra doesn't use
> reprepro).
>

Debian 

Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud Rebillout]

Hello all, let me follow up on this !

According to discussions on this mailing list, I made the following
changes on the packages:

- the license issues have been clarified with containerd projects,
except for containerd-typeurl which doesn't receive much attention from
upstream. As a consequence I let the copyright to 'containerd', except
if there's a better thing to do (like, nothing in the copyright field ?).
- I re-packaged docker-go-metrics to a lower version, so that there is
no need to bump prometheus-client-golang.
- I think I addressed most (if all) of the comments from Michael, ie.
DEP-3 patches, more lintian warnings fixed, and others all along the
discussion.

So let me sum up here the list of packages we're talking about, and that
received changes.

FORGET ABOUT (because it's not needed anymore)




CLONE AGAIN (don't pull because I re-wrote history)



PULL - there are a few changes









PULL - these packages have been rejected due to copyright issues





PULL - this package is already in Debian Sid, should I issue a new
Debian release due to copyright change ?



Ok I think I didn't forget anything :)

Feel free to tell me if there's anything that is still not ok with these
packages, if there's anything I should do. Like, should I always finish
with a commit that updates the changelog (which I didn't do), or not ?
Is it OK to have a debian release ending with '-2' or more if the
package was *never* uploaded before (I know that reprepro doesn't like
that, but I guess the Debian infra doesn't use reprepro).

Thanks a lot for the time and energy spend on that.

  Arnaud

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Call for review - containerd and dependencies

[Michael Stapelberg]

On Fri, Mar 2, 2018 at 4:38 AM, Arnaud 
wrote:

> Hi,
>
> I addressed all your comments, thanks very much for the feedback. More
> details bellow.
>
> On 02/28/2018 04:05 PM, Michael Stapelberg wrote:
>
>
>
>>  containerd
>> 
>> - As for testing the thing really, I didn't go far yet, I just launched
>>   the binary, the log messages that appeared looked healthy enough,
>>   and that's all for now.
>>
>
> Some of the comments below apply (unnecessary-team-upload, DEP-3 headers
> for patches).
>
>
> Fixed.
>
> Also, this requires golang-github-containerd-console-dev to build, which
> is not in the archive and not in this list of packages?
>
>
> golang-github-containerd-console is available at
>  containerd-console>
> 
>
> It was part of the very first packages I made, that's why it's in `
> salsa.debian.org/go-team/packages`
> .
>
> The last time I heard from it it Debian FTP Masters, it said:
>
>   Your package has been put into the NEW queue, which requires manual
> action
>   from the ftpteam to process. The upload was otherwise valid (it had a
> good
>   OpenPGP signature and file hashes are valid), so please be patient.
>
>
Yeah, I see that mail, but I can’t see the package in
https://ftp-master.debian.org/new.822. Might be worth sending an email to
ftp-master about this discrepancy.


>
>
>>
>>  golang-github-docker-go-events
>> > docker-go-events>
>>
>
> Can you address these please?
> P: golang-github-docker-go-events source: file-contains-trailing-whitespace
> debian/control (line 25)
> W: golang-github-docker-go-events source: unnecessary-team-upload
>
>
> Fixed.
>
> I: golang-github-docker-go-events source: vcs-field-uses-insecure-uri
> vcs-git git://anonscm.debian.org/pkg-go/packages/golang-github-
> docker-go-events.git
>
>
> I don't have this warning, neither from lintian Stretch, neither from
> lintian backported from Buster. What do I miss ?
>

Are you enabling all the options I have enabled? See
https://github.com/stapelberg/configfiles/blob/master/lintianrc


>
> Anyway, I compared with other packages and fixed it.
>
>
>
>>
>>  golang-github-docker-go-metrics
>> > docker-go-metrics>
>>
>
> Can’t build this until golang-github-prometheus-client-golang is fixed.
> Some of the lintian warnings above seem to apply here, too, though.
>
>
> Lintian warnings fixed.
>
>
>>
>>
>>  golang-github-prometheus-client-golang
>> > prometheus-client-golang>
>>
>
> This package cannot be cloned with gbp as-is:
>
> % gbp clone https://salsa.debian.org/elboulangero-guest/golang-
> github-prometheus-client-golang
> gbp:info: Cloning from 'https://salsa.debian.org/
> elboulangero-guest/golang-github-prometheus-client-golang'
> gbp:error: Git command failed: Error running git checkout: error: pathspec
> 'master' did not match any file(s) known to git.
>
> I think you’ll need to set debian-branch in debian/gbp.conf.
>
>
> OK, I just changed the default branch in the GitLab settings, and set it
> to `debian/sid`, which is the branch I worked on, and which comes with a
> proper gbp.conf. The default branch before was `debian/jessie-backports`,
> and it doesn't have a gpb.conf.
>
> So now gbp cone works.
>
> This package has no `master` branch, only a `debian/jessie-backports` and
> `debian/sid`. I think it's what DEP-14 recommends so I prefer not to change
> anything here, even more because I'm bumping someone else package.
>

Thanks, the package indeed builds now.

Could you send an email to tincho@ about reviewing/merging these changes
please? I think your update of the upstream branch is different from how
tincho uses the upstream branch.


>
>
>
>  continuity
>> 
>> 
>> - I ran the series of test described at
>>   ,
>>   everything went fine.
>>
>
> It would be good to add a manpage for the continuity binary. Otherwise,
> the package looks fine.
>
>
> Agreed, well, I'm running out of time on that project, so I skip for now,
> if it's ok with you.
>
>
>
>>
>>  golang-gogottrpc
>> 
>> 
>> - Patch and issues submitted upstream.
>>
>
> Can you add DEP-3 tags to the patches please? See http://dep.debian.net/
> deps/dep3/. No need to go overboard, just the 
> last-updated/author/description/forwarded
> ones.
>
>
> Fixed.
>
>
> Also, there seems to be a lintian false-positive: it 

Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud]

Hi,

I addressed all your comments, thanks very much for the feedback. More
details bellow.

On 02/28/2018 04:05 PM, Michael Stapelberg wrote:
>
>
>  containerd
>  >
> - As for testing the thing really, I didn't go far yet, I just
> launched
>   the binary, the log messages that appeared looked healthy enough,
>   and that's all for now.
>
>
> Some of the comments below apply (unnecessary-team-upload, DEP-3
> headers for patches).

Fixed.

> Also, this requires golang-github-containerd-console-dev to build,
> which is not in the archive and not in this list of packages?

golang-github-containerd-console is available at


It was part of the very first packages I made, that's why it's in
`salsa.debian.org/go-team/packages`.

The last time I heard from it it Debian FTP Masters, it said:

  Your package has been put into the NEW queue, which requires manual action
  from the ftpteam to process. The upload was otherwise valid (it had a good
  OpenPGP signature and file hashes are valid), so please be patient.

>  
>
>
>  golang-github-docker-go-events
> 
>  
> >
>
>
> Can you address these please?
> P: golang-github-docker-go-events source:
> file-contains-trailing-whitespace debian/control (line 25)
> W: golang-github-docker-go-events source: unnecessary-team-upload

Fixed.

> I: golang-github-docker-go-events source: vcs-field-uses-insecure-uri
> vcs-git
> git://anonscm.debian.org/pkg-go/packages/golang-github-docker-go-events.git
> 

I don't have this warning, neither from lintian Stretch, neither from
lintian backported from Buster. What do I miss ?

Anyway, I compared with other packages and fixed it.

>  
>
>
>  golang-github-docker-go-metrics
> 
>  
> >
>
>
> Can’t build this until golang-github-prometheus-client-golang is
> fixed. Some of the lintian warnings above seem to apply here, too, though.

Lintian warnings fixed.

>  
>
>
>  golang-github-prometheus-client-golang
> 
>  
> >
>
>
> This package cannot be cloned with gbp as-is:
>
> % gbp clone
> https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang
> gbp:info: Cloning from
> 'https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang'
> gbp:error: Git command failed: Error running git checkout: error:
> pathspec 'master' did not match any file(s) known to git.
>
> I think you’ll need to set debian-branch in debian/gbp.conf.

OK, I just changed the default branch in the GitLab settings, and set it
to `debian/sid`, which is the branch I worked on, and which comes with a
proper gbp.conf. The default branch before was
`debian/jessie-backports`, and it doesn't have a gpb.conf.

So now gbp cone works.

This package has no `master` branch, only a `debian/jessie-backports`
and `debian/sid`. I think it's what DEP-14 recommends so I prefer not to
change anything here, even more because I'm bumping someone else package.

>
>  continuity
>  >
>  >
> - I ran the series of test described at
>    >,
>   everything went fine.
>
>
> It would be good to add a manpage for the continuity binary.
> Otherwise, the package looks fine.

Agreed, well, I'm running out of time on that project, so I skip for
now, if it's ok with you.

>  
>
>
>  golang-gogottrpc
>  >
>  >
> - Patch and issues submitted upstream.
>
>
> Can you add DEP-3 tags to the patches please?
> See http://dep.debian.net/deps/dep3/. No need to go overboard, just
> the last-updated/author/description/forwarded ones.

Fixed.

>
> Also, there seems to be a lintian false-positive: it reports
> statically-linked-binary despite the 

Re: [pkg-go] Call for review - containerd and dependencies

[Michael Stapelberg]

On Wed, Feb 28, 2018 at 3:49 AM, Arnaud 
wrote:

>
>
> On 02/27/2018 03:32 AM, Michael Stapelberg wrote:
> > Once you feel your packages are ready for review (possibly this reply
> > prompts some changes?), please send an up-to-date list of git URLs to
> > what you’d like reviewed. Thanks!
>
> Ok, here is the package list again, I prefer to leave all the packages
> on my personal salsa space for now, just so that I can fix every details
> according to your feedback, then cleanup the git history, and then move
> that definitive version to alioth or salsa, where applicable.
>
> URLS are the same as the initial email, it's just a copy/paste of the
> initial email, from which I removed comments that are not applicable
> anymore.
>
>
>
> BUMPED PACKAGES
> ---
>
>  containerd
> 
> - As for testing the thing really, I didn't go far yet, I just launched
>   the binary, the log messages that appeared looked healthy enough,
>   and that's all for now.
>

Some of the comments below apply (unnecessary-team-upload, DEP-3 headers
for patches).

Also, this requires golang-github-containerd-console-dev to build, which is
not in the archive and not in this list of packages?


>
>  golang-github-docker-go-events
>  github-docker-go-events>
>

Can you address these please?
P: golang-github-docker-go-events source: file-contains-trailing-whitespace
debian/control (line 25)
I: golang-github-docker-go-events source: vcs-field-uses-insecure-uri
vcs-git git://
anonscm.debian.org/pkg-go/packages/golang-github-docker-go-events.git
W: golang-github-docker-go-events source: unnecessary-team-upload

Aside from that, it looks good.


>
>  golang-github-docker-go-metrics
>  github-docker-go-metrics>
>

Can’t build this until golang-github-prometheus-client-golang is fixed.
Some of the lintian warnings above seem to apply here, too, though.


>
>  golang-github-opencontainers-image-spec
>  github-opencontainers-image-spec>
> - I noticed only after doing all the work that Michael Stapelberg was
>   working on this package lately. I hope I don't duplicate the work.
> - I'm not sure about the gbp.conf commit, please confirm whether
>   it's ok.
>

The gbp.conf change is okay. We should eventually clean up gbp.conf across
our packages, but we have enough going on for now.

The package looks good.


>
>  golang-github-prometheus-client-golang
>  github-prometheus-client-golang>
>

This package cannot be cloned with gbp as-is:

% gbp clone
https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang
gbp:info: Cloning from '
https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang
'
gbp:error: Git command failed: Error running git checkout: error: pathspec
'master' did not match any file(s) known to git.

I think you’ll need to set debian-branch in debian/gbp.conf.


>
>
>
> NEW PACKAGES
> 
>
>  continuity
> 
> 
> - I ran the series of test described at
>   ,
>   everything went fine.
>

It would be good to add a manpage for the continuity binary. Otherwise, the
package looks fine.


>
>  golang-gogottrpc
> 
> 
> - Patch and issues submitted upstream.
>

Can you add DEP-3 tags to the patches please? See
http://dep.debian.net/deps/dep3/. No need to go overboard, just the
last-updated/author/description/forwarded ones.

Also, there seems to be a lintian false-positive: it reports
statically-linked-binary despite the Build-Depends on golang-go. Can you
file a lintian bug about that please?


>
>  golang-github-containerd-btrfs
>  github-containerd-btrfs>
> 
> - I disabled the test to avoid installing a btrfs-test binary. I don't
>   think it makes sense to create an additional binary package
>   just for shipping this test.
>

Sounds good. Maybe change cmd to cmd/btrfs-test so that we’ll notice newly
introduced binaries upon updates? Otherwise, the package looks good.


>
>  golang-github-containerd-typeurl
>  github-containerd-typeurl>
> 
> - Patch submitted upstream
>

Please add DEP-3 tags to the patch. Looks good otherwise.


>
>  golang-github-dmcgowan-go-tar
>  >
> 

Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud]

On 02/27/2018 03:32 AM, Michael Stapelberg wrote:
>
> There's a `docs/.gitignore`, it's in a subdirectory. Files-Excluded
> will remove it from the orig tarball, right ? Is it really suitable here ?
>
> Correct, and up to you (see the caveat which tincho expressed). Bug
> #812721 discusses a gbp import-ref command which would honor
> Files-Excluded, but we’re not quite there yet. So, if you want to
> stick to orig tarballs for the time being, Files-Excluded will work.

In the end I solved it a better way, simply by being more selective in
debian/docs.

>  
>
>
> For the moment the only package in which I exclude a file from
> installation is done this way:
>
> override_dh_auto_install:
>     dh_auto_install
>     find $(CURDIR)/debian -name '.tool' -type d -prune -exec rm -r
> '{}' +
>
>
> nit: use find’s -delete action?

Nope :) `-delete` only works for files, not directories.

My concern here is not so much about the find command, but it's more the
location where I look for files. Here I use $(CURDIR)/debian, and it
works, but I'm surprised that there is not a "BUILDDIR" variable
defined, or something similar. I'm not sure if using $(CURDIR)/debian
works for every package in every situation, I don't know enough about
the internals.

>
> Ah, I see what’s wrong here: you are supposed to run lintian on a
> .changes file, so that it can inspect both the binary packages (*.deb)
> and the source package (*.dsc). Indeed, when building gogoprotobuf and
> running “lintian golang-gogoprotobuf_0.5-1_amd64.changes”, I don’t get
> any warnings about statically linked binaries.

A indeed, thanks for pointing that.

>
>
>>  
>>
>>
>> In the `-dev` packages, is `${shlibs:Depends}` needed ?
>> During the builds
>> I see `unknown substitution variable ${shlibs:Depends}`
>> passing by.
>>
>>
>> The messages implies it’s not required. I’m not entirely sure,
>> but would suggest removing it for now.
>
> Ok. I think it should be also changed in dh-make-golang, should I
> look there and issue a PR, or do you prefer not to touch it for now ?
>
>
> Please feel free to send a PR! :)

Done !

Thanks again for all the explanations, that helps a lot.

  Arnaud
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud]

On 02/27/2018 03:32 AM, Michael Stapelberg wrote:
> Once you feel your packages are ready for review (possibly this reply
> prompts some changes?), please send an up-to-date list of git URLs to
> what you’d like reviewed. Thanks!

Ok, here is the package list again, I prefer to leave all the packages
on my personal salsa space for now, just so that I can fix every details
according to your feedback, then cleanup the git history, and then move
that definitive version to alioth or salsa, where applicable.

URLS are the same as the initial email, it's just a copy/paste of the
initial email, from which I removed comments that are not applicable
anymore.



BUMPED PACKAGES
---

 containerd

- As for testing the thing really, I didn't go far yet, I just launched
  the binary, the log messages that appeared looked healthy enough,
  and that's all for now.

 golang-github-docker-go-events


 golang-github-docker-go-metrics


 golang-github-opencontainers-image-spec

- I noticed only after doing all the work that Michael Stapelberg was
  working on this package lately. I hope I don't duplicate the work.
- I'm not sure about the gbp.conf commit, please confirm whether
  it's ok.

 golang-github-prometheus-client-golang




NEW PACKAGES


 continuity


- I ran the series of test described at
  ,
  everything went fine.

 golang-gogottrpc


- Patch and issues submitted upstream.

 golang-github-containerd-btrfs


- I disabled the test to avoid installing a btrfs-test binary. I don't
  think it makes sense to create an additional binary package
  just for shipping this test.

 golang-github-containerd-typeurl


- Patch submitted upstream

 golang-github-dmcgowan-go-tar


- This one was a tricky one, please read the commit messages for details.


Best,

  Arnaud

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Call for review - containerd and dependencies

[Michael Stapelberg]

Once you feel your packages are ready for review (possibly this reply
prompts some changes?), please send an up-to-date list of git URLs to what
you’d like reviewed. Thanks!

Replies inline:

On Fri, Feb 23, 2018 at 11:40 AM, Arnaud 
wrote:

>
>
> On 02/23/2018 05:10 PM, Michael Stapelberg wrote:
>
> I can’t have a look at the individual packages right now
>
>
> No rush !
>
>  containerd
>> 
>> - There's a lintian warning about package-contains-vcs-control-file, but
>> until
>>   now I didn't find the right way to remove a file from installation. I
>> guess
>>   `override_dh_auto_install` is the way to go. Any hint welcome here.
>>
>
> Which file specifically is affected? The Files-Excluded directive in
> debian/copyright is a good way to exclude files.
>
>
> There's a `docs/.gitignore`, it's in a subdirectory. Files-Excluded will
> remove it from the orig tarball, right ? Is it really suitable here ?
>

Correct, and up to you (see the caveat which tincho expressed). Bug #812721
discusses a gbp import-ref command which would honor Files-Excluded, but
we’re not quite there yet. So, if you want to stick to orig tarballs for
the time being, Files-Excluded will work.


>
> For the moment the only package in which I exclude a file from
> installation is done this way:
>
> override_dh_auto_install:
> dh_auto_install
> find $(CURDIR)/debian -name '.tool' -type d -prune -exec rm -r '{}' +
>

nit: use find’s -delete action?


>
> Not really elegant, and it took me two hours to come up with that, after
> trying and failing every other way possible...
>
>
>
>>
>>  golang-github-containerd-btrfs
>> > ontainerd-btrfs>
>> 
>> - I disabled the test to avoid installing a btrfs-test binary, plus I
>> think the
>>   test failed for some reason, I'm not sure to remember though...
>>
>
> To avoid installing a binary, can you use the DH_GOLANG_EXCLUDES option
> please? See https://manpages.debian.org/testing/dh-golang/Debian::De
> bhelper::Buildsystem::golang.3pm.en.html
>
> Also, please add a comment stating why precisely the tests are disabled,
> and what needs to change so that we can re-enable them.
>
>
> Ok I'll try harder :)
>
> I noticed that DH_GOLANG_EXCLUDES will not save me from a test which fails
> though. For example, when I was working with containerd/cgroups, the test
> commmand invoked by dh looks like that:
>
> go test -vet=off -v -p 8 github.com/containerd/cgroups
>
> DH_GOLANG_EXCLUDES is matched against github.com/containerd/cgroups, so
> if it contains a file inside the cgroups directory, it's not excluded from
> the files being tested.
>

DH_GOLANG_EXCLUDES, like the other directives, operates on Go packages, not
individual source code files. All files within github.com/containerd/cgroups
belong to the cgroups package, so you can only exclude it in its entirety,
which is not desired in this case.


>
> It means that if I want to prevent a file from the test, I still need to
> patch it with `// +build ignore`, if I understand properly.
>

Yes, if the whole file should be ignored. In case only individual tests are
affected, prefer using t.Skipf please:
https://golang.org/pkg/testing/#T.Skipf


>
>
>
>
>>
>> I see that most binaries come with the lintian warning
>> `statically-linked-binary`, I guess it's just the way it works in the
>> go world. Should I just add a lintian override ?
>>
>
> lintian does not emit the statically-linked-binary tag for Go packages.
> Can you point me to a specific example where you see it please?
>
>
> Yep, easy.
>
>   apt-get download gogoprotobuf
>   lintian gogoprotobuf_*_amd64.deb
>

Ah, I see what’s wrong here: you are supposed to run lintian on a .changes
file, so that it can inspect both the binary packages (*.deb) and the
source package (*.dsc). Indeed, when building gogoprotobuf and running
“lintian golang-gogoprotobuf_0.5-1_amd64.changes”, I don’t get any warnings
about statically linked binaries.


>
> Is this warning related to the field `Built-Using: ${misc:Built-Using}`
> for binary packages ? After reading the Debian Policy Manual, I seem to
> understand that this field is needed for go binary packages, am I correct ?
>

I don’t see a connection between the two fields. lintian examines the
Build-Depends field for detecting Go packages. Specifically, a package is a
Go package if golang-go or golang-any are present in Build-Depends.

Aside from that, yes, Built-Using must be set when building Go binary
packages, and must be unset for Go library packages. I have recently added
lintian warnings which cover these cases, but they’re not yet in a released
lintian version.


>
> However even with this field, there is still the warning in the
> `containerd` binary package that I built here, but only for *some* of the
> binaries in the package, not 

Re: [pkg-go] Call for review - containerd and dependencies

[Martín Ferrari]

On 23/02/18 11:10, Michael Stapelberg wrote:

> Which file specifically is affected? The Files-Excluded directive in
> debian/copyright is a good way to exclude files.

Not anymore.. If you are not using import-orig and the like, that is
effectively ignored.

-- 
Martín Ferrari (Tincho)

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Call for review - containerd and dependencies

[Arnaud]

On 02/23/2018 05:10 PM, Michael Stapelberg wrote:
> I can’t have a look at the individual packages right now

No rush !

>  containerd
>  >
> - There's a lintian warning about
> package-contains-vcs-control-file, but
> until
>   now I didn't find the right way to remove a file from
> installation. I
> guess
>   `override_dh_auto_install` is the way to go. Any hint welcome here.
>
>
> Which file specifically is affected? The Files-Excluded directive in
> debian/copyright is a good way to exclude files.

There's a `docs/.gitignore`, it's in a subdirectory. Files-Excluded will
remove it from the orig tarball, right ? Is it really suitable here ?

For the moment the only package in which I exclude a file from
installation is done this way:

override_dh_auto_install:
    dh_auto_install
    find $(CURDIR)/debian -name '.tool' -type d -prune -exec rm -r '{}' +

Not really elegant, and it took me two hours to come up with that, after
trying and failing every other way possible...

>  
>
>
>  golang-github-containerd-btrfs
> 
>  
> >
>  >
> - I disabled the test to avoid installing a btrfs-test binary,
> plus I think the
>   test failed for some reason, I'm not sure to remember though...
>
>
> To avoid installing a binary, can you use the DH_GOLANG_EXCLUDES
> option please?
> See 
> https://manpages.debian.org/testing/dh-golang/Debian::Debhelper::Buildsystem::golang.3pm.en.html
>
> Also, please add a comment stating why precisely the tests are
> disabled, and what needs to change so that we can re-enable them.

Ok I'll try harder :)

I noticed that DH_GOLANG_EXCLUDES will not save me from a test which
fails though. For example, when I was working with containerd/cgroups,
the test commmand invoked by dh looks like that:

    go test -vet=off -v -p 8 github.com/containerd/cgroups

DH_GOLANG_EXCLUDES is matched against github.com/containerd/cgroups, so
if it contains a file inside the cgroups directory, it's not excluded
from the files being tested.

It means that if I want to prevent a file from the test, I still need to
patch it with `// +build ignore`, if I understand properly.

>  
>
>
> I see that most binaries come with the lintian warning
> `statically-linked-binary`, I guess it's just the way it works in the
> go world. Should I just add a lintian override ?
>
>
> lintian does not emit the statically-linked-binary tag for Go
> packages. Can you point me to a specific example where you see it please?

Yep, easy.

  apt-get download gogoprotobuf
  lintian gogoprotobuf_*_amd64.deb

Is this warning related to the field `Built-Using: ${misc:Built-Using}`
for binary packages ? After reading the Debian Policy Manual, I seem to
understand that this field is needed for go binary packages, am I correct ?

However even with this field, there is still the warning in the
`containerd` binary package that I built here, but only for *some* of
the binaries in the package, not all of them.

>  
>
>
> In the `-dev` packages, is `${shlibs:Depends}` needed ? During the
> builds
> I see `unknown substitution variable ${shlibs:Depends}` passing by.
>
>
> The messages implies it’s not required. I’m not entirely sure, but
> would suggest removing it for now.

Ok. I think it should be also changed in dh-make-golang, should I look
there and issue a PR, or do you prefer not to touch it for now ?

>  
>
>
> In the `-dev` packages, do we really need to copy-paste all the
> dependencies from the source package ?
>
>
> Yes. They differ in some cases, for example when code generation needs
> more dependencies than the actual compilation/test (in which case the
> extra dependencies show up only in Build-Depends, not Depends).

Ok...

Thanks !

  Arnaud
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Call for review - containerd and dependencies

[Michael Stapelberg]

I can’t have a look at the individual packages right now (but might have
some time in the evening/over the weekend), but here’s some quick feedback:

On Fri, Feb 23, 2018 at 11:01 AM, Arnaud 
wrote:

> Hello Go Packaging Team,
>
> I reached a milestone, I managed to get an up-to-date containerd package!
>

Congratulations!


>
> I changed a bit my workflow and worked on my "personal staging area" in
> salsa, ie `salsa.debian.org/elboulangero-guest`, rather than directly
> in `salsa.debian.org/go-team`. I find it more convenient, I can mess
> around without bothering anyone.
>
> I also packaged several packages before asking a review, as I don'twant
> to waste your time with my iterations, and ask you to review thingsthat
> in the end are not needed.
>
> So now, the bad news is that there's quite a bunch of packages to review,
> but the good news is that if it's all good, then we have the latest
> containerd in Debian, and then we're closer to having docker packaged
> as well (I can't say exactly *how close* though...) !
>
> So here comes the review list, with links and comments !
>
>
>
> BUMPED PACKAGES
> ---
>
> I forked the packages from `anonscm.debian.org` into my personal staging
> area `salsa.debian.org/elboulangero-guest`.
>
> I don't think I have write access to `anonscm.debian.org`, although I
> didn't try. I just don't want to mess up so it's more convenient to use
> my personal namespace on salsa.
>

You are a pkg-go member on alioth, so you do have write access.


>
> I didn't touch the control urls in `debian/control`, so I believe that my
> changes can be merged into the anonscm.debian.org repository without any
> drama. Well, I hope :)
>
>  containerd
> 
> - There's a lintian warning about package-contains-vcs-control-file, but
> until
>   now I didn't find the right way to remove a file from installation. I
> guess
>   `override_dh_auto_install` is the way to go. Any hint welcome here.
>

Which file specifically is affected? The Files-Excluded directive in
debian/copyright is a good way to exclude files.


> - As for testing the thing really, I didn't go far yet, I just launched
>   the binary, the log messages that appeared looked healthy enough, and
>   that's all for now.
>
>  golang-github-docker-go-events
>  github-docker-go-events>
>
>  golang-github-docker-go-metrics
>  github-docker-go-metrics>
>
>  golang-github-opencontainers-image-spec
>  github-opencontainers-image-spec>
> - I noticed only after doing all the work that Michael Stapelberg was
>   working on this package lately. I hope I don't duplicate the work.
> - The 3 last commits are probably not that good, please advise and I'll
>   fix it.
>
>  golang-github-prometheus-client-golang
>  github-prometheus-client-golang>
>
>
>
> NEW PACKAGES
> 
>
> These packages live in my personal staging area, that is:
> `salsa.debian.org/elboulangero-guest`. However the control urls are set to
> `salsa.debian.org/go-team`, so I believe it's just a matter of moving the
> repository there if you give me your ack.
>
>  continuity
> 
> 
> - Produces continuity and golang-github-containerd-continuity-dev.
>   I looked at the existing packages docker and docker-containerd for
>   guidance.
> - I ran the series of test described at
> ,
>   everything went fine.
>
>  golang-gogottrpc
> 
> 
> - Produces golang-gogottrpc and golang-github-stevvooe-ttrpc-dev.
>   I looked at the existing package golang-gogoprotobuf for guidance.
> - Patch and issues submitted upstream.
>
>  golang-github-containerd-btrfs
>  github-containerd-btrfs>
> 
> - I disabled the test to avoid installing a btrfs-test binary, plus I
> think the
>   test failed for some reason, I'm not sure to remember though...
>

To avoid installing a binary, can you use the DH_GOLANG_EXCLUDES option
please? See
https://manpages.debian.org/testing/dh-golang/Debian::Debhelper::Buildsystem::golang.3pm.en.html

Also, please add a comment stating why precisely the tests are disabled,
and what needs to change so that we can re-enable them.


>
>  golang-github-containerd-typeurl
>  github-containerd-typeurl>
> 
> - Patch submitted upstream
>
>  

[pkg-go] Call for review - containerd and dependencies

[Arnaud]

Hello Go Packaging Team,

I reached a milestone, I managed to get an up-to-date containerd package!

I changed a bit my workflow and worked on my "personal staging area" in
salsa, ie `salsa.debian.org/elboulangero-guest`, rather than directly
in `salsa.debian.org/go-team`. I find it more convenient, I can mess
around without bothering anyone.

I also packaged several packages before asking a review, as I don'twant
to waste your time with my iterations, and ask you to review thingsthat
in the end are not needed.

So now, the bad news is that there's quite a bunch of packages to review,
but the good news is that if it's all good, then we have the latest
containerd in Debian, and then we're closer to having docker packaged
as well (I can't say exactly *how close* though...) !

So here comes the review list, with links and comments !



BUMPED PACKAGES
---

I forked the packages from `anonscm.debian.org` into my personal staging
area `salsa.debian.org/elboulangero-guest`.

I don't think I have write access to `anonscm.debian.org`, although I
didn't try. I just don't want to mess up so it's more convenient to use
my personal namespace on salsa.

I didn't touch the control urls in `debian/control`, so I believe that my
changes can be merged into the anonscm.debian.org repository without any
drama. Well, I hope :)

 containerd

- There's a lintian warning about package-contains-vcs-control-file, but
until
  now I didn't find the right way to remove a file from installation. I
guess
  `override_dh_auto_install` is the way to go. Any hint welcome here.
- As for testing the thing really, I didn't go far yet, I just launched
  the binary, the log messages that appeared looked healthy enough, and
  that's all for now.

 golang-github-docker-go-events


 golang-github-docker-go-metrics


 golang-github-opencontainers-image-spec

- I noticed only after doing all the work that Michael Stapelberg was
  working on this package lately. I hope I don't duplicate the work.
- The 3 last commits are probably not that good, please advise and I'll
  fix it.

 golang-github-prometheus-client-golang




NEW PACKAGES


These packages live in my personal staging area, that is:
`salsa.debian.org/elboulangero-guest`. However the control urls are set to
`salsa.debian.org/go-team`, so I believe it's just a matter of moving the
repository there if you give me your ack.

 continuity


- Produces continuity and golang-github-containerd-continuity-dev.
  I looked at the existing packages docker and docker-containerd for
  guidance.
- I ran the series of test described at
,
  everything went fine.

 golang-gogottrpc


- Produces golang-gogottrpc and golang-github-stevvooe-ttrpc-dev.
  I looked at the existing package golang-gogoprotobuf for guidance.
- Patch and issues submitted upstream.

 golang-github-containerd-btrfs


- I disabled the test to avoid installing a btrfs-test binary, plus I
think the
  test failed for some reason, I'm not sure to remember though...

 golang-github-containerd-typeurl


- Patch submitted upstream

 golang-github-dmcgowan-go-tar


- This one was a tricky one, please read the commit messages for details.



GENERAL QUESTIONS
-

I see that most binaries come with the lintian warning
`statically-linked-binary`, I guess it's just the way it works in the
go world. Should I just add a lintian override ?

In the `-dev` packages, is `${shlibs:Depends}` needed ? During the builds
I see `unknown substitution variable ${shlibs:Depends}` passing by.

In the `-dev` packages, do we really need to copy-paste all the
dependencies from the source package ?



Thanks for reading, waiting for your feedback.

Best regards,

  Arnaud

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org