Bug#761429: Acknowledgement (mapnik-vector-tile: new upload needed for protobuf 2.6.0 transition)
Robert Edmonds wrote: I've uploaded 0.5.1+dfsg-1.1 that fixes this bug to DELAYED/5. The diff is attached, and it is very simple :-) This upload was unfortunately eaten by the archive software since my key was replaced just after the upload to DEFERRED. Here is the diff for the -1.2 package that I just uploaded. -- Robert Edmonds edmo...@debian.org diff -Nru mapnik-vector-tile-0.5.1+dfsg/debian/changelog mapnik-vector-tile-0.5.1+dfsg/debian/changelog --- mapnik-vector-tile-0.5.1+dfsg/debian/changelog 2014-08-20 17:06:54.0 -0400 +++ mapnik-vector-tile-0.5.1+dfsg/debian/changelog 2014-09-23 11:57:12.0 -0400 @@ -1,3 +1,13 @@ +mapnik-vector-tile (0.5.1+dfsg-1.2) unstable; urgency=medium + + * Non-maintainer upload. + * No sourceful changes; rebuild against the latest protobuf-compiler due to +the transition in #760343. (Closes: #761429) + * (Second try: the upload of 0.5.1+dfsg-1.1 was eaten by the archive +software due to my key being replaced after the upload to DEFERRED.) + + -- Robert Edmonds edmo...@debian.org Tue, 23 Sep 2014 11:54:40 -0400 + mapnik-vector-tile (0.5.1+dfsg-1) unstable; urgency=medium * Upstream update ___ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
Bug#762643: [Pkg-javascript-devel] Bug#759843: node-mapnik: FTBFS: vector_tile_processor.hpp:48:38: fatal error: mapnik3x_compatibility.hpp: No such file or directory
tags 759843 pending tags 762643 pending thanks Robert Edmonds wrote: Since this blocks an ongoing library transition [0], I would be happy to NMU mapnik-vector-tile, since the fix is trivial. Hi, I've uploaded mapnik-vector-tile 0.5.1+dfsg-1.3 to DELAYED/3. This fixes #762643 (the lack of mapnik3x_compatibility.hpp in mapnik-vector-tile) and #759843 (the FTBFS in mapnik-vector-tile's reverse build dependency caused by #762643). The debdiff is attached. This allows node-mapnik to build again, which will allow the protobuf transition (#760343) to continue. -- Robert Edmonds edmo...@debian.org diff -Nru mapnik-vector-tile-0.5.1+dfsg/debian/changelog mapnik-vector-tile-0.5.1+dfsg/debian/changelog --- mapnik-vector-tile-0.5.1+dfsg/debian/changelog 2014-08-20 17:06:54.0 -0400 +++ mapnik-vector-tile-0.5.1+dfsg/debian/changelog 2014-09-23 21:28:52.0 -0400 @@ -1,3 +1,20 @@ +mapnik-vector-tile (0.5.1+dfsg-1.3) unstable; urgency=medium + + * Non-maintainer upload. + * Actually ship mapnik3x_compatibility.hpp. (Closes: #762643, #759843.) + + -- Robert Edmonds edmo...@debian.org Tue, 23 Sep 2014 21:28:10 -0400 + +mapnik-vector-tile (0.5.1+dfsg-1.2) unstable; urgency=medium + + * Non-maintainer upload. + * No sourceful changes; rebuild against the latest protobuf-compiler due to +the transition in #760343. (Closes: #761429) + * (Second try: the upload of 0.5.1+dfsg-1.1 was eaten by the archive +software due to my key being replaced after the upload to DEFERRED.) + + -- Robert Edmonds edmo...@debian.org Tue, 23 Sep 2014 11:54:40 -0400 + mapnik-vector-tile (0.5.1+dfsg-1) unstable; urgency=medium * Upstream update diff -Nru mapnik-vector-tile-0.5.1+dfsg/debian/install mapnik-vector-tile-0.5.1+dfsg/debian/install --- mapnik-vector-tile-0.5.1+dfsg/debian/install 2013-08-29 07:13:43.0 -0400 +++ mapnik-vector-tile-0.5.1+dfsg/debian/install 2014-09-23 20:50:32.0 -0400 @@ -1 +1,2 @@ +src/mapnik3x_compatibility.hpp usr/include src/vector_tile* usr/include ___ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
Bug#761429: mapnik-vector-tile: new upload needed for protobuf 2.6.0 transition
Source: mapnik-vector-tile Version: 0.5.1+dfsg-1 Severity: important Hi, The package mapnik-vector-tile ships a .pb.h file in /usr/include which is generated by the protoc utility in the protobuf-compiler package. A major new version of protobuf-compiler has been uploaded to unstable, so consequently the mapnik-vector-tile package needs to be rebuilt against protobuf-compiler 2.6.0 or newer, in order to regenerate mapnik-vector-tile's .pb.h file. Unfortunately, mapnik-vector-tile is an Architecture: all package, so it cannot be automatically binNMU'd. Instead, it needs a new sourceful upload, built against the latest version of protobuf-compiler in unstable. As this is blocking the transition of protobuf into testing (#760343), I would be happy to NMU the mapnik-vector-tile package. (Again, there are no sourceful changes needed to the package for this bug report, it just needs to be rebuilt.) Thanks! -- Robert Edmonds edmo...@debian.org ___ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
Bug#761429: Acknowledgement (mapnik-vector-tile: new upload needed for protobuf 2.6.0 transition)
Hi, I've uploaded 0.5.1+dfsg-1.1 that fixes this bug to DELAYED/5. The diff is attached, and it is very simple :-) -- Robert Edmonds edmo...@debian.org diff -Nru mapnik-vector-tile-0.5.1+dfsg/debian/changelog mapnik-vector-tile-0.5.1+dfsg/debian/changelog --- mapnik-vector-tile-0.5.1+dfsg/debian/changelog 2014-08-20 17:06:54.0 -0400 +++ mapnik-vector-tile-0.5.1+dfsg/debian/changelog 2014-09-13 17:28:59.0 -0400 @@ -1,3 +1,11 @@ +mapnik-vector-tile (0.5.1+dfsg-1.1) unstable; urgency=medium + + * Non-maintainer upload. + * No sourceful changes; rebuild against the latest protobuf-compiler due to +the transition in #760343. (Closes: #761429) + + -- Robert S. Edmonds edmo...@debian.org Sat, 13 Sep 2014 17:28:19 -0400 + mapnik-vector-tile (0.5.1+dfsg-1) unstable; urgency=medium * Upstream update ___ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
Bug#756983: Error in `osm2pgsql': free(): invalid pointer: 0x00007f4613a62678 ***
Sebastiaan Couwenberg wrote: Hi Robert, Thanks again for debugging this issue. I can confirm that the osm2pgsql segfault is fixed with a rebuilt libprotobuf-c1 that includes your patch. Great, thanks for confirming. Shall I reassign this issue to libprotobuf-c so you can close it with the upload of the new upstream release when it's out? Yes, please. -- Robert Edmonds edmo...@debian.org ___ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
Bug#756983: Error in `osm2pgsql': free(): invalid pointer: 0x00007f4613a62678 ***
Bas Couwenberg wrote: I can confirm the segfault while importing a PBF file with osm2pgsql. osm2pgsql 0.84.0-1 depends on libprotobuf-c0 (= 0.10), whereas 0.84.0-2 depends on libprotobuf-c1 (= 1.0.0-1~). osm2pgsql upstream uses protobuf_c_default_allocator instead of NULL as suggested by Robert Edmonds. This looks like the cause of the problem. Hi, I'd be happy to take a look and try to debug the issue to see if it's caused by the protobuf-c changes. However, I'm entirely unfamiliar with osm2pgsql. Is there any chance you could walk me through setting up a test case, or provide a sample file and command-line arguments that exhibit the problem? Thanks! -- Robert Edmonds edmo...@debian.org ___ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
Bug#756983: Error in `osm2pgsql': free(): invalid pointer: 0x00007f4613a62678 ***
Sebastiaan Couwenberg wrote:
On 08/04/2014 05:59 PM, Robert Edmonds wrote:
I'd be happy to take a look and try to debug the issue to see if it's
caused by the protobuf-c changes.
Thanks, that's much appreciated.
However, I'm entirely unfamiliar with osm2pgsql. Is there any chance
you could walk me through setting up a test case, or provide a sample
file and command-line arguments that exhibit the problem?
The basic setup is described in the Operation section of the README file
(/usr/share/doc/osm2pgsql/README.gz).
For my own test case I used a wheezy based database server:
createdb osm
createlang plpgsql osm
psql osm /usr/share/postgresql/9.1/contrib/postgis-1.5/postgis.sql
psql osm
/usr/share/postgresql/9.1/contrib/postgis-1.5/spatial_ref_sys.sql
psql -d osm -c ALTER TABLE geometry_columns OWNER TO bas
psql -d osm -c ALTER TABLE spatial_ref_sys OWNER TO bas
psql osm ~/git/pkg-grass/osm2pgsql/900913.sql
echo CREATE EXTENSION hstore | psql osm
Adjust the paths for PostgreSQL 9.3 on sid.
OSM PBF files can be downloaded from Geofabrik:
http://download.geofabrik.de/
I used an old one I had lying around.
osm2pgsql command line I used:
osm2pgsql -c -l -s -d dbname -U dbuser -W -H dbhost -v
netherlands-140201.osm.pbf
Thanks, I was able to figure out how to get an osm2pgsql setup working
with the above instructions and get a reproducible test case.
It looks like we (protobuf-c) were not explicitly zero'ing out memory in
certain cases, namely, when unpacking a 0-length byte string field in a
protobuf message. (In the .osm.pbf file that I tried, this case
reliably appeared in the first element of the StringTable field in
PrimitiveBlock messages.) This was causing a stray pointer to
occasionally be passed to free() when parse-pbf.c's processOsmData()
called primitive_block__free_unpacked(). Most of the time the affected
ProtobufCBinaryData object happens to be allocated with zero'd memory by
chance, which is why this bug wasn't caught sooner.
Here is the patch to protobuf-c. I'll be releasing a new upstream
version of protobuf-c with this fix soon.
diff --git a/protobuf-c/protobuf-c.c b/protobuf-c/protobuf-c.c
index c7fb21d..b66ed93 100644
--- a/protobuf-c/protobuf-c.c
+++ b/protobuf-c/protobuf-c.c
@@ -2304,6 +2304,8 @@ parse_required_member(ScannedMember *scanned_member,
if (bd-data == NULL)
return FALSE;
memcpy(bd-data, data + pref_len, len - pref_len);
+ } else {
+ bd-data = NULL;
}
bd-len = len - pref_len;
return TRUE;
--
Robert Edmonds
edmo...@debian.org
___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
Bug#755212: transition: protobuf-c
navit Embedded copy of libprotobuf-c osm2pgsql Sourceful changes required riemann-c-clientBinNMU possible Here are the details for each package: collectd Rebuilt by hand successfully against protobuf-c 1.0.0~rc2-1 from experimental. Has an unversioned build dependency on libprotobuf-c0-dev. This needs to be updated to libprotobuf-c-dev eventually, but is binNMU safe. Has a build dependency on protobuf-c-compiler and runs protoc-c during the build. No protoc-c generated symbols are exported by libcollectdclient1. The collectd-dev package exports the following header files generated by protoc-c: /usr/include/collectd/core/pinba.pb-c.h /usr/include/collectd/core/riemann.pb-c.h However, I have not found any packages in the Debian archive which utilize these files. I would recommend that the upstream developers ship .proto files instead. criu Rebuilt by hand successfully against protobuf-c 1.0.0~rc2-1 from experimental. Has an unversioned build dependency on libprotobuf-c0-dev. This needs to be updated to libprotobuf-c-dev eventually, but is binNMU safe. Has a build dependency on protobuf-c-compiler and runs protoc-c during the build. The 'criu' binary package ships a shared library which exports symbols generated by protoc-c. However, there are no header files with prototypes for these symbols, and no packages in the Debian archive appear to make use of these symbols or even link against this library. libgadu --- Has a build dependency on protobuf-c-compiler and uses the system's protoc-c during the build, but it uses an embedded copy of libprotobuf-c from protobuf-c 1.0.0. This will cause breakage if libgadu is rebuilt against protobuf-c-compiler = 1.0.0. Adding libprotobuf-c-dev to the build-deps will disable the embedded libprotobuf-c copy. No protoc-c generated symbols are exported by libgadu3. I have attached a patch (libgadu.patch) showing the needed changes. navit - This package has no (build-) dependencies on any of the packages provided by protobuf-c. It has an embedded copy of libprotobuf-c which is used unconditionally and it appears the upstream developer updates the generated .pb-c.c and .pb-c.h files by hand. This package is not affected by a protobuf-c transition but the embedded code copy is a concern. osm2pgsql - Has a too-strict upstream build system check that will cause a FTBFS if the current version is binNMU'd. See the following bug in the upstream issue tracker: https://github.com/openstreetmap/osm2pgsql/issues/129 The build system fix is the first hunk in this commit: https://github.com/openstreetmap/osm2pgsql/commit/8c7c6dbb319e97715b174edd081303174c96b03b.patch There are additional changes needed due to API changes in protobuf-c = 1.0.0 which have not yet been fixed upstream. Has a build-dep on protobuf-c-compiler and runs protoc-c during the build. Has a versioned build-dep on libprotobuf-c0-dev. This needs to be updated to an unversioned build-dep on libprotobuf-c-dev. I have attached a patch (osm2pgsql.patch) showing the needed changes. riemann-c-client Rebuilt by hand successfully against protobuf-c 1.0.0~rc2-1 from experimental. Has an unversioned build dependency on libprotobuf-c0-dev. This needs to be updated to libprotobuf-c-dev eventually. Has a build dependency on protobuf-c-compiler and runs protoc-c during the build. No protoc-c generated symbols are exported by libriemann-client0. The libriemann-client-dev package exports the following header files generated by protoc-c: /usr/include/riemann/proto/riemann.pb-c.h However, I have not found any packages in the Debian archive which utilize this file. I would recommend that the upstream developers ship a .proto file instead. Thanks! -- Robert Edmonds edmo...@debian.org diff -Npru libgadu-1.12.0.orig/debian/control libgadu-1.12.0/debian/control --- libgadu-1.12.0.orig/debian/control 2014-06-15 11:39:00.0 + +++ libgadu-1.12.0/debian/control 2014-07-16 20:04:18.568507791 + @@ -8,7 +8,7 @@ Build-Depends: # build tools autoconf, automake, libtool, pkg-config, protobuf-c-compiler, # runtime dependencies - libgnutls28-dev, zlib1g-dev, ca-certificates, + libgnutls28-dev, zlib1g-dev, ca-certificates, libprotobuf-c-dev, # build-time tests libxml2-dev, # documentation building diff -Npru libgadu-1.12.0.orig/protobufgen.sh libgadu-1.12.0/protobufgen.sh --- libgadu-1.12.0.orig/protobufgen.sh 2014-06-13 18:41:37.0 + +++ libgadu-1.12.0/protobufgen.sh 2014-07-16 20:06:14.570039033 + @@ -6,12 +6,5 @@ if [ $? != 0 ] ; then exit -1 fi -sed -i 's/google\/protobuf-c\/protobuf-c.h
