Bug#802165: maven-debian-helper: Missing dependency on apt-file.

[Emmanuel Bourg]

Le 18/10/2015 21:27, tony mancill a écrit :

> Hmmm... it would be nice to separate the "make-time" (meaning, package
> creation-time) tools from the build-time toolchain.  Do you think it's
> reasonable to have something like a java-package-helper package that
> contained the package make tools, regardless of whether they are for
> ant, maven, gradle, etc.?

That's a good idea, it would make the life of the newcomers easier.
Maybe not grouping the tools under the same package though, but instead
having a meta package depending on them.

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#802165: maven-debian-helper: Missing dependency on apt-file.

[Emmanuel Bourg]

Le 18/10/2015 21:19, Markus Koschany a écrit :

> mh_make even tells you to install apt-file, so I feel
> that Suggests: is a good choice here and ensures that apt-file is not
> pulled in needlessly.

I got another look at the dependencies involved, apt-file pulls just a
few Perl libraries, but devscripts drags a lot of stuff: python3, gnupg,
lintian, strace, wget, gcc and more. It probably explains why Ludovic
changed the relation.

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#802165: maven-debian-helper: Missing dependency on apt-file.

[tony mancill]

On 10/18/2015 12:12 PM, Emmanuel Bourg wrote:
> Le 18/10/2015 20:46, tony mancill a écrit :
> 
>> I have moved devscripts and apt-file back to Recommends for the next
>> upload.  If someone feels strongly that this isn't appropriate, we can
>> discuss on the list.
> 
> The extra dependencies slow down the pbuilder build. I was surprised by
> the missing dependency too, but on a second thought I realized it's
> acceptable to hit the error once and install apt-file manually. The
> error message is quite clear that's not terribly difficult to fix. On
> the other hand the time spent installing the missing dependencies is
> experienced by everyone and on every build.

I thought about that too, but apt-file is tiny compared to the other
packages being installed.  The argument is certainly stronger for
devscripts, which pulls in a lot of r-deps.

> An alternative would be to move mh_make to a separate binary package
> (maven-helper-make?).

Hmmm... it would be nice to separate the "make-time" (meaning, package
creation-time) tools from the build-time toolchain.  Do you think it's
reasonable to have something like a java-package-helper package that
contained the package make tools, regardless of whether they are for
ant, maven, gradle, etc.?

In any event, I'll revert my commit.  It sounds like there are more
reasons for Suggests.

Cheers,
tony






signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#802165: maven-debian-helper: Missing dependency on apt-file.

[Markus Koschany]

Am 18.10.2015 um 20:46 schrieb tony mancill:
> On 10/17/2015 03:01 PM, Kristoffer H Rose wrote:
[...]
>> The package should at least 'Recommend' apt-file.
> 
> Hello Kristoffer,
> 
> Thank you for the bug report.  I tend to agree that a stronger
> dependency is warranted, and personally m-d-h should just Depend on
> apt-file.  In fact, Recommends used to be the relationship, but it was
> changed in 2011:
> 
>> commit bd309118603d193d1355516ff3a9d120ff885c05
>> Author: Ludovic Claude 
>> Date:   Wed Jun 8 22:55:16 2011 +
>>
>> * Move apt-file, devscripts, subversion from Recommends: to Suggests: as
>>   they are only required when mh_make is used

> I have moved devscripts and apt-file back to Recommends for the next
> upload.  If someone feels strongly that this isn't appropriate, we can
> discuss on the list.

Hi tony,

not a real objection, but.. I think Ludovic was right to move apt-file
from Recommends to Suggests since it is only used by mh_make and mh_make
will never be used automatically. In fact it is just a helper tool to
create an
initial debian directory for Maven based packages and is not used for
anything else. mh_make even tells you to install apt-file, so I feel
that Suggests: is a good choice here and ensures that apt-file is not
pulled in needlessly.

Regards,

Markus






signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#802165: maven-debian-helper: Missing dependency on apt-file.

[Emmanuel Bourg]

Le 18/10/2015 20:46, tony mancill a écrit :

> I have moved devscripts and apt-file back to Recommends for the next
> upload.  If someone feels strongly that this isn't appropriate, we can
> discuss on the list.

The extra dependencies slow down the pbuilder build. I was surprised by
the missing dependency too, but on a second thought I realized it's
acceptable to hit the error once and install apt-file manually. The
error message is quite clear that's not terribly difficult to fix. On
the other hand the time spent installing the missing dependencies is
experienced by everyone and on every build.

An alternative would be to move mh_make to a separate binary package
(maven-helper-make?).

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#802165: maven-debian-helper: Missing dependency on apt-file.

[tony mancill]

On 10/17/2015 03:01 PM, Kristoffer H Rose wrote:
> Package: maven-debian-helper
> Version: 1.6.13
> Severity: important
> 
> When run the package reports
> 
>   Checking that apt-file is installed and has been configured...
>   Error: apt-file is not available.
>   Please install the 'apt-file' package and try again.
> 
> The package should at least 'Recommend' apt-file.

Hello Kristoffer,

Thank you for the bug report.  I tend to agree that a stronger
dependency is warranted, and personally m-d-h should just Depend on
apt-file.  In fact, Recommends used to be the relationship, but it was
changed in 2011:

> commit bd309118603d193d1355516ff3a9d120ff885c05
> Author: Ludovic Claude 
> Date:   Wed Jun 8 22:55:16 2011 +
> 
> * Move apt-file, devscripts, subversion from Recommends: to Suggests: as
>   they are only required when mh_make is used
> * mh_make: rescan the Maven repository after the user installs a required 
> package.
> * mh_resolve_dependencies: Also launch Maven in offline mode
>   (with --offline option) when --offline parameter is used. Closes: 
> #629356

I have moved devscripts and apt-file back to Recommends for the next
upload.  If someone feels strongly that this isn't appropriate, we can
discuss on the list.

Cheers,
tony



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#802165: maven-debian-helper: Missing dependency on apt-file.

[Kristoffer H Rose]

Package: maven-debian-helper
Version: 1.6.13
Severity: important

When run the package reports

  Checking that apt-file is installed and has been configured...
  Error: apt-file is not available.
  Please install the 'apt-file' package and try again.

The package should at least 'Recommend' apt-file.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armel, armhf

Kernel: Linux 4.2.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages maven-debian-helper depends on:
ii  default-jdk2:1.7-52.1
ii  libmaven-clean-plugin-java 2.5-1
ii  libmaven-compiler-plugin-2.5-java  2.5.1-4
ii  libmaven-jar-plugin-java   2.4-1
ii  libmaven-resources-plugin-java 2.3-8
ii  libmaven-site-plugin-java  2.1-3
ii  libplexus-velocity-java1.1.8-1
ii  libsurefire-java   2.17-2
ii  maven-repo-helper  1.8.12
ii  maven2 2.2.1-27
ii  velocity   1.7-4

maven-debian-helper recommends no packages.

Versions of packages maven-debian-helper suggests:
pn  apt-file  
ii  devscripts2.15.9
pn  libmaven-javadoc-plugin-java  
ii  subversion1.9.2-1

-- no debconf information

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.