Bug#869361: maven-bundle-plugin: FTBFS after maven-archive 3.1.1 update

[Emmanuel Bourg]

Le 23/07/2017 à 03:34, tony mancill a écrit :

> Thank you for the guidance - much appreciated!  I'm working on the patch
> for maven-bundle-plugin 2.5.4 now, since it's just a simple signature
> change to add the MavenSession [1].

Thank you for the fix Tony!

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#869361: maven-bundle-plugin: FTBFS after maven-archive 3.1.1 update

[tony mancill]

On Sat, Jul 22, 2017 at 08:48:36PM +0200, Emmanuel Bourg wrote:
> Le 22/07/2017 à 19:04, tony mancill a écrit :
> 
> > Shall we go ahead and update maven-bundle-plugin to 3.3.0, or are there
> > advantages to patching the 2.5.x package to work with the newer
> > maven-archiver?
> 
> Yes we should update maven-bundle-plugin but this one is tricky because
> it's tied to bnd. I suggest fixing the compatibility with maven-archiver
> without upgrading the plugin yet, and later upgrade it when the new
> version of bnd is ready.

Hi Emmanuel,

Thank you for the guidance - much appreciated!  I'm working on the patch
for maven-bundle-plugin 2.5.4 now, since it's just a simple signature
change to add the MavenSession [1].

Cheers,
tony

[1] 
https://maven.apache.org/shared/maven-archiver/apidocs/org/apache/maven/archiver/MavenArchiver.html#getManifest-org.apache.maven.execution.MavenSession-org.apache.maven.project.MavenProject-org.apache.maven.archiver.ManifestConfiguration-


signature.asc
Description: PGP signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#869361: maven-bundle-plugin: FTBFS after maven-archive 3.1.1 update

[Emmanuel Bourg]

Le 22/07/2017 à 19:04, tony mancill a écrit :

> Shall we go ahead and update maven-bundle-plugin to 3.3.0, or are there
> advantages to patching the 2.5.x package to work with the newer
> maven-archiver?

Yes we should update maven-bundle-plugin but this one is tricky because
it's tied to bnd. I suggest fixing the compatibility with maven-archiver
without upgrading the plugin yet, and later upgrade it when the new
version of bnd is ready.

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#869361: maven-bundle-plugin: FTBFS after maven-archive 3.1.1 update

[Markus Koschany]

Control: block 869018 with 869361

Am 22.07.2017 um 19:04 schrieb tony mancill:
> Source: maven-bundle-plugin
> Severity: serious
> Justification: 4
> 
> It looks like the update to maven-archiver [1] (for whatever reason,
> tracker.debian.org doesn't have a news entry for the upload yet) break
> maven-bundle-plugin, which is the root cause of FTBFS #869279 [2] and
> probably many others.
> 
>> [ERROR]
>> /build/maven-bundle-plugin-2.5.4/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java:[760,89]
>> incompatible types: org.apache.maven.archiver.MavenArchiveConfiguration
>> cannot be converted to org.apache.maven.archiver.ManifestConfiguration
> 
> Shall we go ahead and update maven-bundle-plugin to 3.3.0, or are there
> advantages to patching the 2.5.x package to work with the newer
> maven-archiver?

Easymock is also affected by this bug. [1] When I fix the
incompatibility with the new version of maven-jar-plugin I get the
following error message:

[ERROR] Failed to execute goal
org.apache.felix:maven-bundle-plugin:2.5.4:manifest (bundle-manifest) on
project easymock: Execution bundle-manifest of goal
org.apache.felix:maven-bundle-plugin:2.5.4:manifest failed: An API
incompatibility was encountered while executing
org.apache.felix:maven-bundle-plugin:2.5.4:manifest:
java.lang.NoSuchMethodError:
org.apache.maven.archiver.MavenArchiver.getManifest(Lorg/apache/maven/project/MavenProject;Lorg/apache/maven/archiver/MavenArchiveConfiguration;)Lorg/codehaus/plexus/archiver/jar/Manifest;

I think we should upgrade maven-bundle-plugin too which would be
consistent. I also would like to suggest that we try to update core
build tools like Maven and related plugins step by step which means
update package1, wait for FTBFS bugs being reported, fix fallout, then
update package2 and repeat. Sometimes I lose track of which update broke
which package and it takes too much time to figure out the root cause.
I'm willing to help but I need more pointers what should be done in
which order.

Markus

[1] https://bugs.debian.org/869018



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Processed: Re: Bug#869361: maven-bundle-plugin: FTBFS after maven-archive 3.1.1 update

[Debian Bug Tracking System]

Processing control commands:

> block 869018 with 869361
Bug #869018 [src:easymock] easymock: FTBFS: find: 
'/usr/share/maven-repo/org/codehaus/plexus/plexus-containers/*/*.jar': No such 
file or directory
869018 was not blocked by any bugs.
869018 was not blocking any bugs.
Added blocking bug(s) of 869018: 869361

-- 
869018: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=869018
869361: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=869361
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#869361: maven-bundle-plugin: FTBFS after maven-archive 3.1.1 update

[tony mancill]

Source: maven-bundle-plugin
Severity: serious
Justification: 4

It looks like the update to maven-archiver [1] (for whatever reason,
tracker.debian.org doesn't have a news entry for the upload yet) break
maven-bundle-plugin, which is the root cause of FTBFS #869279 [2] and
probably many others.

> [ERROR]
> /build/maven-bundle-plugin-2.5.4/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java:[760,89]
> incompatible types: org.apache.maven.archiver.MavenArchiveConfiguration
> cannot be converted to org.apache.maven.archiver.ManifestConfiguration

Shall we go ahead and update maven-bundle-plugin to 3.3.0, or are there
advantages to patching the 2.5.x package to work with the newer
maven-archiver?

Thanks,
tony

[1] https://packages.qa.debian.org/m/maven-archiver/news/20170720T133852Z.html
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=869279

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.