Re: [Pkg-javascript-devel] node-commander ≥ 6
Quoting Jonas Smedegaard (2020-12-23 13:06:40) > Quoting Xavier (2020-12-23 12:28:53) > > Le 23/12/2020 à 12:19, Jonas Smedegaard a écrit : > > > Quoting Xavier (2020-12-23 11:34:41) > > >> node-commander 6 is ready in experimental. It seems that all is > > >> OK, except a little change in uglifyjs.terser help output > > >> detected by your Perl test. > > >> I posted a simple MR, could you see if this is acceptable > > >> (compatible with node-commander 5)? > > > > > > Please attach proposed patch to an email. Preferably as a > > > bugreport. > > > With commander 6, uglifyjs.terser displays: > > > > Usage: uglifyjs [options]... > > > > instead of: > > > > Usage: uglifyjs.terser [options]... > > > > I don't know if my patch is useful here: it replaced your test regex > > with a more tolerant one without fixing the real issue (if this is an > > issue?). > > Ah, thanks - that is a helpful detail. > > No, I don't think that is an issue needed any further work than > wriggling the terser test a bit. > > Please go ahead (assuming no issues elsewhere) with the node-commander > upgrade - i.e. don't wait for terser, I will handle that from there. Oh! This still is just a mailinglist conversation, not a bugreport :-( @Xavier, would you mind filing this as a proper bugreport, please? Or tell me if that is too uch hassle for you, then I will do it, but prefor to give you credit for your work. In case you wonder: No, this is not just bureaucratic busywork: I am in the middle of other work with the terser package (and a pile of other work with other packages, including the mess I made with symlink-to-dir removals), and tracking issues with the bugtracker truly helps. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-commander ≥ 6
Quoting Xavier (2020-12-23 12:28:53) > Le 23/12/2020 à 12:19, Jonas Smedegaard a écrit : > > Quoting Xavier (2020-12-23 11:34:41) > >> node-commander 6 is ready in experimental. It seems that all is OK, > >> except a little change in uglifyjs.terser help output detected by > >> your Perl test. > >> I posted a simple MR, could you see if this is acceptable > >> (compatible with node-commander 5)? > > > > Please attach proposed patch to an email. Preferably as a > > bugreport. > With commander 6, uglifyjs.terser displays: > > Usage: uglifyjs [options]... > > instead of: > > Usage: uglifyjs.terser [options]... > > I don't know if my patch is useful here: it replaced your test regex > with a more tolerant one without fixing the real issue (if this is an > issue?). Ah, thanks - that is a helpful detail. No, I don't think that is an issue needed any further work than wriggling the terser test a bit. Please go ahead (assuming no issues elsewhere) with the node-commander upgrade - i.e. don't wait for terser, I will handle that from there. Thanks! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-commander ≥ 6
Le 23/12/2020 à 12:19, Jonas Smedegaard a écrit : > Hi Xavier, > > Quoting Xavier (2020-12-23 11:34:41) >> node-commander 6 is ready in experimental. It seems that all is OK, >> except a little change in uglifyjs.terser help output detected by your >> Perl test. >> I posted a simple MR, could you see if this is acceptable (compatible >> with node-commander 5)? > > Please attach proposed patch to an email. Preferably as a bugreport. > > Thanks! > > - Jonas Hi, With commander 6, uglifyjs.terser displays: Usage: uglifyjs [options]... instead of: Usage: uglifyjs.terser [options]... I don't know if my patch is useful here: it replaced your test regex with a more tolerant one without fixing the real issue (if this is an issue?). diff --git a/debian/tests/uglifyjs.terser.t b/debian/tests/uglifyjs.terser.t index 7333e22..2412e1c 100644 --- a/debian/tests/uglifyjs.terser.t +++ b/debian/tests/uglifyjs.terser.t @@ -16,7 +16,7 @@ like stdout, qr/^terser [\d.]+$/, 'version, stdout'; cmp_ok stderr, 'eq', '', 'version, stderr'; run_ok $CMD, qw(--help); -like stdout, qr/^\s*Usage: $CMD \[options\] \[files\.\.\.\]\n/, 'help, stdout'; +like stdout, qr/^\s*Usage: uglifyjs\S* \[options\] \[files\.\.\.\]\n/, 'help, stdout'; cmp_ok stderr, 'eq', '', 'help, stderr'; done_testing; -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-commander ≥ 6
Hi Xavier, Quoting Xavier (2020-12-23 11:34:41) > node-commander 6 is ready in experimental. It seems that all is OK, > except a little change in uglifyjs.terser help output detected by your > Perl test. > I posted a simple MR, could you see if this is acceptable (compatible > with node-commander 5)? Please attach proposed patch to an email. Preferably as a bugreport. Thanks! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-commander ≥ 6
Hi Jonas, node-commander 6 is ready in experimental. It seems that all is OK, except a little change in uglifyjs.terser help output detected by your Perl test. I posted a simple MR, could you see if this is acceptable (compatible with node-commander 5)? Xavier -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
