Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
On Mon, 2012-02-13 at 22:19 -0430, Jose Luis Rivas wrote: On 02/13/2012 09:55 PM, Marcelo Jorge Vieira wrote: (and you're one of those I tried to contact some time ago, together with daniel IIRC) I'm sorry about that, but IRC? I rarely use it =/ You should have sent an email to the list... Hey Marcelo, IIRC means If I Recall Correctly, not IRC :-) It's what happens when you reply an email in the dawn and tired =P Cheers, -- Marcelo Jorge Vieira xmpp:me...@jabber-br.org http://metaldot.alucinados.com signature.asc Description: This is a digitally signed message part ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
Hi Jose Luis, 2012/2/14 Jose Luis Rivas josel...@rivco.net: On 02/12/2012 06:05 PM, Emilien Klein wrote: Hey David and Jose Luis I got SSH access, created the repo on the server, and I believe I've managed to create my first ever git repo properly and push it to git.d.o [0]. I'm still a bit confused on the content of the different branches, in particular of master: jQuery's master branch only contains the debian directory, whereas my master contains the entire upstream content as well... Anyway, please let me know what I might need to have to change. Good night! +Emilien Hey Emilian, I just checked your package Thanks! and as a first thing I do I build it in my cowbuilder. I got this error: 8--- mkdir -p debian/tmp-build yui-compressor jquery.lazyload.js -o debian/tmp-build/jquery.lazyload.min.js Error occurred during initialization of VM Could not reserve enough space for object heap Could not create the Java virtual machine. make[1]: *** [override_dh_auto_build] Error 1 make[1]: Leaving directory `/tmp/buildd/jquery-lazyload-1.7.0' make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 E: Failed autobuilding of package ---8 You could use uglifyjs (here in Debian is node-uglify) instead. Done, just committed the change from to yui-compressor to uglifyjs That's what I can tell you so far. I checked everything else and it seems good :-) Let me know if there is anything else you'd like me to change. I'm still wondering if having the full upstream source code in master is correct or not... +Emilien ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
2012/2/14 Jonas Smedegaard d...@jones.dk: On 12-02-14 at 08:51pm, Emilien Klein wrote: I'm still wondering if having the full upstream source code in master is correct or not... I looked briefly at that when you first mentioned it, and looks fine. git-import-orig puts upstream code in the upstream branch and then merges it into the master branch. So upstream contains _only_ upstream code whereas master contains both that and packaging work (i.e. mostly the debian/ subdir). OK, thanks for the explanation. +Emilien ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
On 02/14/2012 04:00 PM, Emilien Klein wrote: 2012/2/14 Jose Luis Rivas ghost...@debian.org: Yep, that's tottaly correct. You should keep `master` with upstream + /debian, `upstream` with just upstream and `pristine-tar` with help of pristine-tar binary. That's at least how is done in pkg-perl (where I come from) I'll check again your package in a few hours, right now my internet link is not very good and I need to connect to a VPS to work on packages. OK, great. I guess I'll see your message when I wake up tomorrow! +Emilien Good enough for me, uploaded to archive. You should get an email about that and needs to wait until get approval, since is an ITP. Keep up the good work! -- Jose Luis Rivas - GPG: 0x7C4DF50D / 0xCACAB118 The Debian Project Developer -- http://ghostbar.ath.cx Barquisimeto, Venezuela signature.asc Description: OpenPGP digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
On 02/13/2012 09:55 PM, Marcelo Jorge Vieira wrote: (and you're one of those I tried to contact some time ago, together with daniel IIRC) I'm sorry about that, but IRC? I rarely use it =/ You should have sent an email to the list... Hey Marcelo, IIRC means If I Recall Correctly, not IRC :-) BTW, which is the IRC channel? #debian-javascript? I'll love to hang out in the IRC channel of pkg-js -- Jose Luis Rivas - GPG: 0x7C4DF50D / 0xCACAB118 The Debian Project Developer -- http://ghostbar.ath.cx Barquisimeto, Venezuela signature.asc Description: OpenPGP digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
On 12-02-13 at 10:19pm, Jose Luis Rivas wrote: BTW, which is the IRC channel? #debian-javascript? I'll love to hang out in the IRC channel of pkg-js #debian-js - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
2012/2/12 Jonas Smedegaard d...@jones.dk: On 12-02-12 at 04:53pm, Emilien Klein wrote: 2012/2/12 Jonas Smedegaard d...@jones.dk: On 12-02-12 at 03:43pm, Emilien Klein wrote: Could one of the teams' DM or DD send such an email for my application to be approved? Done! Great! I haven't received any email, but it seems I've already been approved (my name is on the project members' list) Correct. I posted you privately the confirmation. I got the mail just after sending this one. Phew, what a lot of correspondence needed for this. No wonder Facebook is more appealling to most people :-P ;) And it's not done, according to your instructions I still need to get ssh access to Alioth... Indeed. - What does vasks mean? That's the name of a Debian host. Probably (judging from the context it was mentioned) the one currently hosting the Alioth service more generically offered as git.debian.org. OK. `mtr` to git.d.o indeed mentions vasks.debian.org as last line. (In my 10 years with Debian I have survived referring only to service names. I believe machine names should be avoided whenever possible.) - What am I supposed to put in the branch? I guess only the ./debian folder. What about the source tarball, do I need to put it somewhere? Well, that's certainly one style, but not the one I use (any longer). I use git-buildpackage with options --pristine-tar and --signed-tags, i.e. I bootstrap with either git-import-orig --pristine-tar --signed-tags or (when adopting an existing Debian package not using VCS before) git-import-dscs --debsnap --pristine-tar --signed-tags. OK, I am documenting myself on git/git-buildpackage. I found this page [0] that seems to be pretty exhaustive. We have not discussed VCS habits in this team, nor if we should mandate a certain style. But probably best - especially when new to things here - to adopt the style already used by those you intend to work closely with (i.e. not me since you choose not to use CDBS). Clear. Is there any team member who: - uses dh for packaging - would like to review my package ? If so, please let me know how you'd like me to get the package to you. Have a nice rest of the Sunday! +Emilien [0] http://workaround.org/debian-git-comaintenance ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
On Sun, 12 Feb 2012 17:43:34 +0100, Emilien Klein wrote: Clear. Is there any team member who: - uses dh for packaging - would like to review my package ? If so, please let me know how you'd like me to get the package to you. Here I am :) It seems like Jonas is the CDBS guy, and me the dh7 one :) I prefer git-buildpackage with full sources too (i.e. just follow what Jonas said). And I'd say we should mandate this style in the team :) Just push your repository on vasks where you prefer (pkg-javascript or collab-maint), and then ping me (also via private mail), I'll review it. Kindly, David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
On 12-02-12 at 07:04pm, David Paleino wrote: It seems like Jonas is the CDBS guy, and me the dh7 one :) :-) Please drop the 7 when referring to dh to avoid unnecessary confusion: Yes, debhelper 7 introduced dh, the piece which clashes with CDBS (due to partly reimplementing it), but debhelper 7 did not drop the classic dh_* commands and those continue to work fine together with CDBS. I prefer git-buildpackage with full sources too (i.e. just follow what Jonas said). And I'd say we should mandate this style in the team :) I suggest that instead of mandating we instead simply document our preferences - implicitly inviting strongly opiniated newcomers to try argue their case. That leaves the door open for change: Had the team mandated dh few months ago, then I would have simply stayed away. It would be lovely if all of Debian could agree on a single set of tools (as long as *my* preferences are the ones agreed on ;-) ), but strict team rules is not helping towards that goal IMO. and then ping me (also via private mail), I'll review it. Please do ping via the list, even if (mainly) targeting only one of us: That encourages more/alternate reviewers, and improves transparency in our team. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
On 12-02-12 at 01:50pm, Jose Luis Rivas wrote: I'm not officially member of the team, The way I see it, there is no unofficial members: subscribing to the mailinglist +'contributing something automatically makes you a member - and you contributed just now with your opinion and a concrete offer to help. So welcome aboard :-D Yeah, there is an alioth group that you might not me member of. But I see that only as a technical clutch needed to grant non-DD/non-DM access, and is _exactly_ the reason I use collab-maint: to ease contributions from Debian members (i.e. DDs and DMs). - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
2012/2/12 Emilien Klein emilien+deb...@klein.st: Thanks David and Jose Luis for stepping up. As soon as I figure out how to use git-buildpackage, I'll upload my package and let you all know, on-list. Hey David and Jose Luis I got SSH access, created the repo on the server, and I believe I've managed to create my first ever git repo properly and push it to git.d.o [0]. I'm still a bit confused on the content of the different branches, in particular of master: jQuery's master branch only contains the debian directory, whereas my master contains the entire upstream content as well... Anyway, please let me know what I might need to have to change. Good night! +Emilien [0] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-lazyload.git ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?
Following Jose Luis' comments on the package name, I've renamed it with a dash (it is indeed better readable) You can find it on mentors.d.n: http://mentors.debian.net/package/jquery-lazyload Please let me know if there are other things you'd do differently. Thanks, +Emilien ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
