Re: Packaging PythonQt for Qt 5

[Dmitry Shachnev]

Hi Erik and Sandro,

On Wed, Jun 14, 2017 at 10:56:40PM +0200, Sandro Knauß wrote:
> the SVN link actually pointed me to look at who is actually the maintainer of 
> pythonqt and saw, that is not Debian KDE Maintainers. It is the QA Team
> . So that are the people that you need to talk to, 
> because only those can add your work. Additonally they may have other rules 
> how work should be done.

The QA team is a standard maintainer address when the package is orphaned.

Also, as the package is orphaned, there is no reason to stick to the old SVN
repository. You can convert it into git (i.e. with git-svn) and push to
collab-maint or your personal Git namespace.

If you prefer to maintain it under kde-extras team, ask one of the maintainers
to grant you access there.

> Some general things:
> compat level update to 10 ( that should be used nowadays):
>  * see man 7 debhelper
> with that you can rid of  --parallel ( it is default with v10)
> but bumping the compat level is some thing the maintainers of package needs 
> to 
> do, it may be circumstances not to bump that. But try it if it builds with 
> v10 
> is a good thing to do.
> -> would also need you to update to debhelper (>= 10) in control
> * also checking the Standards-Version and bumping this is also a task to do 
> before uploading a new version.
> *are there tests to run / need to build seperatly?
> * are the patches will  go upstream? Please use dep3 styple for patches:
> http://dep.debian.net/deps/dep3/
> I use "quilt header -e --dep3" to create such headers.
> * did you checked if there are packagages using the dev packages? If yes, 
> there needs to be a transition requested, because all packages needs to 
> rebuilt...
>
> But still I'm not maintainer of this package, so I can't tell you if they 
> also 
> what these changes.

Sandro’s comments make sense, please take them into account.

Some comments from me now:

* There are directories with names generated_cpp_5* with C++ files inside.
  If these C++ files are really generated, then the best Debian practice is
  regenerate them before build (I guess we only need the _56 directory).

* Is Python 2 support really needed? Upstream will drop support for Python 2
  soon, and we are going to follow, so new packages can be packaged for
  Python 3 only unless you know there will be applications that want to use
  PythonQt with Python 2. See [1] for details.

* Lintian warns that library package names do not match their SONAMEs.
  The proper package names would be like libpythonqt-qtall-qt5-python3.5-3.

  Since the ABI would break for Python version bumps, I think adding this
  digit makes sense.

  Also, what is the difference between Qt5 and QtAll-Qt5 libraries?
  The package descriptions do not say anything about that.

* Lintian warns about missing symbols files. This is something not much
  important, but in future you may want to use the symbols files to track
  the package ABI changes. pkgkde-symbolshelper [2] may help you with this.

* Lintian warns about duplicate package short names.

* Lintian also warns about missing DEP-5 copyright. The copyright seems to
  be already in DEP-5 format, so you need to just add a Format: line on top.

* There is Doxygen documentation source in the tarball, you may want to add
  a package for it in the future.

[1]: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python3.html.
[2]: http://pkg-kde.alioth.debian.org/symbolfiles.html

--
Dmitry Shachnev


signature.asc
Description: PGP signature
-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk

Re: Packaging PythonQt for Qt 5

[Sandro Knauß]

Hey,

the SVN link actually pointed me to look at who is actually the maintainer of 
pythonqt and saw, that is not Debian KDE Maintainers. It is the QA Team
. So that are the people that you need to talk to, 
because only those can add your work. Additonally they may have other rules 
how work should be done.

> Actually uploading to mentors.debian.net might be better. A pointer to the
> SVN is also not bad.

+1

> Python is definitely not my area, so I'm afraid I can't help here.

mine yes :)

Some general things:
compat level update to 10 ( that should be used nowadays):
 * see man 7 debhelper
with that you can rid of  --parallel ( it is default with v10)
but bumping the compat level is some thing the maintainers of package needs to 
do, it may be circumstances not to bump that. But try it if it builds with v10 
is a good thing to do.
-> would also need you to update to debhelper (>= 10) in control
* also checking the Standards-Version and bumping this is also a task to do 
before uploading a new version.
*are there tests to run / need to build seperatly?
* are the patches will  go upstream? Please use dep3 styple for patches:
http://dep.debian.net/deps/dep3/
I use "quilt header -e --dep3" to create such headers.
* did you checked if there are packagages using the dev packages? If yes, 
there needs to be a transition requested, because all packages needs to 
rebuilt...

But still I'm not maintainer of this package, so I can't tell you if they also 
what these changes.

Best Regards,

sandro

signature.asc
Description: This is a digitally signed message part.
-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk

Re: Packaging PythonQt for Qt 5

[Lisandro Damián Nicanor Pérez Meyer]

On miércoles, 14 de junio de 2017 01:01:13 -03 Erik Lundin wrote:
> Hi,

Hi Erik!
 
> I'm now done with all changes I would like to see, so if someone would
> like to review them I'm grateful. Please see attached the diff against
> pythonqt 3.0-3. Since the Debian code for this package is hosted in SVN
> [1], I guess this is the easiest way.

Actually uploading to mentors.debian.net might be better. A pointer to the SVN 
is also not bad.

> Here is a summary of the changes:
> 
>* New upstream version
>* Change to Qt5, since Qt4 has been deprecated upstream
>* Adapt building to pure qmake (CMake has been deprecated upstream)
>* Build packages for both Python 2 and Python 3
>* Place QtAll extension in separate package
>* Implement multiarch support
> 
> Since this is my first contribution to Debian, I'm also thankful for
> advices on best practices etc. if applicable.

Python is definitely not my area, so I'm afraid I can't help here.

-- 
7: Hay diferencia entre "cortar" un archivo y "borrarlo" o "eliminarlo"
* Depende cuando se "cuelgue" Windows
Damian Nadales
http://mx.grulic.org.ar/lurker/message/20080307.141449.a70fb2fc.es.html

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


signature.asc
Description: This is a digitally signed message part.
-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk

Re: Packaging PythonQt for Qt 5

[Erik Lundin]

Hi,

I'm now done with all changes I would like to see, so if someone would 
like to review them I'm grateful. Please see attached the diff against 
pythonqt 3.0-3. Since the Debian code for this package is hosted in SVN 
[1], I guess this is the easiest way.


Here is a summary of the changes:

  * New upstream version
  * Change to Qt5, since Qt4 has been deprecated upstream
  * Adapt building to pure qmake (CMake has been deprecated upstream)
  * Build packages for both Python 2 and Python 3
  * Place QtAll extension in separate package
  * Implement multiarch support

Since this is my first contribution to Debian, I'm also thankful for 
advices on best practices etc. if applicable.


/Erik

[1] 
https://anonscm.debian.org/viewvc/debian-med/trunk/packages/pythonqt/trunk/


Den 2017-06-06 kl. 19:29, skrev Sandro Knauß:

Hey,


How can I submit my packaging changes for review? Are you using pull
requests somewhere?


there is no "formal way" nor pull request. The normal workflow is to use
mentors and personal repos and send the link around.

* mentors.debian.org
* https://wiki.debian.org/Alioth/Git#Forking_Git_repositories_onto_Alioth

( You can use every other git hosting platform, if you wish)

After some time we will grant you permission to push to git directly.

Hopefully this works for you.

Best Regards,

sandro

diff -ur --unidirectional-new-file PythonQt3.0/debian/changelog PythonQt3.2/debian/changelog
--- PythonQt3.0/debian/changelog	2016-09-15 18:16:39.0 +0200
+++ PythonQt3.2/debian/changelog	2017-06-14 00:28:51.456754423 +0200
@@ -1,3 +1,14 @@
+pythonqt (3.2-1) UNRELEASED; urgency=medium
+
+  * New upstream version
+  * Change to Qt5, since Qt4 has been deprecated upstream
+  * Adapt building to pure qmake (CMake has been deprecated upstream)
+  * Build packages for both Python 2 and Python 3
+  * Place QtAll extension in separate package
+  * Implement multiarch support
+
+ -- Erik Lundin   Tue, 13 Jun 2017 22:40:27 +0200
+
 pythonqt (3.0-3) unstable; urgency=medium
 
   * QA upload.
diff -ur --unidirectional-new-file PythonQt3.0/debian/control PythonQt3.2/debian/control
--- PythonQt3.0/debian/control	2016-09-15 18:16:39.0 +0200
+++ PythonQt3.2/debian/control	2017-06-14 00:19:55.640303796 +0200
@@ -3,25 +3,34 @@
 Section: libs
 Priority: optional
 Build-Depends: debhelper (>= 9),
-   cmake,
+   dh-exec (>= 0.3),
python-dev,
-   qt4-qmake,
-   libqt4-dev,
-   libqt4-opengl-dev
+   python3-dev,
+   qtbase5-dev,
+   qttools5-dev,
+   qt5-qmake,
+   libqt5svg5-dev,
+   libqt5xmlpatterns5-dev,
+   qtmultimedia5-dev,
+   qtbase5-private-dev,
+   qtdeclarative5-dev,
+   libqt5opengl5-dev
 Standards-Version: 3.9.8
 Vcs-Browser: https://anonscm.debian.org/viewvc/debian-med/trunk/packages/pythonqt/trunk/
 Vcs-Svn: svn://anonscm.debian.org/debian-med/trunk/packages/pythonqt/trunk/
 Homepage: http://pythonqt.sourceforge.net
-X-Python-Version: current
+X-Python-Version: >= 2.6
+X-Python3-Version: >= 3.3
 
-Package: libpythonqt3.0
+Package: libpythonqt-qt5-python2-3
 Architecture: any
+Multi-Arch: same
 Depends: ${shlibs:Depends},
  ${misc:Depends}
 Description: Dynamic Python binding for the Qt framework - runtime
  PythonQt offers an easy way to embed the Python scripting language into a
- C++ Qt applications. It makes heavy use of the QMetaObject system and thus
- requires Qt 4.x.
+ C++ Qt applications. It makes heavy use of the QMetaObject system and
+ requires Qt 5.x.
  The focus of PythonQt is on embedding Python into an existing C++ application,
  not on writing the whole application completely in Python. If you want to write
  your whole application in Python, you should use PyQt or PySide instead.
@@ -29,20 +38,189 @@
  Application and to script parts of your application via Python, PythonQt is the
  way to go!
  .
- This package contains the libraries needed to run PythonQt applications.
+ This package contains the libraries needed to run PythonQt applications
+ for Python 2.
 
-Package: libpythonqt-dev
+Package: libpythonqt-qt5-common-dev
 Architecture: any
+Multi-Arch: same
 Section: libdevel
-Depends: libpythonqt3.0 (= ${binary:Version}),
+Depends: ${shlibs:Depends},
+ ${misc:Depends}
+Description: Dynamic Python binding for the Qt framework - development
+ PythonQt offers an easy way to embed the Python scripting language into a
+ C++ Qt applications. It makes heavy use of the QMetaObject system and
+ requires Qt 5.x.
+ The focus of PythonQt is on embedding Python into an existing C++ application,
+ not on writing the whole application completely in Python. If you want to write
+ your whole application in Python, you should use PyQt or PySide instead.
+ If you are looking for a simple way to embed Python objects into your C++/Qt
+ Application