Bug#734100: Fixed in VLC 3.0
Modestas, in DecoderPlayAudio(), your modified decoder.c patch fails to
unlock the mutex when the loop exits on !p_audio. On my system, this causes
vlc to become unresponsive when a video ends.
I looked in to 557eaa06 and 5b2de769 as suggested by Rémi, but since they
depend on many other commits and don't appear necessary in my own testing, I
abandoned the effort.
I'm attaching my current patches for review. One is adapted from git commit
6ae2905e, while the other is copied verbatim from 47f74a83. As far as I can
tell, they fix the stuttering bug in vlc 2.2.2 and 2.2.4, without causing
new problems.
X-Git-Url:
https://git.videolan.org/?p=vlc.git;a=blobdiff_plain;f=src%2Finput%2Fdecoder.c;h=fe3cd428c65c18bfbdadb55baf11521afdc2bfc7;hp=83aa5bf54e2c29ad93fae803117558e4fcd0f658;hb=6ae2905ef7fbc7de3a3a4a1bdf8ad6df46ce570a;hpb=5b2de76965ee8b1ab5e3257f8b6d71bbb4e9e3f9
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -1162,7 +1162,10 @@
b_paused = p_owner->b_paused;
if (!p_audio)
+{
+vlc_mutex_unlock( &p_owner->lock );
break;
+}
/* */
int i_rate = INPUT_RATE_DEFAULT;
@@ -1180,6 +1183,9 @@
if( unlikely(p_owner->b_paused != b_paused) )
continue; /* race with input thread? retry... */
+
+vlc_mutex_unlock( &p_owner->lock );
+
if( p_aout == NULL )
b_reject = true;
@@ -1199,7 +1205,6 @@
break;
}
-vlc_mutex_unlock( &p_owner->lock );
}
static void DecoderDecodeAudio( decoder_t *p_dec, block_t *p_block )
@@ -1961,11 +1966,10 @@
/* Parameters changed, restart the aout */
vlc_mutex_lock( &p_owner->lock );
-
-aout_DecDelete( p_owner->p_aout );
p_owner->p_aout = NULL;
-
vlc_mutex_unlock( &p_owner->lock );
+aout_DecDelete( p_owner->p_aout );
+
input_resource_PutAout( p_owner->p_resource, p_aout );
}
X-Git-Url:
https://git.videolan.org/?p=vlc.git;a=blobdiff_plain;f=modules%2Faudio_output%2Falsa.c;h=4e9fd53592d048baa8b57f30df15ab5806139d07;hp=2d1f99e9cb743bca12c6bdf32cc84a92d07fda8b;hb=47f74a83c161173b0d15e95dab8ceb7c97de51b4;hpb=6ae2905ef7fbc7de3a3a4a1bdf8ad6df46ce570a
diff --git a/modules/audio_output/alsa.c b/modules/audio_output/alsa.c
index 2d1f99e..4e9fd53 100644
--- a/modules/audio_output/alsa.c
+++ b/modules/audio_output/alsa.c
@@ -495,6 +495,15 @@ static int Start (audio_output_t *aout,
audio_sample_format_t *restrict fmt)
}
sys->rate = fmt->i_rate;
+#if 1 /* work-around for period-long latency outputs (e.g. PulseAudio): */
+param = AOUT_MIN_PREPARE_TIME;
+val = snd_pcm_hw_params_set_period_time_near (pcm, hw, ¶m, NULL);
+if (val)
+{
+msg_Err (aout, "cannot set period: %s", snd_strerror (val));
+goto error;
+}
+#endif
/* Set buffer size */
param = AOUT_MAX_ADVANCE_TIME;
val = snd_pcm_hw_params_set_buffer_time_near (pcm, hw, ¶m, NULL);
@@ -503,14 +512,22 @@ static int Start (audio_output_t *aout,
audio_sample_format_t *restrict fmt)
msg_Err (aout, "cannot set buffer duration: %s", snd_strerror (val));
goto error;
}
-
-param = AOUT_MIN_PREPARE_TIME;
+#if 0
+val = snd_pcm_hw_params_get_buffer_time (hw, ¶m, NULL);
+if (val)
+{
+msg_Warn (aout, "cannot get buffer time: %s", snd_strerror(val));
+param = AOUT_MIN_PREPARE_TIME;
+}
+else
+param /= 2;
val = snd_pcm_hw_params_set_period_time_near (pcm, hw, ¶m, NULL);
if (val)
{
msg_Err (aout, "cannot set period: %s", snd_strerror (val));
goto error;
}
+#endif
/* Commit hardware parameters */
val = snd_pcm_hw_params (pcm, hw);
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: dvd-slideshow depends
On 12-09-2016 17:44, Fabian Greffrath wrote: > Am Montag, den 12.09.2016, 15:41 -0300 schrieb Herbert Fortes: >> So mkisofs will be replaced by genisoimage. I said xorrisofs >> before, but it seems that xorrisofs "does not produce UDF >> filesystems"[2]. Bad because xorriso project is more active >> (2016). genisoimage stopped in 2014. > > I am not sure if GNU xorriso has the same features as the program of > the same name from the libburn project? > I did not understand. xorriso[0] Debian package is from libisoburn source package. [0] - https://packages.qa.debian.org/libi/libisoburn.html Regards, Herbert ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
gnome-mpv 0.10-1 MIGRATED to testing
FYI: The status of the gnome-mpv source package in Debian's testing distribution has changed. Previous version: 0.9-1 Current version: 0.10-1 -- This email is automatically generated once a day. As the installation of new packages into testing happens multiple times a day you will receive later changes on the next day. See https://release.debian.org/testing-watch/ for more information. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Nachricht empfangen am_k_leinanzeigen
Hallo Sie eine Nachricht auf _k_leinanzeigen erhalten haben. Um die Nachricht zu lesen, klicken Sie hier Die Abmeldung von einer Mailingliste erfolgt über eine E-Mail : Sie hier ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Processing of vlc_2.2.4-4_source.changes
vlc_2.2.4-4_source.changes uploaded successfully to localhost along with the files: vlc_2.2.4-4.dsc vlc_2.2.4-4.debian.tar.xz Greetings, Your Debian queue daemon (running on host franck.debian.org) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
vlc_2.2.4-4_source.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Tue, 13 Sep 2016 21:29:23 +0200 Source: vlc Binary: libvlc-dev libvlc5 libvlccore-dev libvlccore8 vlc vlc-data vlc-nox vlc-plugin-fluidsynth vlc-plugin-jack vlc-plugin-notify vlc-plugin-sdl vlc-plugin-svg vlc-plugin-zvbi vlc-plugin-samba Architecture: source Version: 2.2.4-4 Distribution: unstable Urgency: medium Maintainer: Debian Multimedia Maintainers Changed-By: Sebastian Ramacher Description: libvlc-dev - development files for libvlc libvlc5- multimedia player and streamer library libvlccore-dev - development files for libvlccore libvlccore8 - base library for VLC and its modules vlc- multimedia player and streamer vlc-data - Common data for VLC vlc-nox- multimedia player and streamer (without X support) vlc-plugin-fluidsynth - FluidSynth plugin for VLC vlc-plugin-jack - Jack audio plugins for VLC vlc-plugin-notify - LibNotify plugin for VLC vlc-plugin-samba - Samba plugin for VLC vlc-plugin-sdl - SDL video and audio output plugin for VLC vlc-plugin-svg - SVG plugin for VLC vlc-plugin-zvbi - VBI teletext plugin for VLC Closes: 834884 Changes: vlc (2.2.4-4) unstable; urgency=medium . [ Pino Toscano ] * Install solid actions in Frameworks location. (Closes: #834884) . [ Sebastian Ramacher ] * Bump debhelper compat to 10. Checksums-Sha1: 050e192ac6a0d374763d2130b3916a1e0294ac90 5622 vlc_2.2.4-4.dsc 3f7d29e07a3a34b4996a7a8967c836354aaa4d22 75976 vlc_2.2.4-4.debian.tar.xz Checksums-Sha256: a13c6236a7c48042af1d960c8eed2b8b51553862bcbc7416dcb5e7cd4c52f8aa 5622 vlc_2.2.4-4.dsc 202d4bbbf7562d7de95d4faed8d78161a27570b3d86a67d56c920eee600c7ba6 75976 vlc_2.2.4-4.debian.tar.xz Files: 83a00955dbb3a62655d746be4f12b771 5622 video optional vlc_2.2.4-4.dsc d451041fbef7bf5e1da2363b743e39ae 75976 video optional vlc_2.2.4-4.debian.tar.xz -BEGIN PGP SIGNATURE- iQIcBAEBCAAGBQJX2FWbAAoJEGny/FFupxmTkNgP/isXA9PBCu3GtWR0TUQF9Qam 5ATeIql2/Y0NdBfFb4EUexxLCJHWIAV+yZbDIlqXZ2yfKA9GdUZeZOb+CNHAyeIC xvrLb2UZRkat7XlVqhSKe5vNyYiuQdUQBC7s+AtlbXmy2obK09anACNwliluQcYZ Nl7qqSJZPnuBm5NT18UXVlQndDXq+zNl2Pb99pb4dP9ivBBirbCMmM26Cb4aeyio +DEYeHiQx2NxwJ0XXFxAIxEfV4LaqDWTZfwcNR9/3wjiOnT6gJoPIN1n/xsP6/j3 LDH1MtyujZkZx9XB/Z5+0uaksT4Y397U0DJhRvFCBzo/VAyZh9Q52rDbSgfdhuF3 6XspQyZJJAPu/jWBhd/9bNo9FHuI4aXqjoPTFhnCDB1z5P9FZmZ1d0Pg+zEYcqnP cEJJ457onoeOT19BZZg6RsSGOzCpwPkUkczLrgXEcd5gU7MFIM18UqodwAUiWKiB GFGkDaEIGcRsNhDIqMFV3pTfL3EY7Rvb1NcnPGFdX1/hDT2MAQwJDfvbyy5qj9Ap MEtfpI1oYLjkgRXtISQz/s4BSoENkk6Cb86u8Ue5qaFOCdIECBhhdigJIOamxwal qIuohdJU1n48idbPspjEpg1yFzlq7o4JHeilZZOBOkPx08N5kHfjhjn5vqkGi3sK noby8eDTYMdrjIIXlYsD =oMOU -END PGP SIGNATURE- Thank you for your contribution to Debian. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#834884: marked as done (vlc: please move Solid actions to the Frameworks location)
Your message dated Tue, 13 Sep 2016 19:49:32 + with message-id and subject line Bug#834884: fixed in vlc 2.2.4-4 has caused the Debian Bug report #834884, regarding vlc: please move Solid actions to the Frameworks location to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 834884: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834884 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: src:vlc Version: 2.2.4-3 Severity: normal Tags: patch Hi, currently the Debian packaging installs the actions for Solid KDE subsystem under /usr/share/kde4/apps/solid/actions, which is the location of the KDE 4 version. With the migration of the environment to a Qt5-based Plasma and Solid, the location for the Qt5-based Solid action is /usr/share/solid/actions: this means that currently in a Plasma 5 environment the vlc actions are not used (e.g. no "Open DVD with VLC" when inserting a DVD). The easy fix is to change the location specified at configure, so the actions are installed in the better location. Thanks, -- Pino --- a/debian/rules +++ b/debian/rules @@ -90,7 +90,7 @@ confflags += \ --enable-x264 \ --enable-x265 \ --enable-zvbi \ - --with-kde-solid=/usr/share/kde4/apps/solid/actions/ \ + --with-kde-solid=/usr/share/solid/actions/ \ $(NULL) # Reasons for disabling features: # decklink -> not in Debian --- a/debian/vlc.install +++ b/debian/vlc.install @@ -33,5 +33,5 @@ usr/lib/vlc/plugins/video_output/libxcb_ usr/lib/vlc/plugins/video_splitter usr/lib/vlc/plugins/visualization usr/share/applications -usr/share/kde4 +usr/share/solid EOF --- End Message --- --- Begin Message --- Source: vlc Source-Version: 2.2.4-4 We believe that the bug you reported is fixed in the latest version of vlc, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 834...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sebastian Ramacher (supplier of updated vlc package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Tue, 13 Sep 2016 21:29:23 +0200 Source: vlc Binary: libvlc-dev libvlc5 libvlccore-dev libvlccore8 vlc vlc-data vlc-nox vlc-plugin-fluidsynth vlc-plugin-jack vlc-plugin-notify vlc-plugin-sdl vlc-plugin-svg vlc-plugin-zvbi vlc-plugin-samba Architecture: source Version: 2.2.4-4 Distribution: unstable Urgency: medium Maintainer: Debian Multimedia Maintainers Changed-By: Sebastian Ramacher Description: libvlc-dev - development files for libvlc libvlc5- multimedia player and streamer library libvlccore-dev - development files for libvlccore libvlccore8 - base library for VLC and its modules vlc- multimedia player and streamer vlc-data - Common data for VLC vlc-nox- multimedia player and streamer (without X support) vlc-plugin-fluidsynth - FluidSynth plugin for VLC vlc-plugin-jack - Jack audio plugins for VLC vlc-plugin-notify - LibNotify plugin for VLC vlc-plugin-samba - Samba plugin for VLC vlc-plugin-sdl - SDL video and audio output plugin for VLC vlc-plugin-svg - SVG plugin for VLC vlc-plugin-zvbi - VBI teletext plugin for VLC Closes: 834884 Changes: vlc (2.2.4-4) unstable; urgency=medium . [ Pino Toscano ] * Install solid actions in Frameworks location. (Closes: #834884) . [ Sebastian Ramacher ] * Bump debhelper compat to 10. Checksums-Sha1: 050e192ac6a0d374763d2130b3916a1e0294ac90 5622 vlc_2.2.4-4.dsc 3f7d29e07a3a34b4996a7a8967c836354aaa4d22 75976 vlc_2.2.4-4.debian.tar.xz Checksums-Sha256: a13c6236a7c48042af1d960c8eed2b8b51553862bcbc7416dcb5e7cd4c52f8aa 5622 vlc_2.2.4-4.dsc 202d4bbbf7562d7de95d4faed8d78161a27570b3d86a67d56c920eee600c7ba6 75976 vlc_2.2.4-4.debian.tar.xz Files: 83a00955dbb3a62655d746be4f12b771 5622 video optional vlc_2.2.4-4.dsc d451041fbef7bf5e1da2363b743e39ae 75976 video optional vlc_2.2.4-4.debian.tar.xz -BEGIN PGP SIGNATURE- iQIcBAEBCAAGBQJX2FWbAAoJEGny/FFupxmTkNgP/isXA9PBCu3GtWR0TUQF9Qam 5ATeIql2/Y0NdBfFb4EUexxLCJHWIAV+yZbDIlqXZ2yfKA9GdUZeZOb+CNHAyeIC xvrLb2UZRkat7XlVqhSKe5vNyYiuQdUQBC7s+AtlbXmy2obK09anACNwliluQcYZ Nl7qqSJZPnuBm5NT18UXVlQndDXq+zNl2Pb99pb4dP9ivBBirbCMmM26Cb4aeyio +DEYeHiQx2NxwJ0XXFxAIxEfV4LaqDWTZfw
Re: [RFS] updated libva and intel-vaapi-driver bpos
On Mon, Sep 12, 2016 at 06:43:07PM +, Mattia Rizzolo wrote: > On Mon, Sep 12, 2016 at 06:41:25AM +, Mattia Rizzolo wrote: > > Given that I gather intel-vaapi-driver needs the newer libva and today > > I'm too lazy to copy .deb in the local repository I'll wait for libva to > > reach the mirror before doing intel-vaapi-driver. > > apparently amd64 is comparable to mipsel, as it's kinda lagging. > https://buildd.debian.org/status/package.php?p=libva&suite=jessie-backports > > I'm going to just trust you that it build and upload. > > -- > regards, > Mattia Rizzolo > > GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. > more about me: https://mapreri.org : :' : > Launchpad user: https://launchpad.net/~mapreri `. `'` > Debian QA page: https://qa.debian.org/developer.php?login=mattia `- Hi Mattia, Thank you for the sponsored uploads! Does "Needs-Build" status mean that the package is still waiting for CPU time on an armel, armhf, and mipsel system somewhere on the buildd network? Cheers, Nicholas signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [RFS] updated libva and intel-vaapi-driver bpos
On Tue, Sep 13, 2016 at 05:03:23PM -0400, Nicholas D Steeves wrote: > Does "Needs-Build" status mean > that the package is still waiting for CPU time on an armel, armhf, and > mipsel system somewhere on the buildd network? Yes, it's waiting for a spare buildd to pick up the builds. I don't know how the backports upload are considered in the build priority, but clearly not near the top¹.. ¹ e.g. I know that security builds are scheduled before anything else, then stable, then unstable, then experimental; and that within a single suite there are other things dictating priorities (like, new packages are built after updated ones, even if the latter came after). I just don't know where backports is in that list. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
