Bug#770357: smplayer: Complete disable check for updates
Package: smplayer
Version: 14.9.0~ds0-1.1
Severity: normal
Tags: patch
Dear Maintainer,
as updates should only come through package management there is no need for
updates nor
calling home direcly after installation. The attached patch fixes this behaviour
Greetz Alf
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.17-3.towo-siduction-amd64 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages smplayer depends on:
ii libc6 2.19-13
ii libgcc1 1:4.9.2-2
ii libqt4-dbus 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-network 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-script 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-xml 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqtcore4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqtgui4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libstdc++6 4.9.2-2
ii mplayer2 [mplayer] 2.0-728-g2c378c7-4+b1
ii zlib1g 1:1.2.8.dfsg-2
Versions of packages smplayer recommends:
ii smplayer-l10n14.9.0~ds0-1.1
ii smplayer-themes 1:14.9.0-1
smplayer suggests no packages.
-- no debconf information
Description: completely disable the looking for updates
as it is not sufficient to just disable the define.
Author: Alf Gaida
---
Last-Update: <2014-11-20>
--- smplayer-14.9.0~ds0.orig/src/basegui.cpp
+++ smplayer-14.9.0~ds0/src/basegui.cpp
@@ -106,7 +106,9 @@
#include
#endif
+#ifdef CHECK_UPDATE
#include "updatechecker.h"
+#endif
#ifdef YT_USE_SCRIPT
#include "codedownloader.h"
@@ -806,9 +808,11 @@ void BaseGui::createActions() {
connect( showCLOptionsAct, SIGNAL(triggered()),
this, SLOT(helpCLOptions()) );
+#ifdef CHECK_UPDATES
showCheckUpdatesAct = new MyAction( this, "check_updates" );
connect( showCheckUpdatesAct, SIGNAL(triggered()),
this, SLOT(helpCheckUpdates()) );
+#endif
#if defined(YOUTUBE_SUPPORT) && defined(YT_USE_SCRIPT)
updateYTAct = new MyAction( this, "update_youtube" );
@@ -1666,6 +1670,7 @@ void BaseGui::retranslateStrings() {
#ifdef LOG_MPLAYER
showLogMplayerAct->change( "MPlayer" );
#endif
+
#ifdef LOG_SMPLAYER
showLogSmplayerAct->change( "SMPlayer" );
#endif
@@ -1674,7 +1679,10 @@ void BaseGui::retranslateStrings() {
showFirstStepsAct->change( Images::icon("guide"), tr("First Steps &Guide") );
showFAQAct->change( Images::icon("faq"), tr("&FAQ") );
showCLOptionsAct->change( Images::icon("cl_help"), tr("&Command line options") );
+
+#ifdef CHECK_UPDATES
showCheckUpdatesAct->change( Images::icon("check_updates"), tr("Check for &updates") );
+#endif
#if defined(YOUTUBE_SUPPORT) && defined(YT_USE_SCRIPT)
updateYTAct->change( Images::icon("update_youtube"), tr("Update &Youtube code") );
@@ -2678,7 +2686,11 @@ void BaseGui::createMenus() {
helpMenu->addAction(showFAQAct);
helpMenu->addAction(showCLOptionsAct);
helpMenu->addSeparator();
+
+#ifdef CHECK_UPDATES
helpMenu->addAction(showCheckUpdatesAct);
+#endif
+
#if defined(YOUTUBE_SUPPORT) && defined(YT_USE_SCRIPT)
helpMenu->addAction(updateYTAct);
#endif
@@ -4017,11 +4029,13 @@ void BaseGui::helpCLOptions() {
clhelp_window->show();
}
+#ifdef CHECK_UPDATES
void BaseGui::helpCheckUpdates() {
QString url = "http://smplayer.sourceforge.net/changes.php";;
/* if (!pref->language.isEmpty()) url += QString("?tr_lang=%1").arg(pref->language); */
QDesktopServices::openUrl( QUrl(url) );
}
+#endif
void BaseGui::helpShowConfig() {
QDesktopServices::openUrl(QUrl::fromLocalFile(Paths::configPath()));
--- smplayer-14.9.0~ds0.orig/src/basegui.h
+++ smplayer-14.9.0~ds0/src/basegui.h
@@ -111,7 +111,10 @@ public slots:
virtual void helpFirstSteps();
virtual void helpFAQ();
virtual void helpCLOptions();
+#ifdef CHECK_UPDATES
virtual void helpCheckUpdates();
+#endif
+
#ifdef REMINDER_ACTIONS
virtual void helpDonate();
#endif
--- smplayer-14.9.0~ds0.orig/src/preferencesdialog.cpp
+++ smplayer-14.9.0~ds0/src/preferencesdialog.cpp
@@ -29,7 +29,10 @@
#include "prefadvanced.h"
#include "prefplaylist.h"
#include "preftv.h"
+
+#ifdef CHECK_UPDATES
#include "prefupdates.h"
+#endif
#if USE_ASSOCIATIONS
#include "prefassociations.h"
@@ -94,9 +97,10 @@ PreferencesDialog::PreferencesDialog(QWi
addSection(page_associations);
#endif
+#if CHECK_UPDATES
page_updates = new PrefUpdates;
addSection( page_updates )
Bug#770359: smplayer: Do not define reminder actions
Package: smplayer Version: 14.9.0~ds0-1.1 Severity: normal Tags: patch Dear Maintainer, please do not define reminder actions - asking donations should not be in the help menu, the donation links on the project website should be sufficient Greetz Alf -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.17-3.towo-siduction-amd64 (SMP w/4 CPU cores; PREEMPT) Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages smplayer depends on: ii libc6 2.19-13 ii libgcc1 1:4.9.2-2 ii libqt4-dbus 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqt4-network 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqt4-script 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqt4-xml 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqtcore4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqtgui4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libstdc++6 4.9.2-2 ii mplayer2 [mplayer] 2.0-728-g2c378c7-4+b1 ii zlib1g 1:1.2.8.dfsg-2 Versions of packages smplayer recommends: ii smplayer-l10n14.9.0~ds0-1.1 ii smplayer-themes 1:14.9.0-1 smplayer suggests no packages. -- no debconf information Description: not define reminder acitons in the project file as there are enough calls for donations on the project website. Tehre is no need to have anything like that in the application help menu Author: Alf Gaida --- Last-Update: <2014-11-20> --- smplayer-14.9.0~ds0.orig/src/smplayer.pro +++ smplayer-14.9.0~ds0/src/smplayer.pro @@ -23,7 +23,7 @@ DEFINES += MPCGUI DEFINES += SKINS #DEFINES += UPDATE_CHECKER #DEFINES += CHECK_UPGRADED -DEFINES += REMINDER_ACTIONS +#DEFINES += REMINDER_ACTIONS #DEFINES += USE_FONTCONFIG_OPTIONS DEFINES += AUTO_SHUTDOWN_PC ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#770377: smplayer: Use 25 items as recent max items
Package: smplayer
Version: 14.9.0~ds0-1.1
Severity: normal
Tags: patch
Dear Maintainer,
use 25 items as max recent items - 10 are to low.
Greetz Alf
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.17-3.towo-siduction-amd64 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages smplayer depends on:
ii libc6 2.19-13
ii libgcc1 1:4.9.2-2
ii libqt4-dbus 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-network 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-script 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-xml 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqtcore4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqtgui4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libstdc++6 4.9.2-2
ii mplayer2 [mplayer] 2.0-728-g2c378c7-4+b1
ii zlib1g 1:1.2.8.dfsg-2
Versions of packages smplayer recommends:
ii smplayer-l10n14.9.0~ds0-1.1
ii smplayer-themes 1:14.9.0-1
smplayer suggests no packages.
-- no debconf information
Description: max 25 recent items as default
Author: Alf Gaida
---
Last-Update: <2014-11-20>
--- smplayer-14.9.0~ds0.orig/src/recents.cpp
+++ smplayer-14.9.0~ds0/src/recents.cpp
@@ -21,7 +21,7 @@
Recents::Recents()
{
l.clear();
- max_items = 10;
+ max_items = 25;
}
Recents::~Recents() {
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#770382: smplayer: Make local rebuilds possible
Package: smplayer Version: 14.9.0~ds0-1.1 Severity: normal Tags: patch Dear Maintainer, in current state only one local build is possible as dh_auto_clean left over some directories: .moc .obj .ui - the attached patch fixes this. Greetz Alf -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.17-3.towo-siduction-amd64 (SMP w/4 CPU cores; PREEMPT) Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages smplayer depends on: ii libc6 2.19-13 ii libgcc1 1:4.9.2-2 ii libqt4-dbus 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqt4-network 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqt4-script 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqt4-xml 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqtcore4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libqtgui4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1 ii libstdc++6 4.9.2-2 ii mplayer2 [mplayer] 2.0-728-g2c378c7-4+b1 ii zlib1g 1:1.2.8.dfsg-2 Versions of packages smplayer recommends: ii smplayer-l10n14.9.0~ds0-1.1 ii smplayer-themes 1:14.9.0-1 smplayer suggests no packages. -- no debconf information diff --git a/debian/rules b/debian/rules index 91164db..8a77e9b 100755 --- a/debian/rules +++ b/debian/rules @@ -9,6 +9,9 @@ get-orig-source: uscan --force-download override_dh_auto_clean: +[ ! -d src/.moc ] || $(RM) -r src/.moc +[ ! -d src/.obj ] || $(RM) -r src/.obj +[ ! -d src/.ui ] || $(RM) -r src/.ui [ ! -f src/Makefile ] || dh_auto_clean override_dh_auto_build: ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#820472: audacious: A GTK2+ media player should really not depend on Qt 5
Package: audacious Version: 3.7.2-1 Severity: normal Hi, audacious now depends on some Qt 5 stuff, introduced via audacious-plugins - is this really needed? Maybe this bug fits better for audacious-plugins. Cheers Alf -- System Information: Debian Release: stretch/sid APT prefers buildd-unstable APT policy: (990, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (400, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.5.0-towo.1-siduction-amd64 (SMP w/8 CPU cores; PREEMPT) Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages audacious depends on: ii audacious-plugins3.7.2-1 ii dbus 1.10.8-1 ii dbus-x11 1.10.8-1 ii gtk2-engines-pixbuf 2.24.30-1.1 ii libaudcore3 3.7.2-1 ii libc62.22-5 ii libgcc1 1:5.3.1-13 ii libglib2.0-0 2.48.0-1 ii libstdc++6 5.3.1-13 Versions of packages audacious recommends: ii unzip 6.0-20 audacious suggests no packages. -- no debconf information ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
