Bug#665974: Diff between the two libmpc_0.1~r459-X.debian.tar.gz files

2012-06-20 Thread Han Boetes 
Your patch seems to fix the issue.

https://en.wikipedia.org/wiki/External_variable#Definition.2C_declaration_and_the_extern_keyword


# Han





___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#665974: Diff between the two libmpc_0.1~r459-X.debian.tar.gz files

2012-06-20 Thread Han Boetes 
With "CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Werror=format-security"
it fails and with "CFLAGS=-g -O2" it works fine indeed.




___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#665974: Diff between the two libmpc_0.1~r459-X.debian.tar.gz files

2012-06-20 Thread Han Boetes 
On 20-06-12 09:14, Fabian Greffrath wrote:
> Am 19.06.2012 17:57, schrieb Han Boetes:
> Alright. Since I consider CPPFLAGS and LDFLAGS quite harmless, could you
> please leave them as they are and rebuild another time with only CFLAGS
> reset to an empty string?

Most certainly. With only the CFLAGS cleared the library still works,
just like you suspected.


# Han





___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#665974: Diff between the two libmpc_0.1~r459-X.debian.tar.gz files

2012-06-19 Thread Han Boetes 
That is exactly the difference between a working and a non-working
binary. You're on the right track.

I've repeated the buildprocess twice so that the only diffence is the
proposed flag changes.


# Han





___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#665974: Diff between the two libmpc_0.1~r459-X.debian.tar.gz files

2012-06-13 Thread Han Boetes 
So if there is a difference between the two packages it should be in
this diff.

And when looking at it: the differences in libmpcdec6.install... Does it
really mean the installed binaries are the ones found in /usr/lib rather
than in the fake installation directory?


diff -upwr libmpc_0.1~r459-1/changelog libmpc_0.1~r459-2/changelog
--- libmpc_0.1~r459-1/changelog 2010-05-31 16:34:48.0 +0200
+++ libmpc_0.1~r459-2/changelog 2012-02-15 01:12:00.0 +0100
@@ -1,3 +1,13 @@
+libmpc (2:0.1~r459-2) unstable; urgency=low
+
+  * Team upload.
+  * Update maintainer information.
+  * Add watch file.
+  * Build for Multiarch.
+  * Bump Standards.
+
+ -- Alessio Treglia   Wed, 15 Feb 2012 01:11:57 +0100
+
 libmpc (2:0.1~r459-1) unstable; urgency=low

   * New upstream SVN snapshot.
diff -upwr libmpc_0.1~r459-1/compat libmpc_0.1~r459-2/compat
--- libmpc_0.1~r459-1/compat2010-05-31 16:25:23.0 +0200
+++ libmpc_0.1~r459-2/compat2012-02-14 23:27:59.0 +0100
@@ -1 +1 @@
-7
+9
diff -upwr libmpc_0.1~r459-1/control libmpc_0.1~r459-2/control
--- libmpc_0.1~r459-1/control   2010-05-31 16:42:04.0 +0200
+++ libmpc_0.1~r459-2/control   2012-02-15 01:10:45.0 +0100
@@ -1,20 +1,24 @@
 Source: libmpc
 Section: sound
 Priority: optional
-Maintainer: Debian multimedia packages maintainers

+Maintainer: Debian Multimedia Maintainers

 Uploaders: Sebastian Dröge ,
Jorge Salamero Sanz 
-Build-Depends: cdbs (>= 0.4.20),
-   debhelper (>= 7),
+Build-Depends: cdbs (>= 0.4.93~),
+   debhelper (>= 9),
pkg-config,
libreplaygain-dev (>= 1.0~r412),
libcue-dev
-Standards-Version: 3.8.4
+Standards-Version: 3.9.2
 Homepage: http://www.musepack.net
+Vcs-Git: git://anonscm.debian.org/pkg-multimedia/libmpc.git
+Vcs-Browser: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/libmpc.git

 Package: libmpcdec6
 Architecture: any
+Multi-Arch: same
 Section: libs
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${shlibs:Depends},
  ${misc:Depends}
 Description: MusePack decoder - library
@@ -29,6 +33,7 @@ Description: MusePack decoder - library

 Package: libmpcdec-dev
 Architecture: any
+Multi-Arch: same
 Section: libdevel
 Depends: libmpcdec6 (= ${binary:Version}),
  ${misc:Depends}
@@ -47,7 +52,6 @@ Description: MusePack decoder - developm

 Package: musepack-tools
 Architecture: any
-Section: sound
 Depends: ${shlibs:Depends},
  ${misc:Depends}
 Description: MusePack commandline utilities
Only in libmpc_0.1~r459-2: gbp.conf
diff -upwr libmpc_0.1~r459-1/libmpcdec6.install
libmpc_0.1~r459-2/libmpcdec6.install
--- libmpc_0.1~r459-1/libmpcdec6.install2010-05-30 11:59:59.0 
+0200
+++ libmpc_0.1~r459-2/libmpcdec6.install2012-02-14 23:28:10.0 
+0100
@@ -1 +1 @@
-debian/tmp/usr/lib/libmpcdec.so.*
+usr/lib/*/libmpcdec.so.*
diff -upwr libmpc_0.1~r459-1/libmpcdec-dev.install
libmpc_0.1~r459-2/libmpcdec-dev.install
--- libmpc_0.1~r459-1/libmpcdec-dev.install 2010-05-30
11:59:59.0 +0200
+++ libmpc_0.1~r459-2/libmpcdec-dev.install 2012-02-14
23:28:25.0 +0100
@@ -1,3 +1,3 @@
-debian/tmp/usr/include
-debian/tmp/usr/lib/libmpcdec.so
-debian/tmp/usr/lib/libmpcdec.a
+usr/include
+usr/lib/*/libmpcdec.so
+usr/lib/*/libmpcdec.a
diff -upwr libmpc_0.1~r459-1/musepack-tools.install
libmpc_0.1~r459-2/musepack-tools.install
--- libmpc_0.1~r459-1/musepack-tools.install2010-05-30
11:59:59.0 +0200
+++ libmpc_0.1~r459-2/musepack-tools.install2012-02-14
23:28:30.0 +0100
@@ -1 +1 @@
-debian/tmp/usr/bin
+usr/bin
diff -upwr libmpc_0.1~r459-1/rules libmpc_0.1~r459-2/rules
--- libmpc_0.1~r459-1/rules 2010-05-31 16:36:31.0 +0200
+++ libmpc_0.1~r459-2/rules 2012-02-14 23:27:02.0 +0100
@@ -4,8 +4,11 @@ include /usr/share/cdbs/1/rules/debhelpe
 include /usr/share/cdbs/1/class/autotools.mk
 include /usr/share/cdbs/1/rules/utils.mk

+DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
+
 common-binary-post-install-arch:: list-missing

 DEB_DH_MAKESHLIBS_ARGS_libmpcdec6 := -V 'libmpcdec6 (>= 1:0.1~r435)'
 DEB_CONFIGURE_EXTRA_FLAGS += --enable-mpcchap
+DEB_CONFIGURE_EXTRA_FLAGS += --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH)

Only in libmpc_0.1~r459-2: watch



# Han



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers