Re: Bug#560052: The real fix

[Adrian Knoth]

On Thu, Dec 10, 2009 at 04:10:18PM +0100, Fabian Greffrath wrote:

>> So we need a newer VAMP SDK in Debian. After that, this intermediate
>> patch can be removed:
>>
>> 
>> http://git.debian.org/?p=pkg-multimedia/ardour.git;a=commitdiff;h=347e34548cd877123865ddd65339398123f6b6a0
>
> But AFAIUI after removal of this patch we would still include the  
> headers shipped in the ardour source tree but link against the Debian  
> system library. 

You're right. This somewhat just hides the bug as long as ardour's VAMP
source matches the system's VAMP source.


> Wouldn't it make more sense to always use the Debian  package's
> headers then?

ACK, I was saying too much. It seems reasonable to keep this patch.


> BTW, shouldn't the variable, that gets commented out by the patch, be  
> called CPPPATH instead of CPPATH (i.e. three P instead of only 2)?
> 

Probably yes. I've told upstream about it.


Cheerio

-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Bug#560052: The real fix

[Felipe Sateler]

On Thu, 2009-12-10 at 15:37 +0100, Adrian Knoth wrote:
> Hi!
> 
> I've just talked to Paul Davis, ardour author:
> 
> 15:11 < las> -
> 15:11 < las> paul[186]>c++filt 
> 15:11 < las> _ZTIN4Vamp17PluginAdapterBaseE
> 15:11 < las> typeinfo for Vamp::PluginAdapterBase
> 15:11 < las> paul[187]>c++filt 
> 15:11 < las> _ZTIN11_VampPlugin4Vamp17PluginAdapterBaseE
> 15:11 < las> typeinfo for _VampPlugin::Vamp::PluginAdapterBase
> 15:11 < las> --
> 15:12 < las> adi: the vamp plugins in the ardour source tree are based on a 
>  vamp library version with different (newer, i think) namespaces 
>  than the one in your syslibs
> 15:12 < las> adi: you can't mix & match this stuff
> 15:13 < adi> That's what I suspected. When I diff the header files, our local 
>  one misses one (probably important) line.
> 15:14 < adi> _VAMP_SDK_HOSTSPACE_BEGIN(PluginLoader.h)
> 15:15 < adi> That one is missing, also the HOSTSPACE_END line at the end.
> 15:15 < adi> IOW, updating the VAMP libs in Debian should be the better 
> option?
> 15:15 < las> adi: this is precisely the kind of reason why the syslibs thing 
> is 
>  an issue. if you are going to use syslibs, the real patch needs 
> to 
>  be to NOT build and use the vamp plugins within ardour
> 15:16 < las> adi: that mini-library exists because ardour only actually needs 
> a 
>  2 or 3 VAMP plugins and it seemed easier to include them with 
> the 
>  program since they are not really "optional"
> 
> 
> So we need a newer VAMP SDK in Debian. After that, this intermediate
> patch can be removed:

The correct fix is to build using the system VAMP. The problem was
caused by a mismatch of the included and the system VAMP, because the
program was built with the included, but the system one was used at
runtime.


-- 
Saludos,
Felipe Sateler


signature.asc
Description: This is a digitally signed message part
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#560052: The real fix

[Fabian Greffrath]

Am 10.12.2009 15:37, schrieb Adrian Knoth:

So we need a newer VAMP SDK in Debian. After that, this intermediate
patch can be removed:


http://git.debian.org/?p=pkg-multimedia/ardour.git;a=commitdiff;h=347e34548cd877123865ddd65339398123f6b6a0


But AFAIUI after removal of this patch we would still include the 
headers shipped in the ardour source tree but link against the Debian 
system library. Wouldn't it make more sense to always use the Debian 
package's headers then?


BTW, shouldn't the variable, that gets commented out by the patch, be 
called CPPPATH instead of CPPATH (i.e. three P instead of only 2)?



Fabian

--
Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax: +49 (0)234 / 32-14227
E-Mail:  greffr...@leat.ruhr-uni-bochum.de

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Bug#560052: The real fix

[Adrian Knoth]

Hi!

I've just talked to Paul Davis, ardour author:

15:11 < las> -
15:11 < las> paul[186]>c++filt 
15:11 < las> _ZTIN4Vamp17PluginAdapterBaseE
15:11 < las> typeinfo for Vamp::PluginAdapterBase
15:11 < las> paul[187]>c++filt 
15:11 < las> _ZTIN11_VampPlugin4Vamp17PluginAdapterBaseE
15:11 < las> typeinfo for _VampPlugin::Vamp::PluginAdapterBase
15:11 < las> --
15:12 < las> adi: the vamp plugins in the ardour source tree are based on a 
 vamp library version with different (newer, i think) namespaces 
 than the one in your syslibs
15:12 < las> adi: you can't mix & match this stuff
15:13 < adi> That's what I suspected. When I diff the header files, our local 
 one misses one (probably important) line.
15:14 < adi> _VAMP_SDK_HOSTSPACE_BEGIN(PluginLoader.h)
15:15 < adi> That one is missing, also the HOSTSPACE_END line at the end.
15:15 < adi> IOW, updating the VAMP libs in Debian should be the better option?
15:15 < las> adi: this is precisely the kind of reason why the syslibs thing is 
 an issue. if you are going to use syslibs, the real patch needs to 
 be to NOT build and use the vamp plugins within ardour
15:16 < las> adi: that mini-library exists because ardour only actually needs a 
 2 or 3 VAMP plugins and it seemed easier to include them with the 
 program since they are not really "optional"


So we need a newer VAMP SDK in Debian. After that, this intermediate
patch can be removed:

   
http://git.debian.org/?p=pkg-multimedia/ardour.git;a=commitdiff;h=347e34548cd877123865ddd65339398123f6b6a0


-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers