Bug#580088: jack-audio-connection-kit: FTBFS on armel (cannot convert 'int' to 'va_list')

2010-05-03 Thread Adrian Knoth
On Mon, May 03, 2010 at 04:00:14PM +0100, Adam D. Barratt wrote:

 ../common/JackAPI.cpp:303: error: cannot convert 'int' to 'va_list'
 for argument '4' to 'jack_client_t* jack_client_open_aux(const char*,
 jack_options_t, jack_status_t*, va_list)'

The code in question:

   jack_client_open_aux(client_name, (jack_options_t)options, NULL, NULL);

Obviously, arg4 is NULL, so the message means the compiler cannot
convert 0 to a va_list, which should be (more or less) a pointer. Or at
least was until some va_list mangling in gcc-4.4.

I don't have a clue: anybody more common with ARM specifics around?



TIA

-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers


Bug#580088: jack-audio-connection-kit: FTBFS on armel (cannot convert 'int' to 'va_list')

2010-05-03 Thread Simon McVittie
On Mon, 03 May 2010 at 18:13:00 +0200, Adrian Knoth wrote:
 Obviously, arg4 is NULL, so the message means the compiler cannot
 convert 0 to a va_list, which should be (more or less) a pointer.

Or a struct, or a platform-specific-object that exists nowhere else in C, or a
piece of cheese, depending. (C makes no guarantees about what va_list means; I
doubt C++ does either.)

Googling for armel va_list turns up
https://bugs.launchpad.net/ubuntu/+source/gnome-keyring/+bug/527179 which
suggests that va_list is indeed a struct on armel.

 The code in question:

jack_client_open_aux(client_name, (jack_options_t)options, NULL, NULL);

Instead of trying to fake up an empty va_list, why not call the varargs
version, with only the argument terminator in its varargs?

jack_client_open(client_name, (jack_options_t)options, NULL, NULL);

I'm assuming here that jack_client_open_aux is to jack_client_open as
vprintf is to printf, i.e. jack_client_open just calls jack_client_open_aux.

Regards,
S
(who knows very little about armel or JACK)



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers


Bug#580088: jack-audio-connection-kit: FTBFS on armel (cannot convert 'int' to 'va_list')

2010-05-03 Thread Adrian Knoth
On Mon, May 03, 2010 at 05:50:39PM +0100, Simon McVittie wrote:

  The code in question:
 
 jack_client_open_aux(client_name, (jack_options_t)options, NULL, NULL);
 
 Instead of trying to fake up an empty va_list, why not call the varargs
 version, with only the argument terminator in its varargs?
 
 jack_client_open(client_name, (jack_options_t)options, NULL, NULL);

Absolutely. I've been blind. ;)


Thanks, this should work.

-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers


Bug#580088: jack-audio-connection-kit: FTBFS on armel (cannot convert 'int' to 'va_list')

2010-05-03 Thread Julien Cristau
On Mon, May  3, 2010 at 18:13:00 +0200, Adrian Knoth wrote:

 On Mon, May 03, 2010 at 04:00:14PM +0100, Adam D. Barratt wrote:
 
  ../common/JackAPI.cpp:303: error: cannot convert 'int' to 'va_list'
  for argument '4' to 'jack_client_t* jack_client_open_aux(const char*,
  jack_options_t, jack_status_t*, va_list)'
 
 The code in question:
 
jack_client_open_aux(client_name, (jack_options_t)options, NULL, NULL);
 
 Obviously, arg4 is NULL, so the message means the compiler cannot
 convert 0 to a va_list, which should be (more or less) a pointer. Or at
 least was until some va_list mangling in gcc-4.4.
 
va_list is very much not a pointer.  It's an opaque type, using it as a
pointer is wrong.

Cheers,
Julien


signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers