Bug#699127: qjackctl wrapper script broken and not needed anymore

[Kaj Ailomaa]

Package: qjackctl
Version: 0.3.9-2

The wrapper script /usr/bin/qjackctl (launcher.sh) never uses pasuspender,  
since the return of the line:

`whereis -b pasuspender | cut -d ':' -f 2 | tr -d ' '`
is not as expected:
/usr/bin/pasuspender/usr/bin/X11/pasuspender

Also, since we don't need pasuspender in most cases, there should be a  
strong reason to remove it.
The only usecase I can see is when jackd1 is installed (as jackd2 can grab  
the device from pulseaudio), and the user intends to use jack with the  
same device as pulseaudio uses (if using a different device, one might  
want to use pulseaudio in paralell).


So, I suggest removing the wrapper script all together. Here's a patch  
that takes care of that:


diff --git a/debian/launcher.sh b/debian/launcher.sh
deleted file mode 100755
index 6ec8799..000
--- a/debian/launcher.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/sh
-
-# laucher.sh - Disable PulseAudio before launching a JACKD based program
-# Copyright © 2011 Alessio Treglia ales...@debian.org
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-
-PROGRAM=/usr/lib/qjackctl/qjackctl.real
-PASUSPENDER=`whereis -b pasuspender | cut -d ':' -f 2 | tr -d ' '`
-
-( [ -x ${PASUSPENDER} ]  ${PASUSPENDER} -- ${PROGRAM} ${@} ) ||  
${PROGRAM} ${@}

-
-exit 0
diff --git a/debian/rules b/debian/rules
index ff003f9..78d9dad 100755
--- a/debian/rules
+++ b/debian/rules
@@ -20,9 +20,3 @@ cleanbuilddir::
rm -rf src/.moc/ src/.obj/ src/.ui/
rm -rf src/config.h src/qjackctl.desktop src/src.pri \
src/translations/*.qm
-
-install/qjackctl::
-   # Move qjackctl to /usr/lib/qjackctl
-   cd debian/qjackctl/usr  \
-   mv bin/qjackctl lib/qjackctl/qjackctl.real
-   install -m 0755 debian/launcher.sh debian/qjackctl/usr/bin/qjackctl

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#699127: qjackctl wrapper script broken and not needed anymore

[Adrian Knoth]

On 01/27/2013 10:21 PM, Kaj Ailomaa wrote:

 The wrapper script /usr/bin/qjackctl (launcher.sh) never uses
 pasuspender, since the return of the line:
 `whereis -b pasuspender | cut -d ':' -f 2 | tr -d ' '`
 is not as expected:
 /usr/bin/pasuspender/usr/bin/X11/pasuspender

Good catch!

We should probably simply hardcode /usr/bin/pasuspender. I cannot
imagine any other place on Debian/Ubuntu systems.

Alternative: asumme it's in $PATH and call which pasuspender

 Also, since we don't need pasuspender in most cases, there should be a
 strong reason to remove it.
 The only usecase I can see is when jackd1 is installed (as jackd2 can
 grab the device from pulseaudio), and the user intends to use jack with
 the same device as pulseaudio uses (if using a different device, one
 might want to use pulseaudio in paralell).

I agree, but maybe the truth is more complex. It needs newest pulseaudio
to work reliably, right? The one with the recent device reservation
patch.



Cheers

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers