Bug#766993: jackd2: FTBFS with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4
On 10/27/14 16:24, Jonas Smedegaard wrote: Quoting YunQiang Su (2014-10-27 15:16:44) On Mon, Oct 27, 2014 at 9:58 PM, Jonas Smedegaard d...@jones.dk wrote: If I understand your patch correctly (have only read it briefly) the first lines are better written without making shell calls, like this: WAF_EXTRA_ARGS = $(filter-out -j%,$(DEB_MAKE_EXTRA_ARGS)) WAF_JOBS = $(filter -j%,$(DEB_MAKE_EXTRA_ARGS)) Yes, using functions from make should be better. ...and even better by using underlying variable instead of extracting from DEB_MAKE_EXTRA_ARGS. I am not very familiar with cdbs, so no idea about it. Fully understood, and not a problem: I just mention for the record, in case someone would want to dive in and refine even further :-) I do expect your original patch to work fine - all of this is just suggestions for improvements. Thanks, again, for your reporting this issue and providing a patch! I know I'm late by ~10 months, but did you ultimately apply anything? :) Cheers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#766993: jackd2: FTBFS with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4
Quoting Adrian Knoth (2015-08-25 17:42:28) On 10/27/14 16:24, Jonas Smedegaard wrote: Quoting YunQiang Su (2014-10-27 15:16:44) On Mon, Oct 27, 2014 at 9:58 PM, Jonas Smedegaard d...@jones.dk wrote: If I understand your patch correctly (have only read it briefly) the first lines are better written without making shell calls, like this: WAF_EXTRA_ARGS = $(filter-out -j%,$(DEB_MAKE_EXTRA_ARGS)) WAF_JOBS = $(filter -j%,$(DEB_MAKE_EXTRA_ARGS)) Yes, using functions from make should be better. ...and even better by using underlying variable instead of extracting from DEB_MAKE_EXTRA_ARGS. I am not very familiar with cdbs, so no idea about it. Fully understood, and not a problem: I just mention for the record, in case someone would want to dive in and refine even further :-) I do expect your original patch to work fine - all of this is just suggestions for improvements. Thanks, again, for your reporting this issue and providing a patch! I know I'm late by ~10 months, but did you ultimately apply anything? :) nope :-/ - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#766993: jackd2: FTBFS with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4
Package: jackd2 Version: 1.9.10+20140719git3eb0ae6a~dfsg-2 When building jackd2 with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4, it fails: CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -Wall CXXFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -Wall CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-z,relro -j4 ./waf-light configure --prefix=/usr --classic --libdir=/usr/lib/mips64el-linux-gnuabi64 --alsa --dbus /bin/sh: 1: -j4: not found The attached patch can fix it. -- YunQiang Su diff -Nru jackd2-1.9.10+20140719git3eb0ae6a~dfsg/debian/rules jackd2-1.9.10+20140719git3eb0ae6a~dfsg/debian/rules --- jackd2-1.9.10+20140719git3eb0ae6a~dfsg/debian/rules 2014-09-25 03:36:18.0 +0800 +++ jackd2-1.9.10+20140719git3eb0ae6a~dfsg/debian/rules 2034-12-21 20:32:39.0 +0800 @@ -39,12 +39,15 @@ # Minimum assured version referenced upstream as library API/ABI ABI = 0.118.0 +WAF_EXTRA_ARGS=$(shell echo '$(DEB_MAKE_EXTRA_ARGS)' | sed 's/-j[0-9]*//g') +WAF_JOBS=$(shell echo '$(DEB_MAKE_EXTRA_ARGS)' | grep -o -- '-j[0-9]*') + waf-configure-options = --prefix=/usr --classic waf-configure-options += --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) waf-configure-options += $(if $(filter linux,$(DEB_HOST_ARCH_OS)),--alsa --dbus) waf-configure-options += $(if $(filter amd64 i386 powerpc,$(DEB_HOST_ARCH)),--firewire) -DEB_MAKE_INVOKE = $(DEB_MAKE_EXTRA_ARGS) ./waf-light -v --destdir=$(CURDIR)/debian/tmp +DEB_MAKE_INVOKE = $(WAF_EXTRA_ARGS) ./waf-light -v --destdir=$(CURDIR)/debian/tmp $(WAF_JOBS) DEB_MAKE_INSTALL_TARGET = install # TODO: use distclean and drop related clean target, when (or if) @@ -75,7 +78,7 @@ common-configure-impl:: debian/stamp-waf-configure debian/stamp-waf-configure: chmod +x ./waf-light - $(DEB_MAKE_EXTRA_ARGS) ./waf-light configure $(waf-configure-options) + $(WAF_EXTRA_ARGS) ./waf-light configure $(waf-configure-options) $(WAF_JOBS) touch $@ clean:: rm -f debian/stamp-waf-configure___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#766993: jackd2: FTBFS with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4
Quoting YunQiang Su (2014-10-27 14:32:43) When building jackd2 with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4, it fails: CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -Wall CXXFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -Wall CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-z,relro -j4 ./waf-light configure --prefix=/usr --classic --libdir=/usr/lib/mips64el-linux-gnuabi64 --alsa --dbus /bin/sh: 1: -j4: not found The attached patch can fix it. Thanks! If I understand your patch correctly (have only read it briefly) the first lines are better written without making shell calls, like this: WAF_EXTRA_ARGS = $(filter-out -j%,$(DEB_MAKE_EXTRA_ARGS)) WAF_JOBS = $(filter -j%,$(DEB_MAKE_EXTRA_ARGS)) ...and even better by using underlying variable instead of extracting from DEB_MAKE_EXTRA_ARGS. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#766993: jackd2: FTBFS with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4
On Mon, Oct 27, 2014 at 9:58 PM, Jonas Smedegaard d...@jones.dk wrote: Quoting YunQiang Su (2014-10-27 14:32:43) When building jackd2 with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4, it fails: CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -Wall CXXFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -Wall CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-z,relro -j4 ./waf-light configure --prefix=/usr --classic --libdir=/usr/lib/mips64el-linux-gnuabi64 --alsa --dbus /bin/sh: 1: -j4: not found The attached patch can fix it. Thanks! If I understand your patch correctly (have only read it briefly) the first lines are better written without making shell calls, like this: WAF_EXTRA_ARGS = $(filter-out -j%,$(DEB_MAKE_EXTRA_ARGS)) WAF_JOBS = $(filter -j%,$(DEB_MAKE_EXTRA_ARGS)) Yes, using functions from make should be better. ...and even better by using underlying variable instead of extracting from DEB_MAKE_EXTRA_ARGS. I am not very familiar with cdbs, so no idea about it. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private -- YunQiang Su ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#766993: jackd2: FTBFS with DEB_BUILD_PARALLEL=1 DEB_BUILD_OPTIONS=parallel=4
Quoting YunQiang Su (2014-10-27 15:16:44) On Mon, Oct 27, 2014 at 9:58 PM, Jonas Smedegaard d...@jones.dk wrote: If I understand your patch correctly (have only read it briefly) the first lines are better written without making shell calls, like this: WAF_EXTRA_ARGS = $(filter-out -j%,$(DEB_MAKE_EXTRA_ARGS)) WAF_JOBS = $(filter -j%,$(DEB_MAKE_EXTRA_ARGS)) Yes, using functions from make should be better. ...and even better by using underlying variable instead of extracting from DEB_MAKE_EXTRA_ARGS. I am not very familiar with cdbs, so no idea about it. Fully understood, and not a problem: I just mention for the record, in case someone would want to dive in and refine even further :-) I do expect your original patch to work fine - all of this is just suggestions for improvements. Thanks, again, for your reporting this issue and providing a patch! Regards, - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
