Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

Hi Andreas,

2016-11-03 23:06 GMT+01:00 Andreas Cadhalpun :
> Hi Bálint,
>
> On 03.11.2016 13:00, Bálint Réczey wrote:
>> 2016-11-03 12:54 GMT+01:00 Balint Reczey :
>>> Thank you for the triaging and extensive description of the problem.
>>> I have now forwarded the patch to upstream under your name since I did
>>> not really add anything to the patch.
>
> The patch looks good, thanks for forwarding it upstream. (Even though
> one of the upstream developers has some peculiar ideas about correct
> code.)
>
>> If someone having the test file could test latest kodi in unstable
>> that  would be geat.
>
> There is a test file[1] in one of the merged bugs.
> However, testing the latest kodi in unstable is of limited use, since
> it was built against the same ffmpeg version currently in unstable.
>
> If you want to verify that the problem is fixed, you'd have to recompile
> kodi against 3.0.1 and test it with the current ffmpeg libraries (or
> the ones from 3.1.1).

Thank you for pointing to the test file. Proper testing would involve
a recompilation indeed, but since upstream does not want to
merge the patch anyway I don't feel this kind of testing necessary.

Cheers,
Balint

>
> Best regards,
> Andreas
>
>
> 1: 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=832364;filename=test2.ts.gz;msg=67

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

2016-11-03 12:54 GMT+01:00 Balint Reczey :
...
> On Fri, 14 Oct 2016 01:27:47 +0200 Andreas Cadhalpun
>  wrote:
> ...
>
>>
>> Hi,
>>
>> The relevant backtrace from the kodi_crashlog is:
...
>> In the experimental kodi branch there is another occurrence of this bug
>> in xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/MMALRenderer.cpp.
>
> Thank you for the triaging and extensive description of the problem.
> I have now forwarded the patch to upstream under your name since I did
> not really add anything to the patch.


If someone having the test file could test latest kodi in unstable
that  would be geat.

Cheers,
Balint

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Balint Reczey]

Control: forwarded -1 https://github.com/xbmc/xbmc/pull/10846
Control: tags -1 upstream


Hi Andreas,

On Fri, 14 Oct 2016 01:27:47 +0200 Andreas Cadhalpun
 wrote:
...

> 
> Hi,
> 
> The relevant backtrace from the kodi_crashlog is:
> 
> Thread 1 (Thread 0x7f1b6bffe700 (LWP 16893)):
> #0  0x7f1ba92991c8 in __GI_raise (sig=sig@entry=6) at 
> ../sysdeps/unix/sysv/linux/raise.c:54
> #1  0x7f1ba929a64a in __GI_abort () at abort.c:89
> #2  0x7f1ba92d4f4a in __libc_message (do_abort=do_abort@entry=2, 
> fmt=fmt@entry=0x7f1ba93cdb30 "*** Error in `%s': %s: 0x%s ***\n") at 
> ../sysdeps/posix/libc_fatal.c:175
> #3  0x7f1ba92da6b6 in malloc_printerr (action=3, str=0x7f1ba93ca909 
> "free(): invalid pointer", ptr=, ar_ptr=) at 
> malloc.c:5004
> #4  0x7f1ba92dae9e in _int_free (av=0x7f1ba9601b20 , 
> p=, have_lock=0) at malloc.c:3865
> #5  0x7f1baa6d4a9d in av_buffer_unref () from 
> /usr/lib/x86_64-linux-gnu/libavutil.so.55
> #6  0x7f1baa6e15d2 in av_frame_unref () from 
> /usr/lib/x86_64-linux-gnu/libavutil.so.55
> #7  0x7f1bab93cf10 in avcodec_decode_video2 () from 
> /usr/lib/x86_64-linux-gnu/libavcodec.so.57
> #8  0x0090b26c in CDVDDemuxFFmpeg::ParsePacket(AVPacket*) ()
> #9  0x0090d0c2 in CDVDDemuxFFmpeg::Read() ()
> #10 0x01079b53 in CDVDPlayer::ReadPacket(DemuxPacket*&, 
> CDemuxStream*&) ()
> #11 0x0107ecd7 in CDVDPlayer::Process() ()
> #12 0x012103ff in CThread::Action() ()
> #13 0x012106bf in CThread::staticThread(void*) ()
> #14 0x7f1bb23e5464 in start_thread (arg=0x7f1b6bffe700) at 
> pthread_create.c:333
> #15 0x7f1ba934d30d in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> 
> Looking at the ParsePacket function reveals [1]:
> AVFrame picture;
> memset(, 0, sizeof(AVFrame));
> picture.pts = picture.pkt_dts = picture.pkt_pts = 
> picture.best_effort_timestamp = AV_NOPTS_VALUE;
> picture.pkt_pos = -1;
> picture.key_frame = 1;
> picture.format = -1;
> 
> This is using non-public ABI, e.g. the size of AVFrame, while the 
> documentation
> explicitly says "sizeof(AVFrame) is not a part of the public ABI" [2].
> What's worse is that it doesn't use av_frame_alloc as required [3]:
> "AVFrame must be allocated using av_frame_alloc()."
> 
> The whole block quoted above should be replaced with:
> AVFrame *picture = av_frame_alloc().
> 
> Then the following code should use picture instead of :
> avcodec_decode_video2(st->codec, picture, _picture, pkt);
> 
> And at the end it can be freed (instead of using av_frame_unref) with:
> av_frame_free();
> 
> In the experimental kodi branch there is another occurrence of this bug
> in xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/MMALRenderer.cpp.

Thank you for the triaging and extensive description of the problem.
I have now forwarded the patch to upstream under your name since I did
not really add anything to the patch.

> 
> Best regards,
> Andreas
> 
> 
> 1: 
> https://anonscm.debian.org/cgit/pkg-multimedia/kodi.git/tree/xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxFFmpeg.cpp?id=8d5cf423001aa4e7f850c20b158b2811e637e607#n1665
> 2: 
> https://anonscm.debian.org/cgit/pkg-multimedia/ffmpeg.git/tree/libavutil/frame.h?id=87b93f4e3ee2b6253ab9f5a166860a1ff18877d5#n174
> 3: 
> https://anonscm.debian.org/cgit/pkg-multimedia/ffmpeg.git/tree/libavutil/frame.h?id=87b93f4e3ee2b6253ab9f5a166860a1ff18877d5#n154
> 
> 

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Processed: Re: Bug#831591: ffmpeg: kodi crash

[Debian Bug Tracking System]

Processing control commands:

> forwarded -1 https://github.com/xbmc/xbmc/pull/10846
Bug #831591 {Done: Balint Reczey } [kodi] ffmpeg: kodi 
crash
Bug #832364 {Done: Balint Reczey } [kodi] kodi: Crashes 
on trying to play any TV recording
Set Bug forwarded-to-address to 'https://github.com/xbmc/xbmc/pull/10846'.
Set Bug forwarded-to-address to 'https://github.com/xbmc/xbmc/pull/10846'.
> tags -1 upstream
Bug #831591 {Done: Balint Reczey } [kodi] ffmpeg: kodi 
crash
Bug #832364 {Done: Balint Reczey } [kodi] kodi: Crashes 
on trying to play any TV recording
Added tag(s) upstream.
Added tag(s) upstream.

-- 
831591: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831591
832364: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832364
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Andreas Cadhalpun]

Control: reopen -1
Control: reassign -1 kodi 16.1+dfsg1-2
Control: severity -1 important

Hi,

The relevant backtrace from the kodi_crashlog is:

Thread 1 (Thread 0x7f1b6bffe700 (LWP 16893)):
#0  0x7f1ba92991c8 in __GI_raise (sig=sig@entry=6) at 
../sysdeps/unix/sysv/linux/raise.c:54
#1  0x7f1ba929a64a in __GI_abort () at abort.c:89
#2  0x7f1ba92d4f4a in __libc_message (do_abort=do_abort@entry=2, 
fmt=fmt@entry=0x7f1ba93cdb30 "*** Error in `%s': %s: 0x%s ***\n") at 
../sysdeps/posix/libc_fatal.c:175
#3  0x7f1ba92da6b6 in malloc_printerr (action=3, str=0x7f1ba93ca909 
"free(): invalid pointer", ptr=, ar_ptr=) at 
malloc.c:5004
#4  0x7f1ba92dae9e in _int_free (av=0x7f1ba9601b20 , 
p=, have_lock=0) at malloc.c:3865
#5  0x7f1baa6d4a9d in av_buffer_unref () from 
/usr/lib/x86_64-linux-gnu/libavutil.so.55
#6  0x7f1baa6e15d2 in av_frame_unref () from 
/usr/lib/x86_64-linux-gnu/libavutil.so.55
#7  0x7f1bab93cf10 in avcodec_decode_video2 () from 
/usr/lib/x86_64-linux-gnu/libavcodec.so.57
#8  0x0090b26c in CDVDDemuxFFmpeg::ParsePacket(AVPacket*) ()
#9  0x0090d0c2 in CDVDDemuxFFmpeg::Read() ()
#10 0x01079b53 in CDVDPlayer::ReadPacket(DemuxPacket*&, CDemuxStream*&) 
()
#11 0x0107ecd7 in CDVDPlayer::Process() ()
#12 0x012103ff in CThread::Action() ()
#13 0x012106bf in CThread::staticThread(void*) ()
#14 0x7f1bb23e5464 in start_thread (arg=0x7f1b6bffe700) at 
pthread_create.c:333
#15 0x7f1ba934d30d in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Looking at the ParsePacket function reveals [1]:
AVFrame picture;
memset(, 0, sizeof(AVFrame));
picture.pts = picture.pkt_dts = picture.pkt_pts = 
picture.best_effort_timestamp = AV_NOPTS_VALUE;
picture.pkt_pos = -1;
picture.key_frame = 1;
picture.format = -1;

This is using non-public ABI, e.g. the size of AVFrame, while the documentation
explicitly says "sizeof(AVFrame) is not a part of the public ABI" [2].
What's worse is that it doesn't use av_frame_alloc as required [3]:
"AVFrame must be allocated using av_frame_alloc()."

The whole block quoted above should be replaced with:
AVFrame *picture = av_frame_alloc().

Then the following code should use picture instead of :
avcodec_decode_video2(st->codec, picture, _picture, pkt);

And at the end it can be freed (instead of using av_frame_unref) with:
av_frame_free();

In the experimental kodi branch there is another occurrence of this bug
in xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/MMALRenderer.cpp.

Best regards,
Andreas


1: 
https://anonscm.debian.org/cgit/pkg-multimedia/kodi.git/tree/xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxFFmpeg.cpp?id=8d5cf423001aa4e7f850c20b158b2811e637e607#n1665
2: 
https://anonscm.debian.org/cgit/pkg-multimedia/ffmpeg.git/tree/libavutil/frame.h?id=87b93f4e3ee2b6253ab9f5a166860a1ff18877d5#n174
3: 
https://anonscm.debian.org/cgit/pkg-multimedia/ffmpeg.git/tree/libavutil/frame.h?id=87b93f4e3ee2b6253ab9f5a166860a1ff18877d5#n154

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Processed: Re: Bug#831591: ffmpeg: kodi crash

[Debian Bug Tracking System]

Processing control commands:

> reopen -1
Bug #831591 {Done: Bálint Réczey } [ffmpeg] ffmpeg: 
kodi crash
Bug #832364 {Done: Bálint Réczey } [ffmpeg] kodi: 
Crashes on trying to play any TV recording
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions ffmpeg/7:3.1.3-1.
No longer marked as fixed in versions ffmpeg/7:3.1.3-1.
> reassign -1 kodi 16.1+dfsg1-2
Bug #831591 [ffmpeg] ffmpeg: kodi crash
Bug #832364 [ffmpeg] kodi: Crashes on trying to play any TV recording
Bug reassigned from package 'ffmpeg' to 'kodi'.
Bug reassigned from package 'ffmpeg' to 'kodi'.
No longer marked as found in versions ffmpeg/7:3.1.1-2.
No longer marked as found in versions ffmpeg/7:3.1.1-2.
Ignoring request to alter fixed versions of bug #831591 to the same values 
previously set
Ignoring request to alter fixed versions of bug #832364 to the same values 
previously set
Bug #831591 [kodi] ffmpeg: kodi crash
Bug #832364 [kodi] kodi: Crashes on trying to play any TV recording
Marked as found in versions kodi/16.1+dfsg1-2.
Marked as found in versions kodi/16.1+dfsg1-2.
> severity -1 important
Bug #831591 [kodi] ffmpeg: kodi crash
Bug #832364 [kodi] kodi: Crashes on trying to play any TV recording
Severity set to 'important' from 'serious'
Severity set to 'important' from 'serious'

-- 
831591: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831591
832364: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832364
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Processed: Re: Bug#831591: ffmpeg: kodi crash

[Debian Bug Tracking System]

Processing control commands:

> fixed -1 7:3.1.3-1
Bug #831591 [ffmpeg] ffmpeg: kodi crash
Bug #832364 [ffmpeg] kodi: Crashes on trying to play any TV recording
Marked as fixed in versions ffmpeg/7:3.1.3-1.
Marked as fixed in versions ffmpeg/7:3.1.3-1.

-- 
831591: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831591
832364: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832364
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

Control: fixed -1 7:3.1.3-1

Hi Carl,

2016-09-07 20:21 GMT+02:00 Carl Eugen Hoyos :
> Hi Bálint!
>
>> I went throught the unclassified bugs and set the
>> proper state to help tracking them.
>
> This bug (#831591) and #832364 contain neither backtrace
> nor bisect. Note that they most likely have to be fixed
> in Kodi, FFmpeg will (afaict) not break ABI once more
> for the 3.1 release series to work-around bugs in other
> projects.
> (This analysis may of course be wrong but we cannot
> know better so far.)

I'm marking this bug fixed and close it because it does not affect
any package in unstable/testing.

I believe there was an unintended ABI breakage in FFmpeg and
it caused the kodi crash but since no one is really interested in
debugging that after recompiling solved it there is little value in
keeping it open.

>
> Bug #797965 contains no sample, I cannot reproduce.
> (Same for #833722 and #797963 which are marked as
> needs-more-info.)

In #797965 Christoph provided a way of reproducing it:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797965#126

Andreas even provided a patch thus I believe it is a valid bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797965#116

If I ever find time I'll create a reproducer based on Christoph's
guide, but it is unlikely to happen before Stretch's release.

>
> Bug #810224 is invalid: Behaviour is exactly as
> requested by you, my original analysis was wrong.

Closed that one, thanks.

>
> I do not understand why it makes sense to keep #493705
> and #528080 open: I believe Debian decided many years
> ago that they will not be fixed, FFmpeg has repeated
> its opinion that there is no bug last year (when
> Google stopped allowing such binaries in Android).
> (If you want you can fix both bugs anytime by adding
> --disable-asm to the configure options for x86_32.)

Those are known limitations of the Debian package and the bugs'
state reflects that.

> I have fixed #785690 upstream today, don't know how
> you proceed with the report here.
> http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=3e886e7

Marked accordingly, thanks.
It can be closed with uploading a new upstream release containing the fix.
I don't think that this issue warrants a back-port.

Cheers,
Balint

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Carl Eugen Hoyos]

Hi Bálint!

> I went throught the unclassified bugs and set the 
> proper state to help tracking them.

This bug (#831591) and #832364 contain neither backtrace 
nor bisect. Note that they most likely have to be fixed 
in Kodi, FFmpeg will (afaict) not break ABI once more 
for the 3.1 release series to work-around bugs in other 
projects.
(This analysis may of course be wrong but we cannot 
know better so far.)

Bug #797965 contains no sample, I cannot reproduce.
(Same for #833722 and #797963 which are marked as 
needs-more-info.)

Bug #810224 is invalid: Behaviour is exactly as 
requested by you, my original analysis was wrong.

I do not understand why it makes sense to keep #493705 
and #528080 open: I believe Debian decided many years 
ago that they will not be fixed, FFmpeg has repeated 
its opinion that there is no bug last year (when 
Google stopped allowing such binaries in Android).
(If you want you can fix both bugs anytime by adding 
--disable-asm to the configure options for x86_32.)

I have fixed #785690 upstream today, don't know how 
you proceed with the report here.
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=3e886e7

Thank you, Carl Eugen

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

Hi Carl,

2016-09-06 12:41 GMT+02:00 Carl Eugen Hoyos :
> Hi!
>
>> Knowing what broke could be
>> interesting for FFmpeg devs
>
> It would most likely be even more interesting
> for the Kodi developers: We currently assume
> that there is an unknown bug in Kodi...

Well, the first suspect is ffmpeg because updating ffmpeg
broke kodi while there were no planned ABI change.

>
>> > Slightly related: More that half of the open tickets
>> > concerning FFmpeg in Debian either contain no samples to
>> > reproduce or will not be fixed or were never reproducible.
>> > If another FFmpeg developer were interested in fixing
>> > bugs reported here it would be very difficult for him to
>> > find something useful due to the low snr.
>>
>> Those can be marked with the moreinfo tag and IMO it is
>> OK to close them after a reasonable amount of time if
>> the originator is asked to provide a test file but she/he
>> did not.
>
> Are five months enough?

Generally I use a few years if I'm not pretty sure the bug is gone.
I agree with the concept that bugs are part of the documentation
thus closing possibly valid bugs is decreasing the quality of the
documentation, thus the software.

Note that there are way more users of stable and a bug not
reproducible on unstable may show up in stable later.

I went throught the unclassified bugs and set the proper state
to help tracking them.

Cheers,
Balint

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Carl Eugen Hoyos]

Hi!

> Knowing what broke could be
> interesting for FFmpeg devs

It would most likely be even more interesting 
for the Kodi developers: We currently assume 
that there is an unknown bug in Kodi...

> > Slightly related: More that half of the open tickets
> > concerning FFmpeg in Debian either contain no samples to
> > reproduce or will not be fixed or were never reproducible.
> > If another FFmpeg developer were interested in fixing
> > bugs reported here it would be very difficult for him to
> > find something useful due to the low snr.
>
> Those can be marked with the moreinfo tag and IMO it is
> OK to close them after a reasonable amount of time if
> the originator is asked to provide a test file but she/he
> did not.

Are five months enough?

Carl Eugen

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

Hi Carl,

2016-09-06 11:39 GMT+02:00 Carl Eugen Hoyos :
> Hi Bálint!
>
>> I don't have the test file.
>
> In this case I suggest to close the relevant tickets:
> We cannot reproduce, there is no backtrace and no bisect.

Tobias has test files as he wrote in #832364 and he would
share it privately.

>
> Since FFmpeg has made three point releases with the ABI
> that is apparently incompatible with (old) Kodi, it is
> very unlikely that it will be changed again (we would
> likely brake mpv that intentionally uses the invalid API).

From practical POV I'm OK with closing this bug since it does
not affect unstable nor testing. Knowing what broke could be
interesting for FFmpeg devs and in case the change is reverted
I could update ffmpeg in jessie-backports without recompiling
kodi. This is why I have not back-ported latest ffmpeg yet.


>
> Slightly related: More that half of the open tickets
> concerning FFmpeg in Debian either contain no samples to
> reproduce or will not be fixed or were never reproducible.
> If another FFmpeg developer were interested in fixing
> bugs reported here it would be very difficult for him to
> find something useful due to the low snr.

Those can be marked with the moreinfo tag and IMO it is
OK to close them after a reasonable amount of time if
the originator is asked to provide a test file but she/he
did not.

Thanks for helping in managing the FFmpeg bugs in Debian!

Cheers,
Balint

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Carl Eugen Hoyos]

Hi Bálint!

> I don't have the test file.

In this case I suggest to close the relevant tickets:
We cannot reproduce, there is no backtrace and no bisect.

Since FFmpeg has made three point releases with the ABI 
that is apparently incompatible with (old) Kodi, it is 
very unlikely that it will be changed again (we would 
likely brake mpv that intentionally uses the invalid API).

Slightly related: More that half of the open tickets 
concerning FFmpeg in Debian either contain no samples to 
reproduce or will not be fixed or were never reproducible.
If another FFmpeg developer were interested in fixing 
bugs reported here it would be very difficult for him to 
find something useful due to the low snr.

Carl Eugen

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

Hi,

2016-08-27 15:48 GMT+02:00 Carl Eugen Hoyos :
> Hi!
>
>> 2016-08-24 22:55 GMT+02:00 Carl Eugen Hoyos :
>> >
>> > First, please understand that so far, no ABI breakage between
>> > FFmpeg 3.0 and FFmpeg 3.1 was found, only the usage of
>> > non-public api (that we decided to work-around for 3.1.1).
>>
>> OK, then assume that Kodi uses non-public API and the rebuild
>> made kodi use the latest ABI.
>
> I don't know!
> I just wanted to point out that so far, the "bugs" that were
> worked-around in FFmpeg 3.1.1 were bugs in other applications.
>
> I still do not understand completely: Is the crash still reproducible
> after recompiling Kodi or not?

Sorry for not being clear on this. In #832364 the test did show that
the crash is gone with the rebuild. My only assumption was that
it used to be caused by the ABI change.
Latest kodi works well with latest ffmpeg.


>
>> Can I somehow find easily the places where the non-public API is used?
>
> I don't know but...
>
>> > Am I correct that no backtrace was provided for this issue?
>>
>> Yes, AFAIK.
>
> ... adding a backtrace should work fast, no?
> If another developer looks at the backtrace, he might know what the
> issue is.

I don't have the test file. This has been discussed in #832364.

>
>> > But even with a backtrace, I fear a bisect may be necessary.
>
> Bisecting FFmpeg takes less than 20 minutes here, I know it would take
> you longer but if the backtrace does not help, this is the only way to
> find out what the issue is.
> I can try helping to create a specific configure line to speed up the
> backtrace.

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Carl Eugen Hoyos]

Hi!

> 2016-08-24 22:55 GMT+02:00 Carl Eugen Hoyos :
> >
> > First, please understand that so far, no ABI breakage between
> > FFmpeg 3.0 and FFmpeg 3.1 was found, only the usage of
> > non-public api (that we decided to work-around for 3.1.1).
>
> OK, then assume that Kodi uses non-public API and the rebuild 
> made kodi use the latest ABI.

I don't know!
I just wanted to point out that so far, the "bugs" that were 
worked-around in FFmpeg 3.1.1 were bugs in other applications.

I still do not understand completely: Is the crash still reproducible 
after recompiling Kodi or not?

> Can I somehow find easily the places where the non-public API is used?

I don't know but...

> > Am I correct that no backtrace was provided for this issue?
>
> Yes, AFAIK.

... adding a backtrace should work fast, no?
If another developer looks at the backtrace, he might know what the 
issue is.

> > But even with a backtrace, I fear a bisect may be necessary.

Bisecting FFmpeg takes less than 20 minutes here, I know it would take 
you longer but if the backtrace does not help, this is the only way to 
find out what the issue is.
I can try helping to create a specific configure line to speed up the 
backtrace.

Carl Eugen

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Carl Eugen Hoyos]

Hi!

First, please understand that so far, no ABI breakage between 
FFmpeg 3.0 and FFmpeg 3.1 was found, only the usage of 
non-public api (that we decided to work-around for 3.1.1).

Am I correct that no backtrace was provided for this issue?
But even with a backtrace, I fear a bisect may be necessary.

Sorry, Carl Eugen 

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

Hi,

2016-08-18 17:59 GMT+02:00 Bálint Réczey :
> Hi,
>
> 2016-07-17 23:17 GMT+02:00 Sebastian Ramacher :
>> Control: severity -1 serious
>>
>> On 2016-07-17 21:38:13, Carl Eugen Hoyos wrote:
>>> Kodi reports "FFmpeg version: 3.0.1-3":
>>> Could somebody test if the crash disappears after Kodi gets recompiled 
>>> against
>>> current FFmpeg?
>>
>> Wasn't 3.1.1 supposed to revert all the ABI breakage? Raising the severity 
>> until
>> this is resolved.
>
> I have just uploaded a new kodi package to unstable thus this problem
> can be easily tested.

Apparently the ABI breakage is still present in 7:3.1.2-1.
See #832364 for details.

Carl, it would be important to track the breakage.
http://abi-laboratory.pro/tracker/timeline/ffmpeg/ may give some help.

Cheers,
Balint

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Bálint Réczey]

Hi,

2016-07-17 23:17 GMT+02:00 Sebastian Ramacher :
> Control: severity -1 serious
>
> On 2016-07-17 21:38:13, Carl Eugen Hoyos wrote:
>> Kodi reports "FFmpeg version: 3.0.1-3":
>> Could somebody test if the crash disappears after Kodi gets recompiled 
>> against
>> current FFmpeg?
>
> Wasn't 3.1.1 supposed to revert all the ABI breakage? Raising the severity 
> until
> this is resolved.

I have just uploaded a new kodi package to unstable thus this problem
can be easily tested.

Cheers,
Balint

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Sebastian Ramacher]

Control: severity -1 serious

On 2016-07-17 21:38:13, Carl Eugen Hoyos wrote:
> Kodi reports "FFmpeg version: 3.0.1-3":
> Could somebody test if the crash disappears after Kodi gets recompiled 
> against 
> current FFmpeg?

Wasn't 3.1.1 supposed to revert all the ABI breakage? Raising the severity until
this is resolved.

Cheers
-- 
Sebastian Ramacher


signature.asc
Description: PGP signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Processed: Re: Bug#831591: ffmpeg: kodi crash

[Debian Bug Tracking System]

Processing control commands:

> severity -1 serious
Bug #831591 [ffmpeg] ffmpeg: kodi crash
Severity set to 'serious' from 'normal'

-- 
831591: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831591
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Carl Eugen Hoyos]

Kodi reports "FFmpeg version: 3.0.1-3":
Could somebody test if the crash disappears after Kodi gets recompiled against 
current FFmpeg?

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Vladimir Stavrinov]

On Sun, Jul 17, 2016 at 05:30:40PM +0300, Vladmimir Stavrinov wrote:

> It happens with 7:3.1.1-2 - see attached log. With 7:3.0.2-4 there

P.S. kodi crashes on acestream only.

###  Vladimir Stavrinov  ###

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#831591: ffmpeg: kodi crash

[Vladmimir Stavrinov]

Package: ffmpeg
Version: 7:3.1.1-2
Severity: normal

It happens with 7:3.1.1-2 - see attached log. With 7:3.0.2-4 there are no such 
problem.

-- System Information:
Debian Release: stretch/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'unstable'), (500, 'testing'), 
(500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages ffmpeg depends on:
ii  libavcodec57 7:3.1.1-2
ii  libavdevice577:3.1.1-2
ii  libavfilter6 7:3.1.1-2
ii  libavformat577:3.1.1-2
ii  libavresample3   7:3.1.1-2
ii  libavutil55  7:3.1.1-2
ii  libc62.23-1
ii  libpostproc547:3.1.1-2
ii  libsdl1.2debian  1.2.15+dfsg1-4
ii  libswresample2   7:3.1.1-2
ii  libswscale4  7:3.1.1-2
ii  libva1   1.7.1-1

ffmpeg recommends no packages.

Versions of packages ffmpeg suggests:
ii  ffmpeg-doc  7:3.1.1-2

-- no debconf information
## Kodi CRASH LOG ###

 SYSTEM INFO 
 Date: Sun Jul 17 17:28:11 MSK 2016
 Kodi Options: 
 Arch: x86_64
 Kernel: Linux 4.6.0-1-amd64 #1 SMP Debian 4.6.3-1 (2016-07-04)
 Release: Debian GNU/Linux
## END SYSTEM INFO ##

### STACK TRACE #
=>  Core file: /home/vs/core (2016-07-17 17:28:10.264514288 +0300)
=
[New LWP 16893]
[New LWP 16819]
[New LWP 16824]
[New LWP 16838]
[New LWP 16821]
[New LWP 16907]
[New LWP 16834]
[New LWP 16839]
[New LWP 16811]
[New LWP 16822]
[New LWP 16825]
[New LWP 16844]
[New LWP 16845]
[New LWP 16826]
[New LWP 16820]
[New LWP 16906]
[New LWP 16908]
[New LWP 16827]
[New LWP 16848]
[New LWP 16851]
[New LWP 16872]
[New LWP 16877]
[New LWP 16831]
[New LWP 16832]
[New LWP 16836]
[New LWP 16837]
[New LWP 16840]
[New LWP 16842]
[New LWP 16841]
[New LWP 16843]
[New LWP 16847]
[New LWP 16846]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/x86_64-linux-gnu/kodi/kodi.bin'.
Program terminated with signal SIGABRT, Aborted.
#0  0x7f1ba92991c8 in __GI_raise (sig=sig@entry=6) at 
../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7f1b6bffe700 (LWP 16893))]

Thread 32 (Thread 0x7f1b2b7fe700 (LWP 16846)):
#0  0x7f1ba9345f73 in select () at ../sysdeps/unix/syscall-template.S:84
#1  0x00f5bfcc in SOCKETS::CSocketListener::Listen(int) ()
#2  0x00f500de in EVENTSERVER::CEventServer::Run() ()
#3  0x00f50388 in EVENTSERVER::CEventServer::Process() ()
#4  0x012103ff in CThread::Action() ()
#5  0x012106bf in CThread::staticThread(void*) ()
#6  0x7f1bb23e5464 in start_thread (arg=0x7f1b2b7fe700) at 
pthread_create.c:333
#7  0x7f1ba934d30d in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 31 (Thread 0x7f1b2affd700 (LWP 16847)):
#0  0x7f1ba9345f73 in select () at ../sysdeps/unix/syscall-template.S:84
#1  0x00f5df46 in JSONRPC::CTCPServer::Process() ()
#2  0x012103ff in CThread::Action() ()
#3  0x012106bf in CThread::staticThread(void*) ()
#4  0x7f1bb23e5464 in start_thread (arg=0x7f1b2affd700) at 
pthread_create.c:333
#5  0x7f1ba934d30d in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 30 (Thread 0x7f1b517fa700 (LWP 16843)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at 
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x00e9a3ec in NPT_PosixSharedVariable::WaitUntilEquals(int, int) ()
#2  0x011c1067 in PLT_CtrlPointHouseKeepingTask::DoRun() ()
#3  0x00eb46d5 in PLT_ThreadTask::Run() ()
#4  0x00e9a973 in NPT_PosixThread::EntryPoint(void*) ()
#5  0x7f1bb23e5464 in start_thread (arg=0x7f1b517fa700) at 
pthread_create.c:333
#6  0x7f1ba934d30d in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 29 (Thread 0x7f1b527fc700 (LWP 16841)):
#0  0x7f1ba9345f73 in select () at ../sysdeps/unix/syscall-template.S:84
#1  0x00e95662 in NPT_BsdSocketFd::WaitForCondition(bool, bool, bool, 
int) ()
#2  0x00e9607d in NPT_BsdUdpSocket::Receive(NPT_DataBuffer&, 
NPT_SocketAddress*) ()
#3  0x011fc6bc in PLT_InputDatagramStream::Read(void*, unsigned int, 
unsigned int*) ()
#4  0x00ef146b in NPT_BufferedInputStream::FillBuffer() ()
#5  0x00ef125a in NPT_BufferedInputStream::ReadLine(char*, unsigned 
int, unsigned int*, bool) ()
#6  0x00ef168a in NPT_BufferedInputStream::ReadLine(NPT_String&, 
unsigned int, bool) ()
#7  0x00ec143f in NPT_HttpRequest::Parse(NPT_BufferedInputStream&, 
NPT_SocketAddress const*, NPT_HttpRequest*&) ()
#8  0x011cfc36 in