Bug#929730: systemd: boot-and-services test expects first kernel log line, but not always in logs
Opened MR: https://salsa.debian.org/systemd-team/systemd/merge_requests/34 thanks! On Tue, Jun 25, 2019 at 4:55 PM Michael Biebl wrote: > > Am 25.06.19 um 22:51 schrieb Michael Biebl: > > Dan, could you submit your patch as merge request? > > Btw, we use gbp-dch style commit messages. > > E.g. Debian bugs are closed by adding a > > Closes: #929730 > > line to the git commit message. > > http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/man.gbp.dch.html > -- > Why is it that all of the instruments seeking intelligent life in the > universe are pointed away from Earth? > ___ Pkg-systemd-maintainers mailing list Pkg-systemd-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
Bug#929730: systemd: boot-and-services test expects first kernel log line, but not always in logs
Am 25.06.19 um 22:51 schrieb Michael Biebl: > Dan, could you submit your patch as merge request? Btw, we use gbp-dch style commit messages. E.g. Debian bugs are closed by adding a Closes: #929730 line to the git commit message. http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/man.gbp.dch.html -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature ___ Pkg-systemd-maintainers mailing list Pkg-systemd-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
Bug#929730: systemd: boot-and-services test expects first kernel log line, but not always in logs
Am 29.05.19 um 18:49 schrieb Dan Streetman: > On Wed, May 29, 2019 at 12:35 PM Michael Biebl wrote: >> >> Am 29.05.19 um 18:19 schrieb Dan Streetman: >>> Package: systemd >>> Version: 241-5 >>> Severity: normal >>> Tags: patch >>> User: ubuntu-de...@lists.ubuntu.com >>> Usertags: origin-ubuntu eoan ubuntu-patch >>> >>> Dear Maintainer, >>> >>> boot-and-services test expects the first(ish) kernel log line to be in the >>> system logs, but that is not guaranteed to be in the logs. >>> >>> -- Package-specific info: >>> >>> >>> * d/t/boot-and-services: >>> - don't fail if some kernel msgs are missed (LP: #1830479) >> >> >> Afair, this is due to the kernel ring buffer being too small (on arm64) >> Wouldn't it be better to address that? After all, you also want early >> boot messages when running systemd in production. > > that's one reason; is systemd missing kernel messages due to no fault > of its own really something that should fail the test case? > Good question. Since Martin is our autopkgtest expert, it's probably best to wait for his reply here. Again, if you submit a MR via salsa, you make it a bit easier for us to review and apply the changes. Regards, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature ___ Pkg-systemd-maintainers mailing list Pkg-systemd-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
Bug#929730: systemd: boot-and-services test expects first kernel log line, but not always in logs
On Wed, May 29, 2019 at 12:35 PM Michael Biebl wrote: > > Am 29.05.19 um 18:19 schrieb Dan Streetman: > > Package: systemd > > Version: 241-5 > > Severity: normal > > Tags: patch > > User: ubuntu-de...@lists.ubuntu.com > > Usertags: origin-ubuntu eoan ubuntu-patch > > > > Dear Maintainer, > > > > boot-and-services test expects the first(ish) kernel log line to be in the > > system logs, but that is not guaranteed to be in the logs. > > > > -- Package-specific info: > > > > > > * d/t/boot-and-services: > > - don't fail if some kernel msgs are missed (LP: #1830479) > > > Afair, this is due to the kernel ring buffer being too small (on arm64) > Wouldn't it be better to address that? After all, you also want early > boot messages when running systemd in production. that's one reason; is systemd missing kernel messages due to no fault of its own really something that should fail the test case? note that unless systemd-journald explicitly noted that kernel messages were missed, it still checks for the command-line kernel line > > > -- > Why is it that all of the instruments seeking intelligent life in the > universe are pointed away from Earth? > ___ Pkg-systemd-maintainers mailing list Pkg-systemd-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
Bug#929730: systemd: boot-and-services test expects first kernel log line, but not always in logs
Package: systemd
Version: 241-5
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu eoan ubuntu-patch
Dear Maintainer,
boot-and-services test expects the first(ish) kernel log line to be in the
system logs, but that is not guaranteed to be in the logs.
-- Package-specific info:
* d/t/boot-and-services:
- don't fail if some kernel msgs are missed (LP: #1830479)
Thanks for considering the patch.
-- System Information:
Debian Release: buster/sid
APT prefers disco-updates
APT policy: (500, 'disco-updates'), (500, 'disco-security'), (500, 'disco'),
(100, 'disco-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.0.0-13-generic (SMP w/24 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages systemd is related to:
pn dracut
ii initramfs-tools 0.131ubuntu19
ii udev 240-6ubuntu5
diff -Nru systemd-241/debian/tests/boot-and-services
systemd-241/debian/tests/boot-and-services
--- systemd-241/debian/tests/boot-and-services 2019-05-24 16:58:59.0
-0400
+++ systemd-241/debian/tests/boot-and-services 2019-05-29 12:17:13.0
-0400
@@ -108,8 +108,15 @@
with open('/var/log/syslog') as f:
log = f.read()
if not is_container:
+out = subprocess.check_output(['journalctl'])
+if re.search(b'Missed.*kernel messages', out):
+# if we missed some, just check for any kernel msg
+kernel_regex = 'kernel:.*'
+else:
+# otherwise, check for the first(ish) kernel msg
+kernel_regex = 'kernel:.*[cC]ommand line:'
# has kernel messages
-self.assertRegex(log, 'kernel:.*[cC]ommand line:')
+self.assertRegex(log, kernel_regex)
# has init messages
self.assertRegex(log, 'systemd.*Reached target Graphical Interface')
# has other services
@@ -185,8 +192,14 @@
def test_no_options(self):
out = subprocess.check_output(['journalctl'])
if not is_container:
+if re.search(b'Missed.*kernel messages', out):
+# if we missed some, just check for any kernel msg
+kernel_regex = b'kernel:.*'
+else:
+# otherwise, check for the first(ish) kernel msg
+kernel_regex = b'kernel:.*[cC]ommand line:'
# has kernel messages
-self.assertRegex(out, b'kernel:.*[cC]ommand line:')
+self.assertRegex(out, kernel_regex)
# has init messages
self.assertRegex(out, b'systemd.*Reached target Graphical Interface')
# has other services
___
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
