[Pki-devel] [PATCH] Added python-urllib3 dependency

2016-08-05 Thread Matthew Harmsen

Please review this patch which addresses the following ticket:

 * PKI TRAC Ticket #2431 - Errors noticed during ipa server upgrade.
   

-- Matt

From b04707631a362581804574edd0641a3fdbc16565 Mon Sep 17 00:00:00 2001
From: Matthew Harmsen 
Date: Fri, 5 Aug 2016 14:34:57 -0600
Subject: [PATCH] Added python-urllib3 dependency

* PKI TRAC Ticket #2431 - Errors noticed during ipa server upgrade.
---
 specs/pki-core.spec | 12 
 1 file changed, 12 insertions(+)

diff --git a/specs/pki-core.spec b/specs/pki-core.spec
index fac7192..c206b27 100644
--- a/specs/pki-core.spec
+++ b/specs/pki-core.spec
@@ -156,6 +156,11 @@ BuildRequires:python3-flake8
 BuildRequires:python-nss
 BuildRequires:python-requests
 BuildRequires:python-six
+%if 0%{?rhel}
+BuildRequires:python-urllib3
+%else
+BuildRequires:python2-urllib3
+%endif
 BuildRequires:libselinux-python
 BuildRequires:policycoreutils-python
 %if 0%{?fedora} >= 23
@@ -182,6 +187,7 @@ BuildRequires:  python3-devel
 BuildRequires:  python3-nss
 BuildRequires:  python3-requests
 BuildRequires:  python3-six
+BuildRequires:  python3-urllib3
 %endif  # with_python3
 BuildRequires:  python-devel
 
@@ -338,6 +344,11 @@ Conflicts:freeipa-server < 3.0.0
 Requires: python-nss
 Requires: python-requests >= 1.1.0-3
 Requires: python-six
+%if 0%{?rhel}
+Requires: python-urllib3
+%else
+Requires: python2-urllib3
+%endif
 
 %description -n   pki-base
 The PKI Framework contains the common and client libraries and utilities
@@ -424,6 +435,7 @@ Requires: pki-base = %{version}-%{release}
 Requires: python3-nss
 Requires: python3-requests
 Requires: python3-six
+Requires: python3-urllib3
 
 %description -n   pki-base-python3
 This package contains PKI client library for Python 3.
-- 
1.8.3.1

___
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel

Re: [Pki-devel] [PATCH] Added python-urllib3 dependency

2016-08-05 Thread John Magne
Looks reasonable:

ACK with all the customary tested to work disclaimers.

This statement has not been evaluated by the FDA

- Original Message -
From: "Matthew Harmsen" 
To: "pki-devel" 
Sent: Friday, August 5, 2016 1:38:24 PM
Subject: [Pki-devel] [PATCH] Added python-urllib3 dependency



Please review this patch which addresses the following ticket: 

* PKI TRAC Ticket #2431 - Errors noticed during ipa server upgrade. 


-- Matt 

___
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel

___
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel