System Monitor

2008-12-10 Thread Dominik Haumann
Hi,

some months ago I blogged about KDE3's system monitor applet ported
to plasma [1]. It provides a data engine and an applet. The data
engine is more or less just the code taken from KDE3, i.e. it supports
more than just e.g. /proc/cpuinfo depending on the OS. So I'd expect
it to work in KDE4 just as good.

Now there are two other projects:
1. There already is a system monitor data engine in plasma, which is
   even included in KDE4.2 iirc.
2. http://kde-look.org/content/show.php?content=74891
   Seems to be a rewrite from scratch, also based on e.g. /proc/cpuinfo
   etc.

I'd like to finally see this simple applet be in playground to make it
into KDE 4.3.

The right way seems to be to use the system monitor data engine already
available in plasma, and then write the applet on top of it. So it would
be nice to combine the efforts.

The systemmonitor applet seems to provide everything we need:
Processors
- system/processors - processor count
- system/cores (not yet clear how that relates to processors ;))
- cpu/system/TotalLoad
- cpu/system/user
- cpu/system/nice
- cpu/system/wait
- cpu/cpu{%n}/*  (for every cpu if processor count  1)

Memory
- mem/physical/free
- mem/physical/used
- mem/physical/cached
- mem/physical/buf
- mem/physical/application

Swap
- mem/swap/used
- mem/swap/free

So does it make sense to remove the data engines of [1] and [2] and try to
implement the applet by just using the above?

Thanks,
Dominik
PS: I don't want an applet that has a time-axis, ie I like the applet
for its simplicity. So no meters or too complex stuff. Just this
little tool, not more :)

[1] 
http://dhaumann.blogspot.com/2008/05/i-miss-applet-which-shows-system-usage.html
 
[2] http://kde-look.org/content/show.php?content=74891
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: correct panel placement when clicking Add Panel

2008-12-10 Thread Alessandro Diaferia

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/297/
---

Review request for Plasma.


Summary
---

This patch tries to place correctly the panel filling the free edges in the 
current screen.


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/containments/desktop/CMakeLists.txt
  trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.cpp
  trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
  trunk/KDE/kdelibs/plasma/corona.h
  trunk/KDE/kdelibs/plasma/corona.cpp

Diff: http://reviewboard.vidsolbach.de/r/297/diff


Testing
---


Thanks,

Alessandro

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: correct panel placement when clicking Add Panel

2008-12-10 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/297/#review286
---

Ship it!


tried it and it works well, seems also simple enough, ok from me.
aaron, is it ok?

- Marco


On 2008-12-10 03:30:38, Alessandro Diaferia wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard.vidsolbach.de/r/297/
 ---
 
 (Updated 2008-12-10 03:30:38)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 This patch tries to place correctly the panel filling the free edges in the 
 current screen.
 
 
 Diffs
 -
 
   trunk/KDE/kdebase/workspace/plasma/containments/desktop/CMakeLists.txt
   trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.cpp
   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
   trunk/KDE/kdelibs/plasma/corona.h
   trunk/KDE/kdelibs/plasma/corona.cpp
 
 Diff: http://reviewboard.vidsolbach.de/r/297/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alessandro
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: System Monitor

2008-12-10 Thread Aaron J. Seigo
On Wednesday 10 December 2008, Dominik Haumann wrote:
 So does it make sense to remove the data engines of [1] and [2] and try to
 implement the applet by just using the above?

i think so, yes.. the bonus there is that it will be as portable as ksysguard 
is.. =)

 PS: I don't want an applet that has a time-axis, ie I like the applet
 for its simplicity. So no meters or too complex stuff. Just this
 little tool, not more :)

yep =) i used to use that applet all the time myself.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: correct panel placement when clicking Add Panel

2008-12-10 Thread Aaron Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/297/#review287
---

Ship it!


the patch looks ok. one question i have is whether or not this is 4.2 material; 
e.g. does it actually fix a bug or is this a feature enhacement? i think it's 
probably the latter? if so, this needs to wait for 4.3 to open up ...


trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.cpp
http://reviewboard.vidsolbach.de/r/297/#comment238

indentation =) also, why is this whole block wrapped in a ifndef? should 
just the max size bit do that? hmm.. actually, even better it should be using 
corona()-screenSize(screen()) and not Kephal directly here.



trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
http://reviewboard.vidsolbach.de/r/297/#comment239

hm. code duplication. that can't be good =)

perhaps we should look at isolating all this code elsewhere ... i'm not 
sure *where* exactly yet, but in the shell is my first thought. not critical 
for this patch.



trunk/KDE/kdelibs/plasma/corona.h
http://reviewboard.vidsolbach.de/r/297/#comment240

freeScreenEdges(int screen)? perhaps a bit more readable that way?


- Aaron


On 2008-12-10 03:30:38, Alessandro Diaferia wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard.vidsolbach.de/r/297/
 ---
 
 (Updated 2008-12-10 03:30:38)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 This patch tries to place correctly the panel filling the free edges in the 
 current screen.
 
 
 Diffs
 -
 
   trunk/KDE/kdebase/workspace/plasma/containments/desktop/CMakeLists.txt
   trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.cpp
   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
   trunk/KDE/kdelibs/plasma/corona.h
   trunk/KDE/kdelibs/plasma/corona.cpp
 
 Diff: http://reviewboard.vidsolbach.de/r/297/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alessandro
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Problems in i18n messages

2008-12-10 Thread Aaron J. Seigo
On Tuesday 25 November 2008, Albert Astals Cid wrote:
 serviceviewer.cpp:67
 DataEngine: b%1/b; Source: b%2/b; Service b%3/b
 What is DataEngine?

%1 is the name of the engine, DataEngine are what plasmaengineexplorer 
interacts with.

 Why are message fields divided by semicolons?

because it was easier that looking up the keycode for the bullet character? =)

 Why do field names start with capital letters?

because they are field names. no particular reason other than that.

i wonder if there's a misunderstanding here: this is a technical tool meant to 
help in the debugging and testing of DataEngines. it's not something Aunt 
Tilly is ever to be concerned with.

 serviceviewer.cpp:168
 %1 operation with destination %2 failed. The error was:pb%3/b
 serviceviewer.cpp:179
 %1 operation with destination %2 returned successfully. The result
 was:pb %3/b
 *What* is %1?

the name of the operation.

 jobaction.cpp:29
 The JobView for %1 can't be found
 What is JobView?

where did you get this one from?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software














signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: multi-screen fixathon

2008-12-10 Thread Hans Chen
OK, let's start with the most simple case.*

Output: *See attached file


   1. Plasma starts up with *activity A* on *left screen* and *activity B*on
   *right* (main) *screen*.
   2. Zoom out on *left screen.* (Notice: the activities are shown as
   [B][A], and not [A][B] as one would expect.)
   3. Chose *activity B* to zoom in on *left screen*.

Now you have the same activity (*B*) on both screens. At this point the
Plasma feels broken: changing activity on one screen doesn't work and and
some cashews disappear when I try to add activities and zoom in/out. Do you
want plasma output beyond this point too?

2008/12/10 Aaron J. Seigo [EMAIL PROTECTED]

 On Tuesday 09 December 2008, Hans Chen wrote:
  Hi Michael,
 
  It's perfectly OK me.
 
  --
 
  *Aaron*: I've played around a bit and found that it works pretty good in
  trunk - except when I set the same activity to both screens.


 ah, that shouldn't be possible. it *should* result in the activities
 trading with each other.


  Afterwards I
  get the same issue as I described before (at the moment I can't change
  activity on either screen through the ZUI).


 yes, that would be expected if both screens have the same activity


  Do you want some plasma outputs? Should I describe exactly what I do, or
 is
  a log sufficient?


 both please. =)


 --
 Aaron J. Seigo
 humru othro a kohnu se
 GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43


 KDE core developer sponsored by Qt Software



 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel




plasma.log
Description: Binary data
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Plasma::Theme item cache performance improvements

2008-12-10 Thread Aaron Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/298/
---

Review request for Plasma.


Summary
---

Usage of QList instead of QSet, repeated indexing using [] and repeatedly 
saving invalid element values to the config seems a bit wasteful. This patch 
addresses these issues; the one expensive addition to this is that there is a 
List-Set conversion on first access of an invalid item in an SVG, and a 
Set-List conversion for each list of invalid items on application shutdown due 
to KConfig not support QSet natively (a TODO for 4.3 i guess)


Diffs
-

  trunk/KDE/kdelibs/plasma/theme.cpp

Diff: http://reviewboard.vidsolbach.de/r/298/diff


Testing
---

Using it right now with a full plasma session.


Thanks,

Aaron

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Plasma::Theme item cache performance improvements

2008-12-10 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/298/#review288
---

Ship it!


cute:)

- Marco


On 2008-12-10 13:34:45, Aaron Seigo wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard.vidsolbach.de/r/298/
 ---
 
 (Updated 2008-12-10 13:34:45)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 Usage of QList instead of QSet, repeated indexing using [] and repeatedly 
 saving invalid element values to the config seems a bit wasteful. This patch 
 addresses these issues; the one expensive addition to this is that there is a 
 List-Set conversion on first access of an invalid item in an SVG, and a 
 Set-List conversion for each list of invalid items on application shutdown 
 due to KConfig not support QSet natively (a TODO for 4.3 i guess)
 
 
 Diffs
 -
 
   trunk/KDE/kdelibs/plasma/theme.cpp
 
 Diff: http://reviewboard.vidsolbach.de/r/298/diff
 
 
 Testing
 ---
 
 Using it right now with a full plasma session.
 
 
 Thanks,
 
 Aaron
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: New to list, make in applet

2008-12-10 Thread David Baron
On Wednesday 10 December 2008 19:04:12 Aaron J. Seigo wrote:
 On Tuesday 09 December 2008, David Baron wrote:
  Sometime the thing works just fine.
 
  Sometimes, it gets hung up and I get messages like:
 
  link XMLID_34_ hasn't been detected!
  link XMLID_34_ hasn't been detected!
  link XMLID_36_ hasn't been detected!
 
  At this point, it might leave the modem frozen and I need to reboot to
  free up the phone (is there anyway to hard-clear it without a reboot--no
  go through minicom?).

 i have no idea about modems and the code you are using to interact with
 them. sorry =/ perhaps the person who wrote the code you borrowed might be
 able to help..

Yes, I will look into that. Giving higher timeouts for hangup and reset helps 
here.

Those link messages have nothing to do with the modem. I get these messages 
even when things are not hung. I assume they have to do with elements in the 
svgz (specified by XML?) or related to scaling the svgs. There are also 
unrecognized texture messages. The problem might also be related to legacy 
nvidia drivers.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel