FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić 
Hi guys,

I have a problem affecting both 4.2 branch and the trunk.

I'm getting corrupted painting of FrameSvgs in Lancelot and have absolutely no 
idea why.

I became aware of the problem thanks to the forum post [1] and the screenshot 
[2]. It all worked well for me until I cleared the plasma-svgelements cache, 
and now I too get the corrupted drawing.

The most peculiar thing is that the first time, it paints correctly (at least 
on my system), then after changing the element prefix, and then changing it 
back again, it paints badly.

The only thing changed since Lancelot 1.0, as far as the painting of the 
background is concerned, was switching on the cacheAllRenderedFrames... and 
this is *not* causing the problem, I've just tested it.

Any help appreciated, cheerio!

[1] http://forum.kde.org/messy-lancelot-after-update-kde-96-t-25774.html
[2] http://img223.imageshack.us/my.php?image=lancelotbug2gl4.png

-- 
A positive attitude may not solve all your problems, but it will annoy enough 
people to make it worth the effort
   -- Herm Albright

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] fixing krazy2 issues in dataengines

2009-01-15 Thread Artur Souza (MoRpHeUz) 
Hey

2009/1/15 Philipp Klaffert pklaff...@googlemail.com:
 license and copyright issues and you can find the patch in the attachement
 of this Mail.

I think you forgot to attach the patch hehe =)

Cheers

-- 
---
Artur Duque de Souza
OpenBossa Research Labs
INdT - Instituto Nokia de Tecnologia
---
Blog: http://labs.morpheuz.eng.br/blog/
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
---
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[PATCH] fixing krazy2 issues in dataengines

2009-01-15 Thread Philipp Klaffert 
Hi,

according to the Kourse on kde.org [1] I fixed some of the issues in
kdeplasma-addons/dataengines found on EBN. The only issues left are the
license and copyright issues and you can find the patch in the attachement
of this Mail.

Regards
Philipp Klaffert

[1] http://forum.kde.org/-kourse-3-fixing-krazy2-issues-t-18806.html
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

RE: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert 
 Hey

 2009/1/15 Philipp Klaffert pklaffert at googlemail.com 
 https://mail.kde.org/mailman/listinfo/plasma-devel:
* license and copyright issues and you can find the patch in the attachement
** of this Mail.
*
 I think you forgot to attach the patch hehe =)

 Cheers

and I think you are right... :)
Index: dataengines/twitter/timelinesource.cpp
===
--- dataengines/twitter/timelinesource.cpp	(Revision 911365)
+++ dataengines/twitter/timelinesource.cpp	(Arbeitskopie)
@@ -76,7 +76,7 @@
   m_job(0)
 {
 //who should be something like u...@http://twitter.com, if there isn't any @, http://twitter.com will be the default
-QStringList account = who.split(@);
+QStringList account = who.split('@');
 if (account.count() == 2){
 m_serviceBaseUrl = KUrl(account.at(1));
 }else{
Index: dataengines/twitter/twitterengine.cpp
===
--- dataengines/twitter/twitterengine.cpp	(Revision 911365)
+++ dataengines/twitter/twitterengine.cpp	(Arbeitskopie)
@@ -30,7 +30,6 @@
 #include KDebug
 #include KUrl
 #include ksocketfactory.h
-#include KUrl
 
 #include timelinesource.h
 #include imagesource.h
@@ -54,7 +53,7 @@
 return true;
 }
 
-if (!name.startsWith(Timeline:)  !name.startsWith(TimelineWithFriends:)   !name.startsWith(Profile:)) {
+if (!name.startsWith(QString(Timeline:))  !name.startsWith(QString(TimelineWithFriends:))   !name.startsWith(QString(Profile:))) {
 return false;
 }
 
@@ -83,17 +82,17 @@
 {
 //kDebug()  name;
 //right now it only makes sense to do an update on timelines
-if (!name.startsWith(Timeline:)  !name.startsWith(TimelineWithFriends:)  !name.startsWith(Profile:)) {
+if (!name.startsWith(QString(Timeline:))  !name.startsWith(QString(TimelineWithFriends:))  !name.startsWith(QString(Profile:))) {
 return false;
 }
 
 TimelineSource::RequestType requestType;
 
 QString who = name;
-if (name.startsWith(TimelineWithFriends:)) {
+if (name.startsWith(QString(TimelineWithFriends:))) {
 requestType = TimelineSource::TimelineWithFriends;
 who.remove(TimelineWithFriends:);
-} else if (name.startsWith(Profile:)) {
+} else if (name.startsWith(QString(Profile:))) {
 requestType = TimelineSource::Profile;
 who.remove(Profile:);
 }else{
Index: dataengines/comic/comicproviderwrapper.cpp
===
--- dataengines/comic/comicproviderwrapper.cpp	(Revision 911365)
+++ dataengines/comic/comicproviderwrapper.cpp	(Arbeitskopie)
@@ -257,7 +257,7 @@
 
 void ComicProviderWrapper::init()
 {
-const QString path = KStandardDirs::locate( data, plasma/comics/ + mProvider-pluginName() + / );
+const QString path = KStandardDirs::locate( data, plasma/comics/ + mProvider-pluginName() + '/' );
 if ( !path.isEmpty() ) {
 mPackage = new Plasma::Package( path, ComicProviderKross::packageStructure() );
 
@@ -298,8 +298,8 @@
 foreach( const QString interpretername, Kross::Manager::self().interpreters() ) {
 info = Kross::Manager::self().interpreterInfo( interpretername );
 wildcards = info-wildcard();
-wildcards.replace( *,  );
-mExtensions  wildcards.split(   );
+wildcards.replace( '*',  );
+mExtensions  wildcards.split( ' ' );
 }
 }
 return mExtensions;
Index: dataengines/comic/comicproviderwrapper.h
===
--- dataengines/comic/comicproviderwrapper.h	(Revision 911365)
+++ dataengines/comic/comicproviderwrapper.h	(Arbeitskopie)
@@ -38,7 +38,7 @@
 Q_PROPERTY( QImage image READ image WRITE setImage )
 Q_PROPERTY( QByteArray rawData READ rawData WRITE setRawData )
 public:
-ImageWrapper( QObject *parent = 0, const QImage image = QImage() );
+explicit ImageWrapper( QObject *parent = 0, const QImage image = QImage() );
 
 QImage image() const;
 void setImage( const QImage image );
@@ -54,7 +54,7 @@
 Q_OBJECT
 Q_PROPERTY( QDate date READ date WRITE setDate )
 public:
-DateWrapper( QObject *parent = 0, const QDate date = QDate() );
+explicit DateWrapper( QObject *parent = 0, const QDate date = QDate() );
 
 QDate date() const;
 void setDate( const QDate date );
Index: dataengines/comic/cachedprovider.cpp
===
--- dataengines/comic/cachedprovider.cpp	(Revision 911365)
+++ dataengines/comic/cachedprovider.cpp	(Arbeitskopie)
@@ -16,6 +16,8 @@
  *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
+#include cachedprovider.h
+
 #include QtCore/QFile
 #include QtCore/QSettings
 #include QtCore/QTimer
@@ -24,7 +26,6 @@
 #include kstandarddirs.h
 #include KUrl
 
-#include

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Dominik Haumann 
Hi Philipp,

On Thursday 15 January 2009, Philipp Klaffert wrote:
 @@ -54,7 +53,7 @@
  return true;
  }

 -if (!name.startsWith(Timeline:) 
 !name.startsWith(TimelineWithFriends:)  
 !name.startsWith(Profile:)) {
 +if 
 (!name.startsWith(QString(Timeline:)) 
 !name.startsWith(QString(TimelineWithFriends:))  
 !name.startsWith(QString(Profile:))) { return false;
  }

This is also what implicitly happens: const char* is implicitely converted 
to a QString. The right way is afaik to use QLatin1String, see also 
http://doc.trolltech.com/latest/qlatin1string.html for a better 
explanation :)

And then, such optimizations should only be used in time critical cases, as 
the readability decreases when wrapping all strings (more text to read). 
But that's just my personal opinion, and maybe that's always the case in 
plasma - I don't know the preferred way here.

Hope this helps :)
Dominik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert 
Hi Dominik,

thanks for your reply and for the link. For fixing the krazy2 issues
correctly I changed QString to QLatin1String. I understand your point of
view with readability but I won't decide which way is better. I think the
explicit conversion of these Strings makes the understanding of the code not
so much harder...

You can find the modified patch in the attachment.

2009/1/15 Dominik Haumann dh...@gmx.de

 Hi Philipp,

 On Thursday 15 January 2009, Philipp Klaffert wrote:
  @@ -54,7 +53,7 @@
   return true;
   }
 
  -if (!name.startsWith(Timeline:) 
  !name.startsWith(TimelineWithFriends:)  
  !name.startsWith(Profile:)) {
  +if
  (!name.startsWith(QString(Timeline:)) 
  !name.startsWith(QString(TimelineWithFriends:))  
  !name.startsWith(QString(Profile:))) { return false;
   }

 This is also what implicitly happens: const char* is implicitely converted
 to a QString. The right way is afaik to use QLatin1String, see also
 http://doc.trolltech.com/latest/qlatin1string.html for a better
 explanation :)

 And then, such optimizations should only be used in time critical cases, as
 the readability decreases when wrapping all strings (more text to read).
 But that's just my personal opinion, and maybe that's always the case in
 plasma - I don't know the preferred way here.

 Hope this helps :)
 Dominik

Index: dataengines/twitter/timelinesource.cpp
===
--- dataengines/twitter/timelinesource.cpp	(Revision 911365)
+++ dataengines/twitter/timelinesource.cpp	(Arbeitskopie)
@@ -76,7 +76,7 @@
   m_job(0)
 {
 //who should be something like u...@http://twitter.com, if there isn't any @, http://twitter.com will be the default
-QStringList account = who.split(@);
+QStringList account = who.split('@');
 if (account.count() == 2){
 m_serviceBaseUrl = KUrl(account.at(1));
 }else{
Index: dataengines/twitter/twitterengine.cpp
===
--- dataengines/twitter/twitterengine.cpp	(Revision 911365)
+++ dataengines/twitter/twitterengine.cpp	(Arbeitskopie)
@@ -30,7 +30,6 @@
 #include KDebug
 #include KUrl
 #include ksocketfactory.h
-#include KUrl
 
 #include timelinesource.h
 #include imagesource.h
@@ -54,7 +53,7 @@
 return true;
 }
 
-if (!name.startsWith(Timeline:)  !name.startsWith(TimelineWithFriends:)   !name.startsWith(Profile:)) {
+if (!name.startsWith(QLatin1String(Timeline:))  !name.startsWith(QLatin1String(TimelineWithFriends:))   !name.startsWith(QLatin1String(Profile:))) {
 return false;
 }
 
@@ -83,17 +82,17 @@
 {
 //kDebug()  name;
 //right now it only makes sense to do an update on timelines
-if (!name.startsWith(Timeline:)  !name.startsWith(TimelineWithFriends:)  !name.startsWith(Profile:)) {
+if (!name.startsWith(QLatin1String(Timeline:))  !name.startsWith(QLatin1String(TimelineWithFriends:))  !name.startsWith(QLatin1String(Profile:))) {
 return false;
 }
 
 TimelineSource::RequestType requestType;
 
 QString who = name;
-if (name.startsWith(TimelineWithFriends:)) {
+if (name.startsWith(QLatin1String(TimelineWithFriends:))) {
 requestType = TimelineSource::TimelineWithFriends;
 who.remove(TimelineWithFriends:);
-} else if (name.startsWith(Profile:)) {
+} else if (name.startsWith(QLatin1String(Profile:))) {
 requestType = TimelineSource::Profile;
 who.remove(Profile:);
 }else{
Index: dataengines/comic/comicproviderwrapper.cpp
===
--- dataengines/comic/comicproviderwrapper.cpp	(Revision 911365)
+++ dataengines/comic/comicproviderwrapper.cpp	(Arbeitskopie)
@@ -257,7 +257,7 @@
 
 void ComicProviderWrapper::init()
 {
-const QString path = KStandardDirs::locate( data, plasma/comics/ + mProvider-pluginName() + / );
+const QString path = KStandardDirs::locate( data, plasma/comics/ + mProvider-pluginName() + '/' );
 if ( !path.isEmpty() ) {
 mPackage = new Plasma::Package( path, ComicProviderKross::packageStructure() );
 
@@ -298,8 +298,8 @@
 foreach( const QString interpretername, Kross::Manager::self().interpreters() ) {
 info = Kross::Manager::self().interpreterInfo( interpretername );
 wildcards = info-wildcard();
-wildcards.replace( *,  );
-mExtensions  wildcards.split(   );
+wildcards.replace( '*',  );
+mExtensions  wildcards.split( ' ' );
 }
 }
 return mExtensions;
Index: dataengines/comic/comicproviderwrapper.h
===
--- dataengines/comic/comicproviderwrapper.h	(Revision 911365)
+++ dataengines/comic/comicproviderwrapper.h	(Arbeitskopie)
@@ -38,7 +38,7 @@
 Q_PROPERTY( QImage image READ image WRITE setImage )
 Q_PROPERTY( QByteArray rawData READ rawData WRITE

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić 
More strange things.

I've added a couple of debug lines to framesvg.cpp, and I'm receiving this in 
setElementPrefix:

First call of setElementPrefix on the same FrameSvg object:

### setElementPrefix: /opt/kde4trunk/kde/share/apps/desktoptheme/slim-
glow/lancelot/section-buttons.svgz prefix: 'checked'
setElementPrefix: Using this as prefix: 'checked-'
setElementPrefix: Creating a new FrameData
^^ this implies that
 hasElement(prefix + -center) has returned true

The very next call (I've put two setElementPrefix calls one immediately after 
another):

setElementPrefix: /opt/kde4trunk/kde/share/apps/desktoptheme/slim-
glow/lancelot/section-buttons.svgz prefix: 'checked'
WE DON'T HAVE checked-center ELEMENT SOMEHOW!
setElementPrefix: Using this as prefix: ''

This says that the very next time it is called, hasElement returns false...

Cheerio.
-- 
A positive attitude may not solve all your problems, but it will annoy enough 
people to make it worth the effort
   -- Herm Albright

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Philipp Klaffert wrote:
 thanks for your reply and for the link. For fixing the krazy2 issues
 correctly I changed QString to QLatin1String. I understand your point of
 view with readability but I won't decide which way is better. I think the
 explicit conversion of these Strings makes the understanding of the code
 not so much harder...

what jumps out at me is that we have duplications of strings. not fun. if the 
string is changed in one place, it ends up needing to be changed everywhere. 
oh nos!

so ... my suggestion is this:

create as set of static const QString's in the TwitterEngine class and 
initialize them to the values... e.g.:

const QString TwitterEngine::profilePrefix(Profile:);

then the calls become:

name.startsWith(profilePrefix);

no more duplicated strings and no more crazy issues. huzzah!

thanks for working on these, btw =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro 
hey everybody 

IM planing the tokamak meeting details.
So I need some infos from everyone coming to the meeting...
So We can produce a schedule for the days we will be there, sort out all 
details for credentials and stuf.

fristly confirmation for the people coming.

Secondly I asked several people already to prepare a litle presentation to 
give on the 6.  (can be about anything as long as its plasma related, i think 
a small presentatioon of your personal adgenda for the meeting is prety 
interesting).

so if you coud send me a title to the presentation and expected time it will 
take you it will be great.

thanks in advance 
Nuno Pinheiro
-- 
Oxygen coordinator  
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak Meeting II

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Nuno Pinheiro wrote:
 fristly confirmation for the people coming.

shockingly, i'll be there ;)

 Secondly I asked several people already to prepare a litle presentation to
 give on the 6.  (can be about anything as long as its plasma related, i
 think a small presentatioon of your personal adgenda for the meeting is
 prety interesting).

the audience will be the people coming to Tokamak II, correct?

 so if you coud send me a title to the presentation and expected time it
 will take you it will be great.

and remember that there are over a dozen of us there, so keeping it short 
would be good =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Applet Direction

2009-01-15 Thread Jud Craft 
we (plasma team) don't actually control that =)

There really does need to be a pervasive integration of all aspects of
the user-experience with plasma.  Get Hot New Stuff is an interesting
compromise, but at the moment it seems a strange klutch, which stands
in the way of implementing a much more comprehensive solution, similar
to Microsoft's new integrated galleries for downloading widgets and
themes in Vista/Windows 7.

I know 1) that all takes a lot of manpower that's probably not
available, and 2) plasma team probably doesn't want to deal with this
stuff anyway.  I know I wouldn't.  Just a dream. :)  But someday it
would be fantastic to easily browse a gallery of available plasmoids
and metathemes (Qt, Plasma, wallpapers) and immediately apply them
without the hassle of configuration.  But until deeper integration is
done, tedious it stays.

Certainly no one, though, could argue kde-look and kde-apps (and their
gnome counterparts) are pinnacles of web marketplace usability.  My
word those sites are intimidating.  And then you find all sorts of
packages which may or may not work, are too distro-specific, and
require manual compilation*.  I'm certain a lot of work went into
their design, but despite that it's quite a low standard for extending
the free desktop.  Just can't win mindshare with stuff like that.
/rant

*And perhaps these problems are the sad state of linux in general, as
opposed to the website.  Certainly if packages _didn't need to be_
distro-specific or limited by package management, _no one_ would ever
make such packages -- it's a direct result of the linux software
ecosystem.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro 
A Thursday 15 January 2009 17:07:26, Aaron J. Seigo escreveu:
 On Thursday 15 January 2009, Nuno Pinheiro wrote:
  fristly confirmation for the people coming.

 shockingly, i'll be there ;)

  Secondly I asked several people already to prepare a litle presentation
  to give on the 6.  (can be about anything as long as its plasma related,
  i think a small presentatioon of your personal adgenda for the meeting is
  prety interesting).

 the audience will be the people coming to Tokamak II, correct?

for the presentations it self its open its our trade off to them that want to 
get somthing back out of this, but judging from the presentation I gave there 
this sumer there will not be there more than 10 people extra in the audience.. 

  so if you coud send me a title to the presentation and expected time it
  will take you it will be great.

 and remember that there are over a dozen of us there, so keeping it short
 would be good =)

-- 
Oxygen coordinator  
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Applet Direction

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Jud Craft wrote:
 we (plasma team) don't actually control that =)

 There really does need to be a pervasive integration of all aspects of
 the user-experience with plasma.  Get Hot New Stuff is an interesting
 compromise, but at the moment it seems a strange klutch, which stands
 in the way of implementing a much more comprehensive solution, similar
 to Microsoft's new integrated galleries for downloading widgets and
 themes in Vista/Windows 7.

what do you feel is missing exactly? ( i have some ideas, but i want to see 
what yours are without biasing you first ;)

i mean, other than platform independence which is why we:

a) created Plasma::Package
b) are promoting non-compiled components (JavaScript, e.g.)

which renders that part of your email solved.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: My progress

2009-01-15 Thread Marco Martin 
On Wednesday 14 January 2009, Aaron J. Seigo wrote:
 On Wednesday 14 January 2009, Marco Martin wrote:
  On Wednesday 14 January 2009, Aaron J. Seigo wrote:
   On Wednesday 14 January 2009, Marco Martin wrote:
On Tuesday 13 January 2009, Aaron J. Seigo wrote:
 this would probably mean creating a small Plasma::Message class or
 (even re- using Plasma::ToolTipContent perhaps?) and allow
 plasmoids to queue such messages with the Applet class. the Applet
 class would then display it in a plasma way (what does that mean?
 i don't know for sure, but we can work that out together; perhaps
 an overlay on the plasmoid itself if it is big enough, perhaps a
 tooltip type thing, perhaps a notification in the system tray,...?)
   
hmm woudn't this mean duplicating knotify in a similar-but-not-quite
way?
  
   it's not meant as a replacement for notifications, but rather a widget
   appropriate replacement for dialog boxes ...
  
   good example is folderview when it can't load the folder (doesn't
   exist, network down, whatever). that functionality should be available
   to all widgets.
  
   the weather widget in kdrevew uses a KMessagBox right now, because it's
   easy to do, but that causes all sorts of problems: it doesn't look
   Plasma and it blocks mouse interaction with the rest of the desktop.
  
   it'll also give us a nice simple bit of API to give scripters.
 
  could be something like the stuff attached,

 yep, that's probably pretty close =) perhaps showMessage(..) though?
yeah.
  not really sure if it should
  have also other buttons like a yes/no/cancel

 we'll eventually get a request for that, i'm sure. there's also the case
 where there is no Ok option, really. e.g. folderview's I can't load this
 folder!
so displaying the message without possibility of user until the applet 
explicitly says not to... and to deactivate maybe simply a 
showMessage(QString(), QString()) to keep api minimal... 

other things: the available buttons probably the usual combination of 
KDialog::ButtonCode flags (even if just  few of them will be supported..?)
 and then there is the situation of widgets in a space (e.g. the panel) that
 is too small to show it inline, so it would need to go into some sort of
 popup. it's a little more complicated i guess =)
yeah, like reparenting the overlay to graphicsWidget() in case of 
popupapplets, but probably not always, i feel that for configurationRequired 
applets the overlay maybe is better in the icon? (or not? hmm)

yeah, i know that was going to be quite hairy, but i kinda needed a 
distraction from real life, really :D
  and be syncronous like
  dialog.exec()?

 i don't think it needs to be sync, no...
and this is good, because if the applet won't be visible (another containment, 
covered by other applets, whatever) plasma would be pretty much killed in that 
case...

on the other hand i wonder in that case how it will be possible to notify the 
applet what buttons were pressed in a clean way... will either need a signal 
for each button or one with a button parameter, that wouldn't be as simple to 
use in the code (specially scripted one) as a dialong.exec() but probably 
better in the end...

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak Meeting II

2009-01-15 Thread Marco Martin 
On Thursday 15 January 2009, Nuno Pinheiro wrote:
 hey everybody

 IM planing the tokamak meeting details.
 So I need some infos from everyone coming to the meeting...
 So We can produce a schedule for the days we will be there, sort out all
 details for credentials and stuf.

 fristly confirmation for the people coming.

yess!

 Secondly I asked several people already to prepare a litle presentation to
 give on the 6.  (can be about anything as long as its plasma related, i
 think a small presentatioon of your personal adgenda for the meeting is
 prety interesting).
hope to find time to actually get something *prepared* and not go here in 10 
minutes of hmmm ehmmm ohhhm but either case yeah, why not :D

 so if you coud send me a title to the presentation and expected time it
 will take you it will be great.

 thanks in advance
 Nuno Pinheiro


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Applet Direction

2009-01-15 Thread Jud Craft 
I do really like the platform-independence and compilation-free
packages!  I had neglected those; that's awesome, so the picture is
much less depressing than my post says.

Plasma themes themselves are also independent, correct?  (Assumption
based on hearing efforts to port Plasma to Windows).

What would be fantastic if there was one integrated area in the
Control Center for Plasma management.  It really IS the environment,
and this time, unlike KDE3, Plasma's components interact in such a way
that maybe it would make more sense if they were grouped together in
Control Center under Environment, or some other general area
perhaps, instead of trying to fit Plasma functionality into the
control-center templates that were used for Style, Appearance, and
Desktop in KDE3.

For example, Plasma theming and the main containment wouldn't be
side-notes in the Desktop Background dialog.  Right-clicking
Appearance on the desktop could bring up a hypothetical
Plasma/Environment/whatever control dialog, which would have the
different areas of a plasma desktop (Background, Theme, Containments,
Activities, Plasmoids) grouped in a common area, defaulting to
Background (since you did right-click on the Desktop background, after
all).

Another thing, besides reorganization of the plasma config options,
would be unification of the KDE theme settings.  KDE 3's theme
management was also more of a side-note.

Compare GNOME, where theme management is the de facto way to change
the desktop appearance -- you have no choice but to work through a
theme metaphor, and THEN change individual aspects (style, colors,
etc).

Since Plasma seems to have all encompassing themes that control the
environment's appearance (with the exception of Qt style), it seems
like a similar paradigm might work well.  From a central theme
management panel, you could them configure Plasma themes or download
new ones.

A Plasma metatheme (that combines Wallpaper and colors with a plasma
theme) that even possibly configures a Qt style theme would be even
better -- it makes little sense to have two or three different places
that must be traveled to in the Control Center to theme your desktop,
and as long as each component is isolated from the other, it is
difficult to provide a sense of cohesiveness -- a single place you
can go to either choose a new theme, get new themes (a single place to
get new themes -- not having to go different places for color schemes,
Plasma themes, and wallpapers) or alter a component of the current
theme.

The Plasmoids panel then would have a similar feel:  rather than a
mere listbox of Add New Plasmoids, it would be a central area to
download new plasmoids and add/remove them.  But then I don't actually
know of any analog of this in any other OS, so maybe that's overkill.
(Mac and Windows, I believe, also require you to visit a web gallery
and manually hunt for them).  Firefox by comparison has a rather nice
in-program interface to view the latest/popular new extensions, and a
search to quickly query for a particular one.

Such a design could be much more usable than having to browse
kde-look, but I don't mean to put down Get-Hot-New-Stuff:  I just
think that it needs to be a little more than just a web-downloaded
list box of plasmoids.

Most of my discussion focuses too heavily on centralization of theming
and appearance concepts, but I think that's fitting since KDE4 does
strive for a unified sense of style throughout.  I am glad to hear
that several distribution problems seem completely remedied with the
Plasmoids though.  I have no experience planning abstract content
management systems.  I am curious where you see the future of Plasma
heading.  Make more awesome blog posts. :)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak Meeting II

2009-01-15 Thread Anne-Marie Mahfouf 
Le jeudi 15 janvier 2009 17:47:30, Nuno Pinheiro a écrit :
 hey everybody

 IM planing the tokamak meeting details.
 So I need some infos from everyone coming to the meeting...
 So We can produce a schedule for the days we will be there, sort out all
 details for credentials and stuf.

 fristly confirmation for the people coming.
Kévin (ervin) and me will be arriving at 9:05 am  at OPO the 6th. What time 
are these presentations scheduled ? How long do we need to get from the 
airport to the meeting?
 Secondly I asked several people already to prepare a litle presentation to
 give on the 6.  (can be about anything as long as its plasma related, i
 think a small presentatioon of your personal adgenda for the meeting is
 prety interesting).
Depending on the above 
 so if you coud send me a title to the presentation and expected time it
 will take you it will be great.

 thanks in advance
thanks to you for preparing,

Anne-Marie



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Marco Martin 
On Thursday 15 January 2009, Ivan Čukić wrote:
 More strange things.

 I've added a couple of debug lines to framesvg.cpp, and I'm receiving this
 in setElementPrefix:

 First call of setElementPrefix on the same FrameSvg object:

 ### setElementPrefix: /opt/kde4trunk/kde/share/apps/desktoptheme/slim-
 glow/lancelot/section-buttons.svgz prefix: 'checked'
 setElementPrefix: Using this as prefix: 'checked-'
 setElementPrefix: Creating a new FrameData
 ^^ this implies that
  hasElement(prefix + -center) has returned true

 The very next call (I've put two setElementPrefix calls one immediately
 after another):

 setElementPrefix: /opt/kde4trunk/kde/share/apps/desktoptheme/slim-
 glow/lancelot/section-buttons.svgz prefix: 'checked'
 WE DON'T HAVE checked-center ELEMENT SOMEHOW!
 setElementPrefix: Using this as prefix: ''

 This says that the very next time it is called, hasElement returns false...

does the checked-center element get somehow listed among the not available 
elements in the rects cache config file?

 Cheerio.


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak Meeting II

2009-01-15 Thread Artur Souza(MoRpHeUz) 
On Thursday 15 January 2009 17:03:26 Anne-Marie Mahfouf wrote:
  fristly confirmation for the people coming.

I'm all in =P

 Kévin (ervin) and me will be arriving at 9:05 am  at OPO the 6th. What time
 are these presentations scheduled ? How long do we need to get from the
 airport to the meeting?

Hey, I'm arriving at the same day/time! Maybe we are in the same flight from 
Lisbon to Porto ? (TP1952)

  Secondly I asked several people already to prepare a litle presentation
  to give on the 6.  (can be about anything as long as its plasma related,
  i think a small presentatioon of your personal adgenda for the meeting is
  prety interesting).

Fine, I'll prepare that ;)

Do you need any other personal information ? Name, etc ?

Cheers

--
Artur Duque de Souza
OpenBossa Research Labs
INdT - Instituto Nokia de Tecnologia
--
Blog: http://labs.morpheuz.eng.br/blog/
GPG: 0xDBEEAAC3 @ wwwkeys.pgp.net
--


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro 
A Thursday 15 January 2009 20:03:26, Anne-Marie Mahfouf escreveu:
 Le jeudi 15 janvier 2009 17:47:30, Nuno Pinheiro a écrit :
  hey everybody
 
  IM planing the tokamak meeting details.
  So I need some infos from everyone coming to the meeting...
  So We can produce a schedule for the days we will be there, sort out all
  details for credentials and stuf.
 
  fristly confirmation for the people coming.

 Kévin (ervin) and me will be arriving at 9:05 am  at OPO the 6th. What time
 are these presentations scheduled ? How long do we need to get from the
 airport to the meeting?

they are set to go down in the morning I hope.
Depends on how much people will take to deliver them... there is a small 
interval in the morning for a snack.  
from the airport to the place you should take no more than one hour dependind 
hon how much you will have to wayt for the subway.  

I need all of this data so i can sort out a more detailed timetable for each 
day.

  Secondly I asked several people already to prepare a litle presentation
  to give on the 6.  (can be about anything as long as its plasma related,
  i think a small presentatioon of your personal adgenda for the meeting is
  prety interesting).

 Depending on the above

  so if you coud send me a title to the presentation and expected time it
  will take you it will be great.
 
  thanks in advance

 thanks to you for preparing,

 Anne-Marie



 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

-- 
Oxygen coordinator  
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro 
A Thursday 15 January 2009 19:25:29, Artur Souza(MoRpHeUz) escreveu:
 On Thursday 15 January 2009 17:03:26 Anne-Marie Mahfouf wrote:
   fristly confirmation for the people coming.

 I'm all in =P

  Kévin (ervin) and me will be arriving at 9:05 am  at OPO the 6th. What
  time are these presentations scheduled ? How long do we need to get from
  the airport to the meeting?

 Hey, I'm arriving at the same day/time! Maybe we are in the same flight
 from Lisbon to Porto ? (TP1952)

   Secondly I asked several people already to prepare a litle presentation
   to give on the 6.  (can be about anything as long as its plasma
   related, i think a small presentatioon of your personal adgenda for the
   meeting is prety interesting).

 Fine, I'll prepare that ;)

 Do you need any other personal information ? Name, etc ?


The more you give-me the nicer the techbase page will become :)
Me an lydia are goin to refurmulate it a bit so its has more information about 
the meeting :)


 Cheers

 --
 Artur Duque de Souza
 OpenBossa Research Labs
 INdT - Instituto Nokia de Tecnologia
 --
 Blog: http://labs.morpheuz.eng.br/blog/
 GPG: 0xDBEEAAC3 @ wwwkeys.pgp.net
 --

-- 
Oxygen coordinator  
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: a messagebox for applets

2009-01-15 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/327/
---

Review request for Plasma.


Summary
---

this adds Applet::setMessage(icon, message, buttons)
pressing any button (if any ) makes message go away and emit 
messageButtonPressed(button) since we'll keep things async
settings a message also makes the thing go away (useful for messages without 
buttons and let's keep the api little:)

what still has to be ironed out i think is KDialog::ButtonCode that probably 
needs to be replaced with a similar enum internal to plasma (having to include 
kdialog for this thing that is not really it sounds ugly)

and aalso the quite bovine way to discover what button was pressed (no idea how 
to prettify that at the moment)


Diffs
-

  /trunk/KDE/kdelibs/plasma/applet.h
  /trunk/KDE/kdelibs/plasma/applet.cpp

Diff: http://reviewboard.vidsolbach.de/r/327/diff


Testing
---


Thanks,

Marco

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert 
Am 15. Januar 2009 17:39 schrieb Aaron J. Seigo ase...@kde.org:

 On Thursday 15 January 2009, Philipp Klaffert wrote:
  thanks for your reply and for the link. For fixing the krazy2 issues
  correctly I changed QString to QLatin1String. I understand your point of
  view with readability but I won't decide which way is better. I think
 the
  explicit conversion of these Strings makes the understanding of the code
  not so much harder...

 what jumps out at me is that we have duplications of strings. not fun. if
 the
 string is changed in one place, it ends up needing to be changed
 everywhere.
 oh nos!

 so ... my suggestion is this:

 create as set of static const QString's in the TwitterEngine class and
 initialize them to the values... e.g.:

 const QString TwitterEngine::profilePrefix(Profile:);

 then the calls become:

 name.startsWith(profilePrefix);

 no more duplicated strings and no more crazy issues. huzzah!

 thanks for working on these, btw =)

 --
 Aaron J. Seigo
 humru othro a kohnu se
 GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

 KDE core developer sponsored by Qt Software


 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel



Thanks for your advice. After reading your mail I asked myself why I got
that idea not in first place :)
I've now swapped all the Strings with constants and so, just 3 objects an no
more krazy complaining for at least these issues.

Regards
Philipp Klaffert
Index: dataengines/twitter/timelinesource.cpp
===
--- dataengines/twitter/timelinesource.cpp	(Revision 911365)
+++ dataengines/twitter/timelinesource.cpp	(Arbeitskopie)
@@ -76,7 +76,7 @@
   m_job(0)
 {
 //who should be something like u...@http://twitter.com, if there isn't any @, http://twitter.com will be the default
-QStringList account = who.split(@);
+QStringList account = who.split('@');
 if (account.count() == 2){
 m_serviceBaseUrl = KUrl(account.at(1));
 }else{
Index: dataengines/twitter/twitterengine.cpp
===
--- dataengines/twitter/twitterengine.cpp	(Revision 911365)
+++ dataengines/twitter/twitterengine.cpp	(Arbeitskopie)
@@ -30,11 +30,14 @@
 #include KDebug
 #include KUrl
 #include ksocketfactory.h
-#include KUrl
 
 #include timelinesource.h
 #include imagesource.h
 
+const QString TwitterEngine::timelinePrefix(Timeline:);
+const QString TwitterEngine::timelineWithFriendsPrefix(TimelineWithFriends:);
+const QString TwitterEngine::profilePrefix(Profile:);
+
 TwitterEngine::TwitterEngine(QObject* parent, const QVariantList args)
 : Plasma::DataEngine(parent, args)
 {
@@ -54,7 +57,7 @@
 return true;
 }
 
-if (!name.startsWith(Timeline:)  !name.startsWith(TimelineWithFriends:)   !name.startsWith(Profile:)) {
+if (!name.startsWith(timelinePrefix)  !name.startsWith(timelineWithFriendsPrefix)   !name.startsWith(profilePrefix)) {
 return false;
 }
 
@@ -83,22 +86,22 @@
 {
 //kDebug()  name;
 //right now it only makes sense to do an update on timelines
-if (!name.startsWith(Timeline:)  !name.startsWith(TimelineWithFriends:)  !name.startsWith(Profile:)) {
+if (!name.startsWith(timelinePrefix)  !name.startsWith(timelineWithFriendsPrefix)  !name.startsWith(profilePrefix)) {
 return false;
 }
 
 TimelineSource::RequestType requestType;
 
 QString who = name;
-if (name.startsWith(TimelineWithFriends:)) {
+if (name.startsWith(timelineWithFriendsPrefix)) {
 requestType = TimelineSource::TimelineWithFriends;
-who.remove(TimelineWithFriends:);
-} else if (name.startsWith(Profile:)) {
+who.remove(timelineWithFriendsPrefix);
+} else if (name.startsWith(profilePrefix)) {
 requestType = TimelineSource::Profile;
-who.remove(Profile:);
+who.remove(profilePrefix);
 }else{
 requestType = TimelineSource::Timeline;
-who.remove(Timeline:);
+who.remove(timelinePrefix);
 }
 
 TimelineSource *source = dynamic_castTimelineSource*(containerForSource(name));
Index: dataengines/twitter/twitterengine.h
===
--- dataengines/twitter/twitterengine.h	(Revision 911365)
+++ dataengines/twitter/twitterengine.h	(Arbeitskopie)
@@ -65,6 +65,12 @@
 
 protected slots:
 bool updateSourceEvent(const QString name);
+
+private:
+	static const QString timelinePrefix;
+	static const QString timelineWithFriendsPrefix;
+	static const QString profilePrefix;
+
 };
 
 K_EXPORT_PLASMA_DATAENGINE(twitter, TwitterEngine)
Index: dataengines/comic/comicproviderwrapper.cpp
===
--- dataengines/comic/comicproviderwrapper.cpp	(Revision 911365)
+++

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić 
The line

bool found = Theme::defaultTheme()-findInRectsCache(d-path, id, 
elementRect);

returns true, but the elementRect is invalid 0x0, so the hasElement returns 
false.

When I change found to be false always, everything works as it used before - 
no problems...

Cheerio

-- 
A positive attitude may not solve all your problems, but it will annoy enough 
people to make it worth the effort
   -- Herm Albright

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić 
p.s. Why don't we call the /not found/ branch when the rectangle is not valid?

Something like:
if (found  elementRect.isValid()) {
return true;
} else {
d-findAndCacheElementRect(elementId);
return d-renderer-elementExists(elementId);
}


-- 
Those people who think they know everything are a great annoyance to those of 
us who do.
   -- Isaac Asimov

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Applet Direction

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Jud Craft wrote:
 I do really like the platform-independence and compilation-free
 packages!  I had neglected those; that's awesome, so the picture is
 much less depressing than my post says.

 Plasma themes themselves are also independent, correct?  (Assumption
 based on hearing efforts to port Plasma to Windows).

correct.

 What would be fantastic if there was one integrated area in the
 Control Center for Plasma management.

we were discussing this just last week, actually. there are a few things that 
probably belong in there:

* theme choice
* installed component management
* per-virtual desktop views ...

 For example, Plasma theming and the main containment wouldn't be
 side-notes in the Desktop Background dialog.  Right-clicking

well, there actually isn't such a thing as the main containment per se; just 
the currently active one for a given view. i'm a little hesitant on providing 
access to configuration of that out of process because it means loading 
plugins from the same library in two different processes, making sure they are 
both using the same configuration file settings and then coordinating between 
them.

in part, this is a weakness of kconfig. in part, this is just about having 
settings where they are contextually appropriate. the shift in thinking 
required is that Activities are Contextual.

for the other things, yes, a centralized place for those makes sense.

 Appearance on the desktop could bring up a hypothetical
 Plasma/Environment/whatever control dialog, which would have the
 different areas of a plasma desktop (Background, Theme, Containments,
 Activities, Plasmoids) grouped in a common area, defaulting to
 Background (since you did right-click on the Desktop background, after
 all).

the plan for 4.3 is to combine the Activity's own config with the Appearance 
settings, and to move the Theme settings elsewhere. so.. we're on teh same 
general wave length i think.

 Another thing, besides reorganization of the plasma config options,
 would be unification of the KDE theme settings.  KDE 3's theme
 management was also more of a side-note.

this is a long term goal. i want to be fully confident that we have the 
individual pieces figure out first, though.

 Compare GNOME, where theme management is the de facto way to change
 the desktop appearance -- you have no choice but to work through a
 theme metaphor, and THEN change individual aspects (style, colors,
 etc).

yes. different, both in what is good about it and what isn't good about it. 
certainly begs the question if we can do something better than either previous 
system =)

 A Plasma metatheme (that combines Wallpaper and colors with a plasma
 theme) that even possibly configures a Qt style theme would be even
 better -- it makes little sense to have two or three different places
 that must be traveled to in the Control Center to theme your desktop,
 and as long as each component is isolated from the other, it is
 difficult to provide a sense of cohesiveness -- a single place you
 can go to either choose a new theme, get new themes (a single place to
 get new themes -- not having to go different places for color schemes,
 Plasma themes, and wallpapers) or alter a component of the current
 theme.

agreed.

 The Plasmoids panel then would have a similar feel:  rather than a
 mere listbox of Add New Plasmoids, it would be a central area to
 download new plasmoids and add/remove them.  But then I don't actually
 know of any analog of this in any other OS, so maybe that's overkill.

google gadget, the iPhone, Windows 7 ... it's not that exotic =)

 Such a design could be much more usable than having to browse
 kde-look, but I don't mean to put down Get-Hot-New-Stuff:  I just
 think that it needs to be a little more than just a web-downloaded
 list box of plasmoids.

this is simply a presentation issue. it's not a limitation of GHNS or kde-
look. that dialog could be completely redesigned.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Ivan Čukić wrote:
 The line

 bool found = Theme::defaultTheme()-findInRectsCache(d-path, id,
 elementRect);

 returns true, but the elementRect is invalid 0x0, so the hasElement returns
 false.

ah, so either we need to special case non-existing elements a bit better or 
just require that svg's don't have 0x0 elements in them.

i think the latter is easier and even more sensible imho.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Alexis Ménard 
I noticed some artifacts too in my case on the task manager. I will try
lancelot.

The problem appears quite recently since the big move with the caching big
work. I guess it was my Nvidia driver that were crap(as usually) but not
sure now. On my laptop everything works fine so...

2009/1/15 Aaron J. Seigo ase...@kde.org

 On Thursday 15 January 2009, Ivan Čukić wrote:
  p.s. Why don't we call the /not found/ branch when the rectangle is not
  valid?
 
  Something like:
  if (found  elementRect.isValid()) {
  return true;
  } else {
  d-findAndCacheElementRect(elementId);
  return d-renderer-elementExists(elementId);
  }

 because if it is found, then we don't want to re-look it up in the svg. no?

 --
 Aaron J. Seigo
 humru othro a kohnu se
 GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

 KDE core developer sponsored by Qt Software


 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[PATCH] fix for 8 krazy2 issues

2009-01-15 Thread Bruno Bigras 
Have a special look at 6_qclasses.diff, I tested everything I could with
plasmoidviewer but some changes may be in code not used (yet).

Fix issues with the same name as the patch (without the number).
http://englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdeplasma-addons/applets/index.html

apply in kdeplasma-addons/applets


Thanks!

Bruno
Index: lancelot/app/src/models/MessagesKmail.cpp
===
--- lancelot/app/src/models/MessagesKmail.cpp	(révision 910278)
+++ lancelot/app/src/models/MessagesKmail.cpp	(copie de travail)
@@ -128,7 +128,7 @@
 QDBusReply  QString  ricon = m_folderinterface-normalIconPath();
 KIcon icon;
 add(
-name.value() +  ( + QString::number(unread) + ), path,
+name.value() +  ( + QString::number(unread) + ')', path,
 KIcon(
 (ricon.isValid()  !ricon.value().isEmpty())
 ? (ricon.value()) : mail-folder-inbox
Index: lancelot/app/src/models/ContactsKopete.cpp
===
--- lancelot/app/src/models/ContactsKopete.cpp	(révision 910278)
+++ lancelot/app/src/models/ContactsKopete.cpp	(copie de travail)
@@ -89,7 +89,7 @@
 }
 
 foreach (const QString contact, contacts.value()) {
-QStringList contactParts = contact.split(:);
+QStringList contactParts = contact.split(':');
 if (contactParts.size() != 3) {
 continue;
 }
@@ -103,7 +103,7 @@
 continue;
 }
 
-QString avatarPath = m_kopeteAvatarsDir + / + account + / + contactID + .png;
+QString avatarPath = m_kopeteAvatarsDir + '/' + account + '/' + contactID + .png;
 add(contactName.value(), contactID,
 KIcon(
 (QFile::exists(avatarPath))?avatarPath:user-online
Index: lancelot/app/src/models/BaseModel.cpp
===
--- lancelot/app/src/models/BaseModel.cpp	(révision 910278)
+++ lancelot/app/src/models/BaseModel.cpp	(copie de travail)
@@ -92,7 +92,7 @@
 {
 int result = 0;
 foreach (const QString  serviceAlternatives, serviceNames) {
-foreach (const QString  serviceName, serviceAlternatives.split(|)) {
+foreach (const QString  serviceName, serviceAlternatives.split('|')) {
 if (addService(serviceName)) {
 ++result;
 break;
Index: lancelot/app/src/parts/LancelotPart.cpp
===
--- lancelot/app/src/parts/LancelotPart.cpp	(révision 910278)
+++ lancelot/app/src/parts/LancelotPart.cpp	(copie de travail)
@@ -356,7 +356,7 @@
 
 if (loaded) {
 if (!m_data.isEmpty()) {
-m_data += \n;
+m_data += '\n';
 }
 m_data += input;
 saveConfig();
@@ -393,7 +393,7 @@
 if (data.isEmpty()) {
 return false;
 }
-return loadFromList(data.split(\n));
+return loadFromList(data.split('\n'));
 }
 
 void LancelotPart::removeModel(int index)
@@ -404,7 +404,7 @@
 delete model;
 }
 
-QStringList configs = m_data.split(\n);
+QStringList configs = m_data.split('\n');
 configs.removeAt(index);
 m_data = configs.join(\n);
 
Index: lancelot/app/src/Serializator.cpp
===
--- lancelot/app/src/Serializator.cpp	(révision 910278)
+++ lancelot/app/src/Serializator.cpp	(copie de travail)
@@ -34,11 +34,11 @@
 i.next();
 
 if (!result.isEmpty()) {
-result += ;
+result += '';
 }
 
 result +=
-QUrl::toPercentEncoding(i.key()) + = +
+QUrl::toPercentEncoding(i.key()) + '=' +
 QUrl::toPercentEncoding(i.value());
 }
 return result;
@@ -48,9 +48,9 @@
 {
 QMap  QString , QString  result;
 
-QStringList items = data.split();
+QStringList items = data.split('');
 foreach (const QString  item, items) {
-QStringList broken = item.split(=);
+QStringList broken = item.split('=');
 if (broken.size() != 2) {
 continue;
 }
Index: lancelot/libs/lancelot/Global.cpp
===
--- lancelot/libs/lancelot/Global.cpp	(révision 910278)
+++ lancelot/libs/lancelot/Global.cpp	(copie de travail)
@@ -321,7 +321,7 @@
 if (app == lancelot) {
 app = ;
 } else {
-app += -;
+app += '-';
 }
 
 d-confMain = new KConfig(lancelot + app + rc);
Index: weatherstation/weatherstation.cpp
===
--- weatherstation/weatherstation.cpp	(révision 910278)
+++ weatherstation/weatherstation.cpp	(copie de travail)
@@

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Philipp Klaffert wrote:
 I've now swapped all the Strings with constants and so, just 3 objects an
 no more krazy complaining for at least these issues.

great; ready to commit! =))

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Applet Direction

2009-01-15 Thread Jud Craft 
Well, true.  I suppose the only reservation is that such solutions
like the Google Gadget/iPhone software stores require the development
of a supported software delivery system, that I think should not be
outsourced to a third party website.  And that takes a lot of planning
and resources - KDE can't spin up such a framework overnight, and it's
unrealistic of me to hope that you can do such a thing in any short
amount of time. :)  Free software tends to be that way.  Code first,
and then the plan follows it.

(It actually happens the same in the proprietary world, I figure.
Everything is just kept behind close doors for an extended period
until the design is on par with the code. :)  Free software gives
users an earlier-looking glance at the same development timeline --
good for freedom and all, not so great when you see the growing pains
of a new platform.)

(extended note:  that assumes the free software development is
maintained at a healthy pace.  The derailing of free projects off the
path of productivity is almost cliche. :)  )

But, Plasma's definitely on the up-and-up.  Due to difficulties with
my latest Linux install (Amarok2 not working with music players,
Banshee not working with music players, Skype not working, pulse not
working :), etc. ) I've retreated to Windows.  But I really will jump
back to the next Suse or Fedora just to try KDE 4.2.

I really do wish that all these upstream projects (Pulse, GNOME, Xorg,
KDE) didn't all decide to do their revolutionary new releases at once.
 (Pulse's...well, birth, GNOME's GVFS and nautilus refactoring,
Xorg's...whatever the heck they did, and to a lesser extent KDE4.)  It
seemed like everything was working so well back in 2006, when I got
back into linux. :)  I was so impressed when I saw OpenSUSE 10.3 -- I
thought maybe it really was time to give Linux a shot.  But then came
Fedora 9 and OpenSUSE 11, and then KDE 3.5 bit the dust.  Dark times.
:)

But KDE seems to be the earliest project to emerge from the
often-regression-filled evolution that has occupied the last two
years, and it's even better for it.  In fact, considering the problems
the rest of the free software stack is having due to growing pains
these last two years, KDE4 really does deserve a pat on the back for
actually _emerging_ from this mess better than it was, whereas
projects like Pulse and Xorg seem to be fighting to regain the
functionality they previously had.

Sorry.  Another rant.  Great work!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Ivan Čukić wrote:
 The patch hasn't made any changes for me (not for better, nor worse)

ok.. on the one hand, too bad. on the other hand, it's more correct so it not 
breaking it more is a good thing.

  which would result in checking the svg on every invalid entry, which
  would in turn cause the creation of the QSvgRenderer. that would
  completely ruin

 Yes it would, but I can not find where is the problem with caching.

we just need to keep looking.

one thing that might be enlightening is to see if resize is getting called at 
any point with (0, 0). resizing invalidates the cached local entries and will 
access different entries ... though one would expect that when actually drawn 
at whatever size the buttons are drawn they are the correct size.

tomorrow i'll try and write some tests to track it down. which svg file(s) in 
particular is the problematic one(s)?

 (although I could argue that when we have an invalid entry, we should read
 it again,

why? it's not going to magically become invalid.

 but obviously, it would be much better not to have invalid
 entries :) )

the theming relies in several places on the idea of non-existent elements. all 
of the hints, for instance.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] fix for 8 krazy2 issues

2009-01-15 Thread Aaron J. Seigo 
On Thursday 15 January 2009, Bruno Bigras wrote:
 Alex Merry a écrit :
  These all look fine.  Have you visually checked the results of the
  changes in 6_qclasses.diff?
 
  Do you have an SVN account in order to commit these?

 I only tested with the viewer and compiled.

 I don't have an SVN account, it would be nice if you could commit it for
 me.

doing so now ...

btw, if you wish to continue to contribute (same for the other kourseware 
contributors), please consider getting an svn account .. personally, i hope 
you do both want to continue and do apply for an account =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel