Re: Get url list

2009-05-11 Thread Aaron J. Seigo
On Monday 11 May 2009, SUJITH H wrote:
> Can anyone help me how to get the url list of the sorted item
> in launcher applet?

KUrl::List urls;

foreach (QuicklaunchIcon *icon, m_icons) {
urls << icon->url();
}

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: use buttons instead of links in systray notifications

2009-05-11 Thread Aaron Seigo


> On 2009-05-10 13:18:35, Aaron Seigo wrote:
> > hm.. how about a close symbol in the group header, which would then close 
> > the whole group, just as closing one item closes a single item?
> 
> Marco Martin wrote:
> done, looks nice indeed.
> but i wonder if it wouldn't cause some accidental clear when the user 
> wants just to hide it tough.

hopefully there'd be some spacing between them?


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/686/#review1102
---


On 2009-05-11 03:47:16, Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/686/
> ---
> 
> (Updated 2009-05-11 03:47:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> the links for more/less info and "clear all" completed jobs looks really 
> ugly, normal pushbuttons seem to look a bit better.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.h 
> 966519 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp 
> 966519 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 966519 
> 
> Diff: http://reviewboard.kde.org/r/686/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> 
>   http://reviewboard.kde.org/r/686/s/117/
> 
> 
> Thanks,
> 
> Marco
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Get url list

2009-05-11 Thread SUJITH H
Hi,

Can anyone help me how to get the url list of the sorted item
in launcher applet?

Sujith H
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Clean-Blend theme name change.

2009-05-11 Thread Aaron J. Seigo
On Monday 11 May 2009, Sean wrote:
> The plasma theme in kdeartwork, 'Clean-Blend' is now known as 'Blend' and

.. without breaking existing configurations for people who had chosen Clean-
Blend?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Code snippet review for plasmate

2009-05-11 Thread Aaron J. Seigo
On Monday 11 May 2009, Shantanu Tushar Jha wrote:
> > there should be a MimeType role in PackageModel and when data is called
> > for the MimeType it should return the mimetype from the package.
>
> I'm not that experienced in Qt, so had a doubt-
> There are some roles defined in the Qt namespace, but there isn't one for
> MimeType.

correct, this would be custom to the PackageModel.

> So, how to declare a new role in PackageModel (I think that will
> be in packagemodel.h) ?

enum DataRoles { MimeTypeRoe = Qt::UserRole + 1 }

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Code snippet review for plasmate

2009-05-11 Thread Shantanu Tushar Jha
On Sun, May 10, 2009 at 6:29 AM, Aaron J. Seigo  wrote:

> On Saturday 09 May 2009, Shantanu Tushar Jha wrote:
> > I looked at the techbase about kparts and studied kwrite code a bit, and
> > finally started to try with embedding a text editing kpart in Plasmate.
> > I know there's a lot to be done. Just to make sure if I'm going in the
> > right direction and to find possible problems, I've attached a patch that
>
> the "correct" way to do this would be to make PackageModel::data suck less
> ;)
>
> there should be a MimeType role in PackageModel and when data is called for
> the MimeType it should return the mimetype from the package.
>

I'm not that experienced in Qt, so had a doubt-
There are some roles defined in the Qt namespace, but there isn't one for
MimeType. So, how to declare a new role in PackageModel (I think that will
be in packagemodel.h) ?


>
> so slotTreeActivated[1] would do something like:
>
> QStringList mimetypes = index->model()->data(index,
> PackageModel::MimeTypeRole);
>
>
> and in PackageModel::data, if it's a leaf node, e.g. a script, then it
> should
> do:
>
> return m_package->structure()->mimetypes(key);
>
> then based on the mimetypes you can query for the kpart associated with it;
> sth like:
>
> 
> foreach (const QString &mimetype, mimetypes) {
> KService::List offers = KMimeTypeTrader::self()->query(mimetype,
> "KParts/ReadWritePart");
>
>if (offers.isEmpty()) {
>offers = KMimeTypeTrader::self()->query(mimetype,
> "KParts/ReadOnlyPart");
>}
>
>if (!offers.isEmpty()) {
> // create the part using offers.at(0)
> return;
>}
> }
>
> // report an error that we can't view this file type
> ===
>
> that will get us a kpart that can edit the file if it exists, a
> viewing-only
> part if there are no kparts available that can do editing, or nothing at
> all
> if we don't have any available kparts.
>
> this will then work with _all_ file types in the model :)
>
>
> [1] as a side note, please don't preface slot names with "slot"; that's an
> implementation detail that may or may not change over time, just name it
> after
> what it's job is, e.g. "loadEditor(const QModelIndex &)


Understood, I've renamed it.

>
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Software
>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>


-- 
Shantanu Tushar(GMT +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: [Fwd: openSUSE Community Week / KDE]

2009-05-11 Thread Will Stephenson
On Monday 11 May 2009 17:03:56 Jeff Mitchell wrote:
> I met Joe (the openSUSE community manager) at LinuxFest Northwest a
> couple of weeks ago and he sent this to me...passing it on in case
> anyone is interested in hosting a session.
>
> --Jeff

I'm hosting a session right now actually in #opensuse-kde.

Marco is there, and please, if anyone else from the Plasma dev crowd would 
like to attend, you might pick up some useful feedback from the community

Will
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Clean-Blend theme name change.

2009-05-11 Thread Sean
Hello all,

The plasma theme in kdeartwork, 'Clean-Blend' is now known as 'Blend' and
receiving significant updates for 4.3 and in the looks department. The theme
has been mostly updated and you can test it by the usual means.

Here is a screenshot of the non-composited version, which is receiving
attention first this time around.
http://imagebin.ca/view/b7zvWU7.html
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Fwd: openSUSE Community Week / KDE]

2009-05-11 Thread Jeff Mitchell
I met Joe (the openSUSE community manager) at LinuxFest Northwest a
couple of weeks ago and he sent this to me...passing it on in case
anyone is interested in hosting a session.

--Jeff
--- Begin Message ---
Hey Jeff,

We're doing the openSUSE Community Week next week, and part of that is
KDE sessions. Since you're one of the KDE marketing team, I was hoping
you might be interested in helping us spread the word.

You can find more information here:

http://en.opensuse.org/Community_Week

http://news.opensuse.org/2009/05/07/get-ready-for-opensuse-community-week/

Thanks! Please let me know if you have any questions.

Best,

Zonker
-- 
Joe 'Zonker' Brockmeier 
openSUSE Community Manager: http://zonker.opensuse.org
Blogs: http://blogs.zdnet.com/community | http://www.dissociatedpress.net
Twitter: jzb | Identica: jzb
http://identi.ca/group/opensuse/members
--- End Message ---


signature.asc
Description: OpenPGP digital signature
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: use buttons instead of links in systray notifications

2009-05-11 Thread Marco Martin


> On 2009-05-10 13:18:35, Aaron Seigo wrote:
> > hm.. how about a close symbol in the group header, which would then close 
> > the whole group, just as closing one item closes a single item?

done, looks nice indeed.
but i wonder if it wouldn't cause some accidental clear when the user wants 
just to hide it tough.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/686/#review1102
---


On 2009-05-11 03:47:16, Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/686/
> ---
> 
> (Updated 2009-05-11 03:47:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> the links for more/less info and "clear all" completed jobs looks really 
> ugly, normal pushbuttons seem to look a bit better.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.h 
> 966519 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp 
> 966519 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 966519 
> 
> Diff: http://reviewboard.kde.org/r/686/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> 
>   http://reviewboard.kde.org/r/686/s/117/
> 
> 
> Thanks,
> 
> Marco
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: use buttons instead of links in systray notifications

2009-05-11 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/686/
---

(Updated 2009-05-11 03:47:16.790293)


Review request for Plasma.


Changes
---

use a close button to clear the completed jobs


Summary
---

the links for more/less info and "clear all" completed jobs looks really ugly, 
normal pushbuttons seem to look a bit better.


Diffs (updated)
-

  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.h 966519 
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp 
966519 
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 966519 

Diff: http://reviewboard.kde.org/r/686/diff


Testing
---


Screenshots
---


  http://reviewboard.kde.org/r/686/s/117/


Thanks,

Marco

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: change in system tray widget will require change in many theme's widgets/systemtray.svg

2009-05-11 Thread Marco Martin
On Monday 11 May 2009, Aaron J. Seigo wrote:
> hi...
>
> i just committed a change to the system tray that makes it cut out the top
> and bottom edges of the svg and contents margins if the minimum
> height/width or the taskarea is too big to fit.
>
> however, right now the systemtray.svg's we have have rather thick borders
> and no hint-*-margin elements in them, resulting in the borders getting cut
> off unnecessarily (but accurately according to the svg) at large sizes.
>
> for instance, in Air the borders are 7px each. but really, the margin
> should only be 4 (or maybe even 3?) pixels ... the difference is big: with
> 7px margins it requires a 36px high panel (our default is 35 right now
> iirc), while with 4px we get away with just a 30px panel. it's a big
> difference visually.
>
> does anyone feel motivated enough to go through the systemtray.svg files we
> have in the themes in svn and insert more appropriate hint-top-margin,
> hint- bottom-margin, hint-left-margin and hint-right-margin elements? if
> nobody steps up, i'll do it of course ...
done :)
actually just to air oxygen and blens since other themes had systray borders 
4-5 pixels wide already

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


change in system tray widget will require change in many theme's widgets/systemtray.svg

2009-05-11 Thread Aaron J. Seigo
hi...

i just committed a change to the system tray that makes it cut out the top and 
bottom edges of the svg and contents margins if the minimum height/width or 
the taskarea is too big to fit.

however, right now the systemtray.svg's we have have rather thick borders and 
no hint-*-margin elements in them, resulting in the borders getting cut off 
unnecessarily (but accurately according to the svg) at large sizes.

for instance, in Air the borders are 7px each. but really, the margin should 
only be 4 (or maybe even 3?) pixels ... the difference is big: with 7px 
margins it requires a 36px high panel (our default is 35 right now iirc), 
while with 4px we get away with just a 30px panel. it's a big difference 
visually.

does anyone feel motivated enough to go through the systemtray.svg files we 
have in the themes in svn and insert more appropriate hint-top-margin, hint-
bottom-margin, hint-left-margin and hint-right-margin elements? if nobody 
steps up, i'll do it of course ...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


why not to use dptrs in non-libraries

2009-05-11 Thread Aaron J. Seigo
hi..

so, we all know we use dptrs in libraries to maintain binary compatibility. 
but i'm seeing them used more and more in plugins such as plasmoids. this is 
really, really annoying when trying to debug things because then we end up 
with backtraces like this:

Application: Plasma Widget Viewer (plasmoidviewer), signal: Segmentation fault
[KCrash Handler]
#6  0x0011 in ?? ()
#7  0xa98ab67b in Kickoff::RecentlyUsedModel::setNameDisplayOrder 
(this=0x82f2b58, displayOrder=Kickoff::NameBeforeDescription)
at 
/home/aseigo/kde4/KDE/kdebase/workspace/plasma/applets/kickoff/core/recentlyusedmodel.cpp:213
#8  0xa98f9b1b in Kickoff::Launcher::setShowAppsByName (this=0x82b1fc8, 
showAppsByName=true) at 

not good. there's no reason for dptrs except for in libraries that are keeping 
binary compat. please don't use dptrs otherwise, if only for the sake of 
debugging. thanks.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel