Re: Plasmate previewer, again =P
Works for me :) Jason "moofang" Lim Yuen Hoe http://yuenhoe.co.cc/ On Wed, Aug 26, 2009 at 12:15 AM, Aaron J. Seigo wrote: > On Tuesday 25 August 2009, Shantanu Tushar Jha wrote: > > So guys, how about 1430 UTC on Saturday ? > > works great for me if it works for you gusy > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Qt Software > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: reminder for T3: day 1 presentation topics!
In data martedì 25 agosto 2009 16:42:52, Aaron J. Seigo ha scritto: : > hello... > > if you are attending T3, please go here: > > http://techbase.kde.org/Projects/Plasma/Tokamak3#Day_1_Presentations > > to add what your topic will be for the intro day. each attendee will speak > for ~15 minutes or so on their topic, slides are optional and live demos > are best. > > everyone who attends _will_ be presenting on the first day, whether you put > your topic there or not ;) putting your topic up there will help me > organize things better, however. > > thanks :) Ah, I could also join sebas in the NetworkManagement presentation -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: reminder for T3: day 1 presentation topics!
In data martedì 25 agosto 2009 16:42:52, Aaron J. Seigo ha scritto: : > hello... > > if you are attending T3, please go here: > > http://techbase.kde.org/Projects/Plasma/Tokamak3#Day_1_Presentations > > to add what your topic will be for the intro day. each attendee will speak > for ~15 minutes or so on their topic, slides are optional and live demos > are best. Done. I would have liked to show a live presentation on how fine-grant authorization might be useful in Plasma and Plasmoids, but I'm still out of PC (so Mario, please, I need to borrow one from you), I'll make up something live over there or just prepare some slides :) > > everyone who attends _will_ be presenting on the first day, whether you put > your topic there or not ;) putting your topic up there will help me > organize things better, however. > > thanks :) -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Moving theme configuration to system settings.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1404/#review2146 --- we'll talk about this at tokamak, but i think this is a good step in the prettification of this dialog - Marco On 2009-08-25 21:16:03, Davide Bettio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1404/ > --- > > (Updated 2009-08-25 21:16:03) > > > Review request for Plasma. > > > Summary > --- > > This patch removes theme configuration from backround dialog. > > > Diffs > - > > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/BackgroundDialog.ui > 999195 > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.h > 999195 > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp > 999195 > > Diff: http://reviewboard.kde.org/r/1404/diff > > > Testing > --- > > > Thanks, > > Davide > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Moving theme configuration to system settings.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1404/ --- Review request for Plasma. Summary --- This patch removes theme configuration from backround dialog. Diffs - /trunk/KDE/kdebase/workspace/plasma/shells/desktop/BackgroundDialog.ui 999195 /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.h 999195 /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp 999195 Diff: http://reviewboard.kde.org/r/1404/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some dates on Tokamak3
On August 25, 2009 00:14:13 Aaron J. Seigo wrote: > On Monday 24 August 2009, Martin Gräßlin wrote: > > Thursday to Friday in Olten at my sisters but would have to leave on > > Friday morning at about 9:00 so I would be at about 11:30 in Randa. Is > > that Ok, too early, too late? > > i don't know, really. i'll be arriving mid-day myself (iirc), so i hope > that's not too early ;) > > we should put our train arrivals on > > http://techbase.kde.org/Projects/Plasma/Tokamak3#Travelling > > maybe starting a new table? train departures would also be good i think. > i'll be leaving on whatever train most people are, hoping to be back in > zurich on the 5th by ~17:00 > me and ivan are probably going to end up on the 12:40 train from zurich. nobody else has put up any kinda of arrival time :P I'm heading back to zurich on the saturday, the time doesn't really matter (although the less meals I have to buy when I get there the better) -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some dates on Tokamak3
Good morning And now the drawing is on techbase: http://techbase.kde.org/Projects/Plasma/Tokamak3 CU soon Mario ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma/Plasmoid problem with nested KDE 4 session
On August 25, 2009 08:51:54 Aaron J. Seigo wrote: > On Tuesday 25 August 2009, Charles Abela wrote: > > plasma functionality is not. For example rt-clicking on the virtual > > desktop does not popup the menu to manage widgets. > > could be related to the new ContextActions plugins? thiago managed to update exactly halfway through my commits last week; maybe you did too. :) > > It also seems that the changes > > I'm effecting to my code, at present I'm experimenting with plasmoids, is > > not being reflected after restarting plasma-desktop. > > maybe the installation path isn't correct? > check with plasmoidviewer to avoid the slowness of restarting plasma-desktop all the time. -- This message brought to you by eevil bananas and the number 3. www.chani3.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some dates on Tokamak3
Am Dienstag, 25. August 2009 schrieb Chani: Morning > > Btw, when we arrive at Randa, how should we proceed ??? Ask someone for > > Mario's house ? ;) > > a very good question. I'll be getting on an airplane in a couple of days, > my phone will not work when I'm in europe, and I'd really like to know this > stuff before I go. :) I'll do a description of the way. Ok let's do it right here. I'll put it to the wiki with a photo as well. Ok, when you arrive in Randa by train go up to the street (you get out of the train at left). Then follow the street to the right up to the crossroads (and a big house called "Maria am Weg"). There left up to the church where the road turns left. At the next branching take the right on and follow the street several 100 meters. After some stables at right right the Chalet "Nachtigall" appears. Final destination. It takes you 10 to 15 minutes. If you'd like a map. Go to http://www.randa.ch (in german only) click to "Ortsplan" at the top. The red dot is the train station. Search for the Chalet Nachtigall at "Ferienwohnungen" at the left side. (Sorry, my OSM mapping is not yet ready...) > also, I can buy the train ticket with visa, right? how do we get from > zurich airport to the train? Aaron already answered this. About the arrivals times. I'll be there after Thursday afternoon. You should have my mobile number. When I find the time I'll come and catch you at the station myself or send someone ;-). Any other questions? Some important reminders: - Think about Swiss Francs (our currency here). - Think about the Swiss power adapters! - Think about fun and good weather. Mario ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: reminder for T3: day 1 presentation topics!
Am Dienstag, 25. August 2009 schrieb Marco Martin: Morning > On Tuesday 25 August 2009, Aaron J. Seigo wrote: > > hello... > > > > if you are attending T3, please go here: > > > > http://techbase.kde.org/Projects/Plasma/Tokamak3#Day_1_Presentations > > > > to add what your topic will be for the intro day. each attendee will > > speak for ~15 minutes or so on their topic, slides are optional and live > > demos are best. > > > > everyone who attends _will_ be presenting on the first day, whether you > > put your topic there or not ;) putting your topic up there will help me > > organize things better, however. > > > > thanks :) > > will there be a projector? most of the stuff kinda requires showing the > shiny new toys running.. Of course! Mario ;-) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On Tuesday 25 August 2009, Shantanu Tushar Jha wrote: > So guys, how about 1430 UTC on Saturday ? works great for me if it works for you gusy -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma/Plasmoid problem with nested KDE 4 session
On Tuesday 25 August 2009, Charles Abela wrote: > plasma functionality is not. For example rt-clicking on the virtual desktop > does not popup the menu to manage widgets. could be related to the new ContextActions plugins? > It also seems that the changes > I'm effecting to my code, at present I'm experimenting with plasmoids, is > not being reflected after restarting plasma-desktop. maybe the installation path isn't correct? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On Tue, Aug 25, 2009 at 7:55 PM, Aaron J. Seigo wrote: > On Tuesday 25 August 2009, Diego Casella ([Po]lentino) wrote: > > > That means that you'll be available on Saturday, right ? (As on > Saturday > > > Yuen will be comfortable.). > > > > I agree with you, Saturday could be a nice choice both for Yuen and us =) > > Saturday is Day 1 of the conference, which we have planned mostly for > presentations. however, as long as we don't do our meeting first thing in > the > morning (CEST) i think it should be just fine to hold our meeting on irc to > discuss plasmate. > So guys, how about 1430 UTC on Saturday ? > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Qt Software > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: reminder for T3: day 1 presentation topics!
On Tuesday 25 August 2009, Aaron J. Seigo wrote: > hello... > > if you are attending T3, please go here: > > http://techbase.kde.org/Projects/Plasma/Tokamak3#Day_1_Presentations > > to add what your topic will be for the intro day. each attendee will speak > for ~15 minutes or so on their topic, slides are optional and live demos > are best. > > everyone who attends _will_ be presenting on the first day, whether you put > your topic there or not ;) putting your topic up there will help me > organize things better, however. > > thanks :) will there be a projector? most of the stuff kinda requires showing the shiny new toys running.. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
reminder for T3: day 1 presentation topics!
hello... if you are attending T3, please go here: http://techbase.kde.org/Projects/Plasma/Tokamak3#Day_1_Presentations to add what your topic will be for the intro day. each attendee will speak for ~15 minutes or so on their topic, slides are optional and live demos are best. everyone who attends _will_ be presenting on the first day, whether you put your topic there or not ;) putting your topic up there will help me organize things better, however. thanks :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma/Plasmoid problem with nested KDE 4 session
I'm doing some development and using a nested session using Xephyr. Recently I updated from svn and though using Xephyr and startkde works some plasma functionality is not. For example rt-clicking on the virtual desktop does not popup the menu to manage widgets. It also seems that the changes I'm effecting to my code, at present I'm experimenting with plasmoids, is not being reflected after restarting plasma-desktop. Any ideas? cheers ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: can't get qgraphicsgridlayout to resize properly
On Tuesday 25 August 2009, Sebastian Kügler wrote: > On Tuesday 25 August 2009 03:58:11 Amritpal Bath wrote: > > I've got a Plasma::Applet containing a QGraphicsGridLayout, which has a > > couple of QGraphicsWidgets (QLabels via QGraphicsProxyWidget). > > > > The text in my layout gets updated periodically after running an external > > process, but I can't quite get the resizing to work properly. I've > > attached a similar example, with a layout containing two QPushButtons. > > > > I try to adjust the height of the buttons, layout, AND the Applet, but > > nothing I've tried will make the buttons taller. It sounds like maybe > > I'm missing something about QSizePolicy, but I'm not sure. > > > > Can someone please explain the relationship between Plasma::Applet and > > QLayout, and why the attached code does not make the buttons taller? As > > you can see from the .cpp, I've tried most/all things I could find. > > > > Thanks! > > I didn't test your code, but it looks a lot like an issue I'm running into > all the time when working on graphicswidgets that resize themselves. > > It would be good if Alexis (or someone else working on QGraphicsLayouts) > could have a look at this, it looks simple enough for a testcase and would > be very useful to have a fix for. don't worry, at tokamak we'll close him in a dark wet room until everything will work right alexis? :p > > Did you try without the proxywidget stuff, so using QGraphicsWidgets > directly, btw? That would make an even cleaner testcase. > > It would be very nice to see this fixed indeed... > > Cheers, -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Querying the dict dataengine
On Tuesday 25 August 2009, Sebastian Kügler wrote: > I ran into this problem some time ago, basically. The APIDOCS say that if > you don't have data right away, you're supposed to set empty data in the > engine. yes, setting an empty data set is still required and it will remain that way (otherwise we don't know if the process of requesting a source was actually successful and what to connect to on subsequent requests). what is different now, though, is that applets should not get that first empty data set sent to them. :) > (Figure out that reading the docs once in a while > saves time, of course. ;-)). hehe... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On Tuesday 25 August 2009, Diego Casella ([Po]lentino) wrote: > > That means that you'll be available on Saturday, right ? (As on Saturday > > Yuen will be comfortable.). > > I agree with you, Saturday could be a nice choice both for Yuen and us =) Saturday is Day 1 of the conference, which we have planned mostly for presentations. however, as long as we don't do our meeting first thing in the morning (CEST) i think it should be just fine to hold our meeting on irc to discuss plasmate. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: can't get qgraphicsgridlayout to resize properly
On Tuesday 25 August 2009 03:58:11 Amritpal Bath wrote: > I've got a Plasma::Applet containing a QGraphicsGridLayout, which has a > couple of QGraphicsWidgets (QLabels via QGraphicsProxyWidget). > > The text in my layout gets updated periodically after running an external > process, but I can't quite get the resizing to work properly. I've > attached a similar example, with a layout containing two QPushButtons. > > I try to adjust the height of the buttons, layout, AND the Applet, but > nothing I've tried will make the buttons taller. It sounds like maybe I'm > missing something about QSizePolicy, but I'm not sure. > > Can someone please explain the relationship between Plasma::Applet and > QLayout, and why the attached code does not make the buttons taller? As > you can see from the .cpp, I've tried most/all things I could find. > > Thanks! I didn't test your code, but it looks a lot like an issue I'm running into all the time when working on graphicswidgets that resize themselves. It would be good if Alexis (or someone else working on QGraphicsLayouts) could have a look at this, it looks simple enough for a testcase and would be very useful to have a fix for. Did you try without the proxywidget stuff, so using QGraphicsWidgets directly, btw? That would make an even cleaner testcase. It would be very nice to see this fixed indeed... Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Querying the dict dataengine
On Thursday 20 August 2009 10:32:50 Aaron J. Seigo wrote: > On Monday 17 August 2009, alan moore wrote: > > The delay wasn't really the problem, but rather the initial bogus > > output. I guess I'm thinking of this like a database query -- ask a > > question, wait a bit, get an answer. I can see how connectSource() > > makes sense in a situation where you have a constant stream of data you > > want to tap into and pipe out to a widget, but is there not a mechanism > > for simply doing a one-off query? I thought that's what the query() > > method was for, but that wasn't working out either. > > well, no. because in this case the result is fetched asynchronously. which > means the only way to do what you want would be to block all of plasma to > wait for the data. that's obviously not good :) > > query() doesn't _really_ provide a synchronous interface, it just provides > synchronous access to data that already exists. not great in that sense, > but useful at times. > > another thing that's a bit annoying is that we have no way to tell > currently between between "empty set of data is the correct answer" and > "empty set of data right now, will be filled in later", so in the case of > the async call there's always a first call with an empty data set. > > i think i'm going to try a patch in trunk where we don't send the initial > data out if the data set is empty on creation and see if that trips > anything up. i think it will probably match people's expectations > better. I ran into this problem some time ago, basically. The APIDOCS say that if you don't have data right away, you're supposed to set empty data in the engine. I'm not sure what the exact problem was anymore, but it did take me some time to figure out. (Figure out that reading the docs once in a while saves time, of course. ;-)). -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Plasmate previewer, again =P
> > -- Messaggio inoltrato -- > From: Shantanu Tushar Jha > To: plasma-devel@kde.org > Date: Tue, 25 Aug 2009 14:57:55 +0530 > Subject: Re: Plasmate previewer, again =P > > > On Tue, Aug 25, 2009 at 12:45 PM, Aaron J. Seigo wrote: > >> On Monday 24 August 2009, Shantanu Tushar Jha wrote: >> > Yes, last time Aaron could not join us. So we need to plan another >> > date/time. I have classes from 0330 to 1200 hrs, any time outside this >> > range is fine for me. What about you guys? Aaron? >> >> i'm in Switzerland right now; either today or Thursday works for me. >> tomorrow >> i'm busy and friday is "travel to tokamak" day. then i'm at Tokamak for >> the >> next week, which might be a good time to do some Plasmate stuff ;) > > > That means that you'll be available on Saturday, right ? (As on Saturday > Yuen will be comfortable.). > I agree with you, Saturday could be a nice choice both for Yuen and us =) > > ( /me dreams about going to Tokamak and meeting the developers face-to-face > :) ) > >> >> >> -- >> Aaron J. Seigo >> humru othro a kohnu se >> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 >> >> KDE core developer sponsored by Qt Software >> >> ___ >> Plasma-devel mailing list >> Plasma-devel@kde.org >> https://mail.kde.org/mailman/listinfo/plasma-devel >> >> > > > -- > Shantanu Tushar(UTC +0530) > http://www.shantanutushar.com > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: can't get qgraphicsgridlayout to resize properly
On Tuesday 25 August 2009, Amritpal Bath wrote: > I've got a Plasma::Applet containing a QGraphicsGridLayout, which has a > couple of QGraphicsWidgets (QLabels via QGraphicsProxyWidget). > > The text in my layout gets updated periodically after running an external > process, but I can't quite get the resizing to work properly. I've > attached a similar example, with a layout containing two QPushButtons. > > I try to adjust the height of the buttons, layout, AND the Applet, but > nothing I've tried will make the buttons taller. It sounds like maybe I'm > missing something about QSizePolicy, but I'm not sure. > > Can someone please explain the relationship between Plasma::Applet and > QLayout, and why the attached code does not make the buttons taller? As > you can see from the .cpp, I've tried most/all things I could find. > > Thanks! first of all don't use qgraphicsproxywidgets by hand, use the plasma widgets that are already there, Label, PushButton etc (they're proxywidgets too) don't try to compute the size by hand, use sizehints, like Appelt::effectiveSizeHint(Qt::PreferredSize) size hints of qlabels appear to be in no relation with the text size (and you can't acces the indide qtextdocument, so no way to fetch the size of the text) if this is really needed use Plasma::TextBrowser with disabled scrollbars, that should have meaningful size hints -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch to add free space indicator into device notifier plasmoid
On Saturday 22 August 2009 16:02:56 Jacopo De Simoi wrote: > I see two solutions: > - Once the device is made accessible trigger an update of the free disk > space every (say) 10 seconds - Make the KCapacityBar appear on hover and > trigger an update of the free disk space on hover; > > I personally like the second possibility more than the first one, > Best +10 That's what we're doing in the KFilePlaces* component because the last thing we want is an app constantly polling your disk (and preventing them from spinning down) just for that bit of information. Regards. -- Kévin 'ervin' Ottens, http://ervin.ipsquad.net "Ni le maître sans disciple, Ni le disciple sans maître, Ne font reculer l'ignorance." signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: big revamp of Device Notifier
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2143 --- Hi there, thanks for working on this, I've been mostly disconnected for the last two weeks and until friday I'll not be able to test/review this patch. However, I've been working on it as well lately and part of our work overlap, so it's probably a good idea to wait until I'm back online and then I'll be able to say something meaningful. There are quite a lot of things to be merged together and we have quite a lot of time. Thanks --J - Jacopo On 2009-08-21 19:26:43, Giulio Camuffo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1370/ > --- > > (Updated 2009-08-21 19:26:43) > > > Review request for Plasma. > > > Summary > --- > > This is a patch that modifies quite heavily the behaviour of the Device > Notifier. > It comes from here: > http://kde-look.org/content/show.php/Device+Manager?content=106051 > It can show the not removable devices too, it can mount them automatically or > with a click, since the "eject" button is a "mount" button when the volume is > umounted. So that guy on the dot will be ok. > It can hide some items in the same way as Dolphin's places (hide item/ show > all). > Finally, it shows the various opening actions under the device instead of > calling that xp-ish window. > > > Diffs > - > > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui > PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp > 1013960 > > Diff: http://reviewboard.kde.org/r/1370/diff > > > Testing > --- > > I'm using it every day since I released 0.1 on Kde-look. I tried all the > options on my pc and they work. Some people on kde-look posted some comments > about some problems, but it seems to me they are very particular cases, so in > my opinion it is quite stable to go in trunk, but anyway review it! :) > > > Screenshots > --- > > screen > http://reviewboard.kde.org/r/1370/s/183/ > > > Thanks, > > Giulio > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some dates on Tokamak3
On Monday 24 August 2009, Martin Gräßlin wrote: > Am Mittwoch 12 August 2009 17:04:00 schrieb Mario Fux: > > Good morning > > > > Here some dates or proposals to Tokamak3. > > So i have to ask for something unimportant for all those people arriving by > plane ;-) What's actually a good time to arrive on Friday? As I come by > train I'm quite flexible. Nevertheless I could spend the night from > Thursday to Friday in Olten at my sisters but would have to leave on Friday > morning at about 9:00 so I would be at about 11:30 in Randa. Is that Ok, > too early, too late? the plasma italian mafia pack should arrive around that time too so you're in good company eheh :) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch to add free space indicator into device notifier plasmoid
2009/8/22 Jacopo De Simoi
> I've not been connected to the internet for a few days, so please disregard
> this message if it is outdated.
>
> The problem is in fact in the solid plasma engine; the patch works as
> expected (*) with the following patch in soliddeviceengine.cpp
>
> Index: soliddeviceengine.cpp
> ===
> --- soliddeviceengine.cpp=(revision 1013054)
> +++ soliddeviceengine.cpp=(working copy)
>
> @@ -596,7 +597,7 @@
> void SolidDeviceEngine::deviceChanged(const QString& udi, const QString
> &property, const QVariant &value)
> {
> setData(udi, property, value);
> -scheduleSourcesUpdated();
> +updateAllSources();
> }
>
> #include "soliddeviceengine.moc"
>
> However I see a couple of problems with the patch; the first one is that,
> for consistency, I believe the result should look like what is shown in
> KFilePlaces; the second one is that (*) the free disk space is not updated
> if files are added/removed. This is ultimately a problem with the engine but
> makes the free space indicator only partially useful;
> I see two solutions:
> - Once the device is made accessible trigger an update of the free disk
> space every (say) 10 seconds
> - Make the KCapacityBar appear on hover and trigger an update of the free
> disk space on hover;
>
> I personally like the second possibility more than the first one,
> Best
> --J
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
I've already committed a patch for the soliddevice engine and it is the
following:
SVN commit 1013933 by adiaferia:
immediately update free space and hd temp in order to let applets be aware
of the status change of the device
M +2 -4 soliddeviceengine.cpp
---
trunk/KDE/kdebase/workspace/plasma/dataengines/soliddevice/soliddeviceengine.cpp
#1013932:1013933
@@ -507,8 +507,6 @@
setData(query, predicatemap[query]);
}
}
-
-scheduleSourcesUpdated();
}
qlonglong SolidDeviceEngine::freeDiskSpace(const QString &mountPoint)
@@ -591,13 +589,13 @@
devicemap.remove(udi);
removeSource(udi);
-scheduleSourcesUpdated();
}
void SolidDeviceEngine::deviceChanged(const QString& udi, const QString
&property, const QVariant &value)
{
setData(udi, property, value);
-scheduleSourcesUpdated();
+updateFreeSpace(udi);
+updateHardDiskTemperature(udi);
}
#include "soliddeviceengine.moc"
But i dunno if now it updates when files are added/removed. I feel the fix
should go into the engine imho anyway :)
Regards
--
Alessandro Diaferia
KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch to add free space indicator into device notifier plasmoid
I've not been connected to the internet for a few days, so please disregard
this message if it is outdated.
The problem is in fact in the solid plasma engine; the patch works as expected
(*) with the following patch in soliddeviceengine.cpp
Index: soliddeviceengine.cpp
===
--- soliddeviceengine.cpp=(revision 1013054)
+++ soliddeviceengine.cpp=(working copy)
@@ -596,7 +597,7 @@
void SolidDeviceEngine::deviceChanged(const QString& udi, const QString
&property, const QVariant &value)
{
setData(udi, property, value);
-scheduleSourcesUpdated();
+updateAllSources();
}
#include "soliddeviceengine.moc"
However I see a couple of problems with the patch; the first one is that, for
consistency, I believe the result should look like what is shown in
KFilePlaces; the second one is that (*) the free disk space is not updated if
files are added/removed. This is ultimately a problem with the engine but makes
the free space indicator only partially useful;
I see two solutions:
- Once the device is made accessible trigger an update of the free disk space
every (say) 10 seconds
- Make the KCapacityBar appear on hover and trigger an update of the free disk
space on hover;
I personally like the second possibility more than the first one,
Best
--J
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On Tue, Aug 25, 2009 at 12:45 PM, Aaron J. Seigo wrote: > On Monday 24 August 2009, Shantanu Tushar Jha wrote: > > Yes, last time Aaron could not join us. So we need to plan another > > date/time. I have classes from 0330 to 1200 hrs, any time outside this > > range is fine for me. What about you guys? Aaron? > > i'm in Switzerland right now; either today or Thursday works for me. > tomorrow > i'm busy and friday is "travel to tokamak" day. then i'm at Tokamak for the > next week, which might be a good time to do some Plasmate stuff ;) That means that you'll be available on Saturday, right ? (As on Saturday Yuen will be comfortable.). ( /me dreams about going to Tokamak and meeting the developers face-to-face :) ) > > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Qt Software > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some dates on Tokamak3
On August 25, 2009 00:07:50 Aaron J. Seigo wrote: > On Monday 24 August 2009, Chani wrote: > > also, I can buy the train ticket with visa, right? > > yes, they take credit cards at the ticket booths. during the day there are > people who work there so you don't even have to deal with machines if you > don't want to :) heh.. I'd rather deal with the machines. assuming they've got english, which usually is the case > > > how do we get from > > zurich airport to the train? > > there is a train station below the airport; in fact, you don't even need to > leave the airport at all, you just go down the escalators :) so getting to > the trains at the airport is very easy, and the airport station is one of > the main stations in the city. > yay :) -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On Monday 24 August 2009, Shantanu Tushar Jha wrote: > Yes, last time Aaron could not join us. So we need to plan another > date/time. I have classes from 0330 to 1200 hrs, any time outside this > range is fine for me. What about you guys? Aaron? i'm in Switzerland right now; either today or Thursday works for me. tomorrow i'm busy and friday is "travel to tokamak" day. then i'm at Tokamak for the next week, which might be a good time to do some Plasmate stuff ;) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some dates on Tokamak3
On Monday 24 August 2009, Martin Gräßlin wrote: > Thursday to Friday in Olten at my sisters but would have to leave on Friday > morning at about 9:00 so I would be at about 11:30 in Randa. Is that Ok, > too early, too late? i don't know, really. i'll be arriving mid-day myself (iirc), so i hope that's not too early ;) we should put our train arrivals on http://techbase.kde.org/Projects/Plasma/Tokamak3#Travelling maybe starting a new table? train departures would also be good i think. i'll be leaving on whatever train most people are, hoping to be back in zurich on the 5th by ~17:00 -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some dates on Tokamak3
On Monday 24 August 2009, Chani wrote: > also, I can buy the train ticket with visa, right? yes, they take credit cards at the ticket booths. during the day there are people who work there so you don't even have to deal with machines if you don't want to :) > how do we get from > zurich airport to the train? there is a train station below the airport; in fact, you don't even need to leave the airport at all, you just go down the escalators :) so getting to the trains at the airport is very easy, and the airport station is one of the main stations in the city. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
