Re: Bugs in signalplotter.cpp
2009/9/21 Aaron J. Seigo ase...@kde.org: On September 21, 2009, John Tapsell wrote: 2009/9/20 Albert Astals Cid aa...@kde.org: Hi, not sure who's the responsible on that, blame says 73% of lines are from leonhard but CIA says he left KDE time ago, copyright mentions John so i'm mailing for John and plasma-devel (as replacement of leonhard). In plasma/widgets/signalplotter.cpp there is code like this Bah, reason number 412 why code copying is evil. This is a copy of an old version. i can think of two approaches: a) make KSysGuard use QGraphicsView and share the widgets directly that way b) use a QGraphicsProxyWidget and encapsulate KSysGuard's classes that are used in libplasma Do you know the advantages/disadvantages of those two approaches? I do want to get these merged. Do I have to keep ABI/API compatibility now for plasma/widgets/signalplotter ? either way, it would be very nice to see KSysGuard using the plotter classes in libplasma (or libplasma using the same plotter classes as ksyguard, housed somewhere else) so we can get rid of this duplication altogether. Which do you prefer? I was thinking of moving the widget to kdebase/workspace/libs would this be sufficient? John ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: pervirtualdesktopviews=true does not work
sorry for the email above. the configuration works!! can anybody give me a hint about the root cause of the blank desktops problems in kde4.2 ? caused by “pervirtualdesktopviews=true” ? thanks a lot ! 2009/9/22 WuYongbo wilbur.un...@gmail.com I tried the configuration after zoom out, each desktop still failed to show different background or applets. what I am curious is the root cause of the problem there ? I am a green hand to kde source code, can anybody give some hits? 2009/9/17 Artur Souza (MoRpHeUz) morph...@openbossa.org On Thursday 17 September 2009, 05:07 WuYongbo wrote: pervirtualdesktopviews=true in ~/.kde/share/config/plasmarc can not enable different desktops load different applets. any steps I missed? how can each desktops include diff applets? If you are using kde 4.3 you do not need to edit config files anymore. Just zoom out and you'll see a dialog to configure this. Cheers, -- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- -- Good luck ! -- Good luck ! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Bugs in signalplotter.cpp
On 9/22/09, John Tapsell johnf...@gmail.com wrote: 2009/9/21 Aaron J. Seigo ase...@kde.org: On September 21, 2009, John Tapsell wrote: 2009/9/20 Albert Astals Cid aa...@kde.org: Hi, not sure who's the responsible on that, blame says 73% of lines are from leonhard but CIA says he left KDE time ago, copyright mentions John so i'm mailing for John and plasma-devel (as replacement of leonhard). In plasma/widgets/signalplotter.cpp there is code like this Bah, reason number 412 why code copying is evil. This is a copy of an old version. i can think of two approaches: a) make KSysGuard use QGraphicsView and share the widgets directly that way b) use a QGraphicsProxyWidget and encapsulate KSysGuard's classes that are used in libplasma Do you know the advantages/disadvantages of those two approaches? I do want to get these merged. a proxywidget is usuaually a slower to draw using a graphicswidget is ksysguard you would have to keep your view sinced to the proper place of the scene, usual qgraphicsview minor annoyance but no big deal s suppose Do I have to keep ABI/API compatibility now for plasma/widgets/signalplotter ? yes :/ you can't nchange signatures or remove stuff(this excludes also making it a qgrahpicsproxywidget?), but you can add functions either way, it would be very nice to see KSysGuard using the plotter classes in libplasma (or libplasma using the same plotter classes as ksyguard, housed somewhere else) so we can get rid of this duplication altogether. Which do you prefer? I was thinking of moving the widget to kdebase/workspace/libs would this be sufficient? not to be used in libplasma that is in kdelibs /me maybe is for the graphicswidget.. another thing you can do: a pure painting class that has the logic and a paint function that takes a painter argument and both widgets usee that (there is always the question where to put it btw) John ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-09-22 10:30:38.640491) Review request for Plasma, Aaron Seigo and Marco Martin. Changes --- Updated to last changes. Tested with KHistoryComboBox, KRestrictedLine and KTextEdit. Summary --- This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox and similar possibilities for text and line edits. Diffs (updated) - /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1025780 /trunk/KDE/kdelibs/plasma/widgets/lineedit.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/lineedit.cpp 1025780 /trunk/KDE/kdelibs/plasma/widgets/textedit.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/textedit.cpp 1025780 Diff: http://reviewboard.kde.org/r/1094/diff Testing --- Compiles and should work, but not tested. Screenshots --- Plasma themed KHistoryComboBox in Run Command applet http://reviewboard.kde.org/r/1094/s/151/ Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review2415 --- Ship it! to me the patch it's fine (and the webbrowser plasmoid should definitly use that), aaron are there still issues that are pushing it back? - Marco On 2009-09-22 10:30:38, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-09-22 10:30:38) Review request for Plasma, Aaron Seigo and Marco Martin. Summary --- This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox and similar possibilities for text and line edits. Diffs - /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1025780 /trunk/KDE/kdelibs/plasma/widgets/lineedit.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/lineedit.cpp 1025780 /trunk/KDE/kdelibs/plasma/widgets/textedit.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/textedit.cpp 1025780 Diff: http://reviewboard.kde.org/r/1094/diff Testing --- Compiles and should work, but not tested. Screenshots --- Plasma themed KHistoryComboBox in Run Command applet http://reviewboard.kde.org/r/1094/s/151/ Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: pervirtualdesktopviews=true does not work
On Tuesday 22 September 2009, WuYongbo wrote: sorry for the email above. the configuration works!! can anybody give me a hint about the root cause of the blank desktops problems in kde4.2 ? caused by “pervirtualdesktopviews=true” ? in kde 4.2 didn't actually work, iirc was a problem in Containment::setScreen() thanks a lot ! 2009/9/22 WuYongbo wilbur.un...@gmail.com I tried the configuration after zoom out, each desktop still failed to show different background or applets. what I am curious is the root cause of the problem there ? I am a green hand to kde source code, can anybody give some hits? 2009/9/17 Artur Souza (MoRpHeUz) morph...@openbossa.org On Thursday 17 September 2009, 05:07 WuYongbo wrote: pervirtualdesktopviews=true in ~/.kde/share/config/plasmarc can not enable different desktops load different applets. any steps I missed? how can each desktops include diff applets? If you are using kde 4.3 you do not need to edit config files anymore. Just zoom out and you'll see a dialog to configure this. Cheers, -- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- -- Good luck ! -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
On 2009-09-22 05:12:41, David Jarvie wrote: As you say, these changes are incomplete. The way that quitting is handled (whether to quit or not, depending on which windows are open) is a very important feature in KAlarm, and looking at the patch, I'm not convinced that it handles this properly. I don't have time currently to look at this in detail, but please don't commit yet until everything has been fixed and tested. I will not commit anything until I get your ship it. :) On 2009-09-22 05:12:41, David Jarvie wrote: /trunk/KDE/kdepim/kalarm/kalarmapp.cpp, line 753 http://reviewboard.kde.org/r/1655/diff/1/?file=11686#file11686line753 This line shouldn't be removed unless there's some alternative mechanism for showing the window. you can't show()/hide() it. you can only change the status from passive to active or needsattention. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/#review2414 --- On 2009-09-19 21:43:30, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-19 21:43:30) Review request for KDE PIM and Plasma. Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:23:39.660245) Review request for KDE PIM and Plasma. Changes --- it seems that show() and hide() methods are required... Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:24:27.885530) Review request for KDE PIM, Plasma and Marco Martin. Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Ported KTimeTracker to KNotification
On 2009-09-21 13:41:29, Thorsten Staerk wrote: Good to see you working on my baby ktimetracker. Let's have a discussion on irc. ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You can find me in #plasma. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2411 --- On 2009-09-19 20:16:41, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/ --- (Updated 2009-09-19 20:16:41) Review request for KDE PIM and Plasma. Summary --- KTimeTracker has been ported to KNotificationItem but I still have few issues that I've corrected with #if 0. It's not really clear to me how the notification works when KTimeTracker is a KPart. Anyway please don't use XPM pixmaps, use icons. Diffs - /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122 /trunk/KDE/kdepim/ktimetracker/tray.h 1024122 /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122 Diff: http://reviewboard.kde.org/r/1653/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
On 2009-09-22 05:12:41, David Jarvie wrote: /trunk/KDE/kdepim/kalarm/kalarmapp.cpp, line 753 http://reviewboard.kde.org/r/1655/diff/1/?file=11686#file11686line753 This line shouldn't be removed unless there's some alternative mechanism for showing the window. wrote: you can't show()/hide() it. you can only change the status from passive to active or needsattention. yes, it should be just switched between passive/active - Marco --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/#review2414 --- On 2009-09-22 19:24:27, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:24:27) Review request for KDE PIM, Plasma and Marco Martin. Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/#review2422 --- Yes, KAlarm can run with or without the system tray icon. - David On 2009-09-22 19:24:27, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:24:27) Review request for KDE PIM, Plasma and Marco Martin. Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review request: Container plasma applet
Anyway, with your last sentence you was saying that I could have done a similar thing working directly on containments? yes, and that's really probably the way to go about it. use cases would probably help define what direction to actually take. I was actually a bit excited when I saw this applet myself, as I had looked into developing something along the same lines (but gave up because I didn't have the requisite coding knowledge). Basically, my use case is simple: using the KDE panel as a sidebar. The reason being that screens are getting wider and smaller for many users (think notebooks, netbooks, UMPCs), vertical space becomes more valuable, so it makes sense to put stuff like the panel (that mostly just sits there offering some controls) off to the side rather than the traditional top/bottom arrangement. When I tried this with my panel as-is, the results were problematic. Many plasmoids (such as the battery monitor) insist on being square, and in a 200 to 300 px wide sidebar they take up a huge amount of space. Some just kind of fall apart. The tray became a huge squarish thing that took up 1/4 of the height. My thinking for the solution was to create a sub-containment that would allow plasmoids to be arranged in horizontal rows on a vertical sidebar. I don't know if the plasmoid in question can do that, or if the panel can be modified to do that, but it seems a reasonable way to approach the problem. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review request: Container plasma applet
On September 22, 2009, alan moore wrote: My thinking for the solution was to create a sub-containment that would and improving the panel and/or the widgets wasn't a possibility? :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
