Review Request: comic plasmoid - stop the reload timer when not using tabs or when only having one tab

[Bruno Bigras]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2192/
---

Review request for Plasma.


Summary
---

The comic plasmoid has a nice feature that allow to automaticaly switch between 
different source of comic.

I noticed that if you disable the "use tabs" config option, the timer was still 
running.

Also I think it don't make sense to run the timer if there's only one tab.

Without this change we see the busy animation each 10 seconds (by default) for 
no reason.


Diffs
-

  /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 1045605 

Diff: http://reviewboard.kde.org/r/2192/diff


Testing
---


Thanks,

Bruno

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Draft: Widgets Explorer "Add Widgets"

[Anselmo Melo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2191/
---

Review request for Plasma.


Summary
---

"Add widgets" button in the new widgets explorer. There are points that need to 
be defined, such as the button position / strings in the interface. In this 
draft, a toolbutton and a kmenu are used like in the old explorer (Variable 
names changed because IMHO the old ones weren't clear).
A known issue in the interface is the menu position: Although 
corona->popupPosition returns a reasonable point, the menu appears on the top 
of the screen - probably, my fault.

Suggestions and comments are welcome =)


This addresses bug 211576.
https://bugs.kde.org/show_bug.cgi?id=211576


Diffs
-

  
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.cpp
 1049196 

Diff: http://reviewboard.kde.org/r/2191/diff


Testing
---

Adding widgets from GHNS works, Google Gadgets are installed but the widget 
list isn't updated correctly. "From file" needs more tests.


Thanks,

Anselmo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Patch proposed for arrow navigation in Krunner

[Anselmo Melo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2190/
---

Review request for Plasma.


Summary
---

Patch proposed by Jean-Baptiste Rouault as a solution for bug 211578, regarding 
arrow keys navigation in krunner's results list.

In his words:
"Patch to interface.cpp that seems to resolve the above issue

The above is a small workaround to fix the issue.

The problem is that the scene never receive a QEvent::WindowActivate event
because its widget is hidden when KRunner window is shown. I looked at
QGraphicsScene code, if a scene never receive the above event, it is considered
inactive and it can't take the focus.
Maybe a bug should be filed upstream about this issue ?"


This addresses bug 211578.
https://bugs.kde.org/show_bug.cgi?id=211578


Diffs
-

  /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1049196 

Diff: http://reviewboard.kde.org/r/2190/diff


Testing
---

On Krunner, type something that produces a list of results, for example, "kon" 
. then TAB takes the selection to the list and now arrows can be used to 
navigate.


Thanks,

Anselmo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PlasMate questions

[Yuen Hoe Lim]

> maybe it could just be another entry in the file list on the left?


Oh yeah great idea :)

and while a standard kate text editor part
> could do for day 1, it would be nice to have a small TODO list widget (list
> of
> items, be able to mark items as done or not, rank them in importance ..)
>

Hmmm, that kind of functionality seems pretty common and feels like it
should have been done before somewhere somehow.. Will look around and see if
I could ninja something :)


Jason "moofang" Lim Yuen Hoe
http://yuenhoe.co.cc/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

[Aaron Seigo]

> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > 
> >
> > const bool isn't necessary; in fact, i think this whole method 
> > shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then 
> > replaceEmptyQuery should be implied?
> 
> Jacopo De Simoi wrote:
> In fact it should. I was worried of changing the default behaviour of 
> this method. I was not sure to be able to check that this wouldn't affect any 
> other app using runnermanager (kickoff?)
> 
> Aaron Seigo wrote:
> i don't see how it could affect any other users; if they don't call 
> setSingleRunnerMode(true) it behaves exactly as it did before. so it would 
> require purposefully changing the code in the other places it is used to 
> cause problems :)
> 
> Jacopo De Simoi wrote:
> aw, I should really read the whole comment before replying. In fact your 
> comment makes perfect sense
> 
> Jacopo De Simoi wrote:
> I am trying to fix this and now I remember what didn't work without that 
> bool.
> The point is that launchQuery resets() the context, hence it is 
> launchQuery itself that sets the single runner query mode; thus it makes 
> little sense to check RunnerContext::singleRunnerMode(); and I am not sure if 
> assuming that the empty query should always be substituted if a runner is 
> specified would break other apps.
> What should I do then? keep the bool? any alternative solutions?
>

if the runner has set a default syntax, then it should be substituted. if there 
is no default syntax, it doesn't get substituted. in this case, i think it's 
really less a question of what the application using RunnerManager expects and 
more what the AbstractRunner plugin would expect. so yes, i think we can still 
just get rid of that method with the extra bool :)


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

[Aaron Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/#review3130
---

Ship it!


- Aaron


On 2009-11-16 23:50:00, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2091/
> ---
> 
> (Updated 2009-11-16 23:50:00)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This patch adds single runner query support to krunner;
> When loading the runners, if any runner supports a defaultSyntax, then this 
> is exposed via an action which shows up in the global shortcuts;
> When this action is triggered, krunner starts in single-runner-query mode; 
> i.e. queries are processed by the selected runner only; the interfaces 
> changes slightly to reflect this fact  (screenshot) and the query given by 
> the default syntax is automatically run.
> 
> Also a convenient dbus interface is added, in case we want to trigger this 
> internally; 
> 
> The most obvious usecase is the windows runner; an upcoming devicerunner and 
> also the nepomuk search runner could make use of this feature.
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190 
> 
> Diff: http://reviewboard.kde.org/r/2091/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Window runner in single runner mode (+descriptive label)
>   http://reviewboard.kde.org/r/2091/s/264/
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

[Jacopo De Simoi]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/
---

(Updated 2009-11-16 23:50:00.387923)


Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Changes
---

Updated screenshot; waiting for the other part of the patch 
(http://reviewboard.kde.org/r/2090/) to be better defined to post the patch 
here against it.


Summary
---

This patch adds single runner query support to krunner;
When loading the runners, if any runner supports a defaultSyntax, then this is 
exposed via an action which shows up in the global shortcuts;
When this action is triggered, krunner starts in single-runner-query mode; i.e. 
queries are processed by the selected runner only; the interfaces changes 
slightly to reflect this fact  (screenshot) and the query given by the default 
syntax is automatically run.

Also a convenient dbus interface is added, in case we want to trigger this 
internally; 

The most obvious usecase is the windows runner; an upcoming devicerunner and 
also the nepomuk search runner could make use of this feature.


Diffs
-

  trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1046190 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp 
1046190 
  trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h 1046190 
  trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp 
1046190 
  trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190 
  trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190 
  trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190 
  trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190 

Diff: http://reviewboard.kde.org/r/2091/diff


Testing
---


Screenshots (updated)
---

Window runner in single runner mode (+descriptive label)
  http://reviewboard.kde.org/r/2091/s/264/


Thanks,

Jacopo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

[Jacopo De Simoi]

> On 2009-11-12 20:53:01, Aaron Seigo wrote:
> > the line edit for the single query mode should probably have a click text 
> > that comes from the name or description of the runner being used; maybe it 
> > would even be useful to put a label next to the icon with the name of the 
> > runner, so it's really evident what's going on?
> 
> Jacopo De Simoi wrote:
> Clickmessage would be cool, however, since the lineedit immediately gets 
> focus, it is never shown so it is useless.
> A label could be a solution indeed; 
> The issue is: what should the label read? just the name of the runner?
> 
> Aaron Seigo wrote:
> the name of the runner should be enough; hopefully it also looks good :)

The name of the runner looks good enough; I'll go with it


- Jacopo


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/#review3064
---


On 2009-11-16 23:50:00, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2091/
> ---
> 
> (Updated 2009-11-16 23:50:00)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This patch adds single runner query support to krunner;
> When loading the runners, if any runner supports a defaultSyntax, then this 
> is exposed via an action which shows up in the global shortcuts;
> When this action is triggered, krunner starts in single-runner-query mode; 
> i.e. queries are processed by the selected runner only; the interfaces 
> changes slightly to reflect this fact  (screenshot) and the query given by 
> the default syntax is automatically run.
> 
> Also a convenient dbus interface is added, in case we want to trigger this 
> internally; 
> 
> The most obvious usecase is the windows runner; an upcoming devicerunner and 
> also the nepomuk search runner could make use of this feature.
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp 
> 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190 
>   trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190 
> 
> Diff: http://reviewboard.kde.org/r/2091/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Window runner in single runner mode (+descriptive label)
>   http://reviewboard.kde.org/r/2091/s/264/
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

[Jacopo De Simoi]

> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > 
> >
> > const bool isn't necessary; in fact, i think this whole method 
> > shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then 
> > replaceEmptyQuery should be implied?
> 
> Jacopo De Simoi wrote:
> In fact it should. I was worried of changing the default behaviour of 
> this method. I was not sure to be able to check that this wouldn't affect any 
> other app using runnermanager (kickoff?)
> 
> Aaron Seigo wrote:
> i don't see how it could affect any other users; if they don't call 
> setSingleRunnerMode(true) it behaves exactly as it did before. so it would 
> require purposefully changing the code in the other places it is used to 
> cause problems :)
> 
> Jacopo De Simoi wrote:
> aw, I should really read the whole comment before replying. In fact your 
> comment makes perfect sense

I am trying to fix this and now I remember what didn't work without that bool.
The point is that launchQuery resets() the context, hence it is launchQuery 
itself that sets the single runner query mode; thus it makes little sense to 
check RunnerContext::singleRunnerMode(); and I am not sure if assuming that the 
empty query should always be substituted if a runner is specified would break 
other apps.
What should I do then? keep the bool? any alternative solutions?


- Jacopo


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Update on networkmanager plasmoid

[Sebastian Kügler]

Hey all,

After hiding under the rock and hacking on networkmanager, I'd like to give a 
bit of 
a status update on the plasmoid, and move towards getting better artwork in.

On Friday 06 November 2009 23:48:07 Nuno Pinheiro wrote:
> On Friday, 6 de November de 2009 19:20:54 Andreas Demmer wrote:
> > Nuno Pinheiro:
> > > if i was doing it exclusively for air it would be something like this,
> > >  with  more contrast maybe
> >
> > 
> > Attached is a side-by-side comparison with an improved version with
> > better contrast. If you like this, I will do the other states to. Thanks
> > to your SVG template it was very easy to do! :-)
> > 
> > Greets,
> > Andreas
> > 
> 
> excelent

I really like them, too. Can I have them in SVN, in all sizes? :)

http://vizzzion.org/tmp/nm-plasmoid-alpha-2.ogv

In the video, you can see the networkmanager plasmoid (not knetworkmanager!) 
sitting 
in the panel's systray area. the popup shows networkinterfaces on the left, 
checkboxes for dis/enabling networking altogether and dis/enabling wireless. On 
the 
right, you have two tabs, the Connections tab shows the available connections: 
when 
the wireless network is plugged in (it's not in the video), it'll show an 
available 
connection and connect automatically. You can click on those connections, and 
it will 
pop up connection dialogs as needed.
The plasmoid has become a rather thin UI for the whole networkmanager stack now.

As you can see, I've changed a couple of things according to the results in 
this 
discussion. Indeed no overlay for connected, as you can see. I've not done the 
VPN 
overlay yet, but am planning to. (Which icon should be used for this?)

= connecting ... =

For the "connecting" state, I wanted to show the progress somehow. I 
experimented a 
bit with a progress bar, and now have a ring that completes itself while the 
interface is connecting. The different steps have distinct states, a bit like a 
clock, so you can tell "when it's at 0900, it's waiting for a dhcp lease. After 
the 
connection succeeds, the ring becomes green and fades out after a couple of 
seconds.

= painting =

I've also changed the applet so that it will only use sizes predefined by 
KIconLoader 
(so we don't randomly scale, but can get pristine, pixel-perfect painting of 
the icon 
pixmaps -- as long as all sizes are there). I've ditched the SVG in favor of 
using 
KIcon, so we're not bound by Qt's lacking of SVG filters.

= layout problem =

the wireless networks list on the right hand side of the popupapplet actually 
sits 
inside a scrollwidget. I can't get the scrollbars to show, though, the layout 
just 
overflows. It would be nice if someone could have a look at this, I've been 
staring 
at it repeatedly and just can't see what I'm doing wrong there. You can see the 
problem in the screencast when a longer list of wireless networks overflows 
into the 
manage connections IconWidget. It's basically TabWidget holds two 
ActivatableListWidgets which are ScrollWidgets.

I've updated the networkmanagement/applet/README.txt with a couple of TODO 
items, if 
you want to help out.

In general, I feel that most things are falling into place now, it's developing 
nicely and that the UI concept works quite well as it's now.

P.S.: if you wonder what the crappy LSD-style blending in the changing labels 
is, 
that's the radeon graphics driver :/

Cheers,
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: KDE Observatory (new plasmoid)

[Aaron J. Seigo]

On November 16, 2009, Sandro Andrade wrote:
> Yes, I was already considering the DataEngine. Since this should raise
> a major impact I'll keep as a lower priority change for 4.4.

agreed; as noted, it's probably a 4.5 type target.
 
> > * collectFinished is probably getting called more often than needed as
> > its connected to multiple collectors; that means views and what not will
> > get updated for collectors that don't have new data?
> 
> Although it's called by multiple collectors, views are updated only
> when all collectors finish. Since collectors run in a asynchronous way
> I don't know each one is going to finish sooner (and consequently
> later).

ah, indeed, it does update only once all collectors are done.
 
> > * calls like m_right->nativeWidget()->setIcon are generally unecessary.
> > use m_right->setIcon() i'd look through all the nativeWidget() calls and
> > see which can be removed.
> 
> I tried this and it's working when using plasmoidviewer. But when
> adding the plasmoid in desktop the arrows icons didn't appear. This
> was fixed by using nativeWidget()->setIcon. Note: I'm not running
> plasma-desktop from trunk, instead I'm just using 4.3.3. I'll try this
> in trunk.

yes, i extended the api of Plasma::PushButton so it works everywhere. it was a 
really odd issue (KIcon vs QIcon weirdnesses)
 
> > * the icon button in the Configure KDE Observatory page seems to have
> > some layout issues; here it overlaps the divider line at the bottom?
> 
> Strange, I can't reproduce this here.
> 
> > * why is "enable transition effects" an option?
> 
> Just to disable sliding effect for those people with labyrinthitis :)

i guess my question is whether or not there is real value in making this an 
option.
 
> > * why are some view options in the global config options and others in
> > the Views page?
> 
> Ok, in Views page you can select which projects should appear in each
> view. Projects are globally created in Projects page and are
> automatically inserted in all views. For example, you might want to
> see Krazy Report for Plasma but not for Extragear. In Global Config
> Options you can disable a given view (including *all* its projects)
> and set their appearance order.

and why couldn't the order and active status also be set in the Views page? 
it's really not great to have configuration options for the same "thing" (in 
this case views) scattered about, since to get the desired end result i have 
jump between multiple pages.

if those settings were all on View and "Enabled transition effects" was 
removed as an option, then "Global configuration options" could be renamed 
something to do with time :)

> > * the automatic transitions are nice, but when trying to page through
> > them with the left/right buttons it really gets in the way. perhaps a
> > "play/pause" button could be added to the interface and automatically set
> > it to "pause" when one of the arrow buttons are manually pressed?
> 
> Yes, or just re-starting timers giving them a short pause.

that would be an improvement, yes..

> > perhaps the transition
> > could also pause when the mouse is placed over a graph; this would make
> > the tooltips more easily reachable, as right now getting tooltips is a
> > bit of a challenge when the animations are ongoing.
> 
> Deal :)

huzzah! :)
 
> > * the scroll arrows feel "backwards": the right arrow should take me to
> > the "next" item, which means things should scroll to the left not the
> > right.
> 
> Yes, I'm touchscreen influenced :)

if the arrows weren't placed like a scrollbar, it would probably "work".

> > * it would be really nice if it were possible to aggregate some project
> > data; e.g. "plasma" is really kdelibs/plasma + kdebase/runtime/plasma +
> > kdebase/workspace/plasmas + kdeplasma-addons ... not a required feature
> > for sure, but a nice one to have perhaps
> 
> It *was* working that way when I was using regular expressions for
> catching commit subjects from QMaps. It was great but I can't query a
> SQL database by using a regular expression. Any suggestions ?
 
in sqllite, you can do various simple wildcard style matching (and there are 
regexp hooks, though they are not implemented in the bare default sqlite impl 
afaik?). anyways.. if it's just matching for the word "plasma", for instance, 
then in sqlite it's:

WHERE column LIKE '%plasma%'

> > * it would make the widget much more immediately approachable if there
> > were some project presets shipped, such as ones for kdelibs, kdepim,
> > kdegames, plasma, etc. do you have thoughts on how that would be best
> > achieved?
> 
> Yes, that's expected soon. Project information are stored in config
> files. I just need to set up those presets as the default values for
> new created config files. After that user can include/exclude/edit
> project information.

cool ... might be a nice candidate for data to be fetched from the network. 
perhaps ebn could even host a bunch of them, or a GHNS feed could be offered 

Re: Review Request: KDE Observatory (new plasmoid)

[Sandro Andrade]

Hi Aaron, thanks for the review. I'm answering the questions below
while suggestions will be done asap.

> does Plasma::SignalPlotter give
> you something similar?

Apparently yes, investigating.

> * the collectors really look like something that would be better as a
> DataEngine. putting data and visualization into one plugin is generally
> frowned upon in plasma. things like the periodic updates of the collectors are
> taken care of for you if you use a DataEngine, other widgets can more easily
> use the results, the data can be shared between multiple instances of the
> kdeobservatory widget and the widget would be more ready for remote widget
> use. perhaps not necessary for 4.4, but should definitely be considered for
> 4.5.

Yes, I was already considering the DataEngine. Since this should raise
a major impact I'll keep as a lower priority change for 4.4.

> * collectFinished is probably getting called more often than needed as its
> connected to multiple collectors; that means views and what not will get
> updated for collectors that don't have new data?

Although it's called by multiple collectors, views are updated only
when all collectors finish. Since collectors run in a asynchronous way
I don't know each one is going to finish sooner (and consequently
later).

> * calls like m_right->nativeWidget()->setIcon are generally unecessary. use
> m_right->setIcon() i'd look through all the nativeWidget() calls and see which
> can be removed.

I tried this and it's working when using plasmoidviewer. But when
adding the plasmoid in desktop the arrows icons didn't appear. This
was fixed by using nativeWidget()->setIcon. Note: I'm not running
plasma-desktop from trunk, instead I'm just using 4.3.3. I'll try this
in trunk.

> * the icon button in the Configure KDE Observatory page seems to have some
> layout issues; here it overlaps the divider line at the bottom?

Strange, I can't reproduce this here.

> * sync'ing every minute might be a bit much for the default. 5 or 10 minutes
> should be plenty for a default?

For sure :)

>
> * speaking of defaults, is showing just one day of operations really enough to
> give a decent and moral boosting overview? would the last week's worth of data
> be better? a lot of projects see sporadic but regular commits and "one day"
> may not be a whole lot of progress. plasma is active daily as are some of the
> other big projects like kdepim ... but not all are so lucky. this does make
> the db building problem worse, of course.

Yes, I agree a week would be a nice overview. I'll change this as soon
as database issues are fixed.

>
> * why is "enable transition effects" an option?

Just to disable sliding effect for those people with labyrinthitis :)

>
> * why are some view options in the global config options and others in the
> Views page?

Ok, in Views page you can select which projects should appear in each
view. Projects are globally created in Projects page and are
automatically inserted in all views. For example, you might want to
see Krazy Report for Plasma but not for Extragear. In Global Config
Options you can disable a given view (including *all* its projects)
and set their appearance order.

>
> * from a user's perspective, why is there a "global config options"? would
> another name be more useful?

General ?

>
> * the automatic transitions are nice, but when trying to page through them
> with the left/right buttons it really gets in the way. perhaps a "play/pause"
> button could be added to the interface and automatically set it to "pause"
> when one of the arrow buttons are manually pressed?

Yes, or just re-starting timers giving them a short pause.

> perhaps the transition
> could also pause when the mouse is placed over a graph; this would make the
> tooltips more easily reachable, as right now getting tooltips is a bit of a
> challenge when the animations are ongoing.

Deal :)

> * the scroll arrows feel "backwards": the right arrow should take me to the
> "next" item, which means things should scroll to the left not the right.

Yes, I'm touchscreen influenced :)

>
> * it would be really nice if it were possible to aggregate some project data;
> e.g. "plasma" is really kdelibs/plasma + kdebase/runtime/plasma +
> kdebase/workspace/plasmas + kdeplasma-addons ... not a required feature for
> sure, but a nice one to have perhaps

It *was* working that way when I was using regular expressions for
catching commit subjects from QMaps. It was great but I can't query a
SQL database by using a regular expression. Any suggestions ?

> * it would make the widget much more immediately approachable if there were
> some project presets shipped, such as ones for kdelibs, kdepim, kdegames,
> plasma, etc. do you have thoughts on how that would be best achieved?

Yes, that's expected soon. Project information are stored in config
files. I just need to set up those presets as the default values for
new created config files. After that user can include/exclude/edit
proje

Re: Review Request: KDE Observatory (new plasmoid)

[Aaron J. Seigo]

On November 16, 2009, Sandro Andrade wrote:
> somehow stable and with some minor enhancements to be done I think a
> review it's quite necessary because this is my first plasmoid :)

some thoughts:

* it should be in kdereview/plasma/applets/ and added to the build system; 
i've done that now

* i see that it uses Qwt in one class. this is likely to diminish both the 
user base of it as well as it's "plasma-ness". does Plasma::SignalPlotter give 
you something similar? if not, then a check in the CMakeLists.txt file for Qwt 
is required

* the collectors really look like something that would be better as a 
DataEngine. putting data and visualization into one plugin is generally 
frowned upon in plasma. things like the periodic updates of the collectors are 
taken care of for you if you use a DataEngine, other widgets can more easily 
use the results, the data can be shared between multiple instances of the 
kdeobservatory widget and the widget would be more ready for remote widget 
use. perhaps not necessary for 4.4, but should definitely be considered for 
4.5.

* m_progressProxy should be a Plasma::Meter (i just made some relevant methods 
slots in Plasma::Meter to make that even easier)

* collectFinished is probably getting called more often than needed as its 
connected to multiple collectors; that means views and what not will get 
updated for collectors that don't have new data?

* calling collection[something] as in "if (pair.second && 
m_viewProviders[view])" will create an entry in the collection if it doesn't 
exist which is probably an unwanted (or at least unneeded) side effect; in 
these cases you probably want m_viewProviders.value(view)

* passing in a rect and the code in IViewProvider::createView looks fishy and 
indeed doesn't quite work; when KdeObservator::m_viewContainer changes 
geometry, the views won't change their geometry. i'd suggest either using a 
QGraphicsLayout or else putting an event filter on the view container and 
adjusting the geometry of the views when the view container gets a resize or 
related events.

* calls like m_right->nativeWidget()->setIcon are generally unecessary. use 
m_right->setIcon() i'd look through all the nativeWidget() calls and see which 
can be removed.

* on first update, it sat and spun for the better part of a minute writing to 
disk. subsequent starts up are good. i wonder if this is because each commit 
is added one at a time to the sqllite db instead of several at once? this is a 
show stopper for first use in any case. it also happens when adding more days 
to the context :/

* worse, it blocks the app while doing so. the db should either be updated 
incrementally with regular returns to the mainloop to prevent blocking the 
whole plasma application (e.g. plasma-desktop) or it should be done in a 
thread (probably preferred in this case)

* the icon button in the Configure KDE Observatory page seems to have some 
layout issues; here it overlaps the divider line at the bottom?

* sync'ing every minute might be a bit much for the default. 5 or 10 minutes 
should be plenty for a default?

* speaking of defaults, is showing just one day of operations really enough to 
give a decent and moral boosting overview? would the last week's worth of data 
be better? a lot of projects see sporadic but regular commits and "one day" 
may not be a whole lot of progress. plasma is active daily as are some of the 
other big projects like kdepim ... but not all are so lucky. this does make 
the db building problem worse, of course.

* why is "enable transition effects" an option?

* why are some view options in the global config options and others in the 
Views page?

* from a user's perspective, why is there a "global config options"? would 
another name be more useful?

* the automatic transitions are nice, but when trying to page through them 
with the left/right buttons it really gets in the way. perhaps a "play/pause" 
button could be added to the interface and automatically set it to "pause" 
when one of the arrow buttons are manually pressed? perhaps the transition 
could also pause when the mouse is placed over a graph; this would make the 
tooltips more easily reachable, as right now getting tooltips is a bit of a 
challenge when the animations are ongoing.

* it seems that whenever the data is updated, the "slide show" starts from the 
beginning again; it looks a bit odd to have it start all over again. could it 
simply keep going with the slideshow instead of restarting it?

* the scroll arrows feel "backwards": the right arrow should take me to the 
"next" item, which means things should scroll to the left not the right.

* it would be really nice if it were possible to aggregate some project data; 
e.g. "plasma" is really kdelibs/plasma + kdebase/runtime/plasma + 
kdebase/workspace/plasmas + kdeplasma-addons ... not a required feature for 
sure, but a nice one to have perhaps

* it would make the widget much more immediately approachable if there

Re: Review Request: plasmaengineviewer scroll fix for bug #213594

[Aaron J. Seigo]

On November 15, 2009, Beat Wolf wrote:
> > On 2009-11-15 20:54:35, Marco Martin wrote:
> > > seems fine
> 
> as the submitter stated, he has no svn access. can somebody commit this fix
>  and mark this as commited? thank you

done :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PlasMate questions

[Aaron J. Seigo]

On November 16, 2009, Yuen Hoe Lim wrote:
>- Was there any discussion/ideas about what the documentation widget
>should look like? Something browser-ish with a couple of 'bookmark'
>  buttons to api pages and tutorials on techbase?

that would probably do the trick, yes.

>- The PlasMate ideas page on techbase mentioned 'notes/todo'. Question
>  is where should such a widget go? Feels like it would be a little out of
>  the way to put it as a separate tab, but at the same time we're pretty
>  squeezed on dock-widget space now...

maybe it could just be another entry in the file list on the left? it would 
not need to be part of the resulting package (though it could be as a 
README/TODO/CHANGELOG type file) and while a standard kate text editor part 
could do for day 1, it would be nice to have a small TODO list widget (list of 
items, be able to mark items as done or not, rank them in importance ..)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PlasMate questions

[Yuen Hoe Lim]

Hi guys,

Couple more questions that I should have asked in the first place as well:

   - Was there any discussion/ideas about what the documentation widget
   should look like? Something browser-ish with a couple of 'bookmark' buttons
   to api pages and tutorials on techbase?
   - The PlasMate ideas page on techbase mentioned 'notes/todo'. Question is
   where should such a widget go? Feels like it would be a little out of the
   way to put it as a separate tab, but at the same time we're pretty squeezed
   on dock-widget space now...



Jason "moofang" Lim Yuen Hoe
http://yuenhoe.co.cc/



On Sat, Nov 7, 2009 at 12:58 PM, Yuen Hoe Lim  wrote:

> if it's using a QSplitter (which it is iirc?) then you need to set the
>> sizes
>> of the splitter not the widgets in it.
>>
>
> I dunno, but if it is (using QSplitters), then QMainWindow (which
> PlasMate's main window inherits) doesn't seem to expose it =( Seems rather
> odd that QMainWindow doesn't provide an obvious way for programmatic
> adjustment of the relative dockwidget/centralwidget sizes..
>
> no mockup yet, no. to start with it only needs to ask for a location on
>> disk
>> to put the package. the next step would include uploading via
>> GetHotNewStuff.
>>
>>
> Okay, I'll do up something simple to export packages first. I don't know
> much about the uploading gitorious-y stuff, will probably need Diego's help
> on that :)
>
>
>> they just use:
>>
>> dialogText = i18n( "Filename for clipboard content:" );
>> QString file = KInputDialog::getText( QString(), dialogText, QString(),
>> &ok,
>> widget );
>>
>
> Ok.
>
> if you update kdelibs/kate/ and plasmate, it now works. backup saves are
>> saved
>> as hidden files (prefixed with '.') and therefore automagically ignored.
>
>
> ie this has been 'automagically' fixed for me? Great! :)
>
>
> 
> Jason "moofang" Lim Yuen Hoe
> http://yuenhoe.co.cc/
>
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: KDE Observatory (new plasmoid)

[Sandro Andrade]

On Mon, Nov 16, 2009 at 9:44 AM, Marco Martin  wrote:
> On Monday 16 November 2009, Sandro Andrade wrote:
>> > This sounds like a really useful tool, however kdereview is closed for
>> > 4.4, so would be 4.5 material...
>> > anyways, since is a developer tool would kdeplasma-addons and kdebase
>> > would be the proper place? maybe not?
>>
>> Aaron suggested kdeplasma-addons as the proper place. Is
>> kdeplasma-addons also closed for 4.4 ? Anyway, any review is welcome.
>
> for me it would be fine to move it in even directly before the hard freeze.
> depends how many agree with that.
> if kdereview is still open, you should move it in really asap
>

Hi Marco,

I already moved it to kdereview last Saturday because I hadn't noticed
the closing announcement at kde-core-devel. Although the plasmoid is
somehow stable and with some minor enhancements to be done I think a
review it's quite necessary because this is my first plasmoid :)

Thanks,
Sandro

> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: KDE Observatory (new plasmoid)

[Marco Martin]

On Monday 16 November 2009, Sandro Andrade wrote:
> > This sounds like a really useful tool, however kdereview is closed for
> > 4.4, so would be 4.5 material...
> > anyways, since is a developer tool would kdeplasma-addons and kdebase
> > would be the proper place? maybe not?
> 
> Aaron suggested kdeplasma-addons as the proper place. Is
> kdeplasma-addons also closed for 4.4 ? Anyway, any review is welcome.

for me it would be fine to move it in even directly before the hard freeze. 
depends how many agree with that.
if kdereview is still open, you should move it in really asap

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel