Review Request: Sort Kickoff applications by name when Show applications by name config option is set.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2652/ --- Review request for Plasma. Summary --- When applications are shown by name, currently they are still sorted by GenericName. This patch fixes that and matches the behavior of the simple launcher applet. Originally I had a patch that added a separate config option for Sort applications by name but that seemed excessive. This also could be a potential fix for bug 188720. Diffs - /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/launcher.cpp 1073143 Diff: http://reviewboard.kde.org/r/2652/diff Testing --- Tested on my Arch Linux box with KDE SC 4.4 RC1 and works for me. Thanks, Steven ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged()
On January 19, 2010, Marco Martin wrote: On Tue, Jan 19, 2010 at 8:46 AM, Aaron J. Seigo ase...@kde.org wrote: *sigh* so i realized with a start this evening that virtually none of our Plasmoids implement configChanged(). this means that the plasma-desktop js scripting is going to be nearly useless with most of them in terms of setting the configuration for them (without a plasma restart, of course). for applets that reimplement restore(KConfigGroup config) it's probably all good, though restore really shouldn't be reimplemented in the common case. it looks like one of our janitorial endeavors for 4.5 will be to consolidate the configuration reading that goes on in plasmoids into configChanged(). indeed we have to. unfortunately is a thing that is not necessary to make plasmoid work, so it will always be a pita to ensure plasmoid creators, even the new ones will respect it.. it's a little easier with scripted plasmoids, since that's how they tend to get notified that the config dialog has finished. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Sort Kickoff applications by name when Show applications by name config option is set.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2652/#review3763 --- Ship it! nice catch! it looks good; please commit and backport to 4.4 (or one of us can backport it if you wish) - Aaron On 2010-01-20 08:11:53, Steven Eastland wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2652/ --- (Updated 2010-01-20 08:11:53) Review request for Plasma. Summary --- When applications are shown by name, currently they are still sorted by GenericName. This patch fixes that and matches the behavior of the simple launcher applet. Originally I had a patch that added a separate config option for Sort applications by name but that seemed excessive. This also could be a potential fix for bug 188720. Diffs - /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/launcher.cpp 1073143 Diff: http://reviewboard.kde.org/r/2652/diff Testing --- Tested on my Arch Linux box with KDE SC 4.4 RC1 and works for me. Thanks, Steven ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Sort Kickoff applications by name when Show applications by name config option is set.
On 2010-01-20 19:18:48, Aaron Seigo wrote: nice catch! it looks good; please commit and backport to 4.4 (or one of us can backport it if you wish) I don't have a KDE SVN account, so it would be great if you could commit and backport it. Thanks! - Steven --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2652/#review3763 --- On 2010-01-20 08:11:53, Steven Eastland wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2652/ --- (Updated 2010-01-20 08:11:53) Review request for Plasma. Summary --- When applications are shown by name, currently they are still sorted by GenericName. This patch fixes that and matches the behavior of the simple launcher applet. Originally I had a patch that added a separate config option for Sort applications by name but that seemed excessive. This also could be a potential fix for bug 188720. Diffs - /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/launcher.cpp 1073143 Diff: http://reviewboard.kde.org/r/2652/diff Testing --- Tested on my Arch Linux box with KDE SC 4.4 RC1 and works for me. Thanks, Steven ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
documenting javascript DataEgine and Runners
hi ... i've got my hands pretty full right now with documenting the JavaScript Plasmoid API: http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API the DataEngine and Runner JS APIs also need documenting in a similar fashion, though on their own pages on techbase. it would also be a great way to learn the API's the old-fashioned way (reading the source ;) and would be a huge help not only to me but everyone who would like to use these APIs in the future. the sources are in kdebase/runtime/plasma/scriptengines/javascript/ in the javascripdataengine.cpp and javascriptrunner.cpp files. if my experience with documenting the plasmoid API is any indication, documenting the API will also lead to the discover of things that need to get fixed (which i am happy to do if you don't want to or don't know c++ sufficiently to do so :) anyone interested? i'm happy to mentor/provide pointers in the right directions -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: documenting javascript DataEgine and Runners
On Wed, Jan 20, 2010 at 8:29 PM, Aaron J. Seigo ase...@kde.org wrote: the sources are in kdebase/runtime/plasma/scriptengines/javascript/ in the javascripdataengine.cpp and javascriptrunner.cpp files. anyone interested? i'm happy to mentor/provide pointers in the right directions I'll try start writing it during my flight time on Friday but don't take this as granted, so if there is anybody still wanting to do it just go for it :) I can merge stuff later :) Cheers, -- --- Artur Duque de Souza OpenBossa Research Labs INdT - Instituto Nokia de Tecnologia --- Blog: http://labs.morpheuz.eng.br/blog/ PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net --- ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: documenting javascript DataEgine and Runners
On Wed, Jan 20, 2010 at 8:29 PM, Aaron J. Seigo ase...@kde.org wrote: the sources are in kdebase/runtime/plasma/scriptengines/javascript/ in the javascripdataengine.cpp and javascriptrunner.cpp files. anyone interested? i'm happy to mentor/provide pointers in the right directions I'll try start writing it during my flight time on Friday but don't take this as granted, so if there is anybody still wanting to do it just go for it :) I can merge stuff later :) Cheers, -- --- Artur Duque de Souza OpenBossa Research Labs INdT - Instituto Nokia de Tecnologia --- Blog: http://labs.morpheuz.eng.br/blog/ PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net --- ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Add simple Type-and-Select feature to Folderview applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2659/ --- Review request for Plasma and Fredrik Höglund. Summary --- This patch intends to provide a simple selection method to select icons. Its intended to be able to select a file plasma-desktop.desktop by just typing initial characters, plas for example. Comments on the hard-coded 2000ms welcome. If the user doesn't press any key within 2000ms after the last key press, the match string clears. This addresses bug 187241. https://bugs.kde.org/show_bug.cgi?id=187241 Diffs - trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1077898 trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1077898 Diff: http://reviewboard.kde.org/r/2659/diff Testing --- Works with the latest trunk. Thanks, Shantanu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
