Re: Plugins in WebView
On Thu, Feb 25, 2010 at 10:10 PM, Mathieu Ducharme ducharme.math...@gmail.com wrote: I would like to propose allowing plasmoids to enable plugins (ie. Flash) in the WebView widget. I can tell that I personally expected the current Web Browser to be able to play flash videos when I tried it... Anyway, I'm not sure if it is currently possible in C++ (does not seem so), but the scripting API does not have access to WebView settings so I added the following functions to Plasma::WebView - bool pluginsEnabled() - void setPluginsEnabled(bool) One thing to watch with this is whether the plugins paint correctly when an applet is rotated. I know ariya did some work on this, but I don't know if it works in the current Qt release. Cheers Rich. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [GSoC 2010] Plasma Media Center Idea
Morning What about your (Alessandros) participation in the KDE Multimedia meeting in Randa/Switzerland? CU Mario ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Let Kickoff and SimpleLauncher widgets preserve their settings after menu style change
On 2010-02-15 02:44:08, Aaron Seigo wrote: this is an improvement functionality wise; i think it would be nicer if the applet wasn't destroyed and recreated but simple switch the UI; e.g. if the popup widget was swapped between being the kickoff ui and the QMenu. this would mean some juggling in createConfigurationInterface to create the proper interface, but it is doable. in any case, if you don't feel like doing that work (and i'd completely understand) then at least this patch improves the situation even if it is hackish. Yes, merging both plasma widgets will be the best but it is too much work for me at the moment. We could try to polish this hack to at least get something better. Thanks for the review. On 2010-02-15 02:44:08, Aaron Seigo wrote: svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/applet/applet.cpp, line 143 http://reviewboard.kde.org/r/2923/diff/2/?file=19427#file19427line143 should probably just be a call to configChanged() Calling simpleLauncher-configChanged() would cause a config reload? which local Applet function is responsible of reloading the config ? init() ? May be I'm missing something - Darío --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2923/#review4154 --- On 2010-02-15 02:28:15, Darío Andrés wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2923/ --- (Updated 2010-02-15 02:28:15) Review request for Plasma. Summary --- Because of the current implementation (kickoff and simplelauncher are two separate applets), switching from one launcher style to another is just a create a new launcher using the other style and delete me!. This causes all the configuration values to be lost from change to change (including the Icon which is a common setting between the two styles) In the past I have implemented code to preserve the launcher shortcut; however all the other settings are still lost. My patch provides a way to save the configuration values (both config() and globalConfig()) from one applet to another; and reload the applet settings to use the new config values. The code could be a bit hackish (passing KConfigGroups and using copyTo()). I also implemented a delayedConfigLoad var, to not load the settings two times (the first, when the applet is created and the init() function is called; and the second one, when the previously stored values are copied...) [Note, this was only done on the SimpleLauncher, as the delayed config load on Kickoff caused the widget to be iconized even on the default containment of PlasmoidViewer) This shouldn't cause noticeable delays or artifacts as reloadConfigValues() is called inmediatly after the applet creation. Hopefully the APIDOX and the comments are self-explanatory :) [ If somebody knows how to give a default configuration file; or how to copy the configuration file before the init() call, please tell me and I will improve the patch] This addresses bug 192836. https://bugs.kde.org/show_bug.cgi?id=192836 Diffs - svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/applet/applet.h 1088295 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/applet/applet.cpp 1088295 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.h 1088295 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 1088295 Diff: http://reviewboard.kde.org/r/2923/diff Testing --- All the config values (from both styles) are preserved after switching back and forward a couple of times. (The SimpleLauncher constructor may be some review, as I changed the way the applet's args var is handled... but I think it is ok) Also, someone needs to check if the delayedConfigLoad could cause some issue (I didn't notice anyone) Thanks, Darío ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Allow ComboBox.addItem to be used in script.
On February 25, 2010, you wrote: On 2010-02-25 08:57:50, Aaron Seigo wrote: looks good; this should be added to http://techbase.kde.org/index.php?title=Development/Tutorials/Plasma/J avaScript/API as well Committed. (techbase updated as well). Sorry it was not clear but is it ok to backport to the 4.4 branch? yes, it should be, as this is a bug -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Additional style options for TaskManager e.g. Icon only
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1342/#review4297
---
Ship it!
trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
http://reviewboard.kde.org/r/1342/#comment3795
em width used to be the height of a capital 'M' in the typeface, leading
to the phonetically spelled em; in any case, this just essentially sets the
threshold to twice what it was. this can therefore probably just be
fm.width('M') * 6. there is also QFontMetrics::averageCharWidth() but we
probably want a maximal size rather than an average size and i'm concerned
about the speed of that in such a hot path (looking at the code, it might be
somewhat expensive ...)
this is also a value that could probably be cached, of course, and changed
on font change .. but that's likely overengineering the whole thing.
in any case, 'M' * 6 is probably fine. please commit with that change :)
- Aaron
On 2010-02-25 15:53:26, Ralf Engels wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1342/
---
(Updated 2010-02-25 15:53:26)
Review request for Plasma.
Summary
---
The attached diff adds three style options to the task manager widget.
In addition to the normal icon-and-text style you can now have a icon-only,
text-only or text-under-icon style.
This means that e.g. the tasks are displayed by icon only (a much bigger icon
though).
The additional styles are especially useful if you have a vertical panel. In
the icon-and-text style I only had five characters of the task name left.
The new styles can be selected in the Task Manager Settings. Default is the
Windows like icon-and-text.
Heyho...
Don't anyone want to review this?
Diffs
-
trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
1096015
Diff: http://reviewboard.kde.org/r/1342/diff
Testing
---
Tried all possible combinations of style options.
Note: Manual grouping does not seem but work, but I couldn't get this to work
with the original either.
Thanks,
Ralf
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plugins in WebView
On February 25, 2010, Mathieu Ducharme wrote: - bool pluginsEnabled() - void setPluginsEnabled(bool) i don't know if we need to / want to offer full access to QWebSettings, but would a simple(r) setAttribute(QWebSettings::Attribute, bool) do the trick? the rest of the things in QWebSettings don't look overly useful for the use cases we have in plasma? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Creating a rectangular icon
On February 26, 2010, Antony Loebs wrote: On Fri, Feb 26, 2010 at 11:40 AM, Marco Martin notm...@gmail.com wrote: On Thu, Feb 25, 2010 at 10:29 PM, Antony Loebs barefootedjournal...@gmail.com wrote: I have been trying to figure out how to display a rectangular image in the panel to use as a button. The image itself is 30x120, but I can't get it to display to my satisfaction. If I use IconWidget, the image is squashed into a square. If I use PushButton, the image is likewise squashed by the button's borders. I tried changing the stylesheet for the button, setting margin and padding to 0, but with no success. Below is the sample code (the PushButton code is commented out). to just display an image you probably want to use Label (yes, it can display images and a click signaliirc) Two problems: one, I don't see how to make a click on a label register, and two, while it looks fine on the desktop, if it is started in the panel it is squashed horizontally (so the image looks like a vertical line about four or five pixels wide). Additionally, when I rescale the panel, the image scales vertically, but not horizontally. sounds like a layouting issue; you probably need to set a preferred and/or minimum size in your widget. remember that panels can be very small, however. it's never fun when a widget enforces a minimum size that's overly large. :) --- import subprocess self.button = Plasma.Label(self.applet) self.button.setImage(self.package().path() + contents/images/image.png) that should be: self.package().filePath(images, image.png) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
