Re: Review Request: Add libqalculate support to calculator runner
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3483/#review4973 --- I didn't try the patch locally but the code seems good to me and really well done except for what follows... /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp http://reviewboard.kde.org/r/3483/#comment4417 I know nothing about libqalculate but doesn't this lead to a mem leak? /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp http://reviewboard.kde.org/r/3483/#comment4416 wouldn't it be safer using QDir::homePath()? Or, better, does Qalculate have an access method for that directory? - Alessandro On 2010-04-03 11:03:20, Matteo Agostinelli wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3483/ --- (Updated 2010-04-03 11:03:20) Review request for Plasma and Aaron Seigo. Summary --- Adds libqalculate to the default calculator runner. This enables advanced features such as unit/currency conversion, equation solving, symbolic manipulation and more. Diffs - /trunk/KDE/kdebase/workspace/cmake/modules/FindQalculate.cmake PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/CMakeLists.txt 1109927 /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.h 1109927 /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.cpp 1109927 /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/3483/diff Testing --- Tested for several weeks without crashes Thanks, Matteo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Diagram of PMC Architecture including states
Dear friends, I have included a diagram of the Plasma Media Center classes on the techbase: http://techbase.kde.org/index.php?title=Projects/Plasma/Plasma_Media_Centeraction=submit#Architecture (click on picture to enlarge) I marked in green the places where a plugin would have to provide something. I hope this will get us all on the same page concerning how to get PMC as flexible as possible. Discussion go! Chris aka binarylooks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Diagram of PMC Architecture including states
Correct link: http://techbase.kde.org/Projects/Plasma/Plasma_Media_Center#Architecture Sorry On Mon, Apr 12, 2010 at 10:28 AM, Christophe Olinger oling...@binarylooks.com wrote: Dear friends, I have included a diagram of the Plasma Media Center classes on the techbase: http://techbase.kde.org/index.php?title=Projects/Plasma/Plasma_Media_Centeraction=submit#Architecture (click on picture to enlarge) I marked in green the places where a plugin would have to provide something. I hope this will get us all on the same page concerning how to get PMC as flexible as possible. Discussion go! Chris aka binarylooks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add libqalculate support to calculator runner
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3483/ --- (Updated 2010-04-12 09:01:06.760037) Review request for Plasma and Aaron Seigo. Changes --- Implemented both changes suggested by Alessandro. Thanks! Summary --- Adds libqalculate to the default calculator runner. This enables advanced features such as unit/currency conversion, equation solving, symbolic manipulation and more. Diffs (updated) - /trunk/KDE/kdebase/workspace/cmake/modules/FindQalculate.cmake PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/CMakeLists.txt 1109927 /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.h 1109927 /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.cpp 1109927 /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/3483/diff Testing --- Tested for several weeks without crashes Thanks, Matteo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Character-Runner
Am Freitag, 9. April 2010 00:57:10 schrieb Aaron J. Seigo: On April 8, 2010, Anton Kreuzkamp wrote: I would appreciate it if you could review it and possibly integrate it into Trunk. Thanks. looks good. two comments on it: * context.query() is already trim()'d, so you don't have to re-trim() them. * in reloadConfiguration, the runner should create one or more QuerySyntax objects and register them with addSyntax or setSyntaxes. other than that, if you'd like to maintain this in KDE's svn, that'd be cool. you'll need an svn account[1] and commit to maintaining the plugin. it would go into kdeplasma-addons/runners. It arrived there now, but the runner is broken i18n-wise. Messages are extracted to plasma_runner_charrunner, but via the first argument in the K_EXPORT_PLASMA_RUNNER macro it tries to load the non existing catalog plasma_runner_CharacterRunner. How to fix that bug, renaming the catalog or the arg in K_EXPORT_PLASMA_RUNNER macro? -- Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Character-Runner
On April 12, 2010, Burkhard Lück wrote: How to fix that bug, renaming the catalog or the arg in K_EXPORT_PLASMA_RUNNER macro? i changed the name of the catalog. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Reviewing Plasma themes
Greetings, mighty Plasma people! I maintain a Russian blog about KDE since 4.0 went out -- you can find it at http://knotes.ru (I have several co-bloggers there now, but I am the most active) Recently I have posted a big review of Plasma themes -- the text is of course in Russian, but in this case screenshots matter the most: http://knotes.ru/2010/03/plasma-themes-1/ http://knotes.ru/2010/03/plasma-themes-2/ http://knotes.ru/2010/03/plasma-themes-3/ http://knotes.ru/2010/03/plasma-themes-4/ I want to give you some observations based on work I done. 1. Most of popular themes (I reviewed the themes bundled with Plasma and some highest rated/most downloaded themes from GHNS) have usability problems. I was surprised to see either black text on dark background or white text on light background in so many themes. Some themes don't work well with too dark/too light backgrounds (that's why I provided 2 screenshots for each theme). Lancelot has problems with many dark themes (I didn't provide a Lancelot screenshot for each theme, but I specified in the text part which themes tend to show black-on-dark text in Lancelot). Network monitoring widget has problems with most of themes. One would think that default theme shipped with KDE SC 4.4 shouldn't have all these problems -- yet it's very hard to see something on network monitoring widget with this theme (also: please make old Air available as an alternative) 2. Plasma is still unstable. I had more than a dozen crashes of Plasma and KWin. Of course, it's not typical to have so many widgets on desktop, but it seems like a good test case when you're working on stability. 3. Widgets are clumsy. Arranging them took some time and made whish to punch my monitor, because widgets tend to jump back after I resized and/or moved them. This again is not as annoying when you don't have so many widgets, but it's something that you might to want to look at. Folder View is exceptionally cunning: if I move/resize it, and then restart Plasma, it tends to move back where it was before I moved it. 4. I hate new widget explorer. It has so many usability problems, I could write another lengthy rant about it. Please go back to the old add widgets dialog and explore the posibilities of improving it. Please understand that even though that maybe sounded like an angry rant, I consider myself a big supporter of KDE4, so I am posting these observations here, to the people who are working on these things, so you can probably fix them. Thanks for your great work on KDE and Plasma! Aleksey ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviewing Plasma themes
A Segunda, 12 de Abril de 2010 14:30:27 Aleksey Alekseyev você escreveu: One would think that default theme shipped with KDE SC 4.4 shouldn't have all these problems -- yet it's very hard to see something on network monitoring widget with this theme (also: please make old Air available as an alternative) Hey from my end can you please send me the specific problems you have with air or oxygen/plasma theme. We can fix oxygen and air, since we officially maintain them. Non kde oficial themes you need to talk with those themes creators. so they can address them. -- oxygen guy, I make the pretty pictures ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviewing Plasma themes
backtraces? Plasma mostly just silently restarted. Also I am not sure if I had debug information at the moment (I do have it now though) you'd likely end up observing issues we already know about and are working on. you could also offer useful, constructive feedback. not much to say, otherwise. All right, I'll try to be constructive. Two main elements of Widget explorer is the list of categories and the list of widgets. The primary problem with categories is there are quite a lot of them, and presenting a very long list in a horizontal strip is bad, because you have to scroll a lot (especially with how scrolling that list is handled in 4.4) and you can't scan it at a glance. Having so many categories and making it hard to explore and navigate the list of them defeats their purpose The list of widgets makes in its current form makes it hard to both explore the widgets you have and finding one particular widget you need at the moment. Exploring the widgets is inconvenient, because you have to mouse-over every one of them to read what they are doing. Finding a particular widget is hard, because the icons are not always self-explanatory (and sometimes several widgets share icons) and text with the name of the widget is in small font (and again, sometimes you need to re-check the description to be sure that this widget is the one you're looking for) and gets clipped for long names.. Just yesterday I spent several minutes looking for widget which helps me post images/texts to the internet. It wasn't in Internet and services category, its icon didn't catch my eye and scanning widgets by their names is not possible with current layout. Finally I started thinking Wait, how is the site I post text to is called... yes, pastebin!, then typed pastebin in the search box and finally found the widget I needed (e.g. icons on the desktop.) Hey, I don't like icons on desktop either (though their absence is very confusing for those who switch to KDE) I like where you're going with Plasma and the concept of activities and I'm trying to do my best in telling Russian-speaking users about new developments. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviewing Plasma themes
On Monday 12 April 2010, 12:57 Aleksey Alekseyev wrote: The primary problem with categories is there are quite a lot of them, and presenting a very long list in a horizontal strip is bad, because you have to scroll a lot (especially with how scrolling that list is handled in 4.4) and you can't scan it at a glance. Having so many categories and making it hard to explore and navigate the list of them defeats their purpose The list of widgets makes in its current form makes it hard to both explore the widgets you have and finding one particular widget you need at the moment. Exploring the widgets is inconvenient, because you have to mouse-over every one of them to read what they are doing. Finding a particular widget is hard, because the icons are not always self-explanatory (and sometimes several widgets share icons) and text with the name of the widget is in small font (and again, sometimes you need to re-check the description to be sure that this widget is the one you're looking for) and gets clipped for long names.. I don't see how the old widgets explorer was better in managing this issues...actually, in most of them it was worse. Just yesterday I spent several minutes looking for widget which helps me post images/texts to the internet. It wasn't in Internet and services category, its icon didn't catch my eye and scanning widgets by their names is not possible with current layout. Finally I started thinking Wait, how is the site I post text to is called... yes, pastebin!, then typed pastebin in the search box and finally found the widget I needed This is a problem with the pastebin plasmoid, and that will be fixed when the new one comes out. Cheers! -- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: monochrome battery in panel
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3574/ --- Review request for Plasma. Summary --- this makes the battery load a different svg in the panel, a monochrome one, to match with the systray oriented theme it's being building. when it's in the desktop and in the popup is still the default svg Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1113619 Diff: http://reviewboard.kde.org/r/3574/diff Testing --- Screenshots --- http://reviewboard.kde.org/r/3574/s/355/ Thanks, Marco ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviewing Plasma themes
On April 12, 2010, Aleksey Alekseyev wrote: backtraces? Plasma mostly just silently restarted. Also I am not sure if I had debug information at the moment (I do have it now though) that's probably why you didn't get backtraces (no debug info). with it installed now, you should be able to get backtraces. and i bet most of them were KPixmapCache ones if they happened during / shortly after theme changes. The primary problem with categories is there are quite a lot of them, and presenting a very long list in a horizontal strip is bad, because you have to scroll a lot vertical was even worse. and you can't scan it at a glance. Having so what is lost in the horizontal strip is a clear reading line that the vertical one had (left aligned margin), but that can be regained. many categories and making it hard to explore and navigate the list of them defeats their purpose the old one had the exact same issue. but we could use a popup menu there for them. right now, due to bugs in Qt, we can't do that with the new widget (horizontal or vertical). as soon as we can, i'll be dropping the tab widget for the categories. need at the moment. Exploring the widgets is inconvenient, because you have to mouse-over every one of them to read what they are doing. that's a combination of bad naming in some cases and the icons not showing the full names (they get cut off currently, which isn't good) in other cases. services category, its icon didn't catch my eye i'd love to see the icons become little screenshots of the widgets. that requires someone who is somewhat committed to actually ensuring they get done and updated over time. the artists already have enough on their plate as it is, and nice clear little snapshots are something nearly anyone could do. would you be interested in trying to come up with a nice collection of such things? and scanning widgets by their names is not possible with current layout. it was hardly easier in the old one given how many could be shown at once; the horizontal scrolling does need some work, though, i think. besides what can be improved, there's also a lot of habituation to overcome. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: monochrome battery in panel
A Segunda, 12 de Abril de 2010 18:14:21 Marco Martin você escreveu: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3574/ --- Review request for Plasma. Summary --- this makes the battery load a different svg in the panel, a monochrome one, to match with the systray oriented theme it's being building. when it's in the desktop and in the popup is still the default svg Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1113619 Diff: http://reviewboard.kde.org/r/3574/diff Testing --- Screenshots --- http://reviewboard.kde.org/r/3574/s/355/ Thanks, Marco ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel me likes need to find some time to review those icons but overal I like it btw i think i liked the old system try arrow better -- oxygen guy, I make the pretty pictures ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
