Re: Review Request: Close notification with middle click
> On 2010-04-24 19:59:00, Aaron Seigo wrote: > > maybe we should make it possible to close any window by middle clicking on > > it so you don't have to click the small close button. ;) i really don't > > like these kinds of magic behaviours as there is no feedback to the user > > that the action they are about to undertake will have such an effect. it's > > very cool that you've implemented this based on a user request, but i don't > > think it's the kind of request that we should seriously consider fulfilling > > due to its impact on the conistency and trustability of the overall UI. That concern is true, but I think it's kind of consistent. E.g. it is used in tabbox to close a window. It's also possible to be used in present windows to close a window by middle click, but there it is configurable. I thought about exactly that issue and about adding a config option to it, but I think it is overkill. It is a hidden feature, you normally don't middle click a notification or an entry in the tabbox. So the chance to do harm - especially for notifications - is rather low. On the other hand what do you want to achieve if you click a notification? Probably saying "hey I read that, go away!". - Martin --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/#review5211 --- On 2010-04-24 19:17:46, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3802/ > --- > > (Updated 2010-04-24 19:17:46) > > > Review request for Plasma and Marco Martin. > > > Summary > --- > > Adding functionality to close a notifcation when clicking anywhere on the > notification with a middle click. This makes it easier to close the > notification as you do not have to hit the tiny close button. > > I was asked by a user to add this feature :-) > > > Diffs > - > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h > 1117624 > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp > 1117624 > > Diff: http://reviewboard.kde.org/r/3802/diff > > > Testing > --- > > Tested with knotify passivepopup: middle clicking on the notification closes > it both as a standalone notification and in the notification browser. > > > Thanks, > > Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Close notification with middle click
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/#review5211 --- maybe we should make it possible to close any window by middle clicking on it so you don't have to click the small close button. ;) i really don't like these kinds of magic behaviours as there is no feedback to the user that the action they are about to undertake will have such an effect. it's very cool that you've implemented this based on a user request, but i don't think it's the kind of request that we should seriously consider fulfilling due to its impact on the conistency and trustability of the overall UI. - Aaron On 2010-04-24 19:17:46, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3802/ > --- > > (Updated 2010-04-24 19:17:46) > > > Review request for Plasma and Marco Martin. > > > Summary > --- > > Adding functionality to close a notifcation when clicking anywhere on the > notification with a middle click. This makes it easier to close the > notification as you do not have to hit the tiny close button. > > I was asked by a user to add this feature :-) > > > Diffs > - > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h > 1117624 > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp > 1117624 > > Diff: http://reviewboard.kde.org/r/3802/diff > > > Testing > --- > > Tested with knotify passivepopup: middle clicking on the notification closes > it both as a standalone notification and in the notification browser. > > > Thanks, > > Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Close notification with middle click
> On 2010-04-24 19:20:39, Marco Martin wrote: > > i'm not sure it should really close it. > > it should just hide the automatic popup window i think > > (as it does already with left click after a second the mouse cursor hovered > > the notification) > > Marco Martin wrote: > I mean: in NotificationStack::mouseReleaseEvent() > if the pressed button is left, check the timer as is now, if the button > is middle, always emit hideRequested() > > thinking about it, there could be an use case also for actually deleting > the notification... > > what do you think? I just tried with always emitting hideRequested on mid click in NotificationStack and I don't like it :-( For the case of just one notification it hides but it is still visible, so for my prevered use case of clicking away kopete notifies it wouldn't work. So yeah I think it would be nice to have a fast way to delete a notification. - Martin --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/#review5208 --- On 2010-04-24 19:17:46, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3802/ > --- > > (Updated 2010-04-24 19:17:46) > > > Review request for Plasma and Marco Martin. > > > Summary > --- > > Adding functionality to close a notifcation when clicking anywhere on the > notification with a middle click. This makes it easier to close the > notification as you do not have to hit the tiny close button. > > I was asked by a user to add this feature :-) > > > Diffs > - > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h > 1117624 > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp > 1117624 > > Diff: http://reviewboard.kde.org/r/3802/diff > > > Testing > --- > > Tested with knotify passivepopup: middle clicking on the notification closes > it both as a standalone notification and in the notification browser. > > > Thanks, > > Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Close notification with middle click
> On 2010-04-24 19:20:39, Marco Martin wrote: > > i'm not sure it should really close it. > > it should just hide the automatic popup window i think > > (as it does already with left click after a second the mouse cursor hovered > > the notification) I mean: in NotificationStack::mouseReleaseEvent() if the pressed button is left, check the timer as is now, if the button is middle, always emit hideRequested() thinking about it, there could be an use case also for actually deleting the notification... what do you think? - Marco --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/#review5208 --- On 2010-04-24 19:17:46, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3802/ > --- > > (Updated 2010-04-24 19:17:46) > > > Review request for Plasma and Marco Martin. > > > Summary > --- > > Adding functionality to close a notifcation when clicking anywhere on the > notification with a middle click. This makes it easier to close the > notification as you do not have to hit the tiny close button. > > I was asked by a user to add this feature :-) > > > Diffs > - > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h > 1117624 > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp > 1117624 > > Diff: http://reviewboard.kde.org/r/3802/diff > > > Testing > --- > > Tested with knotify passivepopup: middle clicking on the notification closes > it both as a standalone notification and in the notification browser. > > > Thanks, > > Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Close notification with middle click
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/#review5208 --- i'm not sure it should really close it. it should just hide the automatic popup window i think (as it does already with left click after a second the mouse cursor hovered the notification) - Marco On 2010-04-24 19:17:46, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3802/ > --- > > (Updated 2010-04-24 19:17:46) > > > Review request for Plasma and Marco Martin. > > > Summary > --- > > Adding functionality to close a notifcation when clicking anywhere on the > notification with a middle click. This makes it easier to close the > notification as you do not have to hit the tiny close button. > > I was asked by a user to add this feature :-) > > > Diffs > - > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h > 1117624 > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp > 1117624 > > Diff: http://reviewboard.kde.org/r/3802/diff > > > Testing > --- > > Tested with knotify passivepopup: middle clicking on the notification closes > it both as a standalone notification and in the notification browser. > > > Thanks, > > Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Close notification with middle click
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3802/ --- Review request for Plasma and Marco Martin. Summary --- Adding functionality to close a notifcation when clicking anywhere on the notification with a middle click. This makes it easier to close the notification as you do not have to hit the tiny close button. I was asked by a user to add this feature :-) Diffs - trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h 1117624 trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp 1117624 Diff: http://reviewboard.kde.org/r/3802/diff Testing --- Tested with knotify passivepopup: middle clicking on the notification closes it both as a standalone notification and in the notification browser. Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KDE/kdebase/workspace/plasma/desktop/shell
SVN commit 1118428 by mart:
Two desktop views were getting created, as fix, do:
- move the logic of desktop view creation in createWaitingDesktops
- call createView upon containment creation only when the new containment is a
panel
CCMAIL:plasma-devel@kde.org
M +35 -30plasmaapp.cpp
--- trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp
#1118427:1118428
@@ -769,32 +769,8 @@
}
}
-KConfigGroup viewIds(KGlobal::config(), "ViewIds");
-const int id = viewIds.readEntry(QString::number(containment->id()),
0);
-DesktopView *view = viewForScreen(containment->screen(),
-
AppSettings::perVirtualDesktopViews() ? containment->desktop() : -1);
-if (view) {
-kDebug() << "had a view for" << containment->screen() <<
containment->desktop();
-// we already have a view for this screen
-return;
-}
-
-kDebug() << "creating a new view for" << containment->screen() <<
containment->desktop()
-<< "and we have" << Kephal::ScreenUtils::numScreens() << "screens";
-
-// we have a new screen. neat.
-view = new DesktopView(containment, id, 0);
-connect(view, SIGNAL(dashboardClosed()), this,
SLOT(dashboardClosed()));
-if (m_corona) {
-connect(m_corona,
SIGNAL(screenOwnerChanged(int,int,Plasma::Containment*)),
-view,
SLOT(screenOwnerChanged(int,int,Plasma::Containment*)));
-connect(m_corona, SIGNAL(shortcutsChanged()),
-view, SLOT(updateShortcuts()));
-}
-
-m_desktops.append(view);
-view->show();
-setWmClass(view->winId());
+m_desktopsWaiting.append(containment);
+m_desktopViewCreationTimer.start();
}
}
@@ -845,9 +821,35 @@
const QList > containments =
m_desktopsWaiting;
m_desktopsWaiting.clear();
-foreach (QWeakPointer containment, containments) {
-if (containment) {
-createView(containment.data());
+foreach (QWeakPointer weakContainment, containments) {
+if (weakContainment) {
+Plasma::Containment *containment = weakContainment.data();
+KConfigGroup viewIds(KGlobal::config(), "ViewIds");
+const int id =
viewIds.readEntry(QString::number(containment->id()), 0);
+DesktopView *view = viewForScreen(containment->screen(),
+
AppSettings::perVirtualDesktopViews() ? containment->desktop() : -1);
+if (view) {
+kDebug() << "had a view for" << containment->screen() <<
containment->desktop();
+// we already have a view for this screen
+return;
+}
+
+kDebug() << "creating a new view for" << containment->screen() <<
containment->desktop()
+<< "and we have" << Kephal::ScreenUtils::numScreens() <<
"screens";
+
+// we have a new screen. neat.
+view = new DesktopView(containment, id, 0);
+connect(view, SIGNAL(dashboardClosed()), this,
SLOT(dashboardClosed()));
+if (m_corona) {
+connect(m_corona,
SIGNAL(screenOwnerChanged(int,int,Plasma::Containment*)),
+view,
SLOT(screenOwnerChanged(int,int,Plasma::Containment*)));
+connect(m_corona, SIGNAL(shortcutsChanged()),
+view, SLOT(updateShortcuts()));
+}
+
+m_desktops.append(view);
+view->show();
+setWmClass(view->winId());
}
}
}
@@ -863,7 +865,10 @@
}
}
-createView(containment);
+if (isPanelContainment(containment)) {
+createView(containment);
+}
+
disconnect(containment, 0, this, 0);
connect(containment, SIGNAL(configureRequested(Plasma::Containment*)),
this, SLOT(configureContainment(Plasma::Containment*)));
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet
Am Samstag 24 April 2010 12:45:16 schrieb Ingomar Wesp: > Lukas Appelhans wrote: > > For keeping the history we usually use svn copy and then change the files > > > > :) svn move only works with svn paths, not with local paths... > > Please correct me if I'm wrong, but as far as I know "svn move" *does* work > for working copy paths and yields the same result as "svn copy a b" > followed by "svn delete a". Yes, but svn move only works with remote paths (sorry, sometimes I kind of forget english words... strange :D)... Lukas > > > I will test & review the patch soon :) > > Great, thanks! > > Have a nice day, > Ingo > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet
Lukas Appelhans wrote: > For keeping the history we usually use svn copy and then change the files > :) svn move only works with svn paths, not with local paths... Please correct me if I'm wrong, but as far as I know "svn move" *does* work for working copy paths and yields the same result as "svn copy a b" followed by "svn delete a". > I will test & review the patch soon :) Great, thanks! Have a nice day, Ingo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: SkipSwitcher functionality
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3800/#review5202 --- exactly what we wanted :) - Marco On 2010-04-24 10:16:21, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3800/ > --- > > (Updated 2010-04-24 10:16:21) > > > Review request for Plasma, Aaron Seigo, Marco Martin, and Lubos Lunak. > > > Summary > --- > > This patch adds _KDE_STATE_SKIP_SWITCHER to _NET_WM_STATE. Alt+Tab will > exclude windows with this state set (this automatically includes the alt+tab > replacement effects). I will extend Present Windows and Desktop Grid to > honour this flag, too. > > As soon as the patch is committed I will bring this to the NETWM mailinglist > to standardise the flag, so that it becomes _NET_WM_STATE_SKIP_SWITCHER. > > This can be used by plasma to exclude windows from alt+tab. Therefore > KWindowSystem::setState( winId, Net::SkipSwitcher ) can be used. > > > This addresses bugs 171192 and 179723. > https://bugs.kde.org/show_bug.cgi?id=171192 > https://bugs.kde.org/show_bug.cgi?id=179723 > > > Diffs > - > > trunk/KDE/kdebase/workspace/kwin/client.h 1117299 > trunk/KDE/kdebase/workspace/kwin/client.cpp 1117299 > trunk/KDE/kdebase/workspace/kwin/events.cpp 1117299 > trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.h 1117299 > trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.cpp 1117299 > trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidgetbase.ui > 1117299 > trunk/KDE/kdebase/workspace/kwin/manage.cpp 1117299 > trunk/KDE/kdebase/workspace/kwin/rules.h 1117299 > trunk/KDE/kdebase/workspace/kwin/rules.cpp 1117299 > trunk/KDE/kdebase/workspace/kwin/sm.h 1117299 > trunk/KDE/kdebase/workspace/kwin/sm.cpp 1117299 > trunk/KDE/kdebase/workspace/kwin/tabbox.cpp 1117299 > trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1117299 > trunk/KDE/kdelibs/kdeui/windowmanagement/kwindowsystem.h 1117299 > trunk/KDE/kdelibs/kdeui/windowmanagement/netwm.cpp 1117299 > trunk/KDE/kdelibs/kdeui/windowmanagement/netwm_def.h 1117299 > > Diff: http://reviewboard.kde.org/r/3800/diff > > > Testing > --- > > Adding a window specific rule updates the state and the window is not shown > in tabbox. > > > Thanks, > > Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: SkipSwitcher functionality
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3800/ --- Review request for Plasma, Aaron Seigo, Marco Martin, and Lubos Lunak. Summary --- This patch adds _KDE_STATE_SKIP_SWITCHER to _NET_WM_STATE. Alt+Tab will exclude windows with this state set (this automatically includes the alt+tab replacement effects). I will extend Present Windows and Desktop Grid to honour this flag, too. As soon as the patch is committed I will bring this to the NETWM mailinglist to standardise the flag, so that it becomes _NET_WM_STATE_SKIP_SWITCHER. This can be used by plasma to exclude windows from alt+tab. Therefore KWindowSystem::setState( winId, Net::SkipSwitcher ) can be used. This addresses bugs 171192 and 179723. https://bugs.kde.org/show_bug.cgi?id=171192 https://bugs.kde.org/show_bug.cgi?id=179723 Diffs - trunk/KDE/kdebase/workspace/kwin/client.h 1117299 trunk/KDE/kdebase/workspace/kwin/client.cpp 1117299 trunk/KDE/kdebase/workspace/kwin/events.cpp 1117299 trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.h 1117299 trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.cpp 1117299 trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 1117299 trunk/KDE/kdebase/workspace/kwin/manage.cpp 1117299 trunk/KDE/kdebase/workspace/kwin/rules.h 1117299 trunk/KDE/kdebase/workspace/kwin/rules.cpp 1117299 trunk/KDE/kdebase/workspace/kwin/sm.h 1117299 trunk/KDE/kdebase/workspace/kwin/sm.cpp 1117299 trunk/KDE/kdebase/workspace/kwin/tabbox.cpp 1117299 trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1117299 trunk/KDE/kdelibs/kdeui/windowmanagement/kwindowsystem.h 1117299 trunk/KDE/kdelibs/kdeui/windowmanagement/netwm.cpp 1117299 trunk/KDE/kdelibs/kdeui/windowmanagement/netwm_def.h 1117299 Diff: http://reviewboard.kde.org/r/3800/diff Testing --- Adding a window specific rule updates the state and the window is not shown in tabbox. Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
