Re: Review Request: SkipSwitcher functionality
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3800/#review5365 --- Ship it! Looks ok to me. - Lubos On 2010-05-02 14:13:46, Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3800/ --- (Updated 2010-05-02 14:13:46) Review request for Plasma, Aaron Seigo, Marco Martin, and Lubos Lunak. Summary --- This patch adds _KDE_STATE_SKIP_SWITCHER to _NET_WM_STATE. Alt+Tab will exclude windows with this state set (this automatically includes the alt+tab replacement effects). I will extend Present Windows and Desktop Grid to honour this flag, too. As soon as the patch is committed I will bring this to the NETWM mailinglist to standardise the flag, so that it becomes _NET_WM_STATE_SKIP_SWITCHER. This can be used by plasma to exclude windows from alt+tab. Therefore KWindowSystem::setState( winId, Net::SkipSwitcher ) can be used. This addresses bugs 171192 and 179723. https://bugs.kde.org/show_bug.cgi?id=171192 https://bugs.kde.org/show_bug.cgi?id=179723 Diffs - trunk/KDE/kdebase/workspace/kwin/client.h 1121836 trunk/KDE/kdebase/workspace/kwin/client.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/effects.h 1121836 trunk/KDE/kdebase/workspace/kwin/effects.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/effects/desktopgrid/desktopgrid.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/effects/presentwindows/presentwindows.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.h 1121836 trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 1121836 trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1121836 trunk/KDE/kdebase/workspace/kwin/manage.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/rules.h 1121836 trunk/KDE/kdebase/workspace/kwin/rules.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/sm.h 1121836 trunk/KDE/kdebase/workspace/kwin/sm.cpp 1121836 trunk/KDE/kdebase/workspace/kwin/tabbox.cpp 1121836 Diff: http://reviewboard.kde.org/r/3800/diff Testing --- Adding a window specific rule updates the state and the window is not shown in tabbox. Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasmoid configuraiton...
Hi, Firstly, sorry if this a an FAQ or I've just majorly missed something. I only created my first few plasmoids recently. Also, please CC me as I'm currently not on the list :/ If my understanding is correct, to configure a plasmoid you use a KConfigGroup and use readEntry() to get at each key-value pair. createConfigurationInterface() uses a .ui file to create a Qt interface for configuration and then sets each element in the UI::foo to the current setting. When okClicked is emitted and a slot called, you then get the data from the Qt interface widgets, use KConfigGroup::writeEntry() to put each setting out and also set instance variables in the plasmoid and possibly update() to reflect changes. I think I might be off the track a little as it seems that you should be able to automatically link instance variables to the UI widgets using introspection. So if you have int m_funValue; as an instance member in the plasmoid, and there is an m_funValue slider in the .ui file that makes the configuration Qt interface, then the setting of the Qt interface and getting happens automatically and perhaps the link from m_funValue to the KConfigGroup also occurs so that the plasmoid itself doesn't have to do any of the stuff in the proceeding paragraph. If there are examples using the above introspection style then I'd be happy to port over my plasmoid to the same style. Any specific hints as to which plasmoids to check out would be great. Otherwise, does this seem to make sense as a possible extension? signature.asc Description: This is a digitally signed message part ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add a new source to give informations about virtual desktops
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3871/#review5370 --- Ship it! can be an useful addition - Marco On 2010-05-02 20:12:03, Matthieu Gallien wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3871/ --- (Updated 2010-05-02 20:12:03) Review request for Plasma. Summary --- I am following a suggestion of Marco, to not create a new data engine for that. I have added a new source that you have to request. This source is giving the number of virtual desktops and their names. I am using it in my applet in playground. Best regards Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/tasks/CMakeLists.txt 1121233 /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/tasks/tasksengine.h 1121233 /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/tasks/tasksengine.cpp 1121233 /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/tasks/virtualdesktopssource.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/tasks/virtualdesktopssource.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/3871/diff Testing --- Works and I am sure that my testing covered it this time. Thanks, Matthieu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Show only total remaining jobs count
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/#review5371 --- thing is, it would become a thing only for jobs, while now it shows also how many notifications are here. thinking about it, it -could- work if the icon would change between the state of being totally dead (no notification, no job and nothing in the history popup) and the state of having something in the popup, the i itself could change from translucent to opaque or something like that... - Marco On 2010-05-01 10:15:44, Harsh J wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/ --- (Updated 2010-05-01 10:15:44) Review request for Plasma and usability. Summary --- First off, this is more of a personal suggestion than a bug-fix/etc :) As the notification tray item is already such a tiny thing and has newly introduced (cool) animation effects for running job's completion progresses, squeezing a label within like running / total only crowds it more. The animation looks pretty weird around it. Why not just show total remaining jobs and keep counting down at that, much like those loading screens in the old movies that went 5.. 4.. 3.. 2.. 1.. (i).. This so cause at every job completion a notification event is anyway supposed to fire (whether user has set to receive it or not) and the shown number also indicates automatically the no. of jobs left to do -- the user will anyway have to click the icon for detailed information on what is/how many are actually progressing. So lets just show total no. of remaining jobs to run. Comments? P.s. Something can also be done to enhance the look of those numbers (1/2 or even if its just 2). But the result shouldn't hinder the bg animation, and I can't think of what will do both :\ Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/busywidget.cpp 1121172 Diff: http://reviewboard.kde.org/r/3857/diff Testing --- Ran several jobs to see it count down after the notification pops up. Trivial change I think? Screenshots --- Icon with just total displayed, over the bg animation -- instead of running / total. http://reviewboard.kde.org/r/3857/s/383/ Thanks, Harsh ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: system tray work
On Thursday 29 April 2010, Aaron J. Seigo wrote: On April 29, 2010, Marco Martin wrote: On Thursday 29 April 2010, Aaron J. Seigo wrote: this really has little to do with the system tray work, though, other than the icon. probably it has to do a little (window not being raised on top and opening more copies sounds pretty much at that level) they were all bugs in krandr. i just committed fixes for them. i think i like more the second option. the only problem is that the ui for it would be rather clunky (there would be two distinct shortcut configurations in 2 different places that do almost the same thing) yes, a little clunky. perhaps room for improvement in the future. bonus points for working with any entry in the system tray though ;) which reminds me: someday we really ought to implement some keyboard navigation :) now it works: the config ui is still somewhat crap. the shortcut configuration is together the autohide list, to not duplicate a list of all applets, so the page should become items configuration or something like that. but i think the prettiest way would be to separe it to another list and put it under the keyboard shortcut page (only place where it wouldn't be confising i think) i don't think there is a way right now and i wouldn't like to add api just for that hmmm... Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Pastebin widget
On Sunday 02 May 2010, 06:08 mar...@pola.org wrote: I am using the pastebin-widget on my desktop and I really like it. About a few months ago, the site pastebin.com got a totally new design and functionality. That means the widget does not work if you select pastebin.com as pastebin in the options. It would be nice if you could change so it'll be compatible with pastebin.com's new API. You can find it here: http://pastebin.com/api.php It's already fixed in trunk and should be fixed for 4.5. As Marco pointed out, for 4.6 we're reworking the engine and it will be easier to release this fixes and even extend with more providers. Cheers, -- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Pastebin widget
On 03-05-2010 at 16:00:39 Artur Souza (MoRpHeUz) morph...@openbossa.org wrote: for 4.6 we're reworking the engine and it will be easier to release this fixes and even extend with more providers. It will use scripting finally (would allow downloading new providers using hot new stuff etc.)? -- Best regards, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Return 80% functionality to PMC, further evolving of state architecture
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3552/#review5322 --- trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp http://reviewboard.kde.org/r/3552/#comment5010 I don't think we'll always have to deal with KDirModel. Probably we should add a pointer validity check here. trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.h http://reviewboard.kde.org/r/3552/#comment5083 Why is this a slot? trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp http://reviewboard.kde.org/r/3552/#comment5084 m_model isn't probably always a KDirModel so check for it always trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowserlibs/modelpackage.h http://reviewboard.kde.org/r/3552/#comment5012 Probably here we should just make use of MediaCenter::MediaType trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowserlibs/modelpackage.h http://reviewboard.kde.org/r/3552/#comment5013 I'd rather use a protected setAllowedMediaTypes(MediaTypes), where MediaTypes is declared as QFlags of MediaType. And, of course, no need for virtual here. The public method will, instead, return the allowedMediaTypes() const; - Alessandro On 2010-04-27 16:44:10, Christophe Olinger wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3552/ --- (Updated 2010-04-27 16:44:10) Review request for Plasma and Alessandro Diaferia. Summary --- The state calsses now have less functions. Only one for connections and one for configuration. The first one is only called once at PMC initialization, the second one is called at each state switch. Some connections can conflict between states. Those are connected at entry() and disconnected at exit(). Thanks to Alessandr's work we can now also configure the layout from within the state class (I only had to correct some namespace stuff in the medialayout class, I hope that was correct). This patch also gets basic functionality back. The modes are not really useful yet. Video mode is the most complete and can be used to view everything at th moment. Next step: Clean this up a bit Think about subclassing plasma widgets to get the widget type into the widget. This is necessary to be able to tell the controller to layout into zones. Start work on information bar. Diffs - trunk/playground/base/plasma/MediaCenterComponents/applets/CMakeLists.txt 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.h 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.h 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowserlibs/modelpackage.h 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/CMakeLists.txt 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/CMakeLists.txt 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localconfig.ui 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localfiles.desktop 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localfilespackage.h 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localfilespackage.cpp 1117494 trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/CMakeLists.txt PRE-CREATION trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusic.desktop PRE-CREATION trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusicconfig.ui PRE-CREATION trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusicpackage.h PRE-CREATION trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusicpackage.cpp PRE-CREATION
Re: Pastebin widget
On Monday 03 May 2010, 11:03 Emdek wrote: It will use scripting finally (would allow downloading new providers using hot new stuff etc.)? Exactly. ASAP I will commit the prototype to playground. Cheers, -- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Show only total remaining jobs count
My two cents: Indeed, a differentiation between jobs and notifications could be made, only, in the latter case I do not really care about numbers, only that there is a notification. So having a number for the jobs remaining and a different icon for when there are unread notifications would be a good middle way IMHO. Chris On Mon, May 3, 2010 at 5:26 PM, Sebastian Kügler se...@kde.org wrote: On Monday 03 May 2010 14:38:43 Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/#review5371 --- thing is, it would become a thing only for jobs, while now it shows also how many notifications are here. thinking about it, it -could- work if the icon would change between the state of being totally dead (no notification, no job and nothing in the history popup) and the state of having something in the popup, the i itself could change from translucent to opaque or something like that... We could also show one icon per job (if there are not too many), that would make it even easier to keep track of multiple jobs. Just an idea I haven't completely thought through :-) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Show only total remaining jobs count
On 2010-05-03 12:38:48, Marco Martin wrote: thing is, it would become a thing only for jobs, while now it shows also how many notifications are here. thinking about it, it -could- work if the icon would change between the state of being totally dead (no notification, no job and nothing in the history popup) and the state of having something in the popup, the i itself could change from translucent to opaque or something like that... yes, if there are contents, the (i) should be coloured, letting the user know something is up there. when there are jobs the pie chart spinner with a single number should be enough. then we cover all the use cases of the x/y numbers. - Aaron --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/#review5371 --- On 2010-05-01 10:15:44, Harsh J wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/ --- (Updated 2010-05-01 10:15:44) Review request for Plasma and usability. Summary --- First off, this is more of a personal suggestion than a bug-fix/etc :) As the notification tray item is already such a tiny thing and has newly introduced (cool) animation effects for running job's completion progresses, squeezing a label within like running / total only crowds it more. The animation looks pretty weird around it. Why not just show total remaining jobs and keep counting down at that, much like those loading screens in the old movies that went 5.. 4.. 3.. 2.. 1.. (i).. This so cause at every job completion a notification event is anyway supposed to fire (whether user has set to receive it or not) and the shown number also indicates automatically the no. of jobs left to do -- the user will anyway have to click the icon for detailed information on what is/how many are actually progressing. So lets just show total no. of remaining jobs to run. Comments? P.s. Something can also be done to enhance the look of those numbers (1/2 or even if its just 2). But the result shouldn't hinder the bg animation, and I can't think of what will do both :\ Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/busywidget.cpp 1121172 Diff: http://reviewboard.kde.org/r/3857/diff Testing --- Ran several jobs to see it count down after the notification pops up. Trivial change I think? Screenshots --- Icon with just total displayed, over the bg animation -- instead of running / total. http://reviewboard.kde.org/r/3857/s/383/ Thanks, Harsh ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Show only total remaining jobs count
On May 3, 2010, Sebastian Kügler wrote: We could also show one icon per job (if there are not too many), that would make it even easier to keep track of multiple jobs. besides not scalling too well, we're also trying to not make the system tray grow and rearrange the panel too much. points for thinking outside the box though. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Show only total remaining jobs count
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/#review5376 --- Ship it! can you commit it? then I'll change the icon afterwards - Marco On 2010-05-01 10:15:44, Harsh J wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/ --- (Updated 2010-05-01 10:15:44) Review request for Plasma and usability. Summary --- First off, this is more of a personal suggestion than a bug-fix/etc :) As the notification tray item is already such a tiny thing and has newly introduced (cool) animation effects for running job's completion progresses, squeezing a label within like running / total only crowds it more. The animation looks pretty weird around it. Why not just show total remaining jobs and keep counting down at that, much like those loading screens in the old movies that went 5.. 4.. 3.. 2.. 1.. (i).. This so cause at every job completion a notification event is anyway supposed to fire (whether user has set to receive it or not) and the shown number also indicates automatically the no. of jobs left to do -- the user will anyway have to click the icon for detailed information on what is/how many are actually progressing. So lets just show total no. of remaining jobs to run. Comments? P.s. Something can also be done to enhance the look of those numbers (1/2 or even if its just 2). But the result shouldn't hinder the bg animation, and I can't think of what will do both :\ Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/busywidget.cpp 1121172 Diff: http://reviewboard.kde.org/r/3857/diff Testing --- Ran several jobs to see it count down after the notification pops up. Trivial change I think? Screenshots --- Icon with just total displayed, over the bg animation -- instead of running / total. http://reviewboard.kde.org/r/3857/s/383/ Thanks, Harsh ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmoid configuraiton...
On May 3, 2010, Ben Martin wrote: happy to port over my plasmoid to the same style. Any specific hints as to which plasmoids to check out would be great. Otherwise, does this seem to make sense as a possible extension? it's called KConfigXT and it does exactly what you suggest. unfortunately, it also doesn't work with nested KConfigGroups. KConfigSkeleton (the heart of KConfigXT) was designed and created during KDE 3 times when you couldn't have nested KConfigGroups. in KDE 4 you can, and we rely _heavily_ on this feature to keep things sane in Plasma. so as soon as KConfigSkeleton is able to talk to nested KConfigGroups, things will be happy. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Show only total remaining jobs count
On Monday 03 May 2010 19:29:40 Aaron J. Seigo wrote: On May 3, 2010, Sebastian Kügler wrote: We could also show one icon per job (if there are not too many), that would make it even easier to keep track of multiple jobs. besides not scalling too well, we're also trying to not make the system tray grow and rearrange the panel too much. points for thinking outside the box though. Agree (still thanks for the points ;-)). -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Request review for KSharedDataCache (Round 2)
On April 30, 2010, Michael Pyne wrote: For my Plasma dev friends, I also intend to port Plasma::Theme over to use KImageCache, using the attached patch. Please let me know if there are problems with this. after using it since you posted the patch and running my usual tortue plasma to death development routines, it seems very reliable and performance seems good. please commit :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Manual panel hiding [WIP]
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/#review5390 --- any updates on this? - Aaron On 2010-03-04 19:19:53, Andrzej JR Hunt wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/ --- (Updated 2010-03-04 19:19:53) Review request for Plasma. Summary --- Manual panel hiding patch (still in progress). Currently only horizontal panels are properly implemented, there is still a display bug whereby the plasma toolbox (cashew) ignores the contentsMargins set on the containment and thus gets covered by the hiding buttons. This addresses bug 158556. https://bugs.kde.org/show_bug.cgi?id=158556 Diffs - /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 Diff: http://reviewboard.kde.org/r/3121/diff Testing --- Hiding the panels, changing states, changing positions and sizes. Thanks, Andrzej JR ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Let Kickoff and SimpleLauncher widgets preserve their settings after menu style change
On 2010-02-15 02:44:08, Aaron Seigo wrote: svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/applet/applet.cpp, line 143 http://reviewboard.kde.org/r/2923/diff/2/?file=19427#file19427line143 should probably just be a call to configChanged() Darío Andrés wrote: Calling simpleLauncher-configChanged() would cause a config reload? which local Applet function is responsible of reloading the config ? init() ? May be I'm missing something configChanged() is a virtual method in Applet which plasmoids should reimplment to get notified of configuration changes. - Aaron --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2923/#review4154 --- On 2010-02-15 02:28:15, Darío Andrés wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2923/ --- (Updated 2010-02-15 02:28:15) Review request for Plasma. Summary --- Because of the current implementation (kickoff and simplelauncher are two separate applets), switching from one launcher style to another is just a create a new launcher using the other style and delete me!. This causes all the configuration values to be lost from change to change (including the Icon which is a common setting between the two styles) In the past I have implemented code to preserve the launcher shortcut; however all the other settings are still lost. My patch provides a way to save the configuration values (both config() and globalConfig()) from one applet to another; and reload the applet settings to use the new config values. The code could be a bit hackish (passing KConfigGroups and using copyTo()). I also implemented a delayedConfigLoad var, to not load the settings two times (the first, when the applet is created and the init() function is called; and the second one, when the previously stored values are copied...) [Note, this was only done on the SimpleLauncher, as the delayed config load on Kickoff caused the widget to be iconized even on the default containment of PlasmoidViewer) This shouldn't cause noticeable delays or artifacts as reloadConfigValues() is called inmediatly after the applet creation. Hopefully the APIDOX and the comments are self-explanatory :) [ If somebody knows how to give a default configuration file; or how to copy the configuration file before the init() call, please tell me and I will improve the patch] This addresses bug 192836. https://bugs.kde.org/show_bug.cgi?id=192836 Diffs - svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/applet/applet.h 1088295 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/applet/applet.cpp 1088295 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.h 1088295 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 1088295 Diff: http://reviewboard.kde.org/r/2923/diff Testing --- All the config values (from both styles) are preserved after switching back and forward a couple of times. (The SimpleLauncher constructor may be some review, as I changed the way the applet's args var is handled... but I think it is ok) Also, someone needs to check if the delayedConfigLoad could cause some issue (I didn't notice anyone) Thanks, Darío ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Show only total remaining jobs count
On 2010-05-03 17:32:50, Marco Martin wrote: can you commit it? then I'll change the icon afterwards Yep, okay. Done in r1122520. - Harsh --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/#review5376 --- On 2010-05-01 10:15:44, Harsh J wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/ --- (Updated 2010-05-01 10:15:44) Review request for Plasma and usability. Summary --- First off, this is more of a personal suggestion than a bug-fix/etc :) As the notification tray item is already such a tiny thing and has newly introduced (cool) animation effects for running job's completion progresses, squeezing a label within like running / total only crowds it more. The animation looks pretty weird around it. Why not just show total remaining jobs and keep counting down at that, much like those loading screens in the old movies that went 5.. 4.. 3.. 2.. 1.. (i).. This so cause at every job completion a notification event is anyway supposed to fire (whether user has set to receive it or not) and the shown number also indicates automatically the no. of jobs left to do -- the user will anyway have to click the icon for detailed information on what is/how many are actually progressing. So lets just show total no. of remaining jobs to run. Comments? P.s. Something can also be done to enhance the look of those numbers (1/2 or even if its just 2). But the result shouldn't hinder the bg animation, and I can't think of what will do both :\ Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/busywidget.cpp 1121172 Diff: http://reviewboard.kde.org/r/3857/diff Testing --- Ran several jobs to see it count down after the notification pops up. Trivial change I think? Screenshots --- Icon with just total displayed, over the bg animation -- instead of running / total. http://reviewboard.kde.org/r/3857/s/383/ Thanks, Harsh ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
