KDE Observatory moved to kdereview

[Sandro Andrade]

Hi there,

KDE Observatory applet and data engine were moved to kdereview.

What's new ?

- New data engine for acquiring data from commits and krazy reports.
- Performance improvements by getting consolidated data from a servlet
service instead of scan kde-commits archives.
- Filtering by any date range.

Any comments and suggestions are welcome !

Thanks,
Sandro
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Aaron J. Seigo]

On May 5, 2010, Sandro Andrade wrote:
> Hi there,
> 
> KDE Observatory applet and data engine were moved to kdereview.

cool, i'll have to check it out...

> Any comments and suggestions are welcome !

you need to announce this on kde-core-devel as well. iwhat is your target 
destination? kdeplasma-addons? kdesdk? extragear?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Routing (un)mounting error notifications via knotify; part II: dataengine

[Jacopo De Simoi]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3896/
---

Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.


Summary
---

This patch provides a dataengine which collects and exposes (un)mounting error 
notifications; the plasma devicenotifier will spawn an instance of this 
dataengine to tell knotify that it will display such notifications itself. 


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 1123205 
  
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/CMakeLists.txt
 PRE-CREATION 
  
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h
 PRE-CREATION 
  
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.cpp
 PRE-CREATION 
  
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/org.kde.DeviceNotifications.xml
 PRE-CREATION 
  
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop
 PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3896/diff


Testing
---

This patch depends on the corresponding one for knotify;

With that patch it works as expected.


Thanks,

Jacopo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Routing (un)mounting error notifications via knotify; part II: dataengine

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3896/#review5430
---

Ship it!


to me seems the correct way to proceed.


trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop


add yourself here :)


- Marco


On 2010-05-05 16:10:45, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3896/
> ---
> 
> (Updated 2010-05-05 16:10:45)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.
> 
> 
> Summary
> ---
> 
> This patch provides a dataengine which collects and exposes (un)mounting 
> error notifications; the plasma devicenotifier will spawn an instance of this 
> dataengine to tell knotify that it will display such notifications itself. 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 
> 1123205 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/CMakeLists.txt
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.cpp
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/org.kde.DeviceNotifications.xml
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop
>  PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3896/diff
> 
> 
> Testing
> ---
> 
> This patch depends on the corresponding one for knotify;
> 
> With that patch it works as expected.
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Sandro Andrade]

On Wed, May 5, 2010 at 12:55 PM, Aaron J. Seigo  wrote:
> On May 5, 2010, Sandro Andrade wrote:
>> Hi there,
>>
>> KDE Observatory applet and data engine were moved to kdereview.
>
> cool, i'll have to check it out...

Ok !

>
>> Any comments and suggestions are welcome !
>
> you need to announce this on kde-core-devel as well. iwhat is your target
> destination? kdeplasma-addons? kdesdk? extragear?

KDE Observatory (first version, without a data engine) is already in
kdeplasma-addons,
so I'm considering keep things there.

What's the reason for announcing in kde-core-devel ? I didn't do that
for KDE Observatory in KDE SC 4.4.

Thanks,
Sandro

>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Marco Martin]

On Wednesday 05 May 2010, Sandro Andrade wrote:
> On Wed, May 5, 2010 at 12:55 PM, Aaron J. Seigo  wrote:
> > On May 5, 2010, Sandro Andrade wrote:
> >> Hi there,
> >> 
> >> KDE Observatory applet and data engine were moved to kdereview.
> > 
> > cool, i'll have to check it out...
> 
> Ok !
> 
> >> Any comments and suggestions are welcome !
> > 
> > you need to announce this on kde-core-devel as well. iwhat is your target
> > destination? kdeplasma-addons? kdesdk? extragear?
> 
> KDE Observatory (first version, without a data engine) is already in
> kdeplasma-addons,
> so I'm considering keep things there.
> 
> What's the reason for announcing in kde-core-devel ? I didn't do that
> for KDE Observatory in KDE SC 4.4.

so translators can notice and move the translatio files where needed

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Sandro Andrade]

On Wed, May 5, 2010 at 1:53 PM, Marco Martin  wrote:
> On Wednesday 05 May 2010, Sandro Andrade wrote:
>> On Wed, May 5, 2010 at 12:55 PM, Aaron J. Seigo  wrote:
>> > On May 5, 2010, Sandro Andrade wrote:
>> >> Hi there,
>> >>
>> >> KDE Observatory applet and data engine were moved to kdereview.
>> >
>> > cool, i'll have to check it out...
>>
>> Ok !
>>
>> >> Any comments and suggestions are welcome !
>> >
>> > you need to announce this on kde-core-devel as well. iwhat is your target
>> > destination? kdeplasma-addons? kdesdk? extragear?
>>
>> KDE Observatory (first version, without a data engine) is already in
>> kdeplasma-addons,
>> so I'm considering keep things there.
>>
>> What's the reason for announcing in kde-core-devel ? I didn't do that
>> for KDE Observatory in KDE SC 4.4.
>
> so translators can notice and move the translatio files where needed

Great, as soft message freeze occurs only at 19th May I suppose I should
do the review corrections first and then announce it in its final
location (kdeplasma-addons)
instead of in kdereview, right ?

Thanks,
Sandro

>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Routing (un)mounting error notifications via knotify; part II: dataengine

[Aaron Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3896/#review5431
---

Ship it!


my only concern with this is that we then have exactly one thing at a time that 
can be receiving these errors; e.g i couldn't have the errors showing up in a 
system tray loaded in plasma-windowed at the same time as it is being shown in 
plasma-desktop or plasma-netbook, for example. i really do think that 
eventually we will want the error watchers, such as this DataEngine, to 
register themselves with KNotify and let KNotify multiplex the messages to 
them. just as we do with notifications. however, this is a reasonable and 
working first step and will allow us to get the integration into the UI going.


trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h


probably doesn't need to be marked as scriptable


- Aaron


On 2010-05-05 16:10:45, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3896/
> ---
> 
> (Updated 2010-05-05 16:10:45)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.
> 
> 
> Summary
> ---
> 
> This patch provides a dataengine which collects and exposes (un)mounting 
> error notifications; the plasma devicenotifier will spawn an instance of this 
> dataengine to tell knotify that it will display such notifications itself. 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 
> 1123205 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/CMakeLists.txt
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.cpp
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/org.kde.DeviceNotifications.xml
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop
>  PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3896/diff
> 
> 
> Testing
> ---
> 
> This patch depends on the corresponding one for knotify;
> 
> With that patch it works as expected.
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Aaron J. Seigo]

On May 5, 2010, Sandro Andrade wrote:
> KDE Observatory (first version, without a data engine) is already in
> kdeplasma-addons,
> so I'm considering keep things there.

ok, sounds perfect to me :) please bump the version number in the .desktop 
file to reflect the upgrade...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Sandro Andrade]

On Wed, May 5, 2010 at 2:22 PM, Aaron J. Seigo  wrote:
> On May 5, 2010, Sandro Andrade wrote:
>> KDE Observatory (first version, without a data engine) is already in
>> kdeplasma-addons,
>> so I'm considering keep things there.
>
> ok, sounds perfect to me :) please bump the version number in the .desktop
> file to reflect the upgrade...

Deal ! Waiting review suggestions ...

Thanks,
Sandro

>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Burkhard Lück]

Am Mittwoch, 5. Mai 2010, um 19:13:48 schrieb Sandro Andrade:

> Great, as soft message freeze occurs only at 19th May I suppose I should
> do the review corrections first and then announce it in its final
> location (kdeplasma-addons)
> instead of in kdereview, right ?
> 
No.

1) 
applets/kdeobservatory/src/ has a Messages.sh, but you don't have enough karma 
to prevent scripty processing that file in a few hours and spread the news of a 
new message catalog to some hundred translators tomorrow.
Then we will have a duplicated catalog plasma_applet_kdeobservatory. That's 
bad, please contact the i18n coordinator Albert Astals Cid (tsdgeos on irc) .

2)
You move code to kdereview. 
Review includes l10n/i18n issues,so you need to have a working translation in 
kdereview to enable people to check this issue.

3) 
dataengines/kdeobservatory has i18n calls, but no message extraction -> broken 
i18n wise.

CC'ing the i18n coordinator.

-- 
Burkhard Lück
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Albert Astals Cid]

A Dimecres, 5 de maig de 2010, Burkhard Lück va escriure:
> Am Mittwoch, 5. Mai 2010, um 19:13:48 schrieb Sandro Andrade:
> > Great, as soft message freeze occurs only at 19th May I suppose I should
> > do the review corrections first and then announce it in its final
> > location (kdeplasma-addons)
> > instead of in kdereview, right ?
> 
> No.

Agreed, the fact that you forgot about the freeze is not an excuse at all to 
bypass the kdereview stage.

Albert
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Artur Souza (MoRpHeUz)]

On Wednesday 05 May 2010, 16:30 Albert Astals Cid wrote:
> Agreed, the fact that you forgot about the freeze is not an excuse at all
> to bypass the kdereview stage.

Just to clear the subject a little bit: I think the didn't forget about the 
freeze and is not using it as an excuse if I understood correctly. He is just 
*asking* how to proceed. :)

Cheers,

--
Artur Duque de Souza
openBossa
INdT - Instituto Nokia de Tecnologia
--
Blog: http://blog.morpheuz.cc
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
--


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Display brightness OSD notification and change brightness when Fn keys are unhandled

[Felix Geyer]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1942/
---

(Updated 2010-05-05 20:30:50.097920)


Review request for Plasma and Dario Freddi.


Summary
---

This patch addresses the following issues:
- KDE doesn't provide an OSD notification when the user changes the
display brightness.
- The brightness Fn keys don't have an effect if they aren't handled by
the kernel/hardware.

Implementation overview:
PowerDevil uses a KActionCollection to register the 
Qt::Key_MonBrightnessUp/Down keys
and forwards them to Solid. 
Solid then decides if the brightness should be increased/decreased by comparing 
the
current brightness value with the cached one. The brightness is only changed
if both are equal and the brightness_in_hardware HAL property is false.
This prevents a double increase/decrease of the brightness and is consistent 
with
gnome-power-manager using the HAL backend.
In any case PowerDevil emits the brightnessChanged() dbus signal.
The battery applet listens to that signal and displays an OSD.
It uses an adapted copy of the OSDWidget class from KMix. This is suboptimal 
but KDE
doesn't provide a generic way to show this kind of OSD yet.


Diffs
-

  trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/powermanager.h 1122901 
  trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.h 1122901 
  trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.cpp 1122901 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt 
1122901 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1122901 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 
1122901 
  
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/brightnessosdwidget.h
 PRE-CREATION 
  
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/brightnessosdwidget.cpp
 PRE-CREATION 
  trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.h 1122901 
  trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.cpp 1122901 
  trunk/KDE/kdebase/workspace/powerdevil/daemon/org.kde.PowerDevil.xml 1122901 
  trunk/KDE/kdebase/workspace/solid/hal/halpower.h 1122901 
  trunk/KDE/kdebase/workspace/solid/hal/halpower.cpp 1122901 

Diff: http://reviewboard.kde.org/r/1942/diff


Testing
---

This patch in a slightly different implementation (some code moved from 
PowerDevil to Solid)
is being shipped with Kubuntu Karmic and Lucid and I think Fedora. I haven't 
seen any bug reports
concering the OSD or incorrect brightness changes.

Apart from that I tested the changes on my laptop and have verified that the 
code correctly
respects the HAL property.


Thanks,

Felix

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Display brightness OSD notification and change brightness when Fn keys are unhandled

[Felix Geyer]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1942/
---

(Updated 2010-05-05 20:58:51.762208)


Review request for Plasma and Dario Freddi.


Summary
---

This patch addresses the following issues:
- KDE doesn't provide an OSD notification when the user changes the
display brightness.
- The brightness Fn keys don't have an effect if they aren't handled by
the kernel/hardware.

Implementation overview:
PowerDevil uses a KActionCollection to register the 
Qt::Key_MonBrightnessUp/Down keys
and forwards them to Solid. 
Solid then decides if the brightness should be increased/decreased by comparing 
the
current brightness value with the cached one. The brightness is only changed
if both are equal and the brightness_in_hardware HAL property is false.
This prevents a double increase/decrease of the brightness and is consistent 
with
gnome-power-manager using the HAL backend.
In any case PowerDevil emits the brightnessChanged() dbus signal.
The battery applet listens to that signal and displays an OSD.
It uses an adapted copy of the OSDWidget class from KMix. This is suboptimal 
but KDE
doesn't provide a generic way to show this kind of OSD yet.


This addresses bugs 182400 and 187960.
https://bugs.kde.org/show_bug.cgi?id=182400
https://bugs.kde.org/show_bug.cgi?id=187960


Diffs
-

  trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/powermanager.h 1122901 
  trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.h 1122901 
  trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.cpp 1122901 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt 
1122901 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1122901 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 
1122901 
  
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/brightnessosdwidget.h
 PRE-CREATION 
  
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/brightnessosdwidget.cpp
 PRE-CREATION 
  trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.h 1122901 
  trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.cpp 1122901 
  trunk/KDE/kdebase/workspace/powerdevil/daemon/org.kde.PowerDevil.xml 1122901 
  trunk/KDE/kdebase/workspace/solid/hal/halpower.h 1122901 
  trunk/KDE/kdebase/workspace/solid/hal/halpower.cpp 1122901 

Diff: http://reviewboard.kde.org/r/1942/diff


Testing
---

This patch in a slightly different implementation (some code moved from 
PowerDevil to Solid)
is being shipped with Kubuntu Karmic and Lucid and I think Fedora. I haven't 
seen any bug reports
concering the OSD or incorrect brightness changes.

Apart from that I tested the changes on my laptop and have verified that the 
code correctly
respects the HAL property.


Thanks,

Felix

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE Observatory moved to kdereview

[Sandro Andrade]

On Wed, May 5, 2010 at 5:01 PM, Artur Souza (MoRpHeUz)
 wrote:
> On Wednesday 05 May 2010, 16:30 Albert Astals Cid wrote:
>> Agreed, the fact that you forgot about the freeze is not an excuse at all
>> to bypass the kdereview stage.
>
> Just to clear the subject a little bit: I think the didn't forget about the
> freeze and is not using it as an excuse if I understood correctly. He is just
> *asking* how to proceed. :)

Yes, it's clear for me now the reasons for announce. I'm doing this
now in kde-core-devel
and fixing the i18n issues.

Thanks,
Sandro

>
> Cheers,
>
> --
> Artur Duque de Souza
> openBossa
> INdT - Instituto Nokia de Tecnologia
> --
> Blog: http://blog.morpheuz.cc
> PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
> --
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel