Review Request: Fix wetter.com Ion
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5024/ --- Review request for Plasma and Shawn Starr. Summary --- Since 4.5 the wetter.com Ion is broken which means no useful weather information for our German userbase :-( I tracked it down to http://websvn.kde.org/?view=revisionrevision=1072253 which was applied for 4.5, but never for 4.4. Given the referrenced bug report it should have never worked in 4.4, but it did. Reverting this commit, fixes the ion again. So I ask to revert the offending commit in both trunk and branch. And I promise to investigate weather issues the next time when I notice that it is broken and not after the release :-) In general I think it might be an idea to move the API information into the desktop file instead of constants in the header. Diffs - branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/weather/ions/wetter.com/ion_wettercom.h 1157322 Diff: http://reviewboard.kde.org/r/5024/diff Testing --- Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix wetter.com Ion
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5024/#review7051 --- Ship it! i guess an api key worked at some point then was revoked? if with that other key it works, ship it - Marco On 2010-08-14 07:26:19, Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5024/ --- (Updated 2010-08-14 07:26:19) Review request for Plasma and Shawn Starr. Summary --- Since 4.5 the wetter.com Ion is broken which means no useful weather information for our German userbase :-( I tracked it down to http://websvn.kde.org/?view=revisionrevision=1072253 which was applied for 4.5, but never for 4.4. Given the referrenced bug report it should have never worked in 4.4, but it did. Reverting this commit, fixes the ion again. So I ask to revert the offending commit in both trunk and branch. And I promise to investigate weather issues the next time when I notice that it is broken and not after the release :-) In general I think it might be an idea to move the API information into the desktop file instead of constants in the header. Diffs - branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/weather/ions/wetter.com/ion_wettercom.h 1157322 Diff: http://reviewboard.kde.org/r/5024/diff Testing --- Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review request: New share dataengine for plasma
Hello!! On Sun, Aug 1, 2010 at 6:16 PM, Aaron J. Seigo ase...@kde.org wrote: does this mean we should be thinking about a move to kdebase with the other general interest dataengines? Today I finished doing all the fixes that were recommended and also tested all the backends. With today's commits I think that this dataengine is ready to be moved from kdereview to either kdeplasma-addons or kdebase (as the 2 weeks period in kdereview was also reached). So I'm just waiting Aaron's ok to actually move it (and also where it would be better to go, kdebase or kdeplasma-addons) and start porting the current pastebin applet to the new engine. After that I think it comes the GHNS integration step. Cheers and thanks for all the useful feedback and *much appreciated* help and review of the engine :) Artur ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Game of Life Plasmoid -- Cleanup and reflection/density feature addition
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5027/ --- Review request for Plasma. Summary --- This patch fixes a bug wherein the very last cell in the board would never come alive. Also, the configuration UI was updated so that using tab to scroll through options would be consistent (top to bottom.) The patch also adds to new features: game board reflection (the user can choose to generate initial populations that are symmetrical about the horizontal and/or vertical axes,) and user-configurable population density (the user can choose what approximate percentage of cells will be alive in the initial population.) Diffs - /trunk/KDE/kdeplasma-addons/applets/life/life.h 1163310 /trunk/KDE/kdeplasma-addons/applets/life/life.cpp 1163310 /trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui 1163310 Diff: http://reviewboard.kde.org/r/5027/diff Testing --- Various game board sizes were tested (odd and even heights and widths, square and non-square.) The configuration dialog was opened several times and tested to confirm tab order. Various population densities were tested, including 0% (confirmed no cells were alive) and 100% (confirmed that all cells were alive.) All combinations of vertical/horizontal/no reflection were tested at odd and even heights and widths, square and non-square. Tests consisted of setting the proper configuration options, then watching the board for a few generations and confirming that no crashes occurred and that all cells appeared to live and die properly. Screenshots --- Updated Configuration Dialog http://reviewboard.kde.org/r/5027/s/481/ Board Using Vertical and Horizontal Reflection http://reviewboard.kde.org/r/5027/s/482/ Thanks, obby ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
