Re: kdereview: adjustable clock
On 24-08-2010 at 23:02:15 Aaron J. Seigo ase...@kde.org wrote: On Tuesday, August 24, 2010, Emdek wrote: What specifically doesn't work properly? if i use the pre-built mode with the reflections in a panel of ~27px high, it doesn't fit. Well, that format was added mostly to use on desktop (reflections on panels won't look nice anyway), but I can modify it to fit when I'll have some free time. -- Best regards, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kdereview: adjustable clock
On Wednesday 25 August 2010 13:16:17 Emdek wrote: On 24-08-2010 at 23:02:15 Aaron J. Seigo ase...@kde.org wrote: On Tuesday, August 24, 2010, Emdek wrote: What specifically doesn't work properly? if i use the pre-built mode with the reflections in a panel of ~27px high, it doesn't fit. Well, that format was added mostly to use on desktop (reflections on panels won't look nice anyway), but I can modify it to fit when I'll have some free time. Or just switch off reflections when in non-Planar mode? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kdereview: adjustable clock
On 25-08-2010 at 13:30:49 Sebastian Kügler se...@kde.org wrote: On Wednesday 25 August 2010 13:16:17 Emdek wrote: On 24-08-2010 at 23:02:15 Aaron J. Seigo ase...@kde.org wrote: On Tuesday, August 24, 2010, Emdek wrote: What specifically doesn't work properly? if i use the pre-built mode with the reflections in a panel of ~27px high, it doesn't fit. Well, that format was added mostly to use on desktop (reflections on panels won't look nice anyway), but I can modify it to fit when I'll have some free time. Or just switch off reflections when in non-Planar mode? Switching off parts of code is bad idea, we should not force user to not use something if we don't know how he want to use it. Besides there is already version of this format without reflection. ;-) To fix reflection it should be enough to set fixed height or something similar, pure CSS and HTML (well, with some WebKit's additions). Fixed height is OK to use because contents are always scaled to fit. -- Best regards, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kdereview: adjustable clock
On Wednesday 25 August 2010, Emdek wrote: On 25-08-2010 at 13:30:49 Sebastian Kügler se...@kde.org wrote: On Wednesday 25 August 2010 13:16:17 Emdek wrote: On 24-08-2010 at 23:02:15 Aaron J. Seigo ase...@kde.org wrote: On Tuesday, August 24, 2010, Emdek wrote: What specifically doesn't work properly? if i use the pre-built mode with the reflections in a panel of ~27px high, it doesn't fit. Well, that format was added mostly to use on desktop (reflections on panels won't look nice anyway), but I can modify it to fit when I'll have some free time. Or just switch off reflections when in non-Planar mode? Switching off parts of code is bad idea, we should not force user to not use something if we don't know how he want to use it. Besides there is already version of this format without reflection. ;-) To fix reflection it should be enough to set fixed height or something similar, pure CSS and HTML (well, with some WebKit's additions). Fixed height is OK to use because contents are always scaled to fit. or enable/disable reflections on resize constraint events based on the size, but regardless where the plasmoid is designed to belong, to be distributed in the KDE release it must work reasonably well on all containments present in the KDE release. /me thinkssome policies about that should be written down somewhere... Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kdereview: adjustable clock
On 25-08-2010 at 13:47:11 Marco Martin notm...@gmail.com wrote: On Wednesday 25 August 2010, Emdek wrote: On 25-08-2010 at 13:30:49 Sebastian Kügler se...@kde.org wrote: On Wednesday 25 August 2010 13:16:17 Emdek wrote: On 24-08-2010 at 23:02:15 Aaron J. Seigo ase...@kde.org wrote: On Tuesday, August 24, 2010, Emdek wrote: What specifically doesn't work properly? if i use the pre-built mode with the reflections in a panel of ~27px high, it doesn't fit. Well, that format was added mostly to use on desktop (reflections on panels won't look nice anyway), but I can modify it to fit when I'll have some free time. Or just switch off reflections when in non-Planar mode? Switching off parts of code is bad idea, we should not force user to not use something if we don't know how he want to use it. Besides there is already version of this format without reflection. ;-) To fix reflection it should be enough to set fixed height or something similar, pure CSS and HTML (well, with some WebKit's additions). Fixed height is OK to use because contents are always scaled to fit. or enable/disable reflections on resize constraint events based on the size, but regardless where the plasmoid is designed to belong, to be distributed in the KDE release it must work reasonably well on all containments present in the KDE release. Sure, but I still prefer to simply modify that format (which is also simply easier) than adding not needed tricks which can later backfire. ;-) /me thinkssome policies about that should be written down somewhere... Yeah, good idea, but where? -- Best regards, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kdereview: adjustable clock
On Wednesday, August 25, 2010, Emdek wrote: /me thinkssome policies about that should be written down somewhere... Yeah, good idea, but where? community.kde.org/Plasma is a good place to start them. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Launcher support for libtaskmanager
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-08-25 17:59:38.336993) Review request for Plasma. Changes --- Changes as suggested by Aaron. Summary --- Adds support for Windows 7 like launchers in libtaskmanager. (I'm on holliday from 12th July until 1st August so I will not be able to reply during this time.) Diffs (updated) - /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/kustodiangroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1166310 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1166310 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1166310 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.cpp 1148442 Diff: http://reviewboard.kde.org/r/4585/diff Testing (updated) --- Tested with a small test-applett and everything works. Edit: In GroupManagerPrivate::removeTask(TaskPtr task) the method task-classClass()(l.326) returns an empty string (in GroupManagerPrivate::addTask(TaskPtr task) the method item-task()-classClass()(l.289) works just fine), so Launchers don't get showed again after quitting the application. Thanks, Anton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Launcher support for libtaskmanager
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review7215 --- Ship it! looks good :) let's get this into svn and then see about adding support to the tasks widget for launchers. - Aaron On 2010-08-25 18:12:01, Anton Kreuzkamp wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-08-25 18:12:01) Review request for Plasma. Summary --- Adds support for Windows 7 like launchers in libtaskmanager. (I'm on holliday from 12th July until 1st August so I will not be able to reply during this time.) Diffs - /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/kustodiangroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1166310 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1166310 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1166310 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.cpp 1148442 Diff: http://reviewboard.kde.org/r/4585/diff Testing --- Tested with a small test-applett and everything works. Edit: In GroupManagerPrivate::removeTask(TaskPtr task) the method task-classClass()(l.326) returns an empty string (in GroupManagerPrivate::addTask(TaskPtr task) the method item-task()-classClass()(l.289) works just fine), so Launchers don't get showed again after quitting the application. Thanks, Anton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
