configChanged coverage for 4.6
hi all... as you can see here: http://community.kde.org/Plasma/Tasks#Plasmoids we have a large number of plasmoids in kdeplasma-addons that do not have configChanged() implementations, meaning they will not work nicely in plasmoidviewer anymore and they will not work well with the Plasma Desktop Scripting. i'd like to set out a small challenge for us for 4.6: All applets we ship that have any configuration will implement configChanged() i just knocked off one of the more hairy ones, microblogging, but most of the remaining ones are probably fairly simple. if you take one of the applets on, remove them from the list on the wiki page linked above. we can do this! :) for those who have no idea what i'm babbling on about: configChanged() is where all configuration reading should happen. many applets implement this in both init() (or elsewhere, e.g. in graphicsWidget() as the microblog plasmoid was doing) as well as in a slot connected to the configuration dialog. that code needs to put into a public slot with the signature "void configChanged()". this method is called when configuration changes are made, such as after the configuration dialog has gone away or the user runs a script that modifies the applet settings. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: New Applet handle system
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5155/ --- (Updated 2010-09-04 17:44:10.408413) Review request for Plasma. Changes --- we get notifications via the plasma group; no point in getting everything twice. Summary --- This is a rewamp of the Applet handle system. Through its modular architecture it easily allows modifications and reuse of code. It features a base Handle class, AbstractHandle, and a base class for the control elements, ControlElement. I developed an handle based on the actual AppletHandle, DesktopHandle, and the control elements for the usual operations. Diffs - trunk/KDE/kdelibs/plasma/CMakeLists.txt 1171409 trunk/KDE/kdelibs/plasma/applet.h 1171409 trunk/KDE/kdelibs/plasma/applet.cpp 1171409 trunk/KDE/kdelibs/plasma/containment.h 1171409 trunk/KDE/kdelibs/plasma/containment.cpp 1171409 trunk/KDE/kdelibs/plasma/extenders/extender.cpp 1171409 trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1171409 trunk/KDE/kdelibs/plasma/handles/abstracthandle.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/abstracthandle.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/abstractcontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/abstractcontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/abstractcontrol_p.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/configurecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/configurecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/maximizecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/maximizecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/movecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/movecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/removecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/removecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/resizecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/resizecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/rotatecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/rotatecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/desktophandle.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/desktophandle.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/private/applet_p.h 1171409 trunk/KDE/kdelibs/plasma/private/applethandle.cpp 1171409 trunk/KDE/kdelibs/plasma/private/applethandle_p.h 1171409 trunk/KDE/kdelibs/plasma/private/containment_p.h 1171409 Diff: http://svn.reviewboard.kde.org/r/5155/diff Testing --- It isn't finished. It's missing the touch events management (which, however, it's hard for me to do, 'cause i don't have any touch screen device) and a better drag and drop system between containments. I'd like, however, to know what you think about what i've done, especially about the architecture. What's here works, though. Thanks, Giulio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: New Applet handle system
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5155/ --- (Updated 2010-09-04 13:28:40.568518) Review request for Plasma, Aaron Seigo and Marco Martin. Changes --- addressed the issues raised by Aaron. Most of the work has gone to decoupling AbstractHandle and AbstractControl. AbstractHandle is still a friend of AbstractControl because the event handlers are protected. I don't think it's a big deal since it isn't bic to change the friend declarations, however. Summary --- This is a rewamp of the Applet handle system. Through its modular architecture it easily allows modifications and reuse of code. It features a base Handle class, AbstractHandle, and a base class for the control elements, ControlElement. I developed an handle based on the actual AppletHandle, DesktopHandle, and the control elements for the usual operations. Diffs (updated) - trunk/KDE/kdelibs/plasma/CMakeLists.txt 1171409 trunk/KDE/kdelibs/plasma/applet.h 1171409 trunk/KDE/kdelibs/plasma/applet.cpp 1171409 trunk/KDE/kdelibs/plasma/containment.h 1171409 trunk/KDE/kdelibs/plasma/containment.cpp 1171409 trunk/KDE/kdelibs/plasma/extenders/extender.cpp 1171409 trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1171409 trunk/KDE/kdelibs/plasma/handles/abstracthandle.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/abstracthandle.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/abstractcontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/abstractcontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/abstractcontrol_p.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/configurecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/configurecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/maximizecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/maximizecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/movecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/movecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/removecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/removecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/resizecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/resizecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/rotatecontrol.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/controlelements/rotatecontrol.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/handles/desktophandle.h PRE-CREATION trunk/KDE/kdelibs/plasma/handles/desktophandle.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/private/applet_p.h 1171409 trunk/KDE/kdelibs/plasma/private/applethandle.cpp 1171409 trunk/KDE/kdelibs/plasma/private/applethandle_p.h 1171409 trunk/KDE/kdelibs/plasma/private/containment_p.h 1171409 Diff: http://svn.reviewboard.kde.org/r/5155/diff Testing --- It isn't finished. It's missing the touch events management (which, however, it's hard for me to do, 'cause i don't have any touch screen device) and a better drag and drop system between containments. I'd like, however, to know what you think about what i've done, especially about the architecture. What's here works, though. Thanks, Giulio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
