Loosing Plasma config on every other update

2010-10-14 Thread Sebastian Trüg
Hi guys,

running on trunk I loose my Plasma configuration  on every other svn
update. The only exception is the main panel which remains. All the rest
is back to defaults or worse - by worse I mean that I end up with no
widgets at all.
So my only questions are: is this a known problem? Is this simply due to
the fact that I run trunk? Can I do anything against it? Can I maybe
recover the old config?

Thanks a lot,
Sebastian
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Loosing Plasma config on every other update

2010-10-14 Thread Aaron J. Seigo
On Thursday, October 14, 2010, Sebastian Trüg wrote:
 running on trunk I loose my Plasma configuration  on every other svn
 update. The only exception is the main panel which remains. All the rest
 is back to defaults or worse - by worse I mean that I end up with no
 widgets at all.

let me guess: if you pull up the activities manager (meta-q or via the toolbox 
or context menu on the desktop) you see a whole ton of activities? or at least 
one with your widgets on them?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Loosing Plasma config on every other update

2010-10-14 Thread Sebastian Trüg
nope, not a single activity there.

On 10/14/2010 09:38 AM, Aaron J. Seigo wrote:
 On Thursday, October 14, 2010, Sebastian Trüg wrote:
 running on trunk I loose my Plasma configuration  on every other svn
 update. The only exception is the main panel which remains. All the rest
 is back to defaults or worse - by worse I mean that I end up with no
 widgets at all.
 
 let me guess: if you pull up the activities manager (meta-q or via the 
 toolbox 
 or context menu on the desktop) you see a whole ton of activities? or at 
 least 
 one with your widgets on them?
 
 
 
 
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Loosing Plasma config on every other update

2010-10-14 Thread Sebastian Trüg
nevermind, kded was not running.

On 10/14/2010 09:38 AM, Aaron J. Seigo wrote:
 On Thursday, October 14, 2010, Sebastian Trüg wrote:
 running on trunk I loose my Plasma configuration  on every other svn
 update. The only exception is the main panel which remains. All the rest
 is back to defaults or worse - by worse I mean that I end up with no
 widgets at all.
 
 let me guess: if you pull up the activities manager (meta-q or via the 
 toolbox 
 or context menu on the desktop) you see a whole ton of activities? or at 
 least 
 one with your widgets on them?
 
 
 
 
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


KDE/kdelibs/plasma

2010-10-14 Thread Aaron J . Seigo
SVN commit 1185856 by aseigo:

handle the caching case in setImagePath properly; this is a significant 
increase in complexity in this rather fundamental method. in combination with 
the change in Svg::setImagePath to call FrameSvg::setImagePath directly (due to 
an API wart i only today noticed), this has the potential to cause new issues, 
though it is running quite nicely on my system. needs extensive testing, but 
should also hopefully take care of the remaining crash being seen related to 
the FrameData cache
CCMAIL:plasma-devel@kde.org


 M  +50 -6 framesvg.cpp  
 M  +1 -0  svg.h  


--- trunk/KDE/kdelibs/plasma/framesvg.cpp #1185855:1185856
@@ -1,6 +1,6 @@
 /*
- *   Copyright 2008 by Aaron Seigo ase...@kde.org
- *   Copyright 2008 Marco Martin notm...@gmail.com
+ *   Copyright 2008-2010 by Aaron Seigo ase...@kde.org
+ *   Copyright 2008-2010 Marco Martin notm...@gmail.com
  *
  *   This program is free software; you can redistribute it and/or modify
  *   it under the terms of the GNU Library General Public License as
@@ -32,8 +32,9 @@
 
 #include kdebug.h
 
-#include plasma/theme.h
-#include plasma/applet.h
+#include applet.h
+#include theme.h
+#include private/svg_p.h
 
 namespace Plasma
 {
@@ -64,12 +65,55 @@
 return;
 }
 
-Svg::setImagePath(path);
+bool updateNeeded = true;
+clearCache();
+
+FrameData *fd = d-frames[d-prefix];
+if (fd-refcount() == 1) {
+// we're the only user of it, let's remove it from the shared keys
+// we don't want to deref it, however, as we'll still be using it
+const QString oldKey = d-cacheId(fd, d-prefix);
+FrameSvgPrivate::s_sharedFrames.remove(oldKey);
+} else {
+// others are using this frame, so deref it for ourselves
+fd-deref(this);
+fd = 0;
+}
+
+Svg::d-setImagePath(path);
+
+if (!fd) {
+// we need to replace our frame, start by looking in the frame cache
+const QString key = d-cacheId(fd, d-prefix);
+fd = FrameSvgPrivate::s_sharedFrames.value(key);
+
+if (fd) {
+// we found one, so ref it and use it; we also don't need to (or 
want to!)
+// trigger a full update of the frame since it is already the one 
we want
+// and likely already rendered just fine
+fd-ref(this);
+updateNeeded = false;
+} else {
+// nothing exists for us in the cache, so create a new FrameData 
based
+// on the old one
+fd = new FrameData(*d-frames[d-prefix], this);
+}
+
+d-frames.insert(d-prefix, fd);
+}
+
 setContainsMultipleImages(true);
+if (updateNeeded) {
+// ensure our frame is in the cache
+const QString key = d-cacheId(fd, d-prefix);
+FrameSvgPrivate::s_sharedFrames.insert(key, fd);
 
-clearCache();
+// this will emit repaintNeeded() as well when it is done
 d-updateAndSignalSizes();
+} else {
+emit repaintNeeded();
 }
+}
 
 void FrameSvg::setEnabledBorders(const EnabledBorders borders)
 {
--- trunk/KDE/kdelibs/plasma/svg.h #1185855:1185856
@@ -264,6 +264,7 @@
 
 friend class SvgPrivate;
 friend class FrameSvgPrivate;
+friend class FrameSvg;
 };
 
 } // Plasma namespace
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma.ToolTipManager and Plasma.Applet

2010-10-14 Thread Aaron J. Seigo
On Thursday, October 14, 2010, Thomas Olsen wrote:
 TypeError: ToolTipManager.setContent(): argument 1 has unexpected type
 'PyPopupApplet' and the plasmoidviewer crashes.
 
 Have I again misunderstood something or should I file a bugreport against
 the python bindings?

it looks bindings related, yes. your code looks right in the sense that it is 
how it is done in C++ and that should map to Python usage.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma.ToolTipManager and Plasma.Applet

2010-10-14 Thread Luca Beltrame
In data giovedì 14 ottobre 2010 13:17:35, Thomas Olsen ha scritto:
 Plasma.ToolTipManager.self().setContent(self, data)

As far as I can remember, you need to use self.applet instead of self when 
applying something to the applet. I'm not sure it will work, but worth trying.

This should be likely documented somewhere...


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma.ToolTipManager and Plasma.Applet

2010-10-14 Thread Luca Beltrame
In data giovedì 14 ottobre 2010 13:17:35, Thomas Olsen ha scritto:

 Plasma.ToolTipManager.self().setContent(self, data)

Extra reply because I think I wasn't clear enough. Instead of the quoted  
statement, try using:

Plasma.ToolTipManager.self().setContent(self.applet, data)

I think someone stumbled upon this on IRC a while ago and I helped him out: 
from memory, this was the suggestion.


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Bug 254092

2010-10-14 Thread Hans-Rudi Denzler
Does not work anymore.
-- 
Freundliche Grüsse
Hans-Ruedi Denzler
hr.denz...@bluewin.ch
attachment: Bug 254092.png___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bug 254092

2010-10-14 Thread Aaron J. Seigo
On Thursday, October 14, 2010, Hans-Rudi Denzler wrote:
 Does not work anymore.

sorry, what?

the dictionary widget doesn't work for you anymore? in which way? can you file 
a bug report on bugs.kde.org about it? thanks.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bug 254092

2010-10-14 Thread Sebastian Kügler
Hi Hans-Rudi,

On Thursday, October 14, 2010 14:55:48 Hans-Rudi Denzler wrote:
 Does not work anymore.

That's not quite enough information to make sense of your email (though your 
report is appreciated!). Can you file a new bug report on bugs.kde.org, so 
this issue can be taken care of?

It would be necessary though to specify *what* exactly doesn't work, what 
versions you're running, and possibly other observations.

Thanks for the feedback already,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bug 254092

2010-10-14 Thread Anne-Marie Mahfouf
On jeudi 14 octobre 2010 14:55:48 Hans-Rudi Denzler wrote:
 Does not work anymore.
The website www.dict.org is down, that's why.

Anne-Marie
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bug 254092

2010-10-14 Thread Asraniel
You have sent your mail by accident to plasma-devel@kde.org
but i have seen you already correctly attached the file to 
http://bugs.kde.org/show_bug.cgi?id=254092

to the others, there is a bugreport, the discussion should be continued there

Am Donnerstag 14 Oktober 2010, um 14.55:48 schrieb Hans-Rudi Denzler:
 Does not work anymore.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Bugs and aktivities

2010-10-14 Thread Mario Fux
Morning

I try to read kde-commits for several projects and after Ivan blogged about 
his most simple patch I tried to find the commit in the mailinglist (strange 
person me, I know). I found it and 2 hours later Aaron sent a patch which IMHO 
could reintroduce the bug, probably.
Ivan: 
--- trunk/KDE/kdelibs/plasma/theme.cpp #1183401:1183402
@@ -666,7 +666,7 @@
 }
 
 // try a compressed svg file in the fallback theme
-path = d-findInTheme(svgzName % QLatin1Char('z'), d-
fallbackThemes[i]);
+path = d-findInTheme(svgName % QLatin1Char('z'), d-
fallbackThemes[i]);
 
 if (path.isEmpty()) {
 // try an uncompressed svg file in the fallback theme

Aaron:
--- trunk/KDE/kdelibs/plasma/theme.cpp #1183474:1183475
@@ -666,7 +666,7 @@
 }
 
 // try a compressed svg file in the fallback theme
-path = d-findInTheme(svgName % QLatin1Char('z'), d-
fallbackThemes[i]);
+path = d-findInTheme(svgzName, d-fallbackThemes[i]);
 
 if (path.isEmpty()) {
 // try an uncompressed svg file in the fallback theme

Am I right or just to naive and still need to learn a lot about programming. I 
did not read the code of these files but just the two patches. I saw the z 
reappearing in Aarons patch which Ivan removed.

Anyway. Thx for patience. Here my other topic: Activities.

Aaron wrote a blog post about activities in KDE and Gnome (which btw already 
has an article on the german pro-linux.de :-). There severel proposed to 
include some default activities.

First I thought: Nice idea, but an activity is more than starting some 
applications. But then the idea convinced me in another area: KDE software 
promotion.

By providing some activities new users get a showcase of our applications in 
different task. E.g. the default Photo management activity opens Digikam (if 
installed of course) and Gwenview, the default Development activity opens 
Kdevelop, Kwrite/Kate and Konsole, the default Multimedia activity opens 
Dragon player, Amarok and Kccd (later PMC ;-).

Another purpose for this default activity are excibition booths and staff and 
new users get informed about this new concept in an easy way as they can 
just start and stop different default activities and see the effect: learning 
by doing.

griits
Mario
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bugs and aktivities

2010-10-14 Thread Aaron J. Seigo
On Thursday, October 14, 2010, Mario Fux wrote:
 I try to read kde-commits for several projects 

cool :)

 +path = d-findInTheme(svgName % QLatin1Char('z'), d-

 +path = d-findInTheme(svgzName, d-fallbackThemes[i]);

these two lines are equivalent. svgzName is svgName + 'z'.

 Aaron wrote a blog post about activities in KDE and Gnome (which btw
 already has an article on the german pro-linux.de :-). There severel
 proposed to include some default activities.

this could make sense ...

of course, the question would be what should the default activities be.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bugs and aktivities

2010-10-14 Thread Ivan Cukic

 Am I right or just to naive and still need to learn a lot about programming. 
 I 
 did not read the code of these files but just the two patches. I saw the z 
 reappearing in Aarons patch which Ivan removed.

Heh, in the beginning, there were two 'z's:

path = d-findInTheme(svgzName % QLatin1Char('z'), d-fallbackThemes[i]);

And I removed the first 'z'

path = d-findInTheme(svgName % QLatin1Char('z'), d-fallbackThemes[i]);

forgetting that there is a variable for that which Aaron fixed

path = d-findInTheme(svgzName, d-fallbackThemes[i]);

Although, if I saw this, the patch wouldn't be as magnificent :)


Cheerio,
Ivan


-- 
Before you talk to me, I should warn you: I am kind of strange

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel