Re: Plasma themes set in kdeartwork
On 11/26/10, Aaron J. Seigo wrote: > On Friday, November 26, 2010, Ivan Cukic wrote: >> Aaron's stance some time ago was that we shouldn't remove them because it >> would mean problems for users of those themes. > > this has changed a bit since then as we now have a nice working fallback > system for themes that i actually have confidence in. if they are truly > unmaintained and aren't keeping pace with the (recently slower, thankfully) > pace of change in Themes, then i now think we should eject them and replace > them with some of the very nice themes that are being maintained and are > exciting and elegant. +1, we could look on the top-something of kdelook and put the ones that we like more Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma themes set in kdeartwork
Ok, since you've agreed and forgot to include kdeartists list into the discussion, I'll send them a nudge to make some kind of jury (Nuno, me, and possibly someone else). Anybody from plasma interested in judging? -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma themes set in kdeartwork
Ok, plasma ppl agreed on replacing the unmaintained ones: Clean-Blend Elegance Silicon heron Nuno and myself are volunteering to choose the replacements. Is anybody else willing to join us? If we want to change them for 4.6, we have until 20. 12. (hard message and artwork freeze) Cheerio, Ivan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Using Plasma::Svg outside of Plasma
Hey, as you all know, Plasma::Svg is not only used by Plasma itself but by external apps like aurorae too. While this works pretty well in most cases it still uses Plasma::Theme which can lead to annoying behavior. For example if the SVG want to use the current colorscheme. In this case the colors from Plasma's theme are applied which might not be what the author wanted. I was pointed to this by a guy who wanted to use the new feature for 4.6 'current-color-scheme'. This feature uses Plasma::Theme::styleSheet() internally. So my first idea was to provide a function that allows to pass an other styleSheet to the SVG. While this would work for this case it wouldn't work if the SVG would use 'hin-apply-color-scheme'. So the probably better way is, to provide a special Plasma::Theme which uses system colors. One can archive this today by passing Aya to the used SVG. But it is not guaranteed that this theme is installed. So a generic theme that is usable on any installation would be better. What do you think? Should not be too hard to implement and would give way more possibilities to designers. Cheers, Manuel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Supports KDE3 way of starting man/info-pages
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5985/ --- Review request for Plasma and Teemu Rytilahti. Summary --- Supports KDE3 of starting man-pages (#term) and info-pages (##term). This is way faster than typing "man:" or "info:". BUG:200556 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp 1200935 Diff: http://svn.reviewboard.kde.org/r/5985/diff Testing --- Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Using Plasma::Svg outside of Plasma
On Saturday, November 27, 2010, Manuel Mommertz wrote: > as you all know, Plasma::Svg is not only used by Plasma itself but by > external apps like aurorae too. While this works pretty well in most cases > it still uses Plasma::Theme which can lead to annoying behavior. For > example if the SVG want to use the current colorscheme. In this case the > colors from Plasma's theme are applied which might not be what the author > wanted. so that i understand the use case correctly: using Plasma::Svg with a SVG file that is not in the theme, the theme's color scheme is applied? if so, that's a bug, and easily fixed (by not applying the colors to SVGs that are !d->themed). if that isn't what is happening, can you explain the use case in more detail? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Supports KDE3 way of starting man/info-pages
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5985/#review9008 --- Ship it! the logic looks fine, but calling it "kde3Shortcut" is not a great name. it implies knowing what kde3 was doing and doesn't actually describe what the code is attempting to do at all (man/info lookups). please replace it with a descriptive name before committing. - Aaron On 2010-11-27 16:57:02, Matthias Fuchs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5985/ > --- > > (Updated 2010-11-27 16:57:02) > > > Review request for Plasma and Teemu Rytilahti. > > > Summary > --- > > Supports KDE3 of starting man-pages (#term) and info-pages (##term). > This is way faster than typing "man:" or "info:". > BUG:200556 > > > Diffs > - > > > /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp > 1200935 > > Diff: http://svn.reviewboard.kde.org/r/5985/diff > > > Testing > --- > > > Thanks, > > Matthias > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Using Plasma::Svg outside of Plasma
On Saturday 27 November 2010 19:33:13 Aaron J. Seigo wrote: > using Plasma::Svg with a SVG file that is not in the theme, the theme's > color scheme is applied? exactly > if so, that's a bug, and easily fixed (by not applying the colors to SVGs > that are !d->themed). Way better then my idea. But we still need the stylesheet from Plasma::Theme but with colors from the system. Any idea how to archive this? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fixes QuickSand scrolling animation
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5988/ --- Review request for Plasma. Summary --- If an animation is already running finish it before starting a new one. BUG:209485 Diffs - /trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview.h 1201458 /trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview.cpp 1201458 Diff: http://svn.reviewboard.kde.org/r/5988/diff Testing --- Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KRunner Crash BuG:207592
Hi, I was looking at that bug and I am not sure if we should try to fix this. If we would though I would see two ways: 1. do not call save in KBookmarkManager::parse() -- not sure what the consequences would be 2. adding a method to KBookmarkManager to disable the dialog Personally I don't like any of those as it would mean to add code for a very rare case. Maybe another option would be to use KNotification instead, no clue if that would crash. What do you think? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
