Review Request: Allows umlauts and other non-ASCII symbols in the locations runner for URLs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6042/ --- Review request for Plasma and Aaron Seigo. Summary --- Allows a wider range of urls without a protocol to be accepted, like those containing umlauts etc., queries, or IPV4-Adresses. If no protocol has be defined, then ports aren't supported. BUG:227380 This addresses bug 227380. https://bugs.kde.org/show_bug.cgi?id=227380 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp 1203489 Diff: http://svn.reviewboard.kde.org/r/6042/diff Testing --- Tried with different urls, including the one of the bug report www.hörstreich.de, google.at, 74.125.39.99/search?hl=enbiw=1280bih=891q=kdeaq=faqi=g10aql=oq=gs_rfai= etc. There is one problem though that is unrelated to this patch and did _not_ exist in KDE 4.5.4 If I enter google.at it will display the result that I can go to http://google.at, yet if I add :\d e.g. google.at:8 the result won't be updated as nothing matches, yet the old result still stays. In KDE 4.5.4 the old result would also disappear after a short time. Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Allows umlauts and other non-ASCII symbols in the locations runner for URLs + work again with mailto: etc.
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6042/ --- (Updated 2010-12-04 14:24:09.010483) Review request for Plasma and Aaron Seigo. Changes --- Adds modifications to fix another bug. The fixes would be commited seperately though are combined here for an easier review-process. Summary (updated) --- Allows a wider range of urls without a protocol to be accepted, like those containing umlauts etc., queries, or IPV4-Adresses. If no protocol has be defined, then ports aren't supported. BUG:227380 Correctly handle protocols that are not a NetorkLocation or http, ftp. BUG:228017 This addresses bugs 227380 and 228017. https://bugs.kde.org/show_bug.cgi?id=227380 https://bugs.kde.org/show_bug.cgi?id=228017 Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp 1203489 Diff: http://svn.reviewboard.kde.org/r/6042/diff Testing (updated) --- More Urls: Tried with different urls, including the one of the bug report www.hörstreich.de, google.at, 74.125.39.99/search?hl=enbiw=1280bih=891q=kdeaq=faqi=g10aql=oq=gs_rfai= etc. Problem: There is one problem though that is unrelated to this patch and did _not_ exist in KDE 4.5.4 If I enter google.at it will display the result that I can go to http://google.at, yet if I add :\d e.g. google.at:8 the result won't be updated as nothing matches, yet the old result still stays. In KDE 4.5.4 the old result would also disappear after a short time. Correctly handle Protocls: Tried mailto:ch...@example.com, mailto:info...@example.com?subject=current-issue and ~/kde. Problem: Again this problem existed before this patch. In BUG:167862 there is mentioned, that simply entering a folder name in your $HOME-dir displays the folder, so instead of ~/kde also kde should work. Though this is not the case. Instead when the Nepomuk Desktop Search Runner is activated just inputing kde works, unless it is excluded from indexing. Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Lockout widget: Explain to the user that he must select a button to show
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6041/ --- (Updated 2010-12-04 15:00:02.616078) Review request for Plasma. Changes --- i modified to disable the widget when only one is checked and re enable when more than one are checked. Do we need a string for this ? Summary --- When the user ask to show no buttons in the lockout widget, nothing tell the user that this is not possible, and when he saves the configuration nothing changed in the widget. With this patch, if the user unselect all the checkboxes, he is warned. This addresses bug 256879. https://bugs.kde.org/show_bug.cgi?id=256879 Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 1202613 trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1202613 Diff: http://svn.reviewboard.kde.org/r/6041/diff Testing --- Thanks, Nicolas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Supports bookmarks that have no protocol set.
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6045/ --- Review request for Plasma and Aaron Seigo. Summary --- Supports bookmarks that have no protocol set. BUG:228454 This addresses bug 228454. https://bugs.kde.org/show_bug.cgi?id=228454 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 1203528 Diff: http://svn.reviewboard.kde.org/r/6045/diff Testing --- Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9126 --- The bug is in the Notes code. It you remove lines 412 - 417 from notes.cpp you can see that you can set the text marking correctly on the first letter. I hope the patch was not applied because we don't want to make the code more confusing... - Anne-Marie On 2010-11-28 20:23:45, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/ --- (Updated 2010-11-28 20:23:45) Review request for Plasma and Stephen Kelly. Summary --- Text format of the note can't be changed while the note is empty, so I add a space and I change the text format. This work around is rather stupid but I don't have any nicer idea. Anyway this might be a bug in KRichTextEdit so I add to this review request also steveire. Diffs - trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 Diff: http://svn.reviewboard.kde.org/r/6005/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Allows umlauts and other non-ASCII symbols in the locations runner for URLs + work again with mailto: etc.
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6042/#review9127 --- Ship it! /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp http://svn.reviewboard.kde.org/r/6042/#comment9954 const int - Aaron On 2010-12-04 14:24:09, Matthias Fuchs wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6042/ --- (Updated 2010-12-04 14:24:09) Review request for Plasma and Aaron Seigo. Summary --- Allows a wider range of urls without a protocol to be accepted, like those containing umlauts etc., queries, or IPV4-Adresses. If no protocol has be defined, then ports aren't supported. BUG:227380 Correctly handle protocols that are not a NetorkLocation or http, ftp. BUG:228017 This addresses bugs 227380 and 228017. https://bugs.kde.org/show_bug.cgi?id=227380 https://bugs.kde.org/show_bug.cgi?id=228017 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp 1203489 Diff: http://svn.reviewboard.kde.org/r/6042/diff Testing --- More Urls: Tried with different urls, including the one of the bug report www.hörstreich.de, google.at, 74.125.39.99/search?hl=enbiw=1280bih=891q=kdeaq=faqi=g10aql=oq=gs_rfai= etc. Problem: There is one problem though that is unrelated to this patch and did _not_ exist in KDE 4.5.4 If I enter google.at it will display the result that I can go to http://google.at, yet if I add :\d e.g. google.at:8 the result won't be updated as nothing matches, yet the old result still stays. In KDE 4.5.4 the old result would also disappear after a short time. Correctly handle Protocls: Tried mailto:ch...@example.com, mailto:info...@example.com?subject=current-issue and ~/kde. Problem: Again this problem existed before this patch. In BUG:167862 there is mentioned, that simply entering a folder name in your $HOME-dir displays the folder, so instead of ~/kde also kde should work. Though this is not the case. Instead when the Nepomuk Desktop Search Runner is activated just inputing kde works, unless it is excluded from indexing. Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Supports bookmarks that have no protocol set.
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6045/#review9128 --- Ship it! /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp http://svn.reviewboard.kde.org/r/6045/#comment9955 const int /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp http://svn.reviewboard.kde.org/r/6045/#comment9956 const int - Aaron On 2010-12-04 15:56:49, Matthias Fuchs wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6045/ --- (Updated 2010-12-04 15:56:49) Review request for Plasma and Aaron Seigo. Summary --- Supports bookmarks that have no protocol set. BUG:228454 This addresses bug 228454. https://bugs.kde.org/show_bug.cgi?id=228454 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 1203528 Diff: http://svn.reviewboard.kde.org/r/6045/diff Testing --- Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Lockout widget: Explain to the user that he must select a button to show
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6041/#review9129 --- i think it does need a string to explain, because unless one understands _why_ it is doing such a thing it could appear pretty magical. imho this is something that can wait for 4.7 because, while odd and perhaps even annoying, it doesn't result in any data loss. a simple Select one or more items from the list below string would probably help a lot. my other concern with putting this in without a string is that, with the bug fixed, we will forget to go in and add the string when we're open for string freeze. all imho. - Aaron On 2010-12-04 15:00:02, Nicolas Lécureuil wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6041/ --- (Updated 2010-12-04 15:00:02) Review request for Plasma. Summary --- When the user ask to show no buttons in the lockout widget, nothing tell the user that this is not possible, and when he saves the configuration nothing changed in the widget. With this patch, if the user unselect all the checkboxes, he is warned. This addresses bug 256879. https://bugs.kde.org/show_bug.cgi?id=256879 Diffs - trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 1202613 trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1202613 Diff: http://svn.reviewboard.kde.org/r/6041/diff Testing --- Thanks, Nicolas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Remote Widgets on embedded devices
On Sat, Dec 4, 2010 at 14:46, Marco Martin notm...@gmail.com wrote: On Saturday 04 December 2010, Jeffery MacEachern wrote: I recall there being some talk quite a while ago about work being done on remoting plasmoids wirelessly from embedded devices (say, for kiosks or appliances). Aaron said the project was abandoned, but was there ever any code or information published related to that? Hi, at the moment remote widgets do work, and any device with a working libplasma can run and export them. what was not continued (at least on hold for now) is a lightweight server to export widgets from a device too small to run plasma, but if someone would implement a server with the proper protocol, any plasma shell would work just fine as a client. That's what I was referring to. Is that in Playground somewhere? Thanks, - Jeffery MacEachern Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Perl bindings to plasma
On Tuesday, November 16, 2010, Chris Burel wrote: I've come up with two workarounds so far. One is to use LD_PRELOAD to load libperl.so, which isn't really a solution, but it did work in my test. The other is to modify KPluginFactory to have the option of specifying load hints in the constructor, and then have plasma check for a key in the .desktop file to determine if the symbols from the plugin should be exported. Or maybe there's some other/better way for me to make sure that loading kperlpluginfactory will export the necessary symbols from libperl.so? sorry not replying sooner; i was hoping someone else would speak up who knew more about these things than i. it sounds to me like the KPluginFactory extension may be a good approach. but i'd suggest asking on kde-bindings and kde-core-devel to see if anyone else there has input. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Lockout widget: Explain to the user that he must select a button to show
On 2010-12-04 17:29:39, Aaron Seigo wrote: i think it does need a string to explain, because unless one understands _why_ it is doing such a thing it could appear pretty magical. imho this is something that can wait for 4.7 because, while odd and perhaps even annoying, it doesn't result in any data loss. a simple Select one or more items from the list below string would probably help a lot. my other concern with putting this in without a string is that, with the bug fixed, we will forget to go in and add the string when we're open for string freeze. all imho. i see your point. I will try to fix my page and if you validate i will commit when 4.7 will open. Thanks for your review - Nicolas --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6041/#review9129 --- On 2010-12-04 15:00:02, Nicolas Lécureuil wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6041/ --- (Updated 2010-12-04 15:00:02) Review request for Plasma. Summary --- When the user ask to show no buttons in the lockout widget, nothing tell the user that this is not possible, and when he saves the configuration nothing changed in the widget. With this patch, if the user unselect all the checkboxes, he is warned. This addresses bug 256879. https://bugs.kde.org/show_bug.cgi?id=256879 Diffs - trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 1202613 trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1202613 Diff: http://svn.reviewboard.kde.org/r/6041/diff Testing --- Thanks, Nicolas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
