Re: Review Request: Plasmate:error while trying to open a project

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101141/#review2714
---


This review has been submitted with commit 
fd36d0cfbb066cf2897a664e438b7fa12b81a425 by Aaron Seigo.

- Commit


On April 17, 2011, 9:59 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101141/
> ---
> 
> (Updated April 17, 2011, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> hello,
> 
> while trying to open a project using a dir like this,
> "my_plasmoid/package" you will come across an error.With the patch plasmate 
> is able to open correctly projects,which uses the previous directory.
> 
> Thank you for your time.:)
> 
> 
> Diffs
> -
> 
>   mainwindow.cpp 17dcabd 
> 
> Diff: http://git.reviewboard.kde.org/r/101141/diff
> 
> 
> Testing
> ---
> 
> tested by me.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: load button was disable after i insert some text

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101120/#review2713
---


This review has been submitted with commit 
636408428c5cb5034149a47ab51fd8f0c7ef5fdb by Aaron Seigo.

- Commit


On April 14, 2011, 12:58 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101120/
> ---
> 
> (Updated April 14, 2011, 12:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Hello,
> 
> at the start up page of plasmate,when i enter something at the lable "local 
> folder" the button which loads the context of the "local folder" was 
> disable(grey color).
> 
> 
> Diffs
> -
> 
>   startpage.cpp 9bd3658 
> 
> Diff: http://git.reviewboard.kde.org/r/101120/diff
> 
> 
> Testing
> ---
> 
> I tested by myself
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix resizing of popup applets on panel resizing

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101148/#review2709
---


This review has been submitted with commit 
fb0960361ba6cd83bed3a7f1d977e036e37f5ab3 by David Palacio.

- Commit


On April 17, 2011, 8:49 p.m., David Palacio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101148/
> ---
> 
> (Updated April 17, 2011, 8:49 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Summary
> ---
> 
> Since commit 1ed8e4ca6b53c2338d8da8e616752f0426038961 popup applets as Shelf 
> and Places (kde-look.org) do not resize when the panel resizes.
> This patch ensures the icon is added to the widget layout before the function 
> returns.
> 
> 
> This addresses bug 268104.
> http://bugs.kde.org/show_bug.cgi?id=268104
> 
> 
> Diffs
> -
> 
>   plasma/popupapplet.cpp 9238bd1 
> 
> Diff: http://git.reviewboard.kde.org/r/101148/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:error while trying to open a project

[Giorgos Tsiapaliwkas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101141/
---

(Updated April 17, 2011, 9:59 p.m.)


Review request for Plasma.


Changes
---

I have made the appropriate changes,based on Aaron's review.:)

P.S.:Plasmate compiles fine and haven't notice any regressions.


Summary
---

hello,

while trying to open a project using a dir like this,
"my_plasmoid/package" you will come across an error.With the patch plasmate is 
able to open correctly projects,which uses the previous directory.

Thank you for your time.:)


Diffs (updated)
-

  mainwindow.cpp 17dcabd 

Diff: http://git.reviewboard.kde.org/r/101141/diff


Testing
---

tested by me.


Thanks,

Giorgos

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix resizing of popup applets on panel resizing

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101148/#review2708
---

Ship it!


good catch

- Marco


On April 17, 2011, 8:49 p.m., David Palacio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101148/
> ---
> 
> (Updated April 17, 2011, 8:49 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Summary
> ---
> 
> Since commit 1ed8e4ca6b53c2338d8da8e616752f0426038961 popup applets as Shelf 
> and Places (kde-look.org) do not resize when the panel resizes.
> This patch ensures the icon is added to the widget layout before the function 
> returns.
> 
> 
> This addresses bug 268104.
> http://bugs.kde.org/show_bug.cgi?id=268104
> 
> 
> Diffs
> -
> 
>   plasma/popupapplet.cpp 9238bd1 
> 
> Diff: http://git.reviewboard.kde.org/r/101148/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix resizing of popup applets on panel resizing

[David Palacio]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101148/
---

Review request for Plasma, Aaron J. Seigo and Marco Martin.


Summary
---

Since commit 1ed8e4ca6b53c2338d8da8e616752f0426038961 popup applets as Shelf 
and Places (kde-look.org) do not resize when the panel resizes.
This patch ensures the icon is added to the widget layout before the function 
returns.


This addresses bug 268104.
http://bugs.kde.org/show_bug.cgi?id=268104


Diffs
-

  plasma/popupapplet.cpp 9238bd1 

Diff: http://git.reviewboard.kde.org/r/101148/diff


Testing
---


Thanks,

David

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: load button was disable after i insert some text

[Giorgos Tsiapaliwkas]

> On April 14, 2011, 2:06 p.m., Aaron J. Seigo wrote:
> > nice obvious fix :)
> > 
> > for these kinds of simple, evident fixes, just commit+push and we will see 
> > it in the commit log emails :)

I don't have a git account to do it.Someone has to do it for me :)

thanks Aaron for reviewing my patch.:)


- Giorgos


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101120/#review2649
---


On April 14, 2011, 12:58 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101120/
> ---
> 
> (Updated April 14, 2011, 12:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Hello,
> 
> at the start up page of plasmate,when i enter something at the lable "local 
> folder" the button which loads the context of the "local folder" was 
> disable(grey color).
> 
> 
> Diffs
> -
> 
>   startpage.cpp 9bd3658 
> 
> Diff: http://git.reviewboard.kde.org/r/101120/diff
> 
> 
> Testing
> ---
> 
> I tested by myself
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make the activities runner available for single runner use

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101144/#review2701
---

Ship it!



plasma/generic/runners/activities/activityrunner.cpp


can be combined into an "else if"; personally i find that easier to read 
than nested if's when there is no reason for it (usually a nested should 
implies that it is handling a unique sub-case)


- Aaron J.


On April 17, 2011, 12:37 a.m., Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101144/
> ---
> 
> (Updated April 17, 2011, 12:37 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> ---
> 
> Enables the activities runner for single runner use; 
> allows for fast activity switching using an appropriate shortcut
> 
> 
> Diffs
> -
> 
>   plasma/generic/runners/activities/activityrunner.cpp 
> 4df11268fc0f03abd79b972aaa90c40b6b27b9cf 
>   plasma/generic/runners/activities/plasma-runner-activityrunner.desktop 
> 036b389bcfc5237bf74d6a3f11c0bab9e5979270 
> 
> Diff: http://git.reviewboard.kde.org/r/101144/diff
> 
> 
> Testing
> ---
> 
> Compiled and it works
> 
> 
> Thanks,
> 
> Jacopo De
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel