Review Request: Plasmate: Metadata is now able to detect the correct api
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102609/ --- Review request for Plasma. Summary --- Hello In the toolbar files, there is a menu with name metadata, which is responsible to retrieve/write some information to the metadata.desktop file. Write now the plasmate cannot detect the correct api. This patch is fixing this issue. Diffs - editors/metadata/metadata.ui 454643e editors/metadata/metadataeditor.h f0ae30c editors/metadata/metadataeditor.cpp 2b9f89c startpage.h 5a4a5c8 startpage.cpp 4fe287b Diff: http://git.reviewboard.kde.org/r/102609/diff Testing --- Plasmate compiles fines. The only thing that has been left, is to add the correct QLabel to metadata menu. Thanks, Antonis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: merging declarative plasmoids
On Tuesday, September 13, 2011 20:39:20 Viranch Mehta wrote: Also, I would like to make a note here that battery monitor and lock/logout speaking of lock/logout and applets which are essentially rows of icons ... has someone worked out the issues around QML widgets not have size hints and appropriate sizing of applets like lock/logout in panels in plasma-desktop? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: merging declarative plasmoids
On Wednesday 14 September 2011, Aaron J. Seigo wrote: On Tuesday, September 13, 2011 20:39:20 Viranch Mehta wrote: Also, I would like to make a note here that battery monitor and lock/logout speaking of lock/logout and applets which are essentially rows of icons ... has someone worked out the issues around QML widgets not have size hints and appropriate sizing of applets like lock/logout in panels in plasma-desktop? yep, the slc applet should have correct sizing now. unfortunately it requires some manual calculation from the qml side since is not something offered stock, but if the root element offers minimumWidth and minimumHeight the applet will use them as minimum size hints. in plasma2, in the case of a scene that doesn't have qgraphicswidgets in the middle, sizing of things should be a bit easier and a tad more automatic (just remains pretty hard do to expanding things like the taskbar) Viranch, that should be done for the lock/logout applet as well Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML splash screen
as for the qml splash, as it won't be used by default on anything but plasma active, and since not multiscreen means it will either be stretched over all IIRC, you and a couple of other ppl wanted to make it default even for normal KDE Workspace. But, yeah, as long as it is only Active, we don't need multiscreen. Can someone (Aaron, Marco and Martin*) review the branch so that we might merge it? -- Cheerio, Ivan * Martin - because of kwin patches, Aaron and Marco because of the rest :) -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML splash screen
On Wednesday 14 September 2011, Ivan Čukić wrote: as for the qml splash, as it won't be used by default on anything but plasma active, and since not multiscreen means it will either be stretched over all IIRC, you and a couple of other ppl wanted to make it default even for normal KDE Workspace. But, yeah, as long as it is only Active, we don't need multiscreen. Can someone (Aaron, Marco and Martin*) review the branch so that we might merge it? i 've already taken a look at the code, only thing i would change, is as already said, is state - stage, i can do it today -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML splash screen
On Wednesday 14 September 2011, Aaron J. Seigo wrote: as for the qml splash, as it won't be used by default on anything but plasma active, and since not multiscreen means it will either be stretched over all screens or just leave other screens blank .. it's not a show stopper either, especially as 4.8 is quite a ways away for the next desktop and netbook releases. so... merge? ;) also, where i put the qml splash screen for active? it's a bit heavy on graphics, so would make the plasma-mobile repo grow a bit too much forever, maybe have a svn repo only for active artwork? (it would also contain the default list of wallpapers) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML splash screen
On Wednesday, September 14, 2011 11:17:24 Marco Martin wrote: On Wednesday 14 September 2011, Aaron J. Seigo wrote: as for the qml splash, as it won't be used by default on anything but plasma active, and since not multiscreen means it will either be stretched over all screens or just leave other screens blank .. it's not a show stopper either, especially as 4.8 is quite a ways away for the next desktop and netbook releases. so... merge? ;) +1 also, where i put the qml splash screen for active? it's a bit heavy on graphics, so would make the plasma-mobile repo grow a bit too much forever, maybe have a svn repo only for active artwork? (it would also contain the default list of wallpapers) for now an svn repo sounds sane for this, yes ... (seems binary file handing is something git devs are looking into, though, so perhaps we won't have this problem forever :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML splash screen
On Wednesday 14 September 2011, Aaron J. Seigo wrote: also, where i put the qml splash screen for active? it's a bit heavy on graphics, so would make the plasma-mobile repo grow a bit too much forever, maybe have a svn repo only for active artwork? (it would also contain the default list of wallpapers) for now an svn repo sounds sane for this, yes ... (seems binary file handing is something git devs are looking into, though, so perhaps we won't have this problem forever :) ok, good to know ;) i'm now importing it into activeartwork under the old plasma playground svn Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmate: Metadata is now able to detect the correct api
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102609/#review6497 --- great start, nearly there! some additional work is needed imho on what gets stored in which configuration file, but that's all very simple details on top of what you've already done. editors/metadata/metadata.ui http://git.reviewboard.kde.org/r/102609/#comment5748 wonder how that snuck in... editors/metadata/metadataeditor.cpp http://git.reviewboard.kde.org/r/102609/#comment5749 cd(..) only works if the project was created by plasmate. if it was imported from an existing location, the rc file is in the same directory. unfortunate, but how it is. look for other instances of cd(..) to see how this is worked around elsewhere. editors/metadata/metadataeditor.cpp http://git.reviewboard.kde.org/r/102609/#comment5750 shoujld probably just be called Project or similar in the per-project rc file as it isn't about new projects at all :) startpage.cpp http://git.reviewboard.kde.org/r/102609/#comment5751 easier would be to just store the new project settings in plasmaterc as usual. then we don't have to worry about a coupling between how recentProjects is handled and new project defaults. startpage.cpp http://git.reviewboard.kde.org/r/102609/#comment5747 this should be saved in both places, so that when the user goes back to create a new project again, the settings they used last are there again (without having to rely on the implementation / ordering of recentProjects()). in the per-project rc file, the group name should probably just be called Project (or similar) in the per-project rc file as it isn't about new projects at all :) .. things like the email address, username, etc. also don't need to be stored here as they are already in the project's metadata.desktop file. - Aaron J. On Sept. 14, 2011, 8:31 a.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102609/ --- (Updated Sept. 14, 2011, 8:31 a.m.) Review request for Plasma. Summary --- Hello In the toolbar files, there is a menu with name metadata, which is responsible to retrieve/write some information to the metadata.desktop file. Write now the plasmate cannot detect the correct api. This patch is fixing this issue. Diffs - editors/metadata/metadata.ui 454643e editors/metadata/metadataeditor.h f0ae30c editors/metadata/metadataeditor.cpp 2b9f89c startpage.h 5a4a5c8 startpage.cpp 4fe287b Diff: http://git.reviewboard.kde.org/r/102609/diff Testing --- Plasmate compiles fines. The only thing that has been left, is to add the correct QLabel to metadata menu. Thanks, Antonis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML splash screen
On Wednesday 14 September 2011, Marco Martin wrote: On Wednesday 14 September 2011, Ivan Čukić wrote: as for the qml splash, as it won't be used by default on anything but plasma active, and since not multiscreen means it will either be stretched over all IIRC, you and a couple of other ppl wanted to make it default even for normal KDE Workspace. But, yeah, as long as it is only Active, we don't need multiscreen. Can someone (Aaron, Marco and Martin*) review the branch so that we might merge it? i 've already taken a look at the code, only thing i would change, is as already said, is state - stage, i can do it today done that, now to merge the last things to do would be putting the unbranded stripes wallpaper in the qmltest splash and remove the label on the qml- default one (unless we really want to name next kde release Friday ehehe:p) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: QML splash screen
On Wednesday 14 September 2011 11:13:53 Ivan Čukić wrote: as for the qml splash, as it won't be used by default on anything but plasma active, and since not multiscreen means it will either be stretched over all IIRC, you and a couple of other ppl wanted to make it default even for normal KDE Workspace. But, yeah, as long as it is only Active, we don't need multiscreen. Can someone (Aaron, Marco and Martin*) review the branch so that we might merge it? I just had a look at the kwin changes (only saw commit 9fb60932). I don't like that it checks for qt-subapplication, but I fear there is no other easy solution. The proper solution would be to implement the mentioned todo in the login effect which is there since before 4.0, so let's keep the hack ;-) So fine with me. Cheers Martin -- Cheerio, Ivan * Martin - because of kwin patches, Aaron and Marco because of the rest :) -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Active mailing list act...@kde.org https://mail.kde.org/mailman/listinfo/active signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KWin sprint?
Hi all, just a short update: I talked with members of the board this weekend and it would be better if we shift the sprint to 2012. Given that the sprint would be too late for 4.8 anyway I think it's fine to schedule for January. Cheers Martin On Sunday 28 August 2011 10:38:50 Martin Gräßlin wrote: Hi all, this is an idea we came up with at Desktop Summit: what about a KWin sprint? I think that could be very useful and there is lots to discuss. Especially I would like to have a sprint with Nuno and Hugo around to define what services KWin has to provide to make the looks even better. But there are also other areas which we need to further define: e.g. Plasma Active (so one or two Active hackers need to be around), refactoring, Wayland and so on. I think we have enough topics to have a dedicated sprint instead of merging with the larger Tokamaks. Given that lately a few new souls have been working on KWin I would like them to attend. So who would be interested in a sprint? And when should it take place? I would suggest this year maybe end of October or November? If I find a good location I would invite you to Mannheim for the sprint. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: merging declarative plasmoids
In QtQuick 1.1 there are the implicitWidth and implicitHeight properties. Cheers, Daker Fernandes Pinheiro 2011/9/14 Marco Martin notm...@gmail.com On Wednesday 14 September 2011, Aaron J. Seigo wrote: On Tuesday, September 13, 2011 20:39:20 Viranch Mehta wrote: Also, I would like to make a note here that battery monitor and lock/logout speaking of lock/logout and applets which are essentially rows of icons ... has someone worked out the issues around QML widgets not have size hints and appropriate sizing of applets like lock/logout in panels in plasma-desktop? yep, the slc applet should have correct sizing now. unfortunately it requires some manual calculation from the qml side since is not something offered stock, but if the root element offers minimumWidth and minimumHeight the applet will use them as minimum size hints. in plasma2, in the case of a scene that doesn't have qgraphicswidgets in the middle, sizing of things should be a bit easier and a tad more automatic (just remains pretty hard do to expanding things like the taskbar) Viranch, that should be done for the lock/logout applet as well Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma does not build without kdepimlibs
Hi, 9edc8d34b3b0f9983f0eb014f8fbf4bcfcffc3f1 introduced a dependency in plasma on kdepimlibs for gpgme++. The cmake check in kdelibs for kdepimlibs claims it is optional, but the build fails later. The stuff that uses gpgme++ should be compiled conditionally based on whether kdepimlibs was found. Thanks, Steve. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma does not build without kdepimlibs
On Thursday, September 15, 2011 00:21:39 Stephen Kelly wrote: 9edc8d34b3b0f9983f0eb014f8fbf4bcfcffc3f1 introduced a dependency in plasma on kdepimlibs for gpgme++. The cmake check in kdelibs for kdepimlibs claims it is optional, but the build fails later. The stuff that uses gpgme++ should be compiled conditionally based on whether kdepimlibs was found. imho gpgme++ should not be part of kdepimlibs. until that is fixed as part of the Frameworks effort, i don't particularly see anything useful coming from spending time fixing the build as it will need to be re-done again once gpgme++ is broken out (as it probably should have been from the beginning?) on a related note ... there is other code in libplasma2 which uses qca. this needs to get sorted out as well ... i'd like to see it use one or the other, but not both. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
