Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-10-29 Thread David Narváez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102997/
---

Review request for Plasma and Sergio Luis Martins.


Description
---

Adjust KDateTimes after finding out the type of incidence added. Also adjust 
KDateTimes after a change in the Calendar TimeSpec.


This addresses bug 279427.
http://bugs.kde.org/show_bug.cgi?id=279427


Diffs
-

  plasma/generic/dataengines/calendar/akonadi/calendar.cpp 25ec71b 

Diff: http://git.reviewboard.kde.org/r/102997/diff/diff


Testing
---

1. Add an event in any timezone distinct from the local timezone (you can do 
that in KOrganizer)
2. Check the start and end times of the event in the calendar

Not sure how to test changing timezones from Plasma, so proposed patch is based 
on what I think we should do in such a case.


Thanks,

David Narváez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: To much QML options in KDE!

2011-10-29 Thread Aaron J. Seigo
On Saturday, October 29, 2011 21:05:35 Mark wrote:
> Hi plasma people,
> 
> I was expecting some components to be available for KDE and indeed there

most of what you list are not components.

> You have (in kde-runtime/plasma/declarativeimports/):
> - core (what is in there besides the background stuff?)

DataEngine support, for one rather important thing ...

> - draganddrop (uhh.. ?)

d'n'd probably could go into core, yes.

> - graphicslayouts (what is this supposed to be?)
> - graphicswidgets (So these are the Plasma:: widgets right? Sadly they are
> currently broken and give me this error: "Type dump of C++ plugin failed.
> Parse error: 7:5: Component defenition is missing a name binding" .. I would
> like to use this one but it's not working. Could someone knowledgable about
> that one fix it please?)

these are for use with QGraphicsView, which is what we're currently using. in 
some distant future they will be dropped when we also drop QGraphicsView. this 
is why they are in a separate namespace.

as for why GrahicsWidgets aren't working ... sounds like some sort of failure 
in your install, as we use them in several QML components in Active ...

> - plasmacomponents (These are the new components from GSoC right? But why do
> they look so.. different then the Plasma:: components?

because they are still a WIP.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: [Kde-pim] Akonadi Calendar

2011-10-29 Thread David Narvaez
On Sat, Oct 29, 2011 at 3:02 PM, John Layt  wrote:
> Cool :-)  So the plan looks something like:
>
> 1) Sergio finishes the clean-up in kdepim, then moves the code to kdepimlibs
> 2) Someone (probably me) then removes the copy from kde-workspace and points
> the data engine at the kdepimlibs version.
> 3) Someone (David?) overhauls the Data Engines and adds a Service

David who? :) j/k

On personal e-mail I asked Sérgio about a fix I think we need to close
a bug on Plasma Calendar widget, and he told me I should work on that
fix without waiting for him to finish the cleanup for it will take
some time. So that's what I'm working on right now, and I'll have to
commit that patch against the copy of the calendar model we have in
Plasma. I guess that I can sit after the cleanup and check whether
I'll need to fix a regression in the code related to this fix or if it
is already fixed in the cleanup.

In any case, lets just keep everyone informed about this migration as
it will (possitively) affect at least two large projects in KDE.

David E. Narváez
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: [Kde-pim] Akonadi Calendar

2011-10-29 Thread John Layt
On Thursday 27 Oct 2011 21:26:03 Sérgio Martins wrote:

> > The intention has always been to move the Akonadi calendar interface
> > into
> > kdepimlibs so everyone could use it, but I don't know if this has been
> > done yet.  Once done we can delete the copy and switch the data engine
> > to the kdepimlibs version.
> > 
> > Sergio, do you know the status of this?
> 
> I'm in the middle of cleaning kdepim/calendarsupport/ so we can move
> it to kdepimlibs.
> Sorry for not seeing your e-mail, lots of bugs and e-mails piled up
> while on vacation :).

Cool :-)  So the plan looks something like:

1) Sergio finishes the clean-up in kdepim, then moves the code to kdepimlibs
2) Someone (probably me) then removes the copy from kde-workspace and points 
the data engine at the kdepimlibs version.
3) Someone (David?) overhauls the Data Engines and adds a Service

Cheers!

John.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


To much QML options in KDE!

2011-10-29 Thread Mark
Hi plasma people,

I was expecting some components to be available for KDE and indeed there
are. Sadly there is to much with roughly similar names which makes it really
inconvenient to find out which one i should or should not use..

You have (in kde-runtime/plasma/declarativeimports/):
- core (what is in there besides the background stuff?)
- draganddrop (uhh.. ?)
- graphicslayouts (what is this supposed to be?)
- graphicswidgets (So these are the Plasma:: widgets right? Sadly they are
currently broken and give me this error: "Type dump of C++ plugin failed.
Parse error: 7:5: Component defenition is missing a name binding" .. I would
like to use this one but it's not working. Could someone knowledgable about
that one fix it please?)
- plasmacomponents (These are the new components from GSoC right? But why do
they look so.. different then the Plasma:: components? These do work btw.)
- qtextracomponents (What is this?)

So we have - at the very least - 2 "component" plugins. graphicswidgets
and plasmacomponents, but which one am i supposed to use when re-creating
the plasma panel tool box? Right now i go for plasmacomponents since it's
working..

But can't we clean this stuff up a bit, remove what we don't need and just
have "components" for the rest? Then a nice wiki page that explains what's
all in the components.

Kind regards,
Mark
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Some help for recreating the Plasma Tool Box in QML

2011-10-29 Thread Mark
On Sat, Oct 29, 2011 at 11:58 AM, Marco Martin  wrote:

> On Saturday 29 October 2011, Aaron J. Seigo wrote:
> > On Friday, October 28, 2011 22:10:07 Mark wrote:
> > > On Thu, Oct 27, 2011 at 2:24 PM, Aaron J. Seigo 
> wrote:
> > > > On Thursday, October 27, 2011 14:05:42 Mark wrote:
> > > > > Ah men i hate this.. This is a typical "it's right under your nose"
> > > > > case
> > > > :
> > > > :p
> > > >
> > > > usually only after it's been pointed out is it right under your now;
> > > > before
> > > > that it may as well be very well hidden behind your back ;)
> > > >
> > > > don't worry, with time you'll get to learn the source tree and where
> > > > you can
> > > > expect to look for different kinds of things. it's just a learning
> > > > curve, though hopefully one we've made as level as possible.
> > > >
> > > > > Thanx for helping :)
> > > >
> > > > np :)
> > >
> > > Oke, i finally have the darn QML file working in the position where i
> > > want it. Quite irritating since apparently i need to set the base
> > > position of QDeclarativeView in C++ where i'd expect it to be set from
> > > XML with just X and Y position.. Also the line to set some flags
> doesn't
> > > seem to be working on QDeclerativeView:
> KWindowSystem::setState(winId(),
> > > NET::SkipTaskbar | NET::SkipPager | NET::Sticky | NET::KeepAbove); ...
> > > Or i did something wrong.
> > >
> > > Anyway, i'm gonna try to fill up the QML file with elements so it looks
> > > like the current tool box we all know but for that i need to get some
> > > things working..
> > >
> > > 1. How do i get the PlasmaCore import working:
> > >
> http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted#P
> > > las ma_Widgets_in_QML My
> >
> > you just include PlasmaCore like:
> >
> > import org.kde.plasma.core 0.1 as PlasmaCore
> >
> > assumng you have a sufficiently new kde-runtime installed, this should
> > "just work"
>
> make sure the proper import path is set in the qml runtime.
> ie if you are using this from plasma you ***M U S T*** use
> Plasma::DeclarativeWidget
>
> if you are doing tests with qmlviewer, add the command line parameter
> -I /usr/lib/kde4/imports
>
> (or whatever prefix kde is installed instead of /usr)
>
>
> > > 2. Which options are possible for plasmacore backgrounds.. Right now i
> > > have "widgets/frame" but what else is there?
> >
> > these come from the SVG theme... in this case you probably want to use
> > dialogs/background
>
>
> http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails#Current_Theme_Elements
>
> > > 3. Where are the plasma QML files hidden for a button and such and how
> do
> > > i use them (imports.. same as question 1 only with different files)
> >
> > until the MobileComponents and Plasma::Components become available to you
> > (will be in kde-runtime, and eventually a separate KDE QML repository),
> you
> > can use Plasma widgdets like PlasmaWidgets.PushButton
>
> plasma components are now in runtime master (whether leavng them in for 4.8
> is
> another question, but i would)
>
> Cheers,
> Marco Martin
>

Apparently it isn't "just" working. I was missing a "QML_IMPORT_PATH"
environment variable. Once i set that to the imports it worked.
However, if i run it through QtCreator (just a QML file with no project
behind it) then QtCreator still doesn't see it.. Right now i "work around"
this by making a project and setting the "importPaths" variable in the
.qmlproject, but does anyone know the environment variable i need
to edit for the default import paths? Odly enough QtCreator doesn't seem to
look at QML_IMPORT_PATH ...

Thanx.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Plasmate:add a new label at the startpage

2011-10-29 Thread Giorgos Tsiapaliwkas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102991/
---

Review request for Plasma.


Description
---

Hi,

in order someone to load a project using the plasmate,he has to give a path 
like this,"$my_plasmoid/$my_plasmoid/contents".
If someone wasn't aware of that he would have an issue.So i add a label which 
will inform the user about that.

thanks in advance


Diffs
-

  startpage.cpp fc00441 
  startpage.ui 942e6ab 

Diff: http://git.reviewboard.kde.org/r/102991/diff/diff


Testing
---

it's ok


Thanks,

Giorgos Tsiapaliwkas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Plasmate:publisher dialog now also saves the project

2011-10-29 Thread Giorgos Tsiapaliwkas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102990/
---

Review request for Plasma.


Description
---

Until now the publisher dialog wasn't saving the project,so if someone wanted 
to use the specific dialog with some changes we would have
to close the project and then to use the dialog.The patch fixes the issue.

thanks in advance


Diffs
-

  mainwindow.cpp 2fa2742 

Diff: http://git.reviewboard.kde.org/r/102990/diff/diff


Testing
---

it is ok


Thanks,

Giorgos Tsiapaliwkas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

2011-10-29 Thread Giorgos Tsiapaliwkas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102989/
---

Review request for Plasma.


Description
---

With this patch plasmate can now create a CMakeLists.txt.I haven't discussed 
the patch with someone but i believe that plasmate needs this feature.

If so,at the publisher there is an install button should i convert it into a 
combobox in order to add the option to install the project using
cmake and not only using plasmapkg.Of course this will be an another patch.

thanks in advance


Diffs
-

  startpage.cpp fc00441 
  templates/CMakeLists.txt b5f8d2b 
  templates/cmakelists e69de29 

Diff: http://git.reviewboard.kde.org/r/102989/diff/diff


Testing
---

the source code is fine,i am not sure about the quality of the CMakeLists.txt 
file


Thanks,

Giorgos Tsiapaliwkas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Some help for recreating the Plasma Tool Box in QML

2011-10-29 Thread Marco Martin
On Saturday 29 October 2011, Aaron J. Seigo wrote:
> On Friday, October 28, 2011 22:10:07 Mark wrote:
> > On Thu, Oct 27, 2011 at 2:24 PM, Aaron J. Seigo  wrote:
> > > On Thursday, October 27, 2011 14:05:42 Mark wrote:
> > > > Ah men i hate this.. This is a typical "it's right under your nose"
> > > > case
> > > :
> > > :p
> > > 
> > > usually only after it's been pointed out is it right under your now;
> > > before
> > > that it may as well be very well hidden behind your back ;)
> > > 
> > > don't worry, with time you'll get to learn the source tree and where
> > > you can
> > > expect to look for different kinds of things. it's just a learning
> > > curve, though hopefully one we've made as level as possible.
> > > 
> > > > Thanx for helping :)
> > > 
> > > np :)
> > 
> > Oke, i finally have the darn QML file working in the position where i
> > want it. Quite irritating since apparently i need to set the base
> > position of QDeclarativeView in C++ where i'd expect it to be set from
> > XML with just X and Y position.. Also the line to set some flags doesn't
> > seem to be working on QDeclerativeView: KWindowSystem::setState(winId(),
> > NET::SkipTaskbar | NET::SkipPager | NET::Sticky | NET::KeepAbove); ...
> > Or i did something wrong.
> > 
> > Anyway, i'm gonna try to fill up the QML file with elements so it looks
> > like the current tool box we all know but for that i need to get some
> > things working..
> > 
> > 1. How do i get the PlasmaCore import working:
> > http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted#P
> > las ma_Widgets_in_QML My
> 
> you just include PlasmaCore like:
> 
> import org.kde.plasma.core 0.1 as PlasmaCore
> 
> assumng you have a sufficiently new kde-runtime installed, this should
> "just work"

make sure the proper import path is set in the qml runtime.
ie if you are using this from plasma you ***M U S T*** use 
Plasma::DeclarativeWidget

if you are doing tests with qmlviewer, add the command line parameter 
-I /usr/lib/kde4/imports

(or whatever prefix kde is installed instead of /usr)


> > 2. Which options are possible for plasmacore backgrounds.. Right now i
> > have "widgets/frame" but what else is there?
> 
> these come from the SVG theme... in this case you probably want to use
> dialogs/background

http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails#Current_Theme_Elements

> > 3. Where are the plasma QML files hidden for a button and such and how do
> > i use them (imports.. same as question 1 only with different files)
> 
> until the MobileComponents and Plasma::Components become available to you
> (will be in kde-runtime, and eventually a separate KDE QML repository), you
> can use Plasma widgdets like PlasmaWidgets.PushButton

plasma components are now in runtime master (whether leavng them in for 4.8 is 
another question, but i would)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Some help for recreating the Plasma Tool Box in QML

2011-10-29 Thread Aaron J. Seigo
On Friday, October 28, 2011 22:10:07 Mark wrote:
> On Thu, Oct 27, 2011 at 2:24 PM, Aaron J. Seigo  wrote:
> > On Thursday, October 27, 2011 14:05:42 Mark wrote:
> > > Ah men i hate this.. This is a typical "it's right under your nose" case
> > :
> > :p
> > 
> > usually only after it's been pointed out is it right under your now;
> > before
> > that it may as well be very well hidden behind your back ;)
> > 
> > don't worry, with time you'll get to learn the source tree and where you
> > can
> > expect to look for different kinds of things. it's just a learning curve,
> > though hopefully one we've made as level as possible.
> > 
> > > Thanx for helping :)
> > 
> > np :)
> 
> Oke, i finally have the darn QML file working in the position where i want
> it. Quite irritating since apparently i need to set the base position of
> QDeclarativeView in C++ where i'd expect it to be set from XML with just X
> and Y position.. Also the line to set some flags doesn't seem to be working
> on QDeclerativeView: KWindowSystem::setState(winId(), NET::SkipTaskbar |
> NET::SkipPager | NET::Sticky | NET::KeepAbove); ... Or i did something
> wrong.
> 
> Anyway, i'm gonna try to fill up the QML file with elements so it looks like
> the current tool box we all know but for that i need to get some things
> working..
> 
> 1. How do i get the PlasmaCore import working:
> http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted#Plas
> ma_Widgets_in_QML My

you just include PlasmaCore like:

import org.kde.plasma.core 0.1 as PlasmaCore

assumng you have a sufficiently new kde-runtime installed, this should "just 
work"

> 2. Which options are possible for plasmacore backgrounds.. Right now i have
> "widgets/frame" but what else is there?

these come from the SVG theme... in this case you probably want to use 
dialogs/background

> 3. Where are the plasma QML files hidden for a button and such and how do i
> use them (imports.. same as question 1 only with different files)

until the MobileComponents and Plasma::Components become available to you 
(will be in kde-runtime, and eventually a separate KDE QML repository), you 
can use Plasma widgdets like PlasmaWidgets.PushButton

> least have this plasma tool box as QML for KDE 4.9 and perhaps even all
> panel stuff in QML for KDE 4.9? (yeah, i really start to like QML :p)

sounds great :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: IconTasks taskmanager changes

2011-10-29 Thread Aaron J. Seigo
On Friday, October 28, 2011 23:40:03 Jan Gerrit José Marker wrote:
> That would prevent from bloating the code and would make the matching more
> flexible.

while this would work, given the amount of corner cases that need covering and
their complexity, this would be an over-engineered solution. if we do end up
with many unique corner cases that change often, then we can do this.

--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel