Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/#review8202
---
startpage.cpp
http://git.reviewboard.kde.org/r/102732/#comment7025
won't this always be the case for a Plasmoid (or other Plasma Package)?
the normal is:
metadata.desktop
contents/
so ... this will go up one directory when an external project is loaded
and end up in the wrong place. (e.g. an external project is loaded). that looks
incorrect.
it should only go up one directory in the case of a plasmate created
project, which looks like this on disk:
NOTE
.plasmaprojectrc
nameofproject/
\__ metadata.desktop
|__ contents
i think the real problem here is in trying to autodetect by what is on disk
what kind of project it is (created by plasmate, or loaded externally). the
easiest way around this, really, is to stop trying to do that and have plasmate
simply always point to the directory with the .plasmateprojectrc file.
of course, in the case where is no projectrc file, then the problem
remains. instead of having these dir.cd('..') checks throughout the code, and
constantly having bugs in that code, there should be ONE method somewhere that,
given a directory, determines where the root of the project should point to.
this way we can write it once and get it right for all uses.
it may even make sense to simply check and see if the project is in
apddata, and if so then we know it is a plasmate created project with that dir
structure .. otherwise it is an imported project and to be treated that way.
- Aaron J. Seigo
On Nov. 14, 2011, 8:43 p.m., Giorgos Tsiapaliwkas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/
---
(Updated Nov. 14, 2011, 8:43 p.m.)
Review request for Plasma.
Description
---
Hello,
for the moment the .plasmateprojectrc file exists as a mark for the projects
created by plasmate.
We want the file to be created in the creation of the project not in the load
of the project,the patch does that.
cheers
Diffs
-
mainwindow.cpp 6ea7f0c
startpage.h f16af4b
startpage.cpp 75052b1
Diff: http://git.reviewboard.kde.org/r/102732/diff/diff
Testing
---
workinig
Thanks,
Giorgos Tsiapaliwkas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102631/#review8203 --- This review has been submitted with commit 558bc0d77e7076e5111f511e0fe41a9a792e2e1a by Thomas Gahr to branch master. - Commit Hook On Sept. 16, 2011, 2:10 p.m., Thomas Gahr wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102631/ --- (Updated Sept. 16, 2011, 2:10 p.m.) Review request for Plasma. Description --- KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty and thus enable the apply button. In some situations the absolute X/Y position is the only thing the user needs to change. At the moment you need to make some dummy change (change resolution back and forth or alike) to enable the apply button. This is not a good user experience. Sorry for the unnecessary whitespace-changes, qt-creator auto-strips unnecessary space upon saving. If everything else is fine with this patch and anybody insists on it I will update the patch dropping these changes. Diffs - kcontrol/randr/outputconfig.cpp 38c8386 Diff: http://git.reviewboard.kde.org/r/102631/diff/diff Testing --- Backported the patch to kde-workspace sources 4.7.0 used in Fedora's KDE rpms (i.e. change valueChanged(int) to textChanged(const QString), built a new rpm from the patched sources and tested it on my install. Works just as expected. I have yet to finish the setup of my kde-devel environment to test it on current master. Will keep you updated if it breaks anything. [update] Works fine with current master Thanks, Thomas Gahr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Extenders in libplasma2 (or.. not)
hi :) i've been working a bit yesterday and today on the de-QGraphicsView-ification of libplasma2. Applet no longer uses any of the Plasma QGraphicsProxyWidgets and i believe i have it on a path towards proper abstraction so we can have a QGraphicsWidget and a QML Item based implementation. however, one snag i ran into was Extender and ExtenderItem. they are both very much based on QGraphicsView classes and while this is not insurmountable, i decided to look at what uses them. there is exactly *one* plasmoid that we ship that uses them directlly: Notifications. i believe some other applets use them implicitly as they are popup applets and don't provide their own widget. looking at kde-apps.org, it doesn't seem the situation is much different for 3rd party plasmoids either. more plasmoids used to use them .. fewer do now for various reasons. in libplasma, PopupApplet uses Extender, and of course Applet provides support for them. PopupApplet's use could be easily replaced with Plasma::Dialog (which will get both a QGraphicsView and a QML implementation...) our users never seem to have caught on to them as a concept and they didn't prove nearly as useful as i had once hoped. after today's research and reflecting on the situation, i consider them a failed experiment. not a terrible one, but it didn't exactly succeed. i suppose it's the same thing as the old tear-off menus - neat idea, few used them, created as many problems as it solved. so ... i'd like to propose that we kill Extender, ExtenderItem and ExtenderGroup in libplasma2. this will: * make the library lighter * make it much easier to de-QGraphicsView-ize things the cons are: * it means anything using them needs to be revised; however, as i hope we will have a QML notifications plasmoid sooner rather than later and as pretty much nothing else uses it .. i don't think this is a big deal. i can't just move extenders to the plasma QGraphicsView support library, either, as they are (by necessity) deeply entwined with Applet and Containment. thoughts? +1s? -1s? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Extenders in libplasma2 (or.. not)
On Tuesday 15 November 2011, Aaron J. Seigo wrote: hi :) after today's research and reflecting on the situation, i consider them a failed experiment. not a terrible one, but it didn't exactly succeed. i suppose it's the same thing as the old tear-off menus - neat idea, few used them, created as many problems as it solved. so ... i'd like to propose that we kill Extender, ExtenderItem and ExtenderGroup in libplasma2. i say kill it. to me extender is the typical seemed a good idea at the time if really needed again, we can implement afterwards a similar thing in plasma2. now, crazy usual crazy idea moment: funny thing, in qml it would be way easier to do them: we could have an applet that is not much more than a Loader item, that gets created when the dropped mimedata contains a qml snippet directly, so the loader would directly instantiate a component out of that (and save such qml source buh, somewhere) this is quite crazy/scary and i don't want to do it right *now*, but if we will find again an use case for extenders in the future.. well, that would be the fairly easy way to go i think ;) this will: * make the library lighter * make it much easier to de-QGraphicsView-ize things the cons are: * it means anything using them needs to be revised; however, as i hope we will have a QML notifications plasmoid sooner rather than later and as pretty much nothing else uses it .. i don't think this is a big deal. the active notifications applet is of course way simpler, but could be a good starting point (not sure if we should aim to make them the same applet with platform profile support or have 2 instead) i can't just move extenders to the plasma QGraphicsView support library, either, as they are (by necessity) deeply entwined with Applet and Containment. +1, they can live in the qgv support lib. and i don't think the ability to drop notifications on the desktop will be missed much (during 4,x this ability came and gone a couple of times already btw, didn't seem anybody noticed :p) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: port dictionary qml to Plasma Components
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103143/ --- Review request for Plasma. Description --- Hello, i ported the plasmoid to the plasma components and also add an archors property in order to be rendered properly. Diffs - dictionary/package/contents/ui/main.qml e9cb9fc Diff: http://git.reviewboard.kde.org/r/103143/diff/diff Testing --- the PlasmaWidget.WebView doesn't expand in all the entire layout of the plasmoid. Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/ --- Review request for Plasma. Description --- Hello, i modified the dir paths in order to be more common and also i change a little the CMakeLists.txt in order to be correct Diffs - microblog/CMakeLists.txt 3a9d6ec microblog/contents/code/logic.js 8b0af1f microblog/contents/config/main.xml 638b308 microblog/contents/ui/BasicComponents/ListItem.qml 4617da1 microblog/contents/ui/BasicComponents/MessageWidget.qml 6f532ee microblog/contents/ui/BasicComponents/PostingWidget.qml 10600df microblog/contents/ui/BasicComponents/qmldir 5fe1aad microblog/contents/ui/ComplexComponents/MessageList.qml 97f3611 microblog/contents/ui/ComplexComponents/qmldir d788304 microblog/contents/ui/MainWidget/MainWidget.qml 94c0315 microblog/contents/ui/MainWidget/qmldir 8134d44 microblog/contents/ui/config.ui e478c44 microblog/contents/ui/main.qml 64b79f0 microblog/metadata.desktop d7a50b3 microblog/package/contents/code/logic.js e69de29 microblog/package/contents/config/main.xml e69de29 microblog/package/contents/ui/BasicComponents/ListItem.qml e69de29 microblog/package/contents/ui/BasicComponents/MessageWidget.qml e69de29 microblog/package/contents/ui/BasicComponents/PostingWidget.qml e69de29 microblog/package/contents/ui/BasicComponents/qmldir e69de29 microblog/package/contents/ui/ComplexComponents/MessageList.qml e69de29 microblog/package/contents/ui/ComplexComponents/qmldir e69de29 microblog/package/contents/ui/MainWidget/MainWidget.qml e69de29 microblog/package/contents/ui/MainWidget/qmldir e69de29 microblog/package/contents/ui/config.ui e69de29 microblog/package/contents/ui/main.qml e69de29 microblog/package/metadata.desktop e69de29 microblog/package/platformcontents/application/generic/images/background.png e69de29 microblog/package/platformcontents/application/generic/images/listitem.svgz e69de29 microblog/package/platformcontents/application/generic/images/shadow.svgz e69de29 microblog/package/platformcontents/application/generic/images/sidebarbackground.png e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/ListItem.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/qmldir e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/qmldir e69de29 microblog/platformcontents/application/generic/images/background.png b658f04 microblog/platformcontents/application/generic/images/listitem.svgz 828ba19 microblog/platformcontents/application/generic/images/shadow.svgz a3047e1 microblog/platformcontents/application/generic/images/sidebarbackground.png 81908e2 microblog/platformcontents/application/generic/ui/BasicComponents/ListItem.qml 9bb5bab microblog/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml 289c611 microblog/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml c66b2aa microblog/platformcontents/application/generic/ui/BasicComponents/qmldir 5fe1aad microblog/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml d6f8a42 microblog/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml 5e98f07 microblog/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml 23e7884 microblog/platformcontents/application/tablet/ui/MainWidget/qmldir 798f487 Diff: http://git.reviewboard.kde.org/r/103144/diff/diff Testing --- Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/#review8210 --- why a subdirectory more? this is not used anywhere else - Marco Martin On Nov. 15, 2011, 4:18 p.m., Giorgos Tsiapaliwkas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/ --- (Updated Nov. 15, 2011, 4:18 p.m.) Review request for Plasma. Description --- Hello, i modified the dir paths in order to be more common and also i change a little the CMakeLists.txt in order to be correct Diffs - microblog/CMakeLists.txt 3a9d6ec microblog/contents/code/logic.js 8b0af1f microblog/contents/config/main.xml 638b308 microblog/contents/ui/BasicComponents/ListItem.qml 4617da1 microblog/contents/ui/BasicComponents/MessageWidget.qml 6f532ee microblog/contents/ui/BasicComponents/PostingWidget.qml 10600df microblog/contents/ui/BasicComponents/qmldir 5fe1aad microblog/contents/ui/ComplexComponents/MessageList.qml 97f3611 microblog/contents/ui/ComplexComponents/qmldir d788304 microblog/contents/ui/MainWidget/MainWidget.qml 94c0315 microblog/contents/ui/MainWidget/qmldir 8134d44 microblog/contents/ui/config.ui e478c44 microblog/contents/ui/main.qml 64b79f0 microblog/metadata.desktop d7a50b3 microblog/package/contents/code/logic.js e69de29 microblog/package/contents/config/main.xml e69de29 microblog/package/contents/ui/BasicComponents/ListItem.qml e69de29 microblog/package/contents/ui/BasicComponents/MessageWidget.qml e69de29 microblog/package/contents/ui/BasicComponents/PostingWidget.qml e69de29 microblog/package/contents/ui/BasicComponents/qmldir e69de29 microblog/package/contents/ui/ComplexComponents/MessageList.qml e69de29 microblog/package/contents/ui/ComplexComponents/qmldir e69de29 microblog/package/contents/ui/MainWidget/MainWidget.qml e69de29 microblog/package/contents/ui/MainWidget/qmldir e69de29 microblog/package/contents/ui/config.ui e69de29 microblog/package/contents/ui/main.qml e69de29 microblog/package/metadata.desktop e69de29 microblog/package/platformcontents/application/generic/images/background.png e69de29 microblog/package/platformcontents/application/generic/images/listitem.svgz e69de29 microblog/package/platformcontents/application/generic/images/shadow.svgz e69de29 microblog/package/platformcontents/application/generic/images/sidebarbackground.png e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/ListItem.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/qmldir e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/qmldir e69de29 microblog/platformcontents/application/generic/images/background.png b658f04 microblog/platformcontents/application/generic/images/listitem.svgz 828ba19 microblog/platformcontents/application/generic/images/shadow.svgz a3047e1 microblog/platformcontents/application/generic/images/sidebarbackground.png 81908e2 microblog/platformcontents/application/generic/ui/BasicComponents/ListItem.qml 9bb5bab microblog/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml 289c611 microblog/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml c66b2aa microblog/platformcontents/application/generic/ui/BasicComponents/qmldir 5fe1aad microblog/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml d6f8a42 microblog/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml 5e98f07 microblog/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml 23e7884 microblog/platformcontents/application/tablet/ui/MainWidget/qmldir 798f487 Diff: http://git.reviewboard.kde.org/r/103144/diff/diff Testing --- Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/#review8211 --- why a subdirectory more? this is not used anywhere else - Marco Martin On Nov. 15, 2011, 4:18 p.m., Giorgos Tsiapaliwkas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/ --- (Updated Nov. 15, 2011, 4:18 p.m.) Review request for Plasma. Description --- Hello, i modified the dir paths in order to be more common and also i change a little the CMakeLists.txt in order to be correct Diffs - microblog/CMakeLists.txt 3a9d6ec microblog/contents/code/logic.js 8b0af1f microblog/contents/config/main.xml 638b308 microblog/contents/ui/BasicComponents/ListItem.qml 4617da1 microblog/contents/ui/BasicComponents/MessageWidget.qml 6f532ee microblog/contents/ui/BasicComponents/PostingWidget.qml 10600df microblog/contents/ui/BasicComponents/qmldir 5fe1aad microblog/contents/ui/ComplexComponents/MessageList.qml 97f3611 microblog/contents/ui/ComplexComponents/qmldir d788304 microblog/contents/ui/MainWidget/MainWidget.qml 94c0315 microblog/contents/ui/MainWidget/qmldir 8134d44 microblog/contents/ui/config.ui e478c44 microblog/contents/ui/main.qml 64b79f0 microblog/metadata.desktop d7a50b3 microblog/package/contents/code/logic.js e69de29 microblog/package/contents/config/main.xml e69de29 microblog/package/contents/ui/BasicComponents/ListItem.qml e69de29 microblog/package/contents/ui/BasicComponents/MessageWidget.qml e69de29 microblog/package/contents/ui/BasicComponents/PostingWidget.qml e69de29 microblog/package/contents/ui/BasicComponents/qmldir e69de29 microblog/package/contents/ui/ComplexComponents/MessageList.qml e69de29 microblog/package/contents/ui/ComplexComponents/qmldir e69de29 microblog/package/contents/ui/MainWidget/MainWidget.qml e69de29 microblog/package/contents/ui/MainWidget/qmldir e69de29 microblog/package/contents/ui/config.ui e69de29 microblog/package/contents/ui/main.qml e69de29 microblog/package/metadata.desktop e69de29 microblog/package/platformcontents/application/generic/images/background.png e69de29 microblog/package/platformcontents/application/generic/images/listitem.svgz e69de29 microblog/package/platformcontents/application/generic/images/shadow.svgz e69de29 microblog/package/platformcontents/application/generic/images/sidebarbackground.png e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/ListItem.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml e69de29 microblog/package/platformcontents/application/generic/ui/BasicComponents/qmldir e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml e69de29 microblog/package/platformcontents/application/tablet/ui/MainWidget/qmldir e69de29 microblog/platformcontents/application/generic/images/background.png b658f04 microblog/platformcontents/application/generic/images/listitem.svgz 828ba19 microblog/platformcontents/application/generic/images/shadow.svgz a3047e1 microblog/platformcontents/application/generic/images/sidebarbackground.png 81908e2 microblog/platformcontents/application/generic/ui/BasicComponents/ListItem.qml 9bb5bab microblog/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml 289c611 microblog/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml c66b2aa microblog/platformcontents/application/generic/ui/BasicComponents/qmldir 5fe1aad microblog/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml d6f8a42 microblog/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml 5e98f07 microblog/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml 23e7884 microblog/platformcontents/application/tablet/ui/MainWidget/qmldir 798f487 Diff: http://git.reviewboard.kde.org/r/103144/diff/diff Testing --- Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Extenders in libplasma2 (or.. not)
+1 for removal with a small note - I don't think that extenders turned up to be a bad idea - from my pov, extenders in plasma failed because of a few design decisions (eg could have been dropped on an unlocked desktop and nowhere else) and bugs :) -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: RSSNow QML clean up some code
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103145/ --- Review request for Plasma. Description --- Hello, i cleaned up some code and also i removed some white spaces. Diffs - rssnow/package/contents/ui/ListItem.qml d5172fb rssnow/package/contents/ui/ListItemEntry.qml 8ea5e26 rssnow/package/contents/ui/main.qml c0480b6 Diff: http://git.reviewboard.kde.org/r/103145/diff/diff Testing --- Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: RSSNow QML clean up some code
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103145/#review8212 --- Ship it! - Marco Martin On Nov. 15, 2011, 4:32 p.m., Giorgos Tsiapaliwkas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103145/ --- (Updated Nov. 15, 2011, 4:32 p.m.) Review request for Plasma. Description --- Hello, i cleaned up some code and also i removed some white spaces. Diffs - rssnow/package/contents/ui/ListItem.qml d5172fb rssnow/package/contents/ui/ListItemEntry.qml 8ea5e26 rssnow/package/contents/ui/main.qml c0480b6 Diff: http://git.reviewboard.kde.org/r/103145/diff/diff Testing --- Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Krunner Katch-22
On Monday 17 Heshvan 5772 09:22:20 Aaron J. Seigo wrote: On Sunday, November 13, 2011 17:43:22 David Baron wrote: How might these be accomplished? by returning QueryMatch objects of type InformationalMatch with the data set to whatever the subsequent match should be. As said, InformationMatch's have no run or actions. I want the the run to be normal. If I choose one of the alterntive actions, I want to get back to the view and be able to choose another or simply open the selection. To be able to re-run the query as a result of an action would be quite nice. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Krunner Katch-22
On Tuesday, November 15, 2011 20:59:48 you wrote: On Monday 17 Heshvan 5772 09:22:20 Aaron J. Seigo wrote: On Sunday, November 13, 2011 17:43:22 David Baron wrote: How might these be accomplished? by returning QueryMatch objects of type InformationalMatch with the data set to whatever the subsequent match should be. As said, InformationMatch's have no run or actions. I want the the run to be normal. If I choose one of the alterntive actions, I want to get back to the view and be able to choose another or simply open the selection. To be able to re-run the query as a result of an action would be quite nice. ah! i see what you mean.. hm. yes, that's currently not possible. it should be something that could be added (i imagne by providing a slot to connect an action to somewhere; perhaps in the Plasma::Context...) not sure if i will get to such a feature addition right away ... patches are very welcome, though :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Extenders in libplasma2 (or.. not)
On Tuesday, November 15, 2011 16:08:17 Marco Martin wrote: now, crazy usual crazy idea moment: funny thing, in qml it would be way easier to do them: we could have an we talked about exactly this, only SVG+Javascript, at the kdelibs meeting trysil ... yes, that one. way before 4.0. :) some things just take forever to get to ;) btw.. this would also allow apps to drop elements into other apps (e.g. a plasma shell, but not limited to that), which would _really_ blur the lines between where an app begins and ends. requires out of process data separation, or in-process data plugins (e.g. DataEngines), but that's not a big deal. ktorrent already basically does this, though in a very round about way. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Don't set Icon if iconName is Empty in ActivityBar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103153/ --- Review request for Plasma. Description --- Actually just copying code from ActivityBar::insertContainment(Plasma::Containment *cont) where it is already set this way. Diffs - plasma/generic/applets/activitybar/activitybar.cpp eaefafd Diff: http://git.reviewboard.kde.org/r/103153/diff/diff Testing --- Before this patch, activity names without icon would look a bit flushed right. After this patch the names look centered properly. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Looking for Advisory on ActivityBar Size Policy
Hi all, My first disclaimer is that I'm not a UI developer at all, so I'm pretty lost here. I'm trying to address bug 225078, trying to fix the situation described in comment 7. The problem is I'm not clear on what is the expected behavior, so this is what I think should happen (assuming horizontal layout): - You add the ActivityBar, it should take a reasonable* size in the panel - You start switching among activities, but the activity bar should not expand - You stop activities, then the other tabs should fill up the space, the bar itself remains the same size - You start new activities, then the tabs are added and accommodated, if there are just too many, then he little arrows appear at right * For some definition of reasonable which is unknown to me I think that's all possible, except for determining a reasonable size, am I wrong? Also, is that the intended behavior? Or is it actually working as expected as it is now? If the above description makes sense, what's the correct QSizePolicy combination between tab bars,layouts an applets to get it working that way? Thanks in advance. David E. Narváez [0] https://bugs.kde.org/show_bug.cgi?id=225078 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
