Review Request: Fix Library name of dragdropplugin

2011-12-11 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103384/
---

Review request for Plasma.


Description
---

library name is not matching what is specified in qmldir file.


Diffs
-

  plasma/declarativeimports/draganddrop/CMakeLists.txt 5450873 

Diff: http://git.reviewboard.kde.org/r/103384/diff/diff


Testing
---

Yes Kickoff now finds the plugin.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Fix Library name of dragdropplugin

2011-12-11 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103384/#review8870
---

Ship it!


that's it's just a whps!
yes, go ahead, a no brainer ;)

- Marco Martin


On Dec. 11, 2011, 2:02 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103384/
> ---
> 
> (Updated Dec. 11, 2011, 2:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> library name is not matching what is specified in qmldir file.
> 
> 
> Diffs
> -
> 
>   plasma/declarativeimports/draganddrop/CMakeLists.txt 5450873 
> 
> Diff: http://git.reviewboard.kde.org/r/103384/diff/diff
> 
> 
> Testing
> ---
> 
> Yes Kickoff now finds the plugin.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Fix Library name of dragdropplugin

2011-12-11 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103384/#review8872
---


This review has been submitted with commit 
37a52f48ebd4850d07cd8fe7277e6fa7a653c2ae by Martin Gräßlin to branch master.

- Commit Hook


On Dec. 11, 2011, 2:02 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103384/
> ---
> 
> (Updated Dec. 11, 2011, 2:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> library name is not matching what is specified in qmldir file.
> 
> 
> Diffs
> -
> 
>   plasma/declarativeimports/draganddrop/CMakeLists.txt 5450873 
> 
> Diff: http://git.reviewboard.kde.org/r/103384/diff/diff
> 
> 
> Testing
> ---
> 
> Yes Kickoff now finds the plugin.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Runner runOptions Guidelines

2011-12-11 Thread David Baron
Run options as menus (shown at mouse position at right-icon) close when an 
action is clicked.

Run options shown in the widge with buttons, fields, etc., appearing below the 
match, persist when clicked. This means several may be open at once which 
might not be the best idea, side-effects if not syncronized, etc.

What are the guidelines or criteria which to use? ("Run foobar" uses the 
latter but there will only be ONE match for this.)

If the widget idea be preferred, can this be set to either dissappear when a 
selection is clicked or dissappear when it loses focus or another widget is 
so-exercised?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Runner runOptions Guidelines

2011-12-11 Thread Aaron J. Seigo
On Sunday, December 11, 2011 22:38:49 David Baron wrote:
> Run options shown in the widge with buttons, fields, etc., appearing below
> the match, persist when clicked. This means several may be open at once
> which might not be the best idea, side-effects if not syncronized, etc.

i have no idea what you are refering to here. can you please be more technical 
and specific and/or include a screenshot? thanks.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel