Re: unity-like interface

[heathmatlock]

On Thu, Mar 15, 2012 at 4:00 AM, Aaron J. Seigo  wrote:
> On Wednesday, March 14, 2012 17:22:19 Heath Matlock  
> wrote:
>
>> There's someone else
>> working on a Kwin-QML interface similar to what you would get
>> combining Moblin and Gnome, and he's looking at making it a shell.
>
> do you have a link to this?
He/she hangs in #plasma, the user's nickname is "mokush"

re:rest of your responses
Thanks, time to get some work done!


-- 
Heath Matlock
+1 256 274 4225
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Misc Fixes in Plasma Components Gallery

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104296/
---

Review request for Plasma.


Description
---

Add margin on edge of main page
Set default gallery page to the first entry in the menu (Buttons)
Don't overlap main page with scrollbars
Add clipping on main page for nicer animation between pages so it doesn't 
overlap the sidebar


Diffs
-

  plasma/declarativeimports/test/gallery/Gallery.qml 8a74f96 

Diff: http://git.reviewboard.kde.org/r/104296/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Add tool tips to Mouse Actions tool buttons

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104295/
---

Review request for Plasma.


Description
---

The very nice Mouse Actions page in the Desktop Settings dialog shows 
Configure/About/Remove icons on QToolButtons, but there is no text on hover to 
tell the user what the buttons do. I suggest to add these simple tool tips.


Diffs
-

  libs/plasmagenericshell/mousepluginwidget.cpp be52fde 

Diff: http://git.reviewboard.kde.org/r/104295/diff/


Testing
---


Thanks,

Christoph Feck

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Workflow Idea for 4.10

[Kevin Ottens]

Hello,

On Wednesday 14 March 2012 14:38:19 Aaron J. Seigo wrote:
> [...]
> this is what really piques my interest: merge based workflow.
>
> an integration branch would be fantastic. that branch should rebase
> periodically off of master and only be used to merge feature branches. this
> branch would largely take the place of current master: where development
> "happens". feature branches should be merged into integration on a regular
> basis and developers and testers should track this integration branch in
> their day-to-day usage
>
> integration should always be open to feature branch merging. master should
> only be open for feature merge when not in freeze, however.
>
> when in freeze, either a stabilization branch could be made off of master
> for this purpose (probably a very good idea for larger fixes) which is then
> merged down in master at known good points .. or .. master is opened for
> bug fixes directly in those periods. the latter is probably not as "good"
> from a stability POV, but may be more reasonable and less of a workload for
> people doing the actual work.
>
> so what i'm interested in hearing is what sort of branch management scheme
> would work for people. i'm happy to maintain either an integration or the
> master branch (but not both).
> [...]
>
> note that the methods being (slowly) adopted for frameworks devel are also
> moving in the direction noted above.

I'd just like to add my 0.02€ here.

I've been thinking about the git workflow to be used in KDE Frameworks in the
future. Based on observations and discussions with current and future
frameworks maintainer, I think that it would be a mistake to force a single
workflow for all the frameworks. I'm not 100% sure what the final solution
will be but it's likely to end up being a short list of blessed workflows:
 1) Full game, one branch per feature with review time in an
integration/testing branch before hitting master;
 2) Intermediate, one branch per feature with merge in master after
reviewers/maintainer validation;
 3) Easy, features directly developped in master[1].

The choice for a given framework to use one or the other workflow will likely
be left up to the maintainer discretion. I guess the criteria to pick a
workflow will be:
 * Overall size of the framework;
 * Overall number of contributors;
 * Spread of the contributors in the framework repository (aka how independent
from each other contributions are, linked to the internal complexity of the
framework);
 * Automated tests coverage;
 * Overall modularity of the framework (e.g. lots of small plugins or not);
 * Probably more that I missed so far.

I think that's also relevant to the current discussion at hand for the
workspaces. It's reaching a critical mass in size, and you might want to have
a similar balanced position instead of a one size fit all being unilateraly
applied on every one.

Of course kde-workspace is in a different situation since AFAIK there's not
plan to have finer grained repositories. In which case "one size fit all"
might sound more realistic to reduce confusion... Just please try to be
careful with the "oh look shiny cool tool" effect (been there...[3]), which
generally don't solve social problems or might even create new ones ("be
careful what you ask, you might get it").

Definitely more food for thought than anything in the context of the
workspaces. Thought it could help finding the right course. ;-)

Regards.

[1] And before any "we should always branch" zealot cringe (not blaming you,
been there as well), please take a few minutes and read[2]:
http://martinfowler.com/bliki/FeatureToggle.html
If you want to be really complete you can also stop by:
http://martinfowler.com/bliki/FeatureBranch.html
(but maybe not necessary)

[2] BTW, Martin Fowler has really great pieces in his "bliki" it's definitely
worth spending time reading in there.

[3] And of course regularly fall in the trap again. :-)
--
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: [RFC]: Rename "Configure Window Behavior" to "Configure Window Management"

[Richard Stockton]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104284/#review11446
---


Martin, your reasoning is really good: (it's about the windows themselves, not 
things such as decorations, resizing behaviors etc.)

But I recommend against this word, which (both puns intended ;) behaves like an 
example of management-speak. Do we have room to use a 4-word phrase, such as 
"Configure Window Management Options"? The phrase carries confusing baggage 
among many English speakers, because it has too many meanings: For example, If 
you're in upper management, you might "Configure Management" by firing somebody 
;)

- Richard Stockton


On March 15, 2012, 11:19 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104284/
> ---
> 
> (Updated March 15, 2012, 11:19 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> Adding Plasma to get general feedback on this idea.
> 
> The context menu entry to "Configure Window Behavior" opens the
> configuration of the window manager and not about the window.
> In the past the shown configuration dialog only contained entries
> affecting the window behavior but that is no longer true for the
> complete KDE 4.x series since Desktop Effects had been added to
> the menu. This change in naming reflects the situation and should
> help to remove confusion.
> 
> 
> This addresses bug 249486.
> http://bugs.kde.org/show_bug.cgi?id=249486
> 
> 
> Diffs
> -
> 
>   kwin/useractions.cpp dfb6fd4 
> 
> Diff: http://git.reviewboard.kde.org/r/104284/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasmoid qalculate - menu button

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103052/#review11445
---


This review has been submitted with commit 
24b83a5bddc27ac5b423fc41f238883cb8718893 by Gregor Tätzner to branch master.

- Commit Hook


On March 6, 2012, 8:54 p.m., Greg T wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103052/
> ---
> 
> (Updated March 6, 2012, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hey dudes,
> I implemented a little menu that displays the last 10 results. improvement 
> ideas?
> 
> I found this task in the plasma task list: 
> http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid
> 
> 
> Diffs
> -
> 
>   applets/qalculate/qalculate_applet.h aee14c0 
>   applets/qalculate/qalculate_applet.cpp 4da9241 
>   applets/qalculate/qalculate_history.h 59185ee 
>   applets/qalculate/qalculate_history.cpp 35592a7 
>   applets/qalculate/qalculate_settings.h 4ce4e73 
>   applets/qalculate/qalculate_settings.cpp b62145b 
> 
> Diff: http://git.reviewboard.kde.org/r/103052/diff/
> 
> 
> Testing
> ---
> 
> seems to work
> 
> 
> Thanks,
> 
> Greg T
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: GSOC 2012 project: Make plasmate ready for release

[Giorgos Tsiapaliwkas]

On 14 March 2012 15:45, Aaron J. Seigo  wrote:

> for kde-workspace/plasma/generic/tools i think it makes sense to put them
> all
> into the plasmate repo. the runtime tools need to stay where they are as
> they
> are used by 3rd party apps for things like package installation, and
> plasmate
> can rely on them being there as well.


I was thinking to add the scp feature into plasmapkg and then plasmate to
take it
from there. What do you think?

i would like to see the menus from plasma-prevewier in plasmoidviewer,
> however. having to restart plasmoidviewer to get different results sucks :)
> otherwise, +1
>

I modified the proposal in the wiki. :)


> the rest of the tasks look excellent and well though out. if you can put a
> page together on the wiki documenting this that would be great, and i might
> even blog about it to hopefully drum up some more participation.
>

here is the wiki page,  http://community.kde.org/Plasma/GSoC/2012
Feel free to modify the wiki page.:)

Regards,
Giorgos

-- 
Giorgos Tsiapaliwkas (terietor)
KDE Developer

terietor.gr
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Help us finding the new name for Laptop window decoration

[Martin Gräßlin]

Hi all,

in order to find a better name for the window decoration "Laptop" I created a 
doodle with possible names: 

http://www.doodle.com/e9se6zuz8ufepxke

More info: https://git.reviewboard.kde.org/r/104282/

Please vote for your preferred name and don't make the fun out of it that 
everybody votes for a different name ;-)

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rename window deocration "Laptop" to "Minimal"

[Martin Gräßlin]

> On March 15, 2012, 12:16 p.m., Thomas Lübking wrote:
> > "Leightweight"? - "Minimal" is generic and could just as well read "minimal 
> > functionality" or stuff.
> > About the comment: why not paint it directly into the preview? If you write 
> > a tldr; novel into a tooltip, that's not gonna help either.
> 
> Thomas Lübking wrote:
> I'm the ultimate typoking, even beyond nuno - "Lightweight"
> 
> Martin Gräßlin wrote:
> Lightweight had already been discarded as possible name by Aaron (only 
> replied to plasma-devel) as it places Oxygen in a bad light (opposite of 
> lightweight is heavyweight, right ;-).
> 
> Thomas Lübking wrote:
> - thin
> - slim
> - unfancy
> - network transparent ;-)
> - plain
> - modest
> - artless
> - unpretentious
> - simple
> - legacy
> - failsafe
> - low end
> - oldschool
> - traditional
> 
>

created a doodle for it :-)
http://www.doodle.com/e9se6zuz8ufepxke


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104282/#review11428
---


On March 15, 2012, 7:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104282/
> ---
> 
> (Updated March 15, 2012, 7:28 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> The window decoration Laptop is kept for legacy or thin client
> setups. To make this more clear the decoration is renamed. In
> order to make the transition easier only the name is changed,
> while library name is untouched.
> 
> Additionally a comment is added which should be shown in the
> user interface (requires bug #296041 to be implemented).
> 
> 
> Diffs
> -
> 
>   kwin/clients/laptop/laptop.desktop ccc9d54 
>   kwin/clients/laptop/laptopclient.cpp 52efcd1 
> 
> Diff: http://git.reviewboard.kde.org/r/104282/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Renamed decoration
>   http://git.reviewboard.kde.org/r/104282/s/465/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Drop Decorations B2 and Plastik

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104281/#review11434
---

Ship it!


It's a pity BII never got tabbing support, but "to mimic other OS" is rather a 
task for kdeartwork.or kde-look.org

- Thomas Lübking


On March 15, 2012, 7:14 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104281/
> ---
> 
> (Updated March 15, 2012, 7:14 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> As discussed on mailinglist: 
> http://lists.kde.org/?l=kwin&m=133136239707091&w=2
> 
> 
> Diffs
> -
> 
>   kwin/clients/CMakeLists.txt 6019a9e 
>   kwin/clients/b2/CMakeLists.txt 9295cbe 
>   kwin/clients/b2/b2.desktop 2846e39 
>   kwin/clients/b2/b2client.h c9e9b57 
>   kwin/clients/b2/b2client.cpp 6b52996 
>   kwin/clients/b2/bitmaps.h 00c4552 
>   kwin/clients/b2/config/CMakeLists.txt 1aaf8da 
>   kwin/clients/b2/config/config.h c5bc33c 
>   kwin/clients/b2/config/config.cpp fc9c7b9 
>   kwin/clients/plastik/CMakeLists.txt fce0829 
>   kwin/clients/plastik/config/CMakeLists.txt e48955d 
>   kwin/clients/plastik/config/config.h b037efe 
>   kwin/clients/plastik/config/config.cpp a4ddfe0 
>   kwin/clients/plastik/config/configdialog.ui fe9f53a 
>   kwin/clients/plastik/plastik.h ae7a46e 
>   kwin/clients/plastik/plastik.cpp ff9825f 
>   kwin/clients/plastik/plastik.desktop 30550c6 
>   kwin/clients/plastik/plastikbutton.h 395f628 
>   kwin/clients/plastik/plastikbutton.cpp db29d76 
>   kwin/clients/plastik/plastikclient.h 4c5b0d9 
>   kwin/clients/plastik/plastikclient.cpp 58f8324 
> 
> Diff: http://git.reviewboard.kde.org/r/104281/diff/
> 
> 
> Testing
> ---
> 
> it compiles
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rename window deocration "Laptop" to "Minimal"

[Thomas Lübking]

> On March 15, 2012, 12:16 p.m., Thomas Lübking wrote:
> > "Leightweight"? - "Minimal" is generic and could just as well read "minimal 
> > functionality" or stuff.
> > About the comment: why not paint it directly into the preview? If you write 
> > a tldr; novel into a tooltip, that's not gonna help either.
> 
> Thomas Lübking wrote:
> I'm the ultimate typoking, even beyond nuno - "Lightweight"
> 
> Martin Gräßlin wrote:
> Lightweight had already been discarded as possible name by Aaron (only 
> replied to plasma-devel) as it places Oxygen in a bad light (opposite of 
> lightweight is heavyweight, right ;-).

- thin
- slim
- unfancy
- network transparent ;-)
- plain
- modest
- artless
- unpretentious
- simple
- legacy
- failsafe
- low end
- oldschool
- traditional


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104282/#review11428
---


On March 15, 2012, 7:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104282/
> ---
> 
> (Updated March 15, 2012, 7:28 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> The window decoration Laptop is kept for legacy or thin client
> setups. To make this more clear the decoration is renamed. In
> order to make the transition easier only the name is changed,
> while library name is untouched.
> 
> Additionally a comment is added which should be shown in the
> user interface (requires bug #296041 to be implemented).
> 
> 
> Diffs
> -
> 
>   kwin/clients/laptop/laptop.desktop ccc9d54 
>   kwin/clients/laptop/laptopclient.cpp 52efcd1 
> 
> Diff: http://git.reviewboard.kde.org/r/104282/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Renamed decoration
>   http://git.reviewboard.kde.org/r/104282/s/465/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rename window deocration "Laptop" to "Minimal"

[Martin Gräßlin]

> On March 15, 2012, 12:16 p.m., Thomas Lübking wrote:
> > "Leightweight"? - "Minimal" is generic and could just as well read "minimal 
> > functionality" or stuff.
> > About the comment: why not paint it directly into the preview? If you write 
> > a tldr; novel into a tooltip, that's not gonna help either.
> 
> Thomas Lübking wrote:
> I'm the ultimate typoking, even beyond nuno - "Lightweight"

Lightweight had already been discarded as possible name by Aaron (only replied 
to plasma-devel) as it places Oxygen in a bad light (opposite of lightweight is 
heavyweight, right ;-).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104282/#review11428
---


On March 15, 2012, 7:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104282/
> ---
> 
> (Updated March 15, 2012, 7:28 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> The window decoration Laptop is kept for legacy or thin client
> setups. To make this more clear the decoration is renamed. In
> order to make the transition easier only the name is changed,
> while library name is untouched.
> 
> Additionally a comment is added which should be shown in the
> user interface (requires bug #296041 to be implemented).
> 
> 
> Diffs
> -
> 
>   kwin/clients/laptop/laptop.desktop ccc9d54 
>   kwin/clients/laptop/laptopclient.cpp 52efcd1 
> 
> Diff: http://git.reviewboard.kde.org/r/104282/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Renamed decoration
>   http://git.reviewboard.kde.org/r/104282/s/465/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: [RFC]: Rename "Configure Window Behavior" to "Configure Window Management"

[Martin Gräßlin]

> On March 15, 2012, 12:19 p.m., Thomas Lübking wrote:
> > "Configure behavior of windows..:"?
> > In general the current string is bad, but i don't know whether joe windows 
> > user can make anything out of "window management" (the concept of a window 
> > manager and titlebars not being part of the actual window is usually 
> > confusing when you're first confronted with it - i do recall that from my 
> > very own past)

When reordering the menu, I want to move the entry into the advanced section. 
That makes it hopefully better, but a better wording would be nice of course 
nevertheless :-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104284/#review11430
---


On March 15, 2012, 11:19 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104284/
> ---
> 
> (Updated March 15, 2012, 11:19 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> Adding Plasma to get general feedback on this idea.
> 
> The context menu entry to "Configure Window Behavior" opens the
> configuration of the window manager and not about the window.
> In the past the shown configuration dialog only contained entries
> affecting the window behavior but that is no longer true for the
> complete KDE 4.x series since Desktop Effects had been added to
> the menu. This change in naming reflects the situation and should
> help to remove confusion.
> 
> 
> This addresses bug 249486.
> http://bugs.kde.org/show_bug.cgi?id=249486
> 
> 
> Diffs
> -
> 
>   kwin/useractions.cpp dfb6fd4 
> 
> Diff: http://git.reviewboard.kde.org/r/104284/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: [RFC]: Rename "Configure Window Behavior" to "Configure Window Management"

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104284/#review11430
---


"Configure behavior of windows..:"?
In general the current string is bad, but i don't know whether joe windows user 
can make anything out of "window management" (the concept of a window manager 
and titlebars not being part of the actual window is usually confusing when 
you're first confronted with it - i do recall that from my very own past)

- Thomas Lübking


On March 15, 2012, 11:19 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104284/
> ---
> 
> (Updated March 15, 2012, 11:19 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> Adding Plasma to get general feedback on this idea.
> 
> The context menu entry to "Configure Window Behavior" opens the
> configuration of the window manager and not about the window.
> In the past the shown configuration dialog only contained entries
> affecting the window behavior but that is no longer true for the
> complete KDE 4.x series since Desktop Effects had been added to
> the menu. This change in naming reflects the situation and should
> help to remove confusion.
> 
> 
> This addresses bug 249486.
> http://bugs.kde.org/show_bug.cgi?id=249486
> 
> 
> Diffs
> -
> 
>   kwin/useractions.cpp dfb6fd4 
> 
> Diff: http://git.reviewboard.kde.org/r/104284/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rename window deocration "Laptop" to "Minimal"

[Thomas Lübking]

> On March 15, 2012, 12:16 p.m., Thomas Lübking wrote:
> > "Leightweight"? - "Minimal" is generic and could just as well read "minimal 
> > functionality" or stuff.
> > About the comment: why not paint it directly into the preview? If you write 
> > a tldr; novel into a tooltip, that's not gonna help either.

I'm the ultimate typoking, even beyond nuno - "Lightweight"


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104282/#review11428
---


On March 15, 2012, 7:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104282/
> ---
> 
> (Updated March 15, 2012, 7:28 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> The window decoration Laptop is kept for legacy or thin client
> setups. To make this more clear the decoration is renamed. In
> order to make the transition easier only the name is changed,
> while library name is untouched.
> 
> Additionally a comment is added which should be shown in the
> user interface (requires bug #296041 to be implemented).
> 
> 
> Diffs
> -
> 
>   kwin/clients/laptop/laptop.desktop ccc9d54 
>   kwin/clients/laptop/laptopclient.cpp 52efcd1 
> 
> Diff: http://git.reviewboard.kde.org/r/104282/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Renamed decoration
>   http://git.reviewboard.kde.org/r/104282/s/465/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rename window deocration "Laptop" to "Minimal"

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104282/#review11428
---


"Leightweight"? - "Minimal" is generic and could just as well read "minimal 
functionality" or stuff.
About the comment: why not paint it directly into the preview? If you write a 
tldr; novel into a tooltip, that's not gonna help either.

- Thomas Lübking


On March 15, 2012, 7:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104282/
> ---
> 
> (Updated March 15, 2012, 7:28 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> The window decoration Laptop is kept for legacy or thin client
> setups. To make this more clear the decoration is renamed. In
> order to make the transition easier only the name is changed,
> while library name is untouched.
> 
> Additionally a comment is added which should be shown in the
> user interface (requires bug #296041 to be implemented).
> 
> 
> Diffs
> -
> 
>   kwin/clients/laptop/laptop.desktop ccc9d54 
>   kwin/clients/laptop/laptopclient.cpp 52efcd1 
> 
> Diff: http://git.reviewboard.kde.org/r/104282/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Renamed decoration
>   http://git.reviewboard.kde.org/r/104282/s/465/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: [RFC]: Rename "Configure Window Behavior" to "Configure Window Management"

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104284/
---

Review request for kwin and Plasma.


Description
---

Adding Plasma to get general feedback on this idea.

The context menu entry to "Configure Window Behavior" opens the
configuration of the window manager and not about the window.
In the past the shown configuration dialog only contained entries
affecting the window behavior but that is no longer true for the
complete KDE 4.x series since Desktop Effects had been added to
the menu. This change in naming reflects the situation and should
help to remove confusion.


This addresses bug 249486.
http://bugs.kde.org/show_bug.cgi?id=249486


Diffs
-

  kwin/useractions.cpp dfb6fd4 

Diff: http://git.reviewboard.kde.org/r/104284/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: unity-like interface

[Aaron J. Seigo]

On Wednesday, March 14, 2012 17:22:19 you wrote:
> Ideally this work can be downloaded as an activity template, right? Or

yes; however this is where some additional work is needed as this really isn't 
an activity template at all but using the scripting to modify the workspace 
shell itself. so while behind the scenes it's all the same javascript API and 
package format for distribution, plasma-desktop needs to be able to 
differentiate between different kinds of script packages: those which are meant 
to be used as an activity template; those that define a panel layout that can 
be added to an existing configuration; those that re-work the entire shell; 
etc.

> There's someone else
> working on a Kwin-QML interface similar to what you would get
> combining Moblin and Gnome, and he's looking at making it a shell.

do you have a link to this?

> referring to shells or activities? You also stated, "we just need to
> add the ability to run a kwin js after the plasma-desktop js for the
> full effect," how do you propose doing this?

the relevant code is in kde-workspace/plasma/desktop/shell

in plasmaapp.cpp there is a method PlasmaApp::createActivityFromScript which 
is currently called from the ActivityManager. this ends up calling 
DesktopCorona::evaluateScripts. createActivityFromScript is not actually very 
activity-specific at all :)

then there is DesktopCorona::addPanel which is similar and called from the Add 
Panel menu. it optionally loads a script, also using evaluateScripts.

so .. what probably needs to be done:

* a new method in DesktopCorona which takes a Plasma::Package to execute (this 
will encapsulate all the script handling in one place; right now it is 
duplicated/scattered across createActivityFromScript, populateAddPanelsMenu, 
ActivityManager::activityTypeActions, etc.)

* in that method, after running the plasma desktop script, if there is a kwin 
script also in the package, trigger kwin (via dbus) to run it
 
> Also, what do I need to look into in integrating a maximized window's
> titlebar into the default panel? This should be enough to get me
> started.

there is the active window plasmoid, but that always shows the window name and 
close button. so .. one could take that plasmoid and modify it so that only if 
the current window is maximized that it shows anything, and you should be 
done.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11360
---


Read up on i18n, ideally most of 
http://techbase.kde.org/Development/Tutorials/Localization/ and double check 
everything again.

Also personally I like to submit a screenshot with any very visual change.


plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


This is not translated.



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


This i18n string doesn't really work.

1) This string doesn't really contain any words, so it's not really 
suitable for translation. At least use i18nc() so translators have context of 
what it is.

2) the state (i.e charging, charged, discharging) is never translated.





plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


This isn't translated.

Also this is a word puzzle.


http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles

You also can't do

if (hrs==1) {
 "hour"
} else {
 "hours"
}
for some languages plurals come after 1st, 11th 111th.. it's not as simple 
as you just wrote.

use i18np.




plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


Don't do this to determine how wide something should be.
What if the japanese for "power management enabled" is only 3 characters 
long and the time remaining is larger?

Even if you could garauntee it's the longest string right now, what if 
someone changes this in the future?

set the Grid to be 
width:childRect.width.

and remove the call to width on all these labels, and that /should/ work. 
(I've not tested that and could be wrong.)


- David Edmundson


On March 13, 2012, 11:59 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 13, 2012, 11:59 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Rename window deocration "Laptop" to "Minimal"

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104282/
---

Review request for kwin and Plasma.


Description
---

The window decoration Laptop is kept for legacy or thin client
setups. To make this more clear the decoration is renamed. In
order to make the transition easier only the name is changed,
while library name is untouched.

Additionally a comment is added which should be shown in the
user interface (requires bug #296041 to be implemented).


Diffs
-

  kwin/clients/laptop/laptop.desktop ccc9d54 
  kwin/clients/laptop/laptopclient.cpp 52efcd1 

Diff: http://git.reviewboard.kde.org/r/104282/diff/


Testing
---


Screenshots
---

Renamed decoration
  http://git.reviewboard.kde.org/r/104282/s/465/


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Drop Decorations B2 and Plastik

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104281/
---

Review request for kwin and Plasma.


Description
---

As discussed on mailinglist: http://lists.kde.org/?l=kwin&m=133136239707091&w=2


Diffs
-

  kwin/clients/CMakeLists.txt 6019a9e 
  kwin/clients/b2/CMakeLists.txt 9295cbe 
  kwin/clients/b2/b2.desktop 2846e39 
  kwin/clients/b2/b2client.h c9e9b57 
  kwin/clients/b2/b2client.cpp 6b52996 
  kwin/clients/b2/bitmaps.h 00c4552 
  kwin/clients/b2/config/CMakeLists.txt 1aaf8da 
  kwin/clients/b2/config/config.h c5bc33c 
  kwin/clients/b2/config/config.cpp fc9c7b9 
  kwin/clients/plastik/CMakeLists.txt fce0829 
  kwin/clients/plastik/config/CMakeLists.txt e48955d 
  kwin/clients/plastik/config/config.h b037efe 
  kwin/clients/plastik/config/config.cpp a4ddfe0 
  kwin/clients/plastik/config/configdialog.ui fe9f53a 
  kwin/clients/plastik/plastik.h ae7a46e 
  kwin/clients/plastik/plastik.cpp ff9825f 
  kwin/clients/plastik/plastik.desktop 30550c6 
  kwin/clients/plastik/plastikbutton.h 395f628 
  kwin/clients/plastik/plastikbutton.cpp db29d76 
  kwin/clients/plastik/plastikclient.h 4c5b0d9 
  kwin/clients/plastik/plastikclient.cpp 58f8324 

Diff: http://git.reviewboard.kde.org/r/104281/diff/


Testing
---

it compiles


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel