Re: Review Request: Fix padding in ToolButton and TabButton

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104319/#review11644
---


This review has been submitted with commit 
37f04317e55b6d66b043bb74e5c50bc4b3fe1d43 by David Edmundson to branch master.

- Commit Hook


On March 17, 2012, 7:44 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104319/
> ---
> 
> (Updated March 17, 2012, 7:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Fix padding in ToolButton and TabButton between icon and text.
> 
> This also brings it in line with the regular button which is done properly.
> 
> 
> Diffs
> -
> 
>   plasma/declarativeimports/plasmacomponents/qml/TabButton.qml dc8d34a 
>   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 0907a22 
> 
> Diff: http://git.reviewboard.kde.org/r/104319/diff/
> 
> 
> Testing
> ---
> 
> Opened in Gallery.
> 
> 
> Screenshots
> ---
> 
> Tab Before
>   http://git.reviewboard.kde.org/r/104319/s/473/
> Tab After
>   http://git.reviewboard.kde.org/r/104319/s/474/
> ToolButton Before
>   http://git.reviewboard.kde.org/r/104319/s/475/
> ToolButton After
>   http://git.reviewboard.kde.org/r/104319/s/477/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11632
---


as for comments on the screenshot, labels on the left should be right-aligned, 
the code seems fine now

- Marco Martin


On March 14, 2012, 6:46 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 14, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/464/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11631
---


are there updates on this? still issues to work out?

- Marco Martin


On March 14, 2012, 6:46 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 14, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/464/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML Plasmoids and complex configs

[Djuro Drljaca]

Actually Aaron apparently already fixed it :)

On Mon, Mar 19, 2012 at 7:31 PM, Djuro Drljaca wrote:

> Will do. But you should find it in the zip file (*.kcrash file ... I agree
> it might be better if it was named backtrace :) ).
>
>
> On Mon, Mar 19, 2012 at 7:28 PM, Marco Martin  wrote:
>
>> On Monday 19 March 2012, Djuro Drljaca wrote:
>> > Aaron: you can find the bug report with the plasmoid and backtrace here
>> -->
>> > https://bugs.kde.org/show_bug.cgi?id=296379
>> >
>>
>> i can only see the plasmoid as attachment, not the backtrace
>> can you put the backtrace inline as a comment? (opposed to as attachment)
>>
>>
>> --
>> Marco Martin
>> ___
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML Plasmoids and complex configs

[Djuro Drljaca]

Will do. But you should find it in the zip file (*.kcrash file ... I agree
it might be better if it was named backtrace :) ).

On Mon, Mar 19, 2012 at 7:28 PM, Marco Martin  wrote:

> On Monday 19 March 2012, Djuro Drljaca wrote:
> > Aaron: you can find the bug report with the plasmoid and backtrace here
> -->
> > https://bugs.kde.org/show_bug.cgi?id=296379
> >
>
> i can only see the plasmoid as attachment, not the backtrace
> can you put the backtrace inline as a comment? (opposed to as attachment)
>
>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML Plasmoids and complex configs

[Marco Martin]

On Monday 19 March 2012, Djuro Drljaca wrote:
> Aaron: you can find the bug report with the plasmoid and backtrace here -->
> https://bugs.kde.org/show_bug.cgi?id=296379
> 

i can only see the plasmoid as attachment, not the backtrace
can you put the backtrace inline as a comment? (opposed to as attachment)


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Creating windows without a minimize button

[Aaron J. Seigo]

On Monday, March 19, 2012 16:46:23 Thomas Lübking wrote:
> b) I still do believe that this should be handled by the taskbar because
> it is the item with limited access.

agreed; showing minimized windows that are minimized makes sense imo, even if
otherwise marked as "don't show in taskbar". it's conceptually a bit odd, but
in practice probably works better

--
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML Plasmoids and complex configs

[Djuro Drljaca]

Aaron: you can find the bug report with the plasmoid and backtrace here -->
https://bugs.kde.org/show_bug.cgi?id=296379

Regards,
Djuro Drljaca

On Mon, Mar 19, 2012 at 11:08 AM, Djuro Drljaca wrote:

> I will do it when I get back home (Qt was compiling until 0:30 :) so there
> was no time to try it).
>
> Regards,
> Djuro Drljaca
>
> On Mon, Mar 19, 2012 at 11:05 AM, Aaron J. Seigo  wrote:
>
>> On Sunday, March 18, 2012 21:32:19 Djuro Drljaca wrote:
>> > No, but it should be very easy to reproduce. I did something like this
>> in
>> > main.xml:
>>
>> if you can provide a link to a plasmoid package where this is
>> reproduceable,
>> then i can probably find time to reproduce it here and see what can be
>> done.
>> but a backtrace would be appreciated :)
>>
>> --
>> Aaron Seigo
>> ___
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Creating windows without a minimize button

[Nikos Chantziaras]

On 19/03/12 17:46, Thomas Lübking wrote:

Am 19.03.2012, 02:23 Uhr, schrieb Nikos Chantziaras :


On 18/03/12 15:04, Martin Gräßlin wrote:

The hint you want to
set would only remove the minimize button but does not prevent you from
minimizing the window as like I wrote there is no hint to forbid window
minimization. This of course applies for all X11 based window managers
(other platforms like Mac OS or Microsoft Windows are irrelevant),
especially also for GNOME's Metacity as KWin follows Metacity's
interpretation of Motif hints: "To quote from Metacity 'We support those
MWM hints deemed non-stupid'".


Hmm, can you elaborate a bit on this? As mentioned, I tried Gnome (on
Debian 6), and Metacity (v2.30.1) doesn't show a minimize button.
Also, it doesn't allow for minimizing through the title bar system
menu (the "Minimize" menu item is grayed out.)


[...]
Please trust me or Martin or google for thoughts on MWM hints - whatever
is the solution of your issue (i don't say there's none) it is NOT the
MWM hints.
Period ;-)


There's no issue, really.  I just noticed that under KDE, the dialogs of 
my application can be minimized and therefore vanish.  They can't be 
brought back in any intuitive way.  I don't have a big problem with it 
personally, so no issue here.  I can just refrain from minimizing, since 
there's no reason to do that to begin with.  Why would I even want to 
minimize the "About" window?  It just seemed strange that I *can*.  I 
just brought this up here since it seems like a bug, especially since 
only KDE showed this behavior.  If KDE says this is how it should be, 
then that's how it shall be.


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] Mission Statement for KWin

[Martin Gräßlin]

Am 19.03.2012 09:35, schrieb Luca Beltrame:

In data lunedì 19 marzo 2012 09:27:20, Martin Gräßlin ha scritto:

Hello Martin,

I have written down something like a "Mission Statement" for KWin 
[1]

and I would like to get your input on what I have written.


It is a good starting point. I would soften the stance on network
transparency
because it is still used, likely on the line of "it is not its
primary focus,
but it is certainly possible". It comes off less strong than "not 
designed

with".
What I find important is also to describe the current situation as it 
is right now. For Network Transparency the current situation is that the 
following topics are very bad suited for it:

* OpenGL 2 based Compositing
* Window Decorations (especially Oxygen)
* TabBox (written in QML)
* Desktop Change OSD (written in QML)
* Graphics system raster

to me that all does not look like KWin still supports Network 
Transparency at all. Especially Alt+Tab in QML is quite a showstopper 
for the usage on remote setups. The fact that "it is still used" does 
not make it work. It is possible to use KWin with Network Transparency 
but it won't be a pleasant experience and I would not recommend anyone 
to use KWin for Network Transparency.


Cheers
Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Creating windows without a minimize button

[Thomas Lübking]

Am 19.03.2012, 02:23 Uhr, schrieb Nikos Chantziaras :


On 18/03/12 15:04, Martin Gräßlin wrote:

The hint you want to
set would only remove the minimize button but does not prevent you from
minimizing the window as like I wrote there is no hint to forbid window
minimization. This of course applies for all X11 based window managers
(other platforms like Mac OS or Microsoft Windows are irrelevant),
especially also for GNOME's Metacity as KWin follows Metacity's
interpretation of Motif hints: "To quote from Metacity 'We support those
MWM hints deemed non-stupid'".


Hmm, can you elaborate a bit on this?  As mentioned, I tried Gnome (on  
Debian 6), and Metacity (v2.30.1) doesn't show a minimize button.  Also,  
it doesn't allow for minimizing through the title bar system menu (the  
"Minimize" menu item is grayed out.)


I'll jump in here since i don't know how much time Martin has at.

Aside that the comment is about a decade old or so, Metacity still gives a  
s*** on your hints ;-)
So does compiz. E17 and awesome do not care about MWM hits at all (not  
even whether the bar is decorated)


The Button layout comes with the NETWM window type (proof attached, feel  
free to play with it)
Metacity does not allow dialogs (any dialog) to minimize or maximize,  
compiz only to maximize, E17 allows you to configure the decoration style  
even at runtime and awesome does not have titlebars ;-)


Please trust me or Martin or google for thoughts on MWM hints - whatever  
is the solution of your issue (i don't say there's none) it is NOT the MWM  
hints.

Period ;-)
NETWM was introduced for the idea that windows should not control their  
window behavior, but hint a reasonable type and let the WM / DE decide  
what to do with it.


I wonder if KWin could do the same.  On first sight, it doesn't seem to  
break anything.
As mentioned before, kwin used to prevent minimization of transients, the  
pre-pre-maintainer (not me ;-) altered that because kwin started to handle  
modal dialogs smarter (see my former mail)


Most important here is that sheer transients (different from modals*) have  
no strong context with their leaders, ie. if you've an open dialog and  
allow the main window to be up w/o the open dialog, the main window is  
"dead" for no apparent reason.
On the other hand you can open a bazillion file property dialogs and  
happily close a bazillion - 1 to unclutter your desktop. Dolphin remains  
fully usable all the time.


Now, i don't know whether you want to argue that no dialog should ever be  
minimizable or maximizable, but if you argue for the taskbar, non of my  
windows should be minimizable because my "taskbar" shows no windows at all.


It's not like we are not aware that the taskbar handling of transients as  
"skiptaskbar" (yes there's an explicit WM_STATE hint for that) causes an  
issue in context with the relaxed handling of them in kwin (present bug  
report, see former mail as well), but:

a) MWM is not a solution (i hope you got that now ;-)
b) I still do believe that this should be handled by the taskbar because  
it is the item with limited access.
-> i cc'd plasma and craig - if there'd be consens about handling this in  
libtaskbar, i'll happily write a patch.



Cheers,
Thomas

*there's btw. confusion about that at the mutter fraction, there's a  
wiki which suggests to rely on MWM hints for that, we might want to  
contact them

transiency.cpp
Description: Binary data
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: request for review

[Shaun Reich]

On Mon, Mar 19, 2012 at 6:28 AM, Sebastian Kügler  wrote:
> (Positive, because it works, negative, because I
> might have been looking for my furry porn collection, not something I'd want
> to tell any web services.)

yeah, good point. i don't want google knowing i'm into furry porn either.

as for what other people mentioned about the prefixes. i currently
have it activated by typing in "videos kde" and "images something". is
that acceptable? although i will be adding a flickr runner...so how
can i set it to be disabled by default?

-- 
Shaun Reich,
KDE Software Developer (kde.org)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: request for review

[Shaun Reich]

On Mon, Mar 19, 2012 at 6:33 AM, Alex Fiestas  wrote:
> On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote:
>> Hey,
>>
>> One potential issue I see is that you ship the youtube logo inside the
>> runner. We might not be allowed to redistribute it as that.
>>
>> It also scales badly, so looks visually tarred.
>>
>> Can you check the license of the youtube logo, and if we're allowed to ship
>> it, make it look correct?
> I checked that back in the days when added youtube support to Kamoso, iirc you
> can use the youtube logo but without modifications (which makes sense). They
> also provide a policy on which logo you should use depending where you use it.


i checked it as well. from what i understood, you can can modify it as
long as it "still resembles the youtube logo". e.g. you can change the
background colors and stuff like that. they were pretty flexible on it
from what i gathered.

-- 
Shaun Reich,
KDE Software Developer (kde.org)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] Mission Statement for KWin

[Artur de Souza]

Quoting Martin Gräßlin :


I have written down something like a "Mission Statement" for KWin [1]
and I would like to get your input on what I have written.


I think it's good enough and puts KWin's mission in a very good way :)

Cheers,

--
---
http://claimid.com/morpheuz
Blog: http://blog.morpheuz.cc
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net

---

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: request for review

[Dario Freddi]

Il 19 marzo 2012 11:33, Alex Fiestas  ha scritto:
>> Also, enabling these runners by default, which you've essentially done,
>> brings a great privacy problem -- everything I type into KRunner is sent to
>> Google and Bing -- that's not acceptable as such, at least should be
>> discussed before we introduce this kind of change. I was pretty surprised
>> when I saw youtube movies in my krunner results. (Positive, because it
>> works, negative, because I might have been looking for my furry porn
>> collection, not something I'd want to tell any web services.)
>
> In theory they will only be triggered if the prefix match, kinda
>
> youtube: kde rocks

^ +1 to this. Having the (any) runner sending out anything I write on
the internet without my explicit consent is a no-go IMHO.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Pedantic Nitpicking Issues in KRunner

[todd rme]

On Mon, Mar 19, 2012 at 11:07 AM, Aaron J. Seigo  wrote:
> On Monday, March 19, 2012 10:10:49 todd rme wrote:
>> On Sun, Mar 18, 2012 at 8:47 PM, Aaron J. Seigo  wrote:
>> > On Sunday, March 18, 2012 01:33:09 David Edmundson wrote:
>> >> * The help view is scrollable, but there is no indication of this.
>> >>
>> >>     On the desktop, it's not natural to try to scroll on areas without
>> >> scrollbars. All scroll areas should have scrollbars.
>> >
>> > this has been discussed before. krunner's view area will not have scroll
>> > bars.
>> >
>> > the help info is shown in a very quick-n-dirty way: re-using the results
>> > view method. a nice help info specific presentation would be nice and is
>> > probably the best solution here.
>>
>> What about putting the help in the "about" dialog for each runner?
>
> it uses the generic kde plugin selector, so this would require some work on
> that component in kdelibs (which isn't a showstopper, just means it needs to
> become a generic solution)
>
> however, i'm not sure that the user should be concerned about which runner
> something comes from. it should just be "the set of features currently
> available"
>
> --
> Aaron J. Seigo

That makes sense of users are trying to see what krunner can do.  But
there is currently no easy way to figure out how to use a specific
runner.

So say someone downloads a third-party runner, say the public
transport runner, because they want to use it to find a departure
time.  This person has installed a specific runner with the goal of
carrying out a specific task.  Now the user wants to know how to carry
out that task.  The only way to do that is to look individually at
every entry in the help list, since they are sorted by command (which
the user in this situation does not know).  On my computer that is
entry number 40 in the help list.

This is true in any situation where a user has a specific goal they
want to accomplish.  If users want get an introduction to krunner and
what it can do, the help function is useful.  But it is tedious to
find out how to user a specific runner or carry out a specific task.

It is also an issue if a user is deciding whether to turn a runner on
or off, and wants to know what it is capable of so they can determine
if they need it or not.

-Todd
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: request for review

[Aaron J. Seigo]

On Monday, March 19, 2012 11:33:13 Alex Fiestas wrote:
> In theory they will only be triggered if the prefix match, kinda
> 
> youtube: kde rocks

this is easy for the runner itself to do.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: request for review

[Alex Fiestas]

On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote:
> Hey,
> 
> One potential issue I see is that you ship the youtube logo inside the
> runner. We might not be allowed to redistribute it as that.
> 
> It also scales badly, so looks visually tarred.
> 
> Can you check the license of the youtube logo, and if we're allowed to ship
> it, make it look correct?
I checked that back in the days when added youtube support to Kamoso, iirc you 
can use the youtube logo but without modifications (which makes sense). They 
also provide a policy on which logo you should use depending where you use it.

> Also, enabling these runners by default, which you've essentially done,
> brings a great privacy problem -- everything I type into KRunner is sent to
> Google and Bing -- that's not acceptable as such, at least should be
> discussed before we introduce this kind of change. I was pretty surprised
> when I saw youtube movies in my krunner results. (Positive, because it
> works, negative, because I might have been looking for my furry porn
> collection, not something I'd want to tell any web services.)

In theory they will only be triggered if the prefix match, kinda

youtube: kde rocks

If that can't be done for whatever reason then yes, we should disabled them by 
default (I already pushed that change a week ago).
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: request for review

[Sebastian Kügler]

Hey,

One potential issue I see is that you ship the youtube logo inside the runner. 
We might not be allowed to redistribute it as that.

It also scales badly, so looks visually tarred.

Can you check the license of the youtube logo, and if we're allowed to ship 
it, make it look correct?

Also, enabling these runners by default, which you've essentially done, brings 
a great privacy problem -- everything I type into KRunner is sent to Google 
and Bing -- that's not acceptable as such, at least should be discussed before 
we introduce this kind of change. I was pretty surprised when I saw youtube 
movies in my krunner results. (Positive, because it works, negative, because I 
might have been looking for my furry porn collection, not something I'd want 
to tell any web services.)

Cheers,
-- sebas

On Friday, March 16, 2012 13:10:54 Shaun Reich wrote:
> i recently merged some new runners into master kdeplasma-addons
> without a review and i apologize for that (the motivation actually was
> because i was having some difficulties making some packages and had a
> few repos that needed it, but that's moot now).
> 
> either way, i've got the tar if you've got the feathers ;-)
> 
> i can file a formal review request if that makes things easier. i will
> do so later for the non-merged duckduckgo runner, so as to not repeat
> the same mistake.
> 
> but the only things of interest here are the youtube and bing runners.
> the bing one is the same exact thing, except for bing obviously.
> 
> https://projects.kde.org/projects/kde/kdeplasma-addons/repository/revisions/
> master/entry/runners/youtube/youtube.cpp
> 
> https://projects.kde.org/projects/kde/kdeplasma-addons/repository/revisions/
> master/entry/runners/youtube/tubejob.cpp
> 
> the code's relatively straight forward, because json > xml ;)
> 
> the reason why i had to use bing for image searching is because google
> is evil and their api has some silly 1k queries/day/key limit, which
> we could easily outcap. and ironically, bing doesn't have any limits
> on their api. i'm probably going to work on a flickr runner as well,
> because we need more integration with the internets.
> 
> i do have a question however, as to why matches get triggered (even
> for the mediawiki engine which currently resides in there, afict),
> even though it isn't in singlerunnermode, and the prefix isn't being
> hit. e.g. user is typing in "some query" would trigger a match for
> that runner, instead of it only being triggered by "wiki some query".
> any ideas on that?
> 
> seems like a waste of resources if it is in fact unnecessary.
> 
> there is an issue with the icon being installed though. i copied the
> icons from some kipi plugin, because they also happened to have a
> youtube icon set so that saved time.
> 
> however, it now means we have 2 sets of icons being installed. also,
> i'm installing the icons simply by running: kde4_install_icons(
> ${ICON_INSTALL_DIR} )
> 
> is there a good fix for this?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add missing property alias "animation" in Slider Plasma Component

[David Edmundson]

> On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote:
> > what is the use case for knowing if it is animated or not? this seems like 
> > an internal implementation detail?
> 
> David Edmundson wrote:
> I assume it's more for setting whether it animates or not. (when the user 
> clicks on the slider, whether it slides to the new value) Tbh, I'm with you 
> that it's not needed. 
> 
> However the gallery is full of 
> Slider {
> 
>  animated:true;
> } 
> 
> and the documentation at the top of this file says:
> 
> bool animated
> This property holds if the slider will animate or not when other point is 
> clicked,
> and the slider handler is not being dragged. The default value is false.
> 
> So it looked to me like it was meant to exist, and was missed off.
> 
> Aaron J. Seigo wrote:
> it did exist, but was pulled from the code as it should be an 
> implementation detail that is kept consistent within the component set, not 
> controlled by the individual application using the components. from irc today:
> 
> [10:51]  notmart: 
> https://git.reviewboard.kde.org/r/104318/#review11571 <--- do you know why 
> there is an animated property?
> [10:52] * notmart looks
> [10:52]  should be definitely be something not controllable
> [10:53]  aseigo: i'll say, remove it from the documentation 
> rather adding in the code right?
> [10:54]  i think i yanked it in the past but forgot from the docs
> [10:58]  cool. that's what i thought but figured i should ask :)
> 
> so the right fix would be to just remove the documentation :) please do 
> so and commit at your leisure (closing this review in the process) ...

Cool, I should have checked the history.

Make sure Gallery/Sliders.qml is updated too.


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104318/#review11571
---


On March 17, 2012, 7:27 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104318/
> ---
> 
> (Updated March 17, 2012, 7:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Add missing property alias "animation" in Slider Plasma Component
> 
> Item now matches it's own documentation.
> 
> 
> Diffs
> -
> 
>   plasma/declarativeimports/plasmacomponents/qml/Slider.qml 447dbb1 
> 
> Diff: http://git.reviewboard.kde.org/r/104318/diff/
> 
> 
> Testing
> ---
> 
> Tested in Component Gallery (which didn't work before!) 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML Plasmoids and complex configs

[Djuro Drljaca]

I will do it when I get back home (Qt was compiling until 0:30 :) so there
was no time to try it).

Regards,
Djuro Drljaca

On Mon, Mar 19, 2012 at 11:05 AM, Aaron J. Seigo  wrote:

> On Sunday, March 18, 2012 21:32:19 Djuro Drljaca wrote:
> > No, but it should be very easy to reproduce. I did something like this in
> > main.xml:
>
> if you can provide a link to a plasmoid package where this is
> reproduceable,
> then i can probably find time to reproduce it here and see what can be
> done.
> but a backtrace would be appreciated :)
>
> --
> Aaron Seigo
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Pedantic Nitpicking Issues in KRunner

[Aaron J. Seigo]

On Monday, March 19, 2012 10:10:49 todd rme wrote:
> On Sun, Mar 18, 2012 at 8:47 PM, Aaron J. Seigo  wrote:
> > On Sunday, March 18, 2012 01:33:09 David Edmundson wrote:
> >> * The help view is scrollable, but there is no indication of this.
> >> 
> >> On the desktop, it's not natural to try to scroll on areas without
> >> scrollbars. All scroll areas should have scrollbars.
> > 
> > this has been discussed before. krunner's view area will not have scroll
> > bars.
> > 
> > the help info is shown in a very quick-n-dirty way: re-using the results
> > view method. a nice help info specific presentation would be nice and is
> > probably the best solution here.
> 
> What about putting the help in the "about" dialog for each runner?

it uses the generic kde plugin selector, so this would require some work on 
that component in kdelibs (which isn't a showstopper, just means it needs to 
become a generic solution)

however, i'm not sure that the user should be concerned about which runner 
something comes from. it should just be "the set of features currently 
available"

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML Plasmoids and complex configs

[Aaron J. Seigo]

On Sunday, March 18, 2012 21:32:19 Djuro Drljaca wrote:
> No, but it should be very easy to reproduce. I did something like this in
> main.xml:

if you can provide a link to a plasmoid package where this is reproduceable, 
then i can probably find time to reproduce it here and see what can be done. 
but a backtrace would be appreciated :)

-- 
Aaron Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add missing property alias "animation" in Slider Plasma Component

[Aaron J. Seigo]

> On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote:
> > what is the use case for knowing if it is animated or not? this seems like 
> > an internal implementation detail?
> 
> David Edmundson wrote:
> I assume it's more for setting whether it animates or not. (when the user 
> clicks on the slider, whether it slides to the new value) Tbh, I'm with you 
> that it's not needed. 
> 
> However the gallery is full of 
> Slider {
> 
>  animated:true;
> } 
> 
> and the documentation at the top of this file says:
> 
> bool animated
> This property holds if the slider will animate or not when other point is 
> clicked,
> and the slider handler is not being dragged. The default value is false.
> 
> So it looked to me like it was meant to exist, and was missed off.

it did exist, but was pulled from the code as it should be an implementation 
detail that is kept consistent within the component set, not controlled by the 
individual application using the components. from irc today:

[10:51]  notmart: https://git.reviewboard.kde.org/r/104318/#review11571 
<--- do you know why there is an animated property?
[10:52] * notmart looks
[10:52]  should be definitely be something not controllable
[10:53]  aseigo: i'll say, remove it from the documentation rather 
adding in the code right?
[10:54]  i think i yanked it in the past but forgot from the docs
[10:58]  cool. that's what i thought but figured i should ask :)

so the right fix would be to just remove the documentation :) please do so and 
commit at your leisure (closing this review in the process) ...


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104318/#review11571
---


On March 17, 2012, 7:27 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104318/
> ---
> 
> (Updated March 17, 2012, 7:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Add missing property alias "animation" in Slider Plasma Component
> 
> Item now matches it's own documentation.
> 
> 
> Diffs
> -
> 
>   plasma/declarativeimports/plasmacomponents/qml/Slider.qml 447dbb1 
> 
> Diff: http://git.reviewboard.kde.org/r/104318/diff/
> 
> 
> Testing
> ---
> 
> Tested in Component Gallery (which didn't work before!) 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add missing property alias "animation" in Slider Plasma Component

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104318/#review11611
---


actually it was removed and i did forget to remove it from the docs as well.

the rationale is that component users shouldn't be able to have a so fine 
grained control over the appearance otherwise components miss one of their main 
points that is enforcing consistency.

what would be cool is having all animations following a global on/off switch, 
even tough there isn't much infrastructure for it at the moment

- Marco Martin


On March 17, 2012, 7:27 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104318/
> ---
> 
> (Updated March 17, 2012, 7:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Add missing property alias "animation" in Slider Plasma Component
> 
> Item now matches it's own documentation.
> 
> 
> Diffs
> -
> 
>   plasma/declarativeimports/plasmacomponents/qml/Slider.qml 447dbb1 
> 
> Diff: http://git.reviewboard.kde.org/r/104318/diff/
> 
> 
> Testing
> ---
> 
> Tested in Component Gallery (which didn't work before!) 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Breadcrumbs in Kickoff, IMPORTANT FIXUP

[Mark]

On Mon, Mar 19, 2012 at 8:15 AM, Rick Stockton <
rickstock...@reno-computerhelp.com> wrote:

>  I'll top post this one:
>
> OOPS! And PLEASE ignore my post, in Vol 45/Issue 46, where I talked about
> this being requiring "just an easy change": This requires no changes at
> all. It's already supported, and it even works back in 4.7.4. (Maybe
> earlier, but 4.7.4 is the earliest Release I have "lying around" for test
> purposes.)
>
> You only need to ignore the Doco Comment about acceptedButtons taking only
> 3 values ;) Y can give it all 5, like this:
>
> acceptedButtons: Qt.LeftButton | Qt.RightButton
>| Qt.MiddleButton | Qt.XButton1
> | Qt.XButton2
>
> and your MouseArea will start getting Press and Release events (plus
> DoubleClick, plus Press and Hold) for 'BackButton' and 'ForwardButton'.
> Here's my Test/Demo/Example program for you to try, and use as a model
> (just run it using "qmlviewer"): http://pastebin.kde.org/442676/ I set
> the expiration on that Paste at 30 days. It will be an official example,
> but with 27 buttons, in Qt5.
>
> On 03/18/2012 05:27 AM, Mark wrote:
>
> On Sun, Mar 18, 2012 at 1:56 AM, Xavier Sythe  wrote:
>
>> As far as I can recall, it was decided that the "back button" would be
>> implemented in the new Kickoff as support for the mouse's "back button", as
>> well as support for the "backspace" key, in conjunction with the other
>> keyboard navigation. (arrow keys)
>>
>>  I would appreciate Martin and Aaron's confirmation that this is the
>> finalized concept that will be implemented for 4.9.
>>
>>  Cheers,
>> Xavier
>>
>
>
>  I can confirm (or actually deny) that partly.
> They did indeed want to do that, however it was then figured out that QML
> didn't get all the mouse events required for that. That should be fixed in
> Qt5 but not in Qt4. So i'm afraid the mouse back/forward button support
> isn't going to be in anytime soon.
>
>
> Why isn't that documented on the Qt site
http://qt-project.org/doc/qt-4.8/qml-mousearea.html#acceptedButtons-prop?
That really sucks!

Nice to know that it's possible :)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Pedantic Nitpicking Issues in KRunner

[todd rme]

On Sun, Mar 18, 2012 at 8:47 PM, Aaron J. Seigo  wrote:
> On Sunday, March 18, 2012 01:33:09 David Edmundson wrote:
>> * The help view is scrollable, but there is no indication of this.
>>
>>     On the desktop, it's not natural to try to scroll on areas without
>> scrollbars. All scroll areas should have scrollbars.
>
> this has been discussed before. krunner's view area will not have scroll bars.
>
> the help info is shown in a very quick-n-dirty way: re-using the results view
> method. a nice help info specific presentation would be nice and is probably
> the best solution here.

What about putting the help in the "about" dialog for each runner?

-Todd
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] Mission Statement for KWin

[Luca Beltrame]

In data lunedì 19 marzo 2012 09:27:20, Martin Gräßlin ha scritto:

Hello Martin,

> I have written down something like a "Mission Statement" for KWin [1]
> and I would like to get your input on what I have written.

It is a good starting point. I would soften the stance on network transparency
because it is still used, likely on the line of "it is not its primary focus,
but it is certainly possible". It comes off less strong than "not designed
with".

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[RFC] Mission Statement for KWin

[Martin Gräßlin]

Hi all,

I have written down something like a "Mission Statement" for KWin [1]
and I would like to get your input on what I have written.

Why have I written that?
Lately I have been rather dissatisfied with the results of some 
additions

to KWin done by non core developers (e.g. Scripting, Tabbing, Tiling)
and I don't want to see us allowing such code to enter ever again.

The second thing is that while going through (err closing) most of our
feature request I realized that we don't have any reference to give to
our users why the specific feature request won't be implemented or
conflicts with what KWin wants to be.

So I hope that this helps us in future to evaluate features against it
and at the same time make it not appear like random decisions.

Cheers
Martin

[1] http://community.kde.org/KWin/Mission_Statement

P.S.: might have problems replying, so don't wonder if you don't see 
anything the next two days

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Breadcrumbs in Kickoff, IMPORTANT FIXUP

[Rick Stockton]

  
  
I'll top post this one:

OOPS! And PLEASE ignore my post, in Vol 45/Issue 46, where I talked
about this being requiring "just an easy change": This requires no
changes at all. It's already supported, and it even works back in
4.7.4. (Maybe earlier, but 4.7.4 is the earliest Release I have
"lying around" for test purposes.)

You only need to ignore the Doco Comment about acceptedButtons
taking only 3 values ;) Y can give it all 5, like this:

acceptedButtons: Qt.LeftButton | Qt.RightButton
   | Qt.MiddleButton |
Qt.XButton1 | Qt.XButton2 

and your MouseArea will start getting Press and Release events (plus
DoubleClick, plus Press and Hold) for 'BackButton' and
'ForwardButton'.
Here's my Test/Demo/Example program for you to try, and use as a
model (just run it using "qmlviewer"):
http://pastebin.kde.org/442676/ I set the expiration on that Paste
at 30 days. It will be an official example, but with 27 buttons, in
Qt5.

On 03/18/2012 05:27 AM, Mark wrote:

  On Sun, Mar 18, 2012 at 1:56 AM, Xavier
Sythe  wrote:

  As far as I can recall, it was decided that the "back button"
  would be implemented in the new Kickoff as support for the
  mouse's "back button", as well as support for the "backspace"
  key, in conjunction with the other keyboard navigation. (arrow
  keys)
  

  
  I would appreciate Martin and Aaron's confirmation that
this is the finalized concept that will be implemented for
4.9.
  
  
  Cheers,
  Xavier
   


I can confirm (or actually deny) that partly.
They did indeed want to do that, however it was then
  figured out that QML didn't get all the mouse events required
  for that. That should be fixed in Qt5 but not in Qt4. So i'm
  afraid the mouse back/forward button support isn't going to be
  in anytime soon.

  


  

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel