Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)
> On April 12, 2012, 8:37 a.m., Ivan Čukić wrote: > > Ship It! I just realized that i closed it by accident. - makis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12348 --- On April 12, 2012, 8:23 a.m., makis marimpis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104428/ > --- > > (Updated April 12, 2012, 8:23 a.m.) > > > Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić. > > > Description > --- > > (follows discarded review: 104391) > > The plugin adds global keyboard shortcuts for changing the activity. > Defaults start from Qt::MetaModifier + Qt::Key_F1. > > Initially, this functionality was implemented (without correct results) using > KActitivities::Controller. > Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds > delay - so it really needs modification/and i would like more guidance > related to dbus :D. > Other than that, feedback is needed. > > > This addresses bugs 265069 and 273467. > http://bugs.kde.org/show_bug.cgi?id=265069 > http://bugs.kde.org/show_bug.cgi?id=273467 > > > Diffs > - > > service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 > service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION > > service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop > PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104428/diff/ > > > Testing > --- > > Logged in. > Used the default shortcuts to switch activities. > It works! > > > Thanks, > > makis marimpis > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Files, config, and welcome (again)
Hello, I have already written to this list and some of you might know me from other channels (like IRC or StatusNet). Either way - hi and hello! Also, I hope I am writing in the right place. If not, do tell and point me in the right direction. Now, to the point! I am writing a Todo/tasks plasmoid, inspired by TaskTimer. Here's my braindump about it: http://rys.io/en/71 One thing I am missing at this moment, and am missing dearly, is a way to save the state of the tasks (text, elapsed time, etc) so that it gets restored upon plasmoid "restart" (not sure if this is the right word). This can be easily done with a simple JSON text file, or even an INI file for that matter. So basically what I need is either a config store or a way to read/write pure text files. I tried using the KConfig XT, but surprisingly the values did not get saved (yes, main.xml file is created and contains the right stuff); this happened even with the kdeexamples configuration example. Besides, I am wondering if the rigid structure of KConfig XT files is a good bet here; I am adding/removing todo items in the plasmoid, and as far as I understand config entries are defined beforehand - so I would have to store key-value pairs (in JSON?) within the config XML file. Doesn't seem "right". So, three questions: - am I missing something about the KConfig XT approach? - maybe there is a better config API for QML/JS plasmoids? - is there a way to read/write files from a QML/JS plasmoid? I am running KDE SC 4.7.4 in Debian Sid. -- Pozdrawiam Michał "rysiek" Woźniak Fundacja Wolnego i Otwartego Oprogramowania signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QML Lock/logout applet
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/#review12448
---
Couldn’t we add a "Hibernate" dialog, similar to the confirmation on shutdown,
i.e that dialog that counts down "Shutting down in 30 seconds" with the ability
to cancel it? You press Hibernate, and a KSMserver dialog (that we don’t have
yet?) pops up and after 30 seconds, it will hibernate anway. This way, if you
miss the dialog, e.g. you are in a hurry, it will proceed after the countdown
runs out.
- Kai Uwe Broulik
On April 13, 2012, 6:18 p.m., Viranch Mehta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104592/
> ---
>
> (Updated April 13, 2012, 6:18 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> ---
>
> This patch essentially contains the new QML lock logout applet, along with
> required changes to powermanagement engine.
>
> The patch contains *some* irrelevant code too (in powermanagement data
> engine) since the same branch has QML battery applet. So it'd be best to
> checkout plasma/viranch/powermanagementservices branch and compile
> plasma/generic/{applets/lockout,dataengines/powermanagement} instead of using
> the attached patch.
>
> Two pending issues with the applet:
> - There is no shine on the icons on hover.
> - Sleep/Hibernate actions do not ask for confirmation, as does the current
> C++ version
>
> Comments welcome on this thread :)
>
>
> Diffs
> -
>
> plasma/generic/applets/lock_logout/CMakeLists.txt a19615b
> plasma/generic/applets/lock_logout/contents/config/main.xml PRE-CREATION
> plasma/generic/applets/lock_logout/contents/ui/config.ui PRE-CREATION
> plasma/generic/applets/lock_logout/contents/ui/data.js PRE-CREATION
> plasma/generic/applets/lock_logout/contents/ui/lockout.qml PRE-CREATION
> plasma/generic/applets/lock_logout/lockout.h 94f33cf
> plasma/generic/applets/lock_logout/lockout.cpp 830e64b
> plasma/generic/applets/lock_logout/lockoutConfig.ui d9285c2
> plasma/generic/applets/lock_logout/metadata.desktop PRE-CREATION
> plasma/generic/applets/lock_logout/plasma-applet-lockout.desktop d8a4337
> plasma/generic/dataengines/powermanagement/CMakeLists.txt 9f2a528
> plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
> plasma/generic/dataengines/powermanagement/powermanagementengine.cpp
> 5572fcb
> plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
> plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
>
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations
> ad1301f
>
> Diff: http://git.reviewboard.kde.org/r/104592/diff/
>
>
> Testing
> ---
>
> - Tested inside horizontal/vertical panels and floating on desktop, sizing
> works as expected.
> - There may be some unexpected behavior if the panel containing the applet is
> changed from being horizontal to vertical or vice-versa.
>
>
> Screenshots
> ---
>
> Screenshot of the applet on desktop
> http://git.reviewboard.kde.org/r/104592/s/526/
>
>
> Thanks,
>
> Viranch Mehta
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Misc minor fixes in KRunner.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104431/#review12430 --- This review has been submitted with commit 611c461bcf3687d02a9b1078f1451bc7f81bdd94 by David Edmundson to branch master. - Commit Hook On April 6, 2012, 10:20 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104431/ > --- > > (Updated April 6, 2012, 10:20 p.m.) > > > Review request for Plasma. > > > Description > --- > > * Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is > implied from the context and to bring consistency. > * Add correct icon for activities runner > * Use correct case in description of "places" runner. > * Use correct case in Webshorts runner description > * Match top and bottom margin sizes. This updates a bodge that removed 2 > pixels from the top margin to only use 1. > * Reword "Available Features" to "Available Plugins" for consistency > * Make the krunner config dialog appear to load slightly faster by loading > the list of plugins after we've shown the dialog. > * Remove undefined (and unused) private method. > > > Diffs > - > > krunner/configdialog.h a9c353a > krunner/configdialog.cpp 80485ca > krunner/krunnerdialog.cpp 007887f > plasma/generic/runners/activities/plasma-runner-activityrunner.desktop > 853c680 > plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop > 0319463 > plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 > plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop > f234b4f > > Diff: http://git.reviewboard.kde.org/r/104431/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Misc minor fixes in KRunner.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104431/#review12429 --- Ship it! Ship It! - Lamarque Vieira Souza On April 6, 2012, 10:20 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104431/ > --- > > (Updated April 6, 2012, 10:20 p.m.) > > > Review request for Plasma. > > > Description > --- > > * Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is > implied from the context and to bring consistency. > * Add correct icon for activities runner > * Use correct case in description of "places" runner. > * Use correct case in Webshorts runner description > * Match top and bottom margin sizes. This updates a bodge that removed 2 > pixels from the top margin to only use 1. > * Reword "Available Features" to "Available Plugins" for consistency > * Make the krunner config dialog appear to load slightly faster by loading > the list of plugins after we've shown the dialog. > * Remove undefined (and unused) private method. > > > Diffs > - > > krunner/configdialog.h a9c353a > krunner/configdialog.cpp 80485ca > krunner/krunnerdialog.cpp 007887f > plasma/generic/runners/activities/plasma-runner-activityrunner.desktop > 853c680 > plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop > 0319463 > plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 > plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop > f234b4f > > Diff: http://git.reviewboard.kde.org/r/104431/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
