Re: Review Request: Add comment to blackboard applet

[Maarten De Meyer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105704/
---

(Updated Aug. 23, 2012, 11:13 a.m.)


Review request for Plasma.


Changes
---

I hope it works now :)


Description
---

Add a comment (description) to the blackboard applet.
Feedback welcome.

I do not have commit access. This introduces a new string.


This addresses bug 302636.
http://bugs.kde.org/show_bug.cgi?id=302636


Diffs (updated)
-

  applets/blackboard/plasma-applet-blackboard.desktop 298316e 

Diff: http://git.reviewboard.kde.org/r/105704/diff/


Testing
---


Thanks,

Maarten De Meyer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/#review17927
---



konsole/konsolepreviewer.cpp


Would be useful if the user was told what to do about it (i.e. either give 
the name of the expected file, or explain where you can set the name (and what 
it should be).



mainwindow.cpp


I don't really like this deviation in behavior, mainly because I don't see 
a reason for it.

I think the behaviour of opening the konsole from the previewer is not 
ideal anyway, since that's a very unusual way to trigger a change in the main 
UI. The issue you're trying to address here is in the previewer, and access to 
the console should be in the main UI anyway (i.e. menu entry, shortcut, and 
possibly toolbar action).



mainwindow.cpp


Seems like a toggle button (checkable) is needed here, instead of trying to 
come up with whacky new concepts of doing the exact same =).


- Sebastian Kügler


On Aug. 22, 2012, 9:34 a.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106118/
> ---
> 
> (Updated Aug. 22, 2012, 9:34 a.m.)
> 
> 
> Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and 
> Giorgos Tsiapaliwkas.
> 
> 
> Description
> ---
> 
> Hello,
> 
> This patch is adding the konsolepreviewer support to the KWin Scripts.
> When the user, is pressing the "Execute" button, then the script is being 
> called.
> Also on the toolbar, there is a new action with name "konsole". This action 
> is visible only when we are inside to a KWin Script.
> All the other packages, have a previewer. So the "konsole" action is located 
> inside the previewer.
> 
> 
> Diffs
> -
> 
>   konsole/konsolepreviewer.h 8dd4369 
>   konsole/konsolepreviewer.cpp c4f9f8b 
>   main.cpp 298be51 
>   mainwindow.h 8005d26 
>   mainwindow.cpp b84da4a 
>   plasmateui.rc b51884d 
> 
> Diff: http://git.reviewboard.kde.org/r/106118/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> konsole
>   http://git.reviewboard.kde.org/r/106118/s/693/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities KCM

[Christoph Feck]

On Thursday 23 August 2012 15:45:02 Ivan Čukić wrote:
> I don't know what to think of this. Hiding is prettier (to me)
> while disabling has its own advantages. Anyone else cares to pitch
> in?
> 
> As far as I see, we have both approaches in kcm.

I just checked System Settings, and all modules except the Proxy 
configuration use "disabling" instead of "hiding", and the only reason 
the Proxy module uses hiding is that otherwise the dialog would have 
been too tall. There was a review request about other possibilities, 
because we usually do not hide user interface elements, but in this 
case hiding was the least evil.

So definitely "disabling" in your case.

-- 
Christoph Feck
http://kdepepo.wordpress.com/
KDE Quality Team
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

[Richard Stockton]

> On Aug. 23, 2012, 2:53 p.m., Greg T wrote:
> > I think this time we can get kickoff-qml into kde 4.10. But this is no 
> > reason to push this fix not into master :)

Thanks, Greg! I think we both plan this method for managing the two modules, 
please advise if I am no correct: First, right now, this Update goes to Trunk 
AND 4.9 because kickoff-widget has not yet been removed from Trunk. (Trunk 
shold contain our best code, with all fixes.) When kickoff-qml is done, and 
completely replaces kickoff-widget: then it's maintainer should Update 4.10 
branch (if already branched off) AND master, removing kickoff-widget entirely. 
That will avoid a 4.10 or later occurence of the bug which I allowed to 
re-appear in 4.9, by assuming that kickoff-qml would replace kickoff-widget 
within 4.9.

Removal of Kickoff-widget will be a happy day for everyone - and me, 
especially. :)


- Richard


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106125/#review17903
---


On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106125/
> ---
> 
> (Updated Aug. 23, 2012, 12:28 a.m.)
> 
> 
> Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. 
> This version combines https://git.reviewboard.kde.org/r/104422/ and 
> https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 
> when the feature (RFE bug 276932) is added to 4.9 and Trunk.
> 
> 
> This addresses bugs 276932 and 297842.
> http://bugs.kde.org/show_bug.cgi?id=276932
> http://bugs.kde.org/show_bug.cgi?id=297842
> 
> 
> Diffs
> -
> 
>   plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 
>   plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 
> 
> Diff: http://git.reviewboard.kde.org/r/106125/diff/
> 
> 
> Testing
> ---
> 
> #1 Arrow key movement among programs in the flipscrollview (Right, back to 
> Left, and Up/Down). Activbation of highlighted/selected programs.
> #2 Search bar entry, movement into View of matches using the Tab key. Move 
> among multiple matching prgrams via arrow keys. Tab goes back to the search 
> TextEdit field, allowing the search to be modified; and it is highlighted, 
> allowing the search text to be deleted.
> #3 an empty search text field re-shows the tab bar and flipscrollview; tab 
> selection is again enabled via left/right arrow keys.
> 
> NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via 
> keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller 
> has insufficient knowledge of where you came from, and often tries to send 
> your keystroke to an invisible, non-responsive View. IMO, Re-design or total 
> replacement (Kickoff-QML) IS appropriate.
> 
> But it works sort of.
> 
> 
> Thanks,
> 
> Richard Stockton
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

[Greg T]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106125/#review17903
---


I think this time we can get kickoff-qml into kde 4.10. But this is no reason 
to push this fix not into master :)

- Greg T


On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106125/
> ---
> 
> (Updated Aug. 23, 2012, 12:28 a.m.)
> 
> 
> Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. 
> This version combines https://git.reviewboard.kde.org/r/104422/ and 
> https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 
> when the feature (RFE bug 276932) is added to 4.9 and Trunk.
> 
> 
> This addresses bugs 276932 and 297842.
> http://bugs.kde.org/show_bug.cgi?id=276932
> http://bugs.kde.org/show_bug.cgi?id=297842
> 
> 
> Diffs
> -
> 
>   plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 
>   plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 
> 
> Diff: http://git.reviewboard.kde.org/r/106125/diff/
> 
> 
> Testing
> ---
> 
> #1 Arrow key movement among programs in the flipscrollview (Right, back to 
> Left, and Up/Down). Activbation of highlighted/selected programs.
> #2 Search bar entry, movement into View of matches using the Tab key. Move 
> among multiple matching prgrams via arrow keys. Tab goes back to the search 
> TextEdit field, allowing the search to be modified; and it is highlighted, 
> allowing the search text to be deleted.
> #3 an empty search text field re-shows the tab bar and flipscrollview; tab 
> selection is again enabled via left/right arrow keys.
> 
> NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via 
> keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller 
> has insufficient knowledge of where you came from, and often tries to send 
> your keystroke to an invisible, non-responsive View. IMO, Re-design or total 
> replacement (Kickoff-QML) IS appropriate.
> 
> But it works sort of.
> 
> 
> Thanks,
> 
> Richard Stockton
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities KCM

[todd rme]

On Thu, Aug 23, 2012 at 3:45 PM, Ivan Čukić  wrote:
>
>> > This should be done automatically - the activities should be scored based
>> > on the current location and stuff like in Plasma Active, and the switcher
>> > should sort them by the score, or mark them in some way.
>>
>> I don't really agree here.  There are some activities you probably
>> never want to have at work, for instance a "games" activity.
>
> And that is what the usage statistics should provide. I'm not against the
> idea, just don't see a direct benefit. And it would need a new UI for the
> activity switcher - it is important that you can access the /hidden/
> activities as well. (something like /more/ button)

I am not saying they should be hidden, I am saying they shouldn't be
running.  A lot of games these days connect over a network to a remote
server, you probably don't want that happening on your laptop at all,
even if it is just for the first few times you come to work.

>> > I don't like the idea of starting/switching/stopping activities
>> > automatically for any reason. (can exist as a plugin, like VD switching,
>> > global shortcuts)
>> Is there a plugin system for activity behavior?
>
> Behaviour in what sense?

Can the stopping and starting of activities be controlled by a plugin?

>> However, how does size work?  It looks like there is a ton of wated
>> space in the first and second mode (especially second), but suddenly
>> all this space gets taken up.  Perhaps the GUI elements should be
>> grayed out instead of invisible?
>
> I don't know what to think of this. Hiding is prettier (to me) while disabling
> has its own advantages. Anyone else cares to pitch in?
>
> As far as I see, we have both approaches in kcm.

I don't really know, personally.  I was bringing it up as a potential
issue, I don't have a strong feeling one way or the other.

>> However, I think something like "Only remember for applications in
>> this list" is just as clear, is exactly the same length (in character
>
> The sentence should state that you have selected which applications should be
> tracked, choosing from those that have already reported events to kamd. And
> that you want to ignore any new applications that come up.

Alright, that is not what I thought that sentence was saying. I
thought it was choosing how to handle applications that would never
appear on the list, not setting the default for future applications on
the list.

> For this, I don't think that  "Only remember for applications in
> this list" is specific enough. On the other hand, the word /blacklist/ might
> be problematic.
>
> Need more ideas :)

How about "Remember history by default for future applications"?

-Todd
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities KCM

[Ivan Čukić]

> > This should be done automatically - the activities should be scored based
> > on the current location and stuff like in Plasma Active, and the switcher
> > should sort them by the score, or mark them in some way.
> 
> I don't really agree here.  There are some activities you probably
> never want to have at work, for instance a "games" activity.

And that is what the usage statistics should provide. I'm not against the 
idea, just don't see a direct benefit. And it would need a new UI for the 
activity switcher - it is important that you can access the /hidden/ 
activities as well. (something like /more/ button)

> > I don't like the idea of starting/switching/stopping activities
> > automatically for any reason. (can exist as a plugin, like VD switching,
> > global shortcuts)
> Is there a plugin system for activity behavior?

Behaviour in what sense?

> However, how does size work?  It looks like there is a ton of wated
> space in the first and second mode (especially second), but suddenly
> all this space gets taken up.  Perhaps the GUI elements should be
> grayed out instead of invisible?

I don't know what to think of this. Hiding is prettier (to me) while disabling 
has its own advantages. Anyone else cares to pitch in?

As far as I see, we have both approaches in kcm.

> However, I think something like "Only remember for applications in
> this list" is just as clear, is exactly the same length (in character

The sentence should state that you have selected which applications should be 
tracked, choosing from those that have already reported events to kamd. And 
that you want to ignore any new applications that come up.

For this, I don't think that  "Only remember for applications in
this list" is specific enough. On the other hand, the word /blacklist/ might 
be problematic.

Need more ideas :)


Ch!


-- 
Progress isn't made by early risers. It's made by lazy men trying to find
easier ways to do something.
  -- Robert Heinlein


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities KCM

[todd rme]

On Thu, Aug 23, 2012 at 11:47 AM, Ivan Čukić  wrote:
> Thanks for the suggestions.
>
> First, lets start with the feature requests.
>
>> 1. Which applications start automatically with a given activity.
>
> As Marco said (and I agree), this shouldn't be for per-activity settings.
> But I do think we should have this feature.

I thought that might be the case, but I wasn't sure whether the
question was meant for this particular KCM or more generally.

>> 2. Which activities are started automatically on boot
>> 3. Which activity is shown when the system starts
>
> 2 and 3 are not something I think should be configurable, but maybe can be
> persuaded - the system is restored to the state you left it - both the
> activities that are running and the current activity.

I can think of some use-cases for these, but they are probably not
common enough to be worth it.

>> 4. Location, network APN, or time-aware activities.
>
> This should be done automatically - the activities should be scored based on
> the current location and stuff like in Plasma Active, and the switcher should
> sort them by the score, or mark them in some way.

I don't really agree here.  There are some activities you probably
never want to have at work, for instance a "games" activity.

> I don't like the idea of starting/switching/stopping activities automatically
> for any reason. (can exist as a plugin, like VD switching, global shortcuts)

Is there a plugin system for activity behavior?

>> From the screenshots:
>
> New screenshots (some advice followed):
> http://img560.imageshack.us/img560/6324/kamdsettings231.png
> http://img846.imageshack.us/img846/8627/kamdsettings232.png
> http://img694.imageshack.us/img694/8717/kamdsettings233.png

Much better.

However, how does size work?  It looks like there is a ton of wated
space in the first and second mode (especially second), but suddenly
all this space gets taken up.  Perhaps the GUI elements should be
grayed out instead of invisible?

>> 1. What is being blacklisted?  Activity support, remembering document,
>
> +1

Better now.

>>  Same for the checkbox on the bottom.
>
> Is the blacklist checkbox still confusing? (mind that the application view +
> checkbox are shown only when the appr radio button is selected.

I don't know, I guess it depends on how well-known the term
"blacklist" is.  I am sure it is known amongst programmers, but how
common it is in the general population I am not sure.  I don't
normally encounter it in everyday speech, or in the user interfaces of
software I commonly use.

However, I think something like "Only remember for applications in
this list" is just as clear, is exactly the same length (in character
count), but avoids the problem entirely.  It is also put in a positive
manner rather than negative.

>> 3. I am not sure how this would look, or if it would work with other
>> widget themes, but could you put the "Keep History" dropdown next to
>> "Remember open documents"?, and get rid of the "Keep History" text?
>
> Didn't quite understand this. Did you mean to move it above, so that it says
> Remember opened documents [forever]
> Remember opened documents [for 5 months]
>
> If yes, the problem is that visibility of those depends on the "don't
> remember" radio button not being selected. Hiding something above is not
> something that I'd consider pretty.

Good point.  Nevermind.

-Todd
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Activities KCM

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106130/
---

(Updated Aug. 23, 2012, 1:08 p.m.)


Review request for Plasma.


Description
---

System settings module for activities


Diffs (updated)
-

  cmake/modules/c++11-test-initializer-lists-N2672.cpp PRE-CREATION 
  src/CMakeLists.txt 63ed737 
  src/config-features.h.cmake bde6b66 
  src/service/Application.cpp 5dadbca 
  src/service/plugins/sqlite/StatsPlugin.cpp 6f24be8 
  src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.cpp 568e0f9 
  src/workspace/CMakeLists.txt 8a6e1bb 
  src/workspace/settings/BlacklistedApplicationsModel.h PRE-CREATION 
  src/workspace/settings/BlacklistedApplicationsModel.cpp PRE-CREATION 
  src/workspace/settings/CMakeLists.txt PRE-CREATION 
  src/workspace/settings/MainConfigurationWidget.h PRE-CREATION 
  src/workspace/settings/MainConfigurationWidget.cpp PRE-CREATION 
  src/workspace/settings/kcm_activities.cpp PRE-CREATION 
  src/workspace/settings/kcm_activities.desktop PRE-CREATION 
  src/workspace/settings/qml/BlacklistApplicationView.qml PRE-CREATION 
  src/workspace/settings/ui/MainConfigurationWidgetBase.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106130/diff/


Testing
---


Thanks,

Ivan Čukić

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add comment to blackboard applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105704/#review17897
---


committed

- Marco Martin


On Aug. 23, 2012, 11:13 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105704/
> ---
> 
> (Updated Aug. 23, 2012, 11:13 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Add a comment (description) to the blackboard applet.
> Feedback welcome.
> 
> I do not have commit access. This introduces a new string.
> 
> 
> This addresses bug 302636.
> http://bugs.kde.org/show_bug.cgi?id=302636
> 
> 
> Diffs
> -
> 
>   applets/blackboard/plasma-applet-blackboard.desktop 298316e 
> 
> Diff: http://git.reviewboard.kde.org/r/105704/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add comment to blackboard applet

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105704/#review17896
---


This review has been submitted with commit 
2c0b9004a516b23012dee604e624004b44221287 by Marco Martin to branch master.

- Commit Hook


On Aug. 23, 2012, 11:13 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105704/
> ---
> 
> (Updated Aug. 23, 2012, 11:13 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Add a comment (description) to the blackboard applet.
> Feedback welcome.
> 
> I do not have commit access. This introduces a new string.
> 
> 
> This addresses bug 302636.
> http://bugs.kde.org/show_bug.cgi?id=302636
> 
> 
> Diffs
> -
> 
>   applets/blackboard/plasma-applet-blackboard.desktop 298316e 
> 
> Diff: http://git.reviewboard.kde.org/r/105704/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add fade effect on the nowplaying text cycling

[Martin Klapetek]

> On Aug. 21, 2012, 3:54 p.m., Commit Hook wrote:
> > This review has been submitted with commit 
> > 48ccff55dabc7ad9a173ee6b50d955c85e42aa27 by Martin Klapetek to branch 
> > KDE/4.9.
> 
> Alex Merry wrote:
> I don't think this should really have gone into 4.9, as it is a feature, 
> rather than a bug fix.

Depends. Would it be a bug if I opened a bug report first (as it was a bug from 
my point of view)? Also I don't think it's a feature really, 
enhancement/improvement yes, but feature? Not really.

For the record - I asked if that can go in 4.9 first.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106095/#review17810
---


On Aug. 20, 2012, 11:13 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106095/
> ---
> 
> (Updated Aug. 20, 2012, 11:13 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> When the nowplaying is in panel, it cycles through title, artist and album in 
> one Label. This adds a simple, decent fade effect between the changes.
> 
> 
> Diffs
> -
> 
>   applets/nowplaying/package/contents/ui/MetadataLine.qml b793464 
> 
> Diff: http://git.reviewboard.kde.org/r/106095/diff/
> 
> 
> Testing
> ---
> 
> In plasmoidviewer.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

[Alexey Shmalko]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/
---

(Updated Aug. 22, 2012, 6:44 p.m.)


Review request for kwin and Plasma.


Description
---

Make autohide panel do not intercept events in fullscreen app.

I changed PanelView::shouldHintHide() to return true if current active 
application is in fullscreen mode. So in fullscreen applications panel will be 
always hidden.


This addresses bugs 297920 and 305497.
http://bugs.kde.org/show_bug.cgi?id=297920
http://bugs.kde.org/show_bug.cgi?id=305497


Diffs
-

  plasma/desktop/shell/panelview.cpp 7713740 

Diff: http://git.reviewboard.kde.org/r/106110/diff/


Testing (updated)
---

Tested with patched gentoo ebuild. Works fine.


Thanks,

Alexey Shmalko

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

[Alexey Shmalko]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/
---

(Updated Aug. 22, 2012, 11:50 a.m.)


Review request for kwin and Plasma.


Description
---

Make autohide panel do not intercept events in fullscreen app.

I changed PanelView::shouldHintHide() to return true if current active 
application is in fullscreen mode. So in fullscreen applications panel will be 
always hidden.


This addresses bugs 297920 and 305497.
http://bugs.kde.org/show_bug.cgi?id=297920
http://bugs.kde.org/show_bug.cgi?id=305497


Diffs
-

  plasma/desktop/shell/panelview.cpp 7713740 

Diff: http://git.reviewboard.kde.org/r/106110/diff/


Testing
---


Thanks,

Alexey Shmalko

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

[Alexey Shmalko]

> On Aug. 21, 2012, 4:22 a.m., Martin Gräßlin wrote:
> > I do not see a reason why the hidden panel should not be allowed to go 
> > above a fullscreen window. True it's not possible for the normal panel 
> > case, but hidden panel is kind of special.
> > 
> > Apart from that I think you modified the wrong place as it's only about the 
> > hint and you bound it with whether compositing is used.
> 
> Alexey Shmalko wrote:
> I moved check for fullscreen application in another place.
> 
> Don't know how to make panel slide over fullscreen apps. If somebody 
> points me in right direction to search, I'll try to do this.

I thought for a while and decided that it's bad idea to allow hidden panel to 
go above a full-screen window. The reason is that some apps provide their own 
menus, like guest systems in VirtualBox.


- Alexey


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review17790
---


On Aug. 21, 2012, 10:06 a.m., Alexey Shmalko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> ---
> 
> (Updated Aug. 21, 2012, 10:06 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Make autohide panel do not intercept events in fullscreen app.
> 
> I changed PanelView::shouldHintHide() to return true if current active 
> application is in fullscreen mode. So in fullscreen applications panel will 
> be always hidden.
> 
> 
> This addresses bugs 297920 and 305497.
> http://bugs.kde.org/show_bug.cgi?id=297920
> http://bugs.kde.org/show_bug.cgi?id=305497
> 
> 
> Diffs
> -
> 
>   plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexey Shmalko
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add fade effect on the nowplaying text cycling

[Alex Merry]

> On Aug. 21, 2012, 3:54 p.m., Commit Hook wrote:
> > This review has been submitted with commit 
> > 48ccff55dabc7ad9a173ee6b50d955c85e42aa27 by Martin Klapetek to branch 
> > KDE/4.9.

I don't think this should really have gone into 4.9, as it is a feature, rather 
than a bug fix.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106095/#review17810
---


On Aug. 20, 2012, 11:13 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106095/
> ---
> 
> (Updated Aug. 20, 2012, 11:13 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> When the nowplaying is in panel, it cycles through title, artist and album in 
> one Label. This adds a simple, decent fade effect between the changes.
> 
> 
> Diffs
> -
> 
>   applets/nowplaying/package/contents/ui/MetadataLine.qml b793464 
> 
> Diff: http://git.reviewboard.kde.org/r/106095/diff/
> 
> 
> Testing
> ---
> 
> In plasmoidviewer.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities KCM

[Ivan Čukić]

Thanks for the suggestions.

First, lets start with the feature requests.

> 1. Which applications start automatically with a given activity.

As Marco said (and I agree), this shouldn't be for per-activity settings.
But I do think we should have this feature.

> 2. Which activities are started automatically on boot
> 3. Which activity is shown when the system starts

2 and 3 are not something I think should be configurable, but maybe can be 
persuaded - the system is restored to the state you left it - both the 
activities that are running and the current activity.

> 4. Location, network APN, or time-aware activities.

This should be done automatically - the activities should be scored based on 
the current location and stuff like in Plasma Active, and the switcher should 
sort them by the score, or mark them in some way.

I don't like the idea of starting/switching/stopping activities automatically 
for any reason. (can exist as a plugin, like VD switching, global shortcuts)
 
> From the screenshots:
 
New screenshots (some advice followed):
http://img560.imageshack.us/img560/6324/kamdsettings231.png
http://img846.imageshack.us/img846/8627/kamdsettings232.png
http://img694.imageshack.us/img694/8717/kamdsettings233.png

> 1. What is being blacklisted?  Activity support, remembering document,

+1

>  Same for the checkbox on the bottom.

Is the blacklist checkbox still confusing? (mind that the application view + 
checkbox are shown only when the appr radio button is selected.

> 3. I am not sure how this would look, or if it would work with other
> widget themes, but could you put the "Keep History" dropdown next to
> "Remember open documents"?, and get rid of the "Keep History" text?

Didn't quite understand this. Did you mean to move it above, so that it says
Remember opened documents [forever]
Remember opened documents [for 5 months]

If yes, the problem is that visibility of those depends on the "don't 
remember" radio button not being selected. Hiding something above is not 
something that I'd consider pretty.

Thanks!

-- 
I don't really trust a sane person.
  -- Lyle Alzado


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities KCM

[todd rme]

On Wed, Aug 22, 2012 at 8:21 PM, Ivan Čukić  wrote:
> What would you like to see configurable in activities?

1. Which applications start automatically with a given activity.
2. Which activities are started automatically on boot
3. Which activity is shown when the system starts
4. Location, network APN, or time-aware activities.

From the screenshots:

1. What is being blacklisted?  Activity support, remembering document,
remembering sessions, something else?  I would probably say something
like "Which applications should remember open documents?" (assuming
two, just as an example).  Same for the checkbox on the bottom.

2. "Only specific applications:" ends with a colon, which is then
followed by "Keep History", which makes it look like "specific
applicaitons" refers to "keep history".  If it is for the applications
box below, I would put the second radio last, and just get rid of the
text above the applications list.

3. I am not sure how this would look, or if it would work with other
widget themes, but could you put the "Keep History" dropdown next to
"Remember open documents"?, and get rid of the "Keep History" text?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel